Commit Graph

6754 Commits

Author SHA1 Message Date
Mozilla L10n Automation Bot
a28ffd76bd Import l10n. 2022-08-13 15:55:23 +00:00
Gabriel Luong
a98868d791 For #26412 - Remove try catch for NimbusFeatureException from FxNimbus value() getter 2022-08-12 16:05:23 +00:00
sarah541
bbb602a2fd For #26308 - Add feature flag for MR onboarding 2022-08-12 15:01:33 +00:00
Mugurell
e74742a3e6 For #25602: Lowercase search engine id when recording telemetry 2022-08-12 06:41:29 +00:00
Alexandru2909
c268161311 For #26115 - Change homescreen Show all button color according to wallpaper 2022-08-12 00:55:43 +00:00
Charlie Humphreys
b33abbbec2 change name for isFirstRun to isFirstNimbusRun and move setter to after experiments are set 2022-08-12 00:24:28 +00:00
Charlie Humphreys
1ce99506ad update isFirstRun to be manually set and set experiments locally on first run 2022-08-12 00:24:28 +00:00
MatthewTighe
72959901d8 Fixes #26245: refactor the WallpaperManager as several WallpaperUseCases 2022-08-11 14:56:49 +00:00
Jonathan Almeida
d0c21c06aa Close #26041: Remove un-needed Nimbus workaround
This workaround was temporary and is not needed with the Nimbus groovy
plugin updates in Android Components.
2022-08-11 10:13:19 -04:00
Roger Yang
4204c43236 Close #26198: Add debounce to account manager syncs 2022-08-10 21:06:29 +00:00
Mozilla L10n Automation Bot
f356df785c Import l10n. 2022-08-10 07:26:01 +00:00
rxu
2a30213fc1 Add "manage account and devices" button to home menu in mozillaonline builds 2022-08-10 06:50:08 +00:00
Noah Bond
a77375a363 For #22558 - Fix private theme bug in Tabs Tray 2022-08-09 21:08:38 +00:00
Jonathan Almeida
f03ee91ecb Close #26041: Re-set TrackingProtectionPolicy after Nimbus SDK is initialized
There are three issues here that we have uncovered while investigating
this bug:

 1. Settings.kt has a lazy block around `enabledTotalCookieProtection`
    which ends up caching the first result it evaluates.
 3. The `FeatureHolder` within FxNimbus caches the incorrectly
    evaluated value and returns this value hence forth.
 4. Nimbus is not ready to return a result for an engine experiment
    when we need it early on in the dependency tree initialization.

There are multiple systems that require engine to be initialized for
 them to work (e.g. Glean, Profiler, concept-fetch). In our TCP,
 experiment, we need to apply these engine settings during the engine
 initialization. So when we try and evaluate Nimbus that early on, it
 has not had time to initialize itself correctly or even use the
 engine's concept-fetch client to return the correct experiment result.
 This bug is made worse because of the first two caching bugs where we
 are always holding onto a cached value of the wrong result.

Our temporary solution is to:

 1. Remove the `lazy` around `Settings.enabledTotalCookieProtection`.
 2. Set the `FxNimbus.api` value right after we are done initializing
    `FxNimbus` and `NimbusApi` so that all future queries to FxNimbus
    will be made against a real instance of `NimbusApi`. This is a
    short-term fix for the `FeatureHolder` caching bug.
 3. Set a new TrackingProtectionPolicy that will evaluate Nimbus now
    that it is in the correct state when receive the
    `NimbusInterface.Observer.onUpdatesApplied`.

Co-authored-by: jhugman <jhugman@users.noreply.github.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2022-08-09 19:33:00 +00:00
MatthewTighe
29a8c33ba5 Fixes #26377: re-open already opened recent synced tabs 2022-08-09 19:00:40 +00:00
Mozilla L10n Automation Bot
37745eb83d Import l10n. 2022-08-09 10:12:58 +00:00
Noah Bond
db0162465b For #26289 - Remove search term tab groups metrics and setting 2022-08-08 18:16:33 +00:00
rudmannn
8e8ea5e57a
Fix #26362: Use app:lineHeight to support API Level <= 27 (#26364)
* Fix android:lineHeight

Change android:lineHeight to app:lineHeight for incompatibilities at API Level <= 27

* Fix android:lineHeight (Part 2)

Change android:lineHeight to app:lineHeight for fixing incompatibilities in custom_search_engine

* Change android:lineHeight (Part 3)

Change android:lineHeight to app:lineHeight in settings_https_only for incompatibilities at API Level <= 27

* cleanup lint-baseline.xml

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-08-08 12:12:18 -04:00
Jan-Erik Rediger
06488cdabe Move startup perf measurements to a background thread
This is required to avoid loading the Glean core library (provided by libxul) early on.
Fenix needs to do the time measurement itself for now.
2022-08-08 14:10:36 +00:00
Alexandru2909
1a2b357119 For #26302 - Change header text height to wrap_content for autofill add/edit screens 2022-08-08 05:37:09 +00:00
Mozilla L10n Automation Bot
9255d351fd Import l10n. 2022-08-08 00:39:10 +00:00
Mozilla L10n Automation Bot
4f77d2966b Import l10n. 2022-08-07 00:43:28 +00:00
Mozilla L10n Automation Bot
4379b06288 Import l10n. 2022-08-06 00:39:20 +00:00
indu
1488e8e87b For #26236: Fix breaking change from AC regarding exitImmersiveModeIfNeeded
This will allow Fenix to use the refactored method name 'exitImmersiveMode' in Activity from Android Components library

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
2022-08-05 15:25:39 +00:00
Mozilla L10n Automation Bot
926daabe1f Import l10n. 2022-08-05 00:40:01 +00:00
Mozilla L10n Automation Bot
dd563b19f0 Import l10n. 2022-08-04 01:10:03 +00:00
Noah Bond
8656fd48eb For #26227 - Remove search term tab groups from Jump Back In 2022-08-04 00:10:47 +00:00
Mugurell
aa992263d6 For #26172 - New CFR popup composable
This will allow for pinpoint accuracy when anchoring and resolve any color
disparities between the popup body and the indicator arrow by having everything
drawn programmatically as one shape.

Because of the async nature of the values for insets and screen rotation
immediately after an orientation change the popup will automatically get
dismissed to prevent any anchoring issues.
While not ideal the effect of this is better than accepting layout issues after
orientation changes and is the same approach used for other of our popups.
2022-08-03 19:04:31 +00:00
Alexandru2909
ec4ad984c2 For #26239 - Avoid displaying multiple download items for the same file 2022-08-03 11:49:42 +00:00
Christian Sadilek
7ddc50017e Revert "For #26227 - Remove search term tab groups from Jump Back In"
This reverts commit fa00527dc6.
2022-08-03 02:39:42 +00:00
Christian Sadilek
b24650c449 Revert "For #26227 - Remove search term tab groups from Recently Visited"
This reverts commit c45e4b4ac5.
2022-08-03 02:39:42 +00:00
Arturo Mejia
bddac731d5 For #26283: Use message buttonLabel in MessageCard. 2022-08-03 01:54:13 +00:00
Mozilla L10n Automation Bot
4ee1b6da9e Import l10n. 2022-08-03 00:36:46 +00:00
Noah Bond
c45e4b4ac5 For #26227 - Remove search term tab groups from Recently Visited 2022-08-02 22:46:10 +00:00
Noah Bond
fa00527dc6 For #26227 - Remove search term tab groups from Jump Back In 2022-08-02 22:46:10 +00:00
MatthewTighe
9fb6eeb8cf Fixes: #26052 remove WallpaperManager::updateWallpaper 2022-08-02 21:33:54 +00:00
Alexandru2909
acf9206fe1 For #25837 - Invalidate cached nimbusValidation values when changing locale settings 2022-08-02 07:45:13 +00:00
Mozilla L10n Automation Bot
1cf34a5ac4 Import l10n. 2022-08-02 01:35:29 +00:00
Mozilla L10n Automation Bot
c80195064f Import l10n. 2022-08-01 00:39:20 +00:00
Mozilla L10n Automation Bot
b57ff63707 Import l10n. 2022-07-31 00:45:15 +00:00
Mozilla L10n Automation Bot
77a6381520 Import l10n. 2022-07-30 00:42:27 +00:00
MatthewTighe
767d604315 Fixes #26029: Add wallpaper state to AppStore 2022-07-29 22:18:19 +00:00
Alexandru2909
7d85a9d274 For #26221 - Use favicon instead of ic_globe for composed tab grid item 2022-07-29 13:06:48 +00:00
Mozilla L10n Automation Bot
5e58ace753 Import l10n. 2022-07-29 00:42:02 +00:00
mike a
6483e1c647 Closes #25942: use HistoryFragment to show synced history 2022-07-28 20:53:36 +00:00
Mozilla L10n Automation Bot
cf21e02182 Import l10n. 2022-07-28 00:38:34 +00:00
Roger Yang
015b79f833 For #26061: Make sure favicons are cropped correctly 2022-07-27 22:11:13 +00:00
mcarare
11a7085e46 For #26197: Cancel history list update on fragment destroyed. 2022-07-27 18:06:56 +00:00
Mozilla L10n Automation Bot
d48bb493e7 Import l10n. 2022-07-27 00:48:42 +00:00
mike a
063a09782a Issue #26101: add telementry for deleting history time range 2022-07-26 20:59:16 +00:00
mcarare
4b5b15aa53 For #22692: Remove Metropolis font. 2022-07-26 16:39:29 +00:00
Alexandru2909
335159cef5 For #25891 - Move GridViewHolder to compose 2022-07-26 09:17:09 +00:00
Gabriel Luong
8f51a9968a For #26026 - Refactor the FenixTabCounterMenu creation from HomeFragment to TabCounterBuilder 2022-07-26 05:41:42 +00:00
Gabriel Luong
ac51c345e7 For #26182 - Remove all unused strings marked moz:removedIn <= 102 2022-07-26 02:29:54 +00:00
Mozilla L10n Automation Bot
74d143721c Import l10n. 2022-07-26 01:52:49 +00:00
mike a
ed152a31c1 Closes #26174: remove escapes from the typographic quotes 2022-07-25 19:30:19 +00:00
mike a
a475541be2 Closes #26174: fix delete time range prompt text punctuation 2022-07-25 19:30:19 +00:00
Mozilla L10n Automation Bot
4ec71c3aba Import l10n. 2022-07-25 00:43:30 +00:00
Mozilla L10n Automation Bot
7c4e087749 Import l10n. 2022-07-24 00:39:21 +00:00
Mozilla L10n Automation Bot
75864cca82 Import l10n. 2022-07-23 00:41:38 +00:00
Gabriel Luong
1e43c4474c For #26146 - Use the correct moz:removedIn version in @string/delete_browsing_data_prompt_message 2022-07-22 16:28:53 +00:00
Alexandru2909
2345eb22a8 For #26089 - Record metrics for save credit card prompt shown 2022-07-22 14:54:02 +00:00
Mozilla L10n Automation Bot
fa8e4a7cc6 Import l10n. 2022-07-22 00:48:41 +00:00
Gabriel Luong
7603d6db66 For #26134 - Add parameter description for @string/delete_all_history_group_prompt_message 2022-07-21 15:58:22 +00:00
Mozilla L10n Automation Bot
15a870c356 Import l10n. 2022-07-21 00:43:17 +00:00
mike a
7982c6b79f Close #25954: add a new delete time range confirmation dialog for history screen 2022-07-20 21:01:14 +00:00
Gabriel Luong
bfd0eb7306 For #26113 ⁃ Enable address autofill in all channels 2022-07-20 20:31:51 +00:00
Mozilla L10n Automation Bot
52a2cb6a4d Import l10n. 2022-07-20 00:42:36 +00:00
MatthewTighe
f58f1541ce Fixes #26050: show jump back in when only synced tab available 2022-07-19 18:40:34 +00:00
Noah Bond
7e59a644d5 For #21898 - Remove search term tab groups from the Tabs Tray 2022-07-19 16:59:57 +00:00
sarah541
da4328e53f For #22186 - Scroll to collection after creating one 2022-07-19 16:07:18 +00:00
Mozilla L10n Automation Bot
96472c9d72 Import l10n. 2022-07-19 00:44:36 +00:00
sarah541
4419e99b48 For #25894 - Add firefox suggest header for lib suggestions 2022-07-18 18:47:10 +00:00
Mozilla L10n Automation Bot
9f36956291 Import l10n. 2022-07-18 00:42:19 +00:00
Mozilla L10n Automation Bot
f3e0848533 Import l10n. 2022-07-17 00:46:06 +00:00
Mozilla L10n Automation Bot
51715c27b9 Import l10n. 2022-07-16 01:46:12 +00:00
mike a
f910fcfe76 Closes #25967: add classes to support multiple viewHolders 2022-07-16 01:03:53 +00:00
MatthewTighe
5e15e9a6b3 Fixes #25955: refactor RecentSyncedTabsFeature to use SyncStore 2022-07-16 00:29:16 +00:00
mike a
bbc835ad02 Closes #25952: update close icon, start using close_20 on smaller ui elements 2022-07-15 23:24:27 +00:00
Roger Yang
ee3fd03313 No issue: remove unused inactive tab auto close dialog controller 2022-07-15 19:07:25 +00:00
Mozilla L10n Automation Bot
6c5e8b6e1d Import l10n. 2022-07-15 00:46:50 +00:00
MatthewTighe
1d20914f8f Fixes 24823: remove recent synced tab when logged out 2022-07-14 21:46:05 +00:00
Mozilla L10n Automation Bot
4f9516eb67 Import l10n. 2022-07-14 00:53:09 +00:00
mcarare
0b289fd3cf For #25994: Make installToHomescreen item a collapsing menu limit.
The item is visible instead of addToHomeScreenItem when
current session can be installed as a PWA.
2022-07-13 13:14:04 +00:00
Mozilla L10n Automation Bot
2474b15ff6 Import l10n. 2022-07-13 00:48:30 +00:00
Mozilla L10n Automation Bot
203d4c6f72 Import l10n. 2022-07-12 01:01:52 +00:00
mike a
8af600d90b Closes #25937: update library item text size, change text size in synced and recently closed nav items, change remove icon size to wrap content 2022-07-11 22:58:26 +00:00
mike a
8d4ab0f0eb Closes #25937: update history list element design 2022-07-11 22:58:26 +00:00
Mozilla L10n Automation Bot
6b089268a3 Import l10n. 2022-07-11 22:25:14 +00:00
Jonathan Almeida
7309b671b1 Close #25982: Fix check between current and new when adding a bookmark 2022-07-11 21:41:40 +00:00
Alexandru2909
beca81b442 For #25829 - String updates for Sync 2022-07-11 13:58:15 +00:00
Mozilla L10n Automation Bot
3a8ad63850 Import l10n. 2022-07-10 00:46:30 +00:00
Mozilla L10n Automation Bot
279efffd9b Import l10n. 2022-07-09 00:52:48 +00:00
Arturo Mejia
e1b7262ca8 For #25938: Address MessageCard text not adapting to the dark theme 2022-07-08 14:17:57 +00:00
Arturo Mejia
261569c2c5 For #25915: Remove the hard coded default browser message 2022-07-07 22:16:25 +00:00
Gabriel Luong
80524cd6ab For #25935 - Catch NimbusFeatureException from calling FxNimbus value getter 2022-07-07 21:14:07 +00:00
Gabriel Luong
1207180aa8 For #25933 - Ensure sponsored tiles are enable if enrolled in active experiment 2022-07-07 19:28:33 +00:00
Mozilla L10n Automation Bot
2ed23db9d8 Import l10n. 2022-07-06 00:57:46 +00:00
Arturo Mejia
8c752c3be1 For #25736: Add experiment for Total cookie protection. 2022-07-05 19:07:05 +00:00
rxu
f7826c41bf Disable marketing telemetry until privacy pop window approved in Mozillaonline builds 2022-07-05 08:04:47 +00:00
mcarare
70e6422d94 For #25846: Save the City field in addresses. 2022-07-04 13:58:25 +00:00
Alexandru2909
b6f140a76f For #24528 - Remove isPrivate conditional in getTheme in favor of inComposePreview 2022-07-04 06:18:38 +00:00
Roger Yang
46d73673ec Issue #25805: Always anchored unified search menu to the toolbar icon 2022-06-30 16:53:13 +00:00
mcarare
808938137d For #25815: Fix interactor calls for address management. 2022-06-29 22:30:03 +00:00
Alexandru2909
4d430adbbe For #25764 - Prevent sponsored shortcut URLs from appearing as frecent shortcuts 2022-06-29 20:14:35 +00:00
Mugurell
d4dd62341a For #25401 - Record Pocket sponsored stories telemetry 2022-06-29 18:30:54 +00:00
Mugurell
feae3344de For #25401 - Improve how sponsored stories impressions are reported
While testing I observed that the Rect returned from `boundsInWindow()`
- will have the full height and width of the composable even if scrolled
offscreen vertically
- will only have the height and width of what part of the composable is shown
pn the screen.
Possibly because of the interactions of a vertically scrollable RecyclerView
and the LazyRow the composable is shown in.

To account for this the method calculating how much of the composable is shown
on screen will also now receive the real composable size as an argument.
2022-06-29 18:30:54 +00:00
Mugurell
c5f37f01eb For #25538 - Add "metrics" telemetry for if default wallpaper is shown 2022-06-29 17:52:51 +00:00
Mugurell
8d9ccd76e9 For #25538 - Add a simple way to check if the default wallpaper is to be shown
A previous check for whether the persisted name of the current wallpaper is
empty made checking whether the default wallpaper is to be shown brittle.
Instead of duplicating such a check in multiple places it is now extracted in
one method that can be used in multiple places including the new telemetry.
2022-06-29 17:52:51 +00:00
Arturo Mejia
8ba7b8bddc For #25213: Add tabs prioritization experiment 2022-06-29 17:11:54 +00:00
Arturo Mejia
61807c5316 No issue: Add number_of_app_launches custom attribute to nimbus messages. 2022-06-29 12:13:24 -04:00
Mozilla L10n Automation Bot
9ba0ba563c Import l10n. 2022-06-29 01:30:27 +00:00
Marc Leclair
0680d7027c Fixed PR review 2022-06-29 00:54:30 +00:00
Marc Leclair
0da739930c Lint fixes 2022-06-29 00:54:30 +00:00
Marc Leclair
ed45675755 Added strings and keys to XML 2022-06-29 00:54:30 +00:00
Marc Leclair
f35e03f726 Added start and stop dialog fo navigation xml 2022-06-29 00:54:30 +00:00
Marc Leclair
739839356a Added profiler option to SettingsFragment 2022-06-29 00:54:30 +00:00
Marc Leclair
2a83d029c8 Added ProfilerUtils 2022-06-29 00:54:30 +00:00
Marc Leclair
c0a95805aa Added ProfilerReusableComposable 2022-06-29 00:54:30 +00:00
Marc Leclair
b08058e2bd Added ProfilerStopDialogFragment 2022-06-29 00:54:30 +00:00
Michael Comella
985f4ede00 Added ProfilerStartDialogFragment. 2022-06-29 00:54:30 +00:00
Marc Leclair
09a31e03ab For #14854: Added ProfilerViewModel 2022-06-29 00:54:30 +00:00
Gabriel Luong
83e19be385 For #24967 - Enable address autofill for Nightly and Debug 2022-06-28 23:14:16 +00:00
MatthewTighe
d6952cb2aa Fixes #25545: wait to draw Pocket until after first frame 2022-06-28 16:47:51 +00:00
Mozilla L10n Automation Bot
1597231ea1 Import l10n. 2022-06-28 01:27:10 +00:00
Arturo Mejia
5f1448460e For #21894: Move Tabs Tray to compose: Individual tab viewholders: ListViewHolder. 2022-06-27 21:27:55 +00:00
Gabriel Luong
8f65658e86 For #25767 - Remove all unused strings marked moz:removedIn <= 101 2022-06-27 18:09:25 +00:00
mcarare
6719eeb129 For #24857: Add metrics for addresses autofill. 2022-06-27 10:24:13 +00:00
Mozilla L10n Automation Bot
16dc078d6c Import l10n. 2022-06-27 00:59:40 +00:00
Mozilla L10n Automation Bot
4af92436d9 Import l10n. 2022-06-26 00:39:27 +00:00
Mozilla L10n Automation Bot
09e6f9416d Import l10n. 2022-06-25 00:43:02 +00:00
Gabriel Luong
8fa08f31b9 For #25750 - Use Headline7 for the expandable list headers that appear in cards 2022-06-24 18:45:03 +00:00
Gabriel Luong
2f17888f79 For #25750 - Change Headline8 to 14dp 2022-06-24 18:45:03 +00:00
Mugurell
fd28889d71 For #25658 - Track the site permissions prompt and user actions
Track when the prompt is shown and when the permissions are allowed/denied.
2022-06-24 18:08:55 +00:00
Alexandru2909
4fc65b700a For #25721 - Remove 'Daylight' from the 'About Firefox' screen 2022-06-24 13:47:42 +00:00
Mozilla L10n Automation Bot
8794cdb1e2 Import l10n. 2022-06-23 01:00:15 +00:00
Roger Yang
7a5e126f24 Issue #24740: Use unified search bar in bookmark search 2022-06-22 19:27:42 +00:00
Noah Bond
5f7fd5313c For #25491 - Refactor InactiveTabs interactors and controllers 2022-06-22 18:37:06 +00:00
Gabriel Luong
d275152789 For #25708 - Change Credit Card preference label to Autofill when address autofill is enabled 2022-06-22 15:43:41 +00:00
mcarare
572838f672 For #25435: Hide accept button just for HSTS error page. 2022-06-22 07:45:33 +00:00
Roger Yang
22ac345513 Issue #24740: Use unified search bar in history search 2022-06-21 16:57:39 +00:00
sarah541
8791a25522 For #23966 - Migrate MessageCardViewHolder to Compose 2022-06-21 15:35:10 +00:00
Mozilla L10n Automation Bot
9c3405cac9 Import l10n. 2022-06-21 00:52:08 +00:00
Mozilla L10n Automation Bot
2e0f445076 Import l10n. 2022-06-20 00:44:39 +00:00
Mozilla L10n Automation Bot
65410d0dca Import l10n. 2022-06-19 00:48:13 +00:00
Mozilla L10n Automation Bot
d35e3830cd Import l10n. 2022-06-18 00:46:14 +00:00
Mozilla L10n Automation Bot
759f0bd800 Import l10n. 2022-06-17 00:41:41 +00:00
Alexandru2909
1ff5b8129f Fixes #25622 - PromptFeature use LoginDelegate and CreditCardDelegate as parameters for login and credit card pickers 2022-06-16 22:06:44 +00:00
CHAN, Chak Shing
9a6380d55b For #25183 - Update the Sentry base URL
Update the Sentry base URL to use the new instance
2022-06-16 18:57:10 +00:00
Mozilla L10n Automation Bot
bef5c3054b Import l10n. 2022-06-16 03:35:10 +00:00
mcarare
d595e199c9 For #25435: Handle ERROR_BAD_HSTS_CERT error. 2022-06-16 02:14:23 +00:00
Mugurell
0ee911ea8c For #25586 - Allow for localized sumo links for the https-only mode 2022-06-16 01:05:10 +00:00
Ben Dean-Kawamura
ad222521be Adding support for app-services error reporting 2022-06-15 23:59:40 +00:00
Arturo Mejia
34b31f8b11 For #25446: Ensure for every message shown we have recordExposure 2022-06-15 22:32:20 +00:00
Alexandru2909
3b4e11b796 For #24969 - Display address autofill prompt 2022-06-15 06:43:17 +00:00
Mozilla L10n Automation Bot
685424de9a Import l10n. 2022-06-15 00:45:00 +00:00
Mugurell
ed2857bbe0 For #25586 - Update HTTPs-only setting sumo link 2022-06-14 06:49:39 +00:00
Noah Bond
683226541c For #25490 - Remove PrimaryText and SecondaryText 2022-06-13 21:17:58 +00:00
Mozilla L10n Automation Bot
01be73255e Import l10n. 2022-06-13 00:46:52 +00:00
Mozilla L10n Automation Bot
345f9fd2d2 Import l10n. 2022-06-12 01:24:54 +00:00
Mozilla L10n Automation Bot
2ecfa3bcf7 Import l10n. 2022-06-11 00:41:03 +00:00
Mugurell
df5786f1e3 For #25381 - Add a setting allowing to toggle Pocket sponsored stories 2022-06-10 15:01:35 +00:00
Mozilla L10n Automation Bot
13c34f16dd Import l10n. 2022-06-10 00:44:11 +00:00
Jan-Erik Rediger
ba7028ec6a Upgrade to Glean v50 and adopt new Glean APIs 2022-06-09 18:08:04 -04:00
MatthewTighe
8a7e8e7b96 for #25545: turn off task continuity in nightly 2022-06-09 20:56:18 +00:00
indu
31336c0d87 For #25413: App should not be locked in landscape when a tab or custom tab loads while in pip mode
App should not be locked in landscape while in pip mode when a tab or custom tab loads

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
2022-06-09 19:48:40 +03:00
mcarare
e81c38e8fd For #25563: Avoid showing delete all dialog twice. 2022-06-09 15:15:43 +00:00
mcarare
78e4875713 For #25563: Ensure popBackStack does not navigate away from HistoryFragment. 2022-06-09 15:15:43 +00:00
mcarare
ed480b24c4 For #25563: Show Snackbar only if fragment is still attached. 2022-06-09 15:15:43 +00:00
Mugurell
1a2be2065a For #24744 - Observe and update selector icon while the View is attached
This avoids having to pass another LifecycleOwner from outside and will ensure
the View is update only in the bounds of it being attached.

The observe-update code is moved to bind(..) as that seems like a more
idiomatic callback for updating an already constructed View rather than
createView() which should only create and return a View.
2022-06-08 11:33:25 +00:00
Mozilla L10n Automation Bot
070d6288e1 Import l10n. 2022-06-08 00:47:04 +00:00
Roger Yang
b48123aa50 Issue #24522: Add telemetry for unified search 2022-06-07 14:33:46 +00:00
Arturo Mejia
6f0aea9fd9
For #21102: Build with SDK for Android 12 / API 31 (#25494)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-06-07 09:36:46 +00:00
indu
ac31a1ace4 For #25455 : Let A-C handle toolbar expanding when URL changes
This fix allows the toolbar to be visible after the user clicks on a link and scrolls

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
2022-06-07 11:49:16 +03:00
Mozilla L10n Automation Bot
ca800f122e Import l10n. 2022-06-07 01:17:38 +00:00
Mozilla L10n Automation Bot
2cd6e15db8 Import l10n. 2022-06-06 00:40:46 +00:00
Arturo Mejia
6a33f29a91 Revert "For #24455 - Migrate NoCollectionsMessageViewHolder to Compose"
This reverts commit 7b895aba
2022-06-05 13:26:43 +00:00
Mozilla L10n Automation Bot
f55e21e1df Import l10n. 2022-06-05 00:56:29 +00:00
Mozilla L10n Automation Bot
0e9b9722a1 Import l10n. 2022-06-04 00:48:18 +00:00
Noah Bond
08a84f8353 For #21897 - Convert inactive tabs to compose 2022-06-03 18:49:13 +00:00
mcarare
48cb5ec268 For #25505: Clear the stored result in case there is no listener with the same key set.
This is the case when the sharing happens outside the tabs tray.
2022-06-03 14:01:40 +00:00
Mozilla L10n Automation Bot
2e5c979ef9 Import l10n. 2022-06-02 21:11:55 -04:00
sunil9211
f89e2f4aca For #20848 - Hide Download List delete icon in multiselect mode 2022-06-02 22:17:56 +00:00
Noah Bond
9520b8c1f3 For #25379 - Plug FenixTypography into ListItem, Button, TextButton, and ExpandableListHeader 2022-06-02 21:23:50 +00:00
Noah Bond
4c118f4816 For #25379 - Create a Compose Typography system 2022-06-02 21:23:50 +00:00
Mozilla L10n Automation Bot
e2fdca8d47 Import l10n. 2022-06-02 01:56:13 +00:00
Mozilla L10n Automation Bot
c3811199b4 Import l10n. 2022-06-01 01:40:23 +00:00
Roger Yang
519f3f96fc No issue: Cleanup default toolbar menu 2022-05-31 21:36:25 +00:00
Mugurell
392f585ba0 For #25459 - Show Pocket sponsored stories irrespective of topics selections 2022-05-31 11:07:43 +00:00
mcarare
d20ba1d0fe For #25437: Fix label values for labeled counters. 2022-05-31 10:25:06 +00:00
Mozilla L10n Automation Bot
efef63afb2 Import l10n. 2022-05-31 06:04:06 +00:00
Roger Yang
ff683c67e0 Close #25449: Use "Enter search terms" as hint when using application search engine 2022-05-30 22:56:54 +00:00
Gabriel Luong
980b1f1f7d For #25444 - Remove all unused strings marked moz:removedIn <= 100 2022-05-30 18:17:47 +00:00
Mozilla L10n Automation Bot
5ea4c6533a Import l10n. 2022-05-30 00:59:48 +00:00
Mozilla L10n Automation Bot
b85886eb21 Import l10n. 2022-05-29 15:11:35 -04:00
Arturo Mejia
c9240e20ed No issue: Renew/Remove metrics set to expire in v104 2022-05-28 00:39:23 +00:00
MatthewTighe
3fab791980 fixes #24918: add subregion dropdown to address editor 2022-05-27 22:53:45 +00:00
MatthewTighe
07d4a8599d fixes #25386: turn task continuity on by default for nightly 2022-05-27 22:18:40 +00:00
Gabriel Luong
72a2ee688f For #24300 - Add Tabs to the search engine menu 2022-05-27 21:42:56 +00:00
Alexandru Putanu
b9b1124b66
For #25397 - Telemetry for credit card save and update (#25411)
* For #25397 - Telemetry for credit card save and update

* Use Fenix Issue fro Bugs

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Co-authored-by: Roger Yang <royang@mozilla.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-05-27 21:11:59 +00:00
Mugurell
849d922038 For #25352 - Add a new FML feature to gate Pocket sponsored stories 2022-05-27 18:16:22 +00:00
Roger Yang
229b949650 Issue #24301: Add Bookmarks to the search engine menu 2022-05-27 16:00:29 +00:00
Mugurell
666c839eb7
For #24040: App should not crash when the search widget is clicked while PIP mode is active (#25410)
When the search event is from the search widget while PIP is active, the search fragment opens after the screen is unlocked. This avoids the issue of the search page opening in landscape mode and also the app doesn't crash.

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>

Co-authored-by: indu <indu@ramkystech.com>
2022-05-27 16:44:06 +03:00
Mozilla L10n Automation Bot
ab36146e3e Import l10n. 2022-05-27 00:42:34 +00:00
Arturo Mejia
d2c1893cf9 For #25212: Add tabs prioritization 2022-05-26 20:44:40 +00:00
Mugurell
12070cb7b8 For #25281 - Improve stories impressions recording.
This fixes the following two scenarios resulting in improper recordings:
- sponsored stories were recorded as shown as part of the impressions recording
for all the stories (both recommended and sponsored). Separated the two.
- sponsored stories were not recorded as shown if the user doesn't scroll.
This could happen if just toggling categories which would result in a new list
of stories to show. Will recheck after the time to settle if the composable is
shown.
2022-05-26 18:26:00 +00:00
Mugurell
41a1f31a84 For #25281 - Consider the toolbar when reporting stories visibility
The toolbar may appear over the Pocket stories causing our functionality for
reporting when a specific story is visible to misreport.
At the moment hardcoding the toolbar height in the visibility checks seems like
the best solution to ensure reliable data.
2022-05-26 18:26:00 +00:00
Mugurell
0b972660ca For #25281 - Allow the Pocket section to settle before reporting impressions
Currently just a hack that will ensure more reliable data.
This will have to be re-evaluated after the homescreen is migrated to compose.
2022-05-26 18:26:00 +00:00
Mugurell
dfa5281b23 For #25281 - Pace and rotate sponsored stories
A new way to be able to reliably record actual impressions of sponsored stories
was needed and based on this data we can ensure we are promoting fresh stories
(with fewer impressions) or the ones with a higher priority.
2022-05-26 18:26:00 +00:00
Roger Yang
2b777c3428 Issue #24299: Do not show history search engine in the search settings 2022-05-26 14:42:58 +00:00
Mozilla L10n Automation Bot
123a7aba3d Import l10n. 2022-05-26 00:39:56 +00:00
Arturo Mejia
b7c1f8ef6b Revert "For #23966 - Migrate MessageCardViewHolder to Compose"
This reverts commit aea6124851.
2022-05-25 23:10:28 +00:00
Noah Bond
ebd97f5a34 For #25291 - Swap the new TextButton composable into WallpaperSettings 2022-05-25 22:24:46 +00:00
Noah Bond
2165ae501a For #25291 - Create a TextButton composable component 2022-05-25 22:24:46 +00:00
Roger Yang
3de38984fd Issue #24299: Sort unified search selector menu items based on user settings 2022-05-25 19:17:44 +00:00
mcarare
0127b39fad For #25313: Handle exceptions when getting ClipData.Item. 2022-05-25 18:25:54 +00:00
Mugurell
2343b7534c For #25311 - Set tokens used when communicating with Pocket 2022-05-25 15:53:24 +00:00
Arturo Mejia
98e3b8bf52 For #25374: Skip action validation for control messages 2022-05-25 14:55:28 +00:00
Mugurell
75a2ed8c30 For #25025 - Old imports cleanup.
Importing `R.string` does allow to avoid the `R` when using a String from
Resources but seems like a small gain to break app consistency.
2022-05-25 07:28:57 +00:00
Mugurell
2074131a58 For #25025 - Show sponsored stories on debug only
The design asks for a new row in between the primary and the secondary text so
I went with making "ListItemTabSurface" public allowing for customizing the
content it will show but keeping the same layout and general UX.
2022-05-25 07:28:57 +00:00
Mugurell
06d4384c11 For #25025 - Rename PocketStoriesChange to PocketStoriesClean
PocketStoriesChange was called only once - to clean the shown stories when the
user gets to the homescreen and the Pocket feature is disabled - useful for the
situations in which the user returns after disabling the feature in settings.

Populating the store with recommended stories to show was already happening
based on 'PocketStoriesCategoriesChange' and sponsored stories will be added by
using 'PocketSponsoredStoriesChange' so renaming 'PocketStoriesChange' will
help on reducing any confusion in the future.

Also added documentation for all Pocket related actions from AppStore and
removed the 'UndocumentedPublicClass' detekt suppressions.
2022-05-25 07:28:57 +00:00
Mugurell
bd1feeaac9 For #25025 - Download sponsored stories on debug only 2022-05-25 07:28:57 +00:00
Mugurell
1c7e788bae For #25025 - Use the PocketStory supertype
This prepares extending support from just `PocketRecommendedStory` to
`PocketSponsoredStory` also.
2022-05-25 07:28:57 +00:00
Mugurell
abff68a31b For #25025 - Hardcode showing at max 8 Pocket stories
The default was already 8. This is now being moved closer to the source from
where the stories to be shown are emitted.
With the addition of sponsored stories at fixed positions having to support a
variable number of stories being returned from AppState#getFilteredStories
means increased complexity with no benefit.
2022-05-25 07:28:57 +00:00
sarah541
aea6124851 For #23966 - Migrate MessageCardViewHolder to Compose 2022-05-25 04:14:10 +00:00
Mozilla L10n Automation Bot
a3d930b5e2 Import l10n. 2022-05-25 00:46:21 +00:00
mike a
3904cb9340 Closes #25368: duplicate items in history
Change pagination to be based on loadSize of DataSource
2022-05-24 20:11:16 +00:00
mcarare
a0a02e5627 For #25360: Selectively update addresses preference only when needed. 2022-05-24 15:44:52 +00:00
Mozilla L10n Automation Bot
c5b4faf335 Import l10n. 2022-05-24 00:43:23 +00:00
Alexandru2909
73dcc0c6d6 For #23173 - CheckChanged use a single variable instead of two for checked status 2022-05-23 09:36:24 +00:00
Alexandru2909
bea17a4ab8 For #23670 - Update collection on tab removal 2022-05-23 08:30:56 +00:00
mcarare
cb4f8ed0c0 For #24968: Add preference for enabling/disabling addresses autofill.
For #24968: Add preference for enabling/disabling addresses autofill.
2022-05-23 07:30:07 +00:00
Mozilla L10n Automation Bot
25075fe4b3 Import l10n. 2022-05-23 00:45:08 +00:00
Mozilla L10n Automation Bot
83af557f37 Import l10n. 2022-05-22 00:44:54 +00:00
Robert-Aron293
76ea2fa3e4 For #22310 - Change tab holder's checkbox state when pressing "Select All"/"Deselect All" 2022-05-20 21:20:17 +00:00
Roger Yang
5bb9e50e96 Close #25288: Disable autocomplete for unified history search 2022-05-20 16:51:27 +00:00
JLRoberts
479e44b0a1 For #23700 - HistoryFragment: Exit edit mode when multi-selection is opened in tabs or shared.
This mirrors behavior currently in Bookmarks library with the same actions.
2022-05-20 15:51:07 +00:00
Gabriel Luong
f25129c8ac For #24991 - Refactor the HomeMenu creation from HomeFragment to HomeMenuBuilder 2022-05-20 07:26:56 +00:00
Mozilla L10n Automation Bot
ba2af02407 Import l10n. 2022-05-20 02:19:22 +00:00
MatthewTighe
676d7090f0 Fixes #24917: add country dropdown to address editor 2022-05-19 23:52:05 +00:00
Gabriel Luong
9a965e420d For #25119 - Add Secondary, Tertiary and Destructive Button composable components 2022-05-19 22:19:37 +00:00
James Hugman
165ce0151e Filter messaging experiments from the Studies screen 2022-05-19 15:37:11 +00:00
Gabriel Luong
0001f00f40 For #24936 - Replace ListItemIcon with IconButton and Icon 2022-05-19 02:09:48 +00:00
Mozilla L10n Automation Bot
f2e24d66a1 Import l10n. 2022-05-19 00:46:25 +00:00
Roger Yang
7f29461c75 Issue #24299: Add history to the search engine menu 2022-05-18 19:48:26 +00:00
Gabriel Luong
9e8ee28e40 For #25264 - Refactor toShortUrl extension function from TabSessionState to String 2022-05-18 17:29:13 +00:00
Mugurell
a93e434f0d For #24316 - Migrate TabInCollectionViewHolder to Compose 2022-05-18 15:24:52 +00:00
jhugman
30fa80151d
Change FxNimbus/Nimbus startup sequence (#25266)
* Change FxNimbus initialization sequence

Add cache invalidation

* Change ordering of message restoration and Nimbus initialization

* Address reviewer comments
2022-05-18 13:23:26 +00:00
Mozilla L10n Automation Bot
b002de7700 Import l10n. 2022-05-18 00:54:10 +00:00
Arturo Mejia
9a27030f87 For #25209: Avoid trying to download wallpapers without a server URL. 2022-05-17 20:52:14 +00:00