ishan/fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
7,908 Commits 34 Branches 356 Tags 125 MiB
e7d64d886e
Commit Graph

6585 Commits

Author SHA1 Message Date
Mozilla L10n Automation Bot
7e66c02363 Import l10n. 2021-11-05 00:48:20 +00:00
Roger Yang
04618983aa Close #22299: Add history search term group telemetry 2021-11-04 22:08:56 +00:00
Grisha Kruglov
294997e559 No issue: history view search group missing 
Our boundary conditions for matching search groups to visits was wrong.

This change switches the boundary buffer to only be applied to history
items, not the metadata items.

In other words, when checking if any of the metadata items match the
current "page" of history, we'll be looking to see if the item falls
within this time window:
buffer - oldest history item <= metadata item <= newest history item +
buffer

There's a separate problem with buffer though: it's reset to 0 when requested
offset is >0, but that requires a larger refactor of this code, for a
separate PR.
 2021-11-04 16:02:18 +00:00
Oana Horvath
4d88c521ac For #22304 & #22256: Disabled failing visitedUrlHistoryTest & editCustomSearchEngineTest tests 2021-11-04 15:18:47 +00:00
Mozilla L10n Automation Bot
ed0389abe3 Import l10n. 2021-11-04 14:44:09 +00:00
Michael Comella
7d67b84a92 For #22177: add SearchDialogFragmentConstraintLayout; has markers. 
Here's a profile with these changes: https://share.firefox.dev/3vTpZha
 2021-11-04 05:26:39 +00:00
Michael Comella
bc6d8be9c1 For #22177: change onMeasure/onLayout markers into a single track + draw. 
When you want to look at one of these markers, you usually want to look
at all three so I found that having them on a single track was easier to
follow. Since they run in sequence, they should never overlap and that
should minimize confusion.
 2021-11-04 05:26:39 +00:00
Michael Comella
ed8f2c0bc3 For #22177: rename RootLinearLayout -> HomeActivityRoot... 
This is so we can be more specific with the detail text in our markers.
 2021-11-04 05:26:39 +00:00
Elise Richards
6296ed939f
For #21313: Renew product telemetry expiring in December (#21316) 
* For #21313: Product telemetry renewals for December

* For #21313: Data review for december product telemetry renewals

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-11-04 04:28:52 +00:00
Elise Richards
4f55f16bd7
For #21313: Remove expiring/unused metrics for December (#21789) 
* Remove crash reporter metrics

* Remove tab counter menu item probe

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-11-04 03:54:18 +00:00
Christian Sadilek
76bb0c3b37 Closes #21659: Add SERPs to history search groups 2021-11-03 23:19:46 -04:00
Noah Bond
8caefbe2d5
Recent bookmark count telemetry (#22293) 
* For #22075 - Added event to track the count of recent bookmarks

* For #22075 - Added data review issue number

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-11-04 00:14:21 +00:00
Arturo Mejia
cff78afe27 For #22078 Selecting search group in Jump back in switches active tab 2021-11-03 22:02:22 +00:00
Matt Boris
1809bea49d For #22281 Fix studies opt out learn more link 2021-11-03 20:19:49 +00:00
Gabriel Luong
6747e9d554 For #21973 - Remove @color/search_suggestion_indicator_icon_color_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
baa8c6582a For #21973 - Remove @color/accent_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
6770a70bdd For #21973 - Remove @color/foundation_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
f7f942f2d9 For #21973 - Remove @color/tab_tray_selected_mask_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
d6002f3307 For #21973 - Remove @color/tab_tray_item_thumbnail_icon_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
b7c3d0ec5a For #21973 - Remove @color/tab_tray_item_thumbnail_background_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
e304885581 For #21973 - Remove @color/tab_tray_heading_icon_menu_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
8d9550a6a7 For #21973 - Remove @color/tab_tray_item_media_background_dark_them redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
2b996a607c For #21973 - Remove @color/tab_tray_item_divider_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
19a947240b For #21973 - Remove @color/tab_tray_toolbar_background_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
3fd6f4c420 For #21973 - Remove @color/tab_tray_item_background_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
ee59848064 For #21973 - Remove @color/tab_tray_item_url_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
498d8ccc19 For #21973 - Remove @color/tab_tray_item_text_dark_theme redirection 2021-11-03 19:38:26 +00:00
Michael Comella
0c079fde91 Closes #22213: add marker for LayoutInflater.inflate. 
Here is a profile with this change: https://share.firefox.dev/3mlQSHu
 2021-11-03 19:06:48 +00:00
Arturo Mejia
5a11985d22 No issue: Address tracking protection exceptions breaking changes 2021-11-03 13:01:05 -04:00
AndiAJ
1066acbe1e Improve deleteBookmarkInEditModeTest UI test coverage 2021-11-03 06:34:52 +00:00
Mozilla L10n Automation Bot
3f7cd1be8c Import l10n. 2021-11-03 01:04:35 +00:00
Arturo Mejia
2061779938 For #22170 record auto-close prompt telemetry events 2021-11-03 00:26:17 +00:00
Roger Yang
930599407c No issue: Show snackbar when opening non-http URL 2021-11-02 23:44:15 +00:00
Noah Bond
a06b04ec6d
MR2 Telemetry: Recent tabs section probe (#22166) 
* For #22107 - Added probe to track if the Recent tabs / jump back in section is visible

* For #22107 - Fixed lint errors

* For #22107 - added data review number to metric

* For #22166 - fixed expiration date

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-11-02 23:08:30 +00:00
Gabriel Luong
9a53a12c57 For #21973 - Remove @color/onboarding_illustration_deselected_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
e586d27983 For #21973 - Remove @color/search_suggestion_indicator_icon_bookmark_color_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
5c32efa9a3 For #21973 - Remove @color/preference_section_header_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
0cb91151b1 For #21973 - Remove @color/prompt_login_edit_text_cursor_color_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
f436d3ef02 For #21973 - Remove @color/add_on_private_browsing_interior_icon_background_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
90fd1ea363 For #21973 - Remove @color/add_on_private_browsing_exterior_circle_background_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
830ade29f9 For #21973 - Remove @color/sync_disconnected_background_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
eb6de2b21c For #21973 - Remove @color/sync_disconnected_icon_fill_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
c9afe46dd6 For #21973 - Remove @color/toolbar_[start|center|end]_gradient_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
6923a27be7 For #21973 - Remove @color/toolbar_divider_color_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
37058f596e For #21973 - Remove @color/swipe_delete_background_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
3cf985d09c For #21973 - Remove @color/onboarding_illustration_selected_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
d71447a691 For #21973 - Remove @color/onboarding_card_background_[start|end]_gradient_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
075f3a3dd9 For #21973 - Remove @color/disabled_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
25592dc25c For #21973 - Remove @color/shadow_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
35a235c598 For #21973 - Remove @color/neutral_faded_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
2f4e0e14ba For #21973 - Remove @color/neutral_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
b682f2d5c5 For #21973 - Remove @color/tab_ring_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
7019e32f40 For #21973 - Remove @color/scrimEnd_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
ee96021f19 For #21973 - Remove @color/scrimStart_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
d516eefb1d For #21973 - Remove @color/recently_used_share_menu_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
ec259fbfd7 For #21973 - Remove @color/tab_history_item_selected_background_light_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
dff26e0ce1 For #21973 - Remove @color/menu_item_button_light_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
e50a2b3cb3 For #21973 - Remove @color/search_suggestion_indicator_icon_bookmark_color_light_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
f5f96d8766 For #21973 - Remove @color/search_suggestion_indicator_icon_color_light_them redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
679d7e5161 For #21973 - Remove @color/prompt_login_edit_text_cursor_color_light_them redirection 2021-11-02 19:49:20 +00:00
Jonathan Almeida
9bb49585ea No issue: Merge our inactive tab interactor/controllers 2021-11-02 17:12:45 +00:00
Jonathan Almeida
f363b145f2 No issue: Remove unused InactiveTabState code 2021-11-02 17:12:45 +00:00
Mugurell
207e85e59d For #22155 - Inactive tabs count telemetry 
A quantity probe in the metrics ping means we'll loose the granularity events
provided but it will be easier to extract the values.

For reporting whether the inactive tabs feature is enabled or not we already
have the "preferences.inactive_tabs_enabled" probe so I didn't duplicate this.
 2021-11-02 16:32:00 +00:00
Roger Yang
a46905b5e7 Issue #22057: Add search term groups telemetry 2021-11-02 15:46:29 +00:00
Christian Sadilek
687209fee8 Introduce test rule to work around intermittent mockk failures 2021-11-02 15:14:18 +00:00
AndiAJ
ff0befdd1d Improve coverage for cancelCreateBookmarkFolderTest UI test 2021-11-02 11:55:33 +00:00
AndiAJ
979d8a79cd For #18421 re-enable verifyContextOpenImageNewTab, verifyContextOpenLinkNewTab & verifyContextOpenLinkPrivateTab UI tests 2021-11-02 11:16:33 +00:00
Mugurell
018fe15072 For #22138 - Install source metrics probe 2021-11-02 09:12:34 +00:00
Mugurell
9cce30b824 For #22226 - Open grouped history entries the same as individual ones 2021-11-02 07:59:13 +00:00
Roger Yang
4e5c9a3440 Close #22172: Add Recent searches telemetry 2021-11-02 04:17:10 +00:00
Roger Yang
9c970a5276 Close #22103: Add recent bookmarks telemetry 2021-11-02 01:35:36 +00:00
Mozilla L10n Automation Bot
b698d6ac77 Import l10n. 2021-11-02 00:47:31 +00:00
Elise Richards
7480e806c7 For #22175: Add data review link 2021-11-01 21:24:00 +00:00
Elise Richards
e4cc22fb71 For #22175: Telemetry event for deleting a search term group from the recent searches section on home 2021-11-01 20:40:05 +00:00
Jonathan Almeida
8c43ccc0f6 Issue #20704: Use AppStore for inactive expanded state 2021-11-01 19:23:42 +00:00
Jonathan Almeida
9cef9357b1 Close #20704: Add AppStore to Components 2021-11-01 19:23:42 +00:00
Oana Horvath
cee72a965b For #21397: disabled homescreen features to improve collections visibility 2021-11-01 15:52:42 +00:00
Arturo Mejia
940af156eb For #22192 add telemetry for studies 2021-11-01 14:08:52 +00:00
Mozilla L10n Automation Bot
f3bf56ac60 Import l10n. 2021-11-01 07:28:34 +00:00
Mozilla L10n Automation Bot
ef43107e67 Import l10n. 2021-10-31 17:18:08 +00:00
Mozilla L10n Automation Bot
57c375cea2 Import l10n. 2021-10-30 00:34:58 +00:00
Gabriel Luong
e3e0b9c207
For #21973 - Reduce redirection of colors variables between dark and light theme - Part 3 (#22220) 
* For #21973 - Remove @color/disabled_light_theme redirection

* For #21973 - Remove @color/scrimStart_light_theme redirection

* For #21973 - Remove @color/scrimEnd_light_theme reddirection

* For #21973 - Remove @color/synced_tabs_separator_light_theme redirection

* For #21973 - Remove @color/toolbar_[start/center/end]_gradient_light_theme redirection

* For #21973 - Remove @color/toolbar_divider_color_light_theme redirection

* For #21973 - Remove @color/fill_link_from_clipboard_light_theme redirection

* For #21973 - Remove @color/sync_disconnected_icon_fill_light_theme redirection

* For #21973 - Remove @color/sync_disconnected_background_light_theme redirection

* For #21973 - Remove @color/swipe_delete_background_light_theme redirection

* For #21973 - Remove @color/onboarding_illustration_selected_light_theme redirection

* For #21973 - Remove @color/onboarding_illustration_deselected_light_theme redirection

* For #21973 - Remove @color/add_on_private_browsing_exterior_circle_background_light_theme redirection

* For #21973 - Remove @color/add_on_private_browsing_interior_icon_background_light_theme redirection

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-10-29 14:08:35 +00:00
Mozilla L10n Automation Bot
c2f0b574fd Import l10n. 2021-10-29 13:39:23 +00:00
Oana Horvath
f6b83e37b1 For #15624 & #17484: improves tab drawer locator & avoids homescreen refreshing 2021-10-29 16:13:19 +03:00
Gabriel Luong
a99b7d3f71 For #21973 - Remove @color/destructive_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
1eb41ff558 For #21973 - Remove @color/shadow_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
9331b971f8 For #21973 - Remove @color/neutral_faded_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
58e9d3dd08 For #21973 - Remove @color/neutral_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
7c9ae669aa For #21973 - Remove @color/tab_ring_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
00b4688fd5 For #21973 - Remove @color/accent_high_contrast_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
cb92e48c0d For #21973 - Remove @color/about_link_dark_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
fe0affa167 For #21973 - Remove @color/above_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
2336f9d9d6 For #21973 - Remove @color/caption_text_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
b510a6d0ca For #21973 - Remove @color/secondary_text_light_theme redirection 2021-10-29 00:50:09 +00:00
Christian Sadilek
3e6cd7d821 Closes #21355: Fix intermittent test failures in BookmarkItemMenuTest 2021-10-28 18:15:55 -04:00
Christian Sadilek
75c70ff814 Closes #21952: Ignore intermittently failing FenixSnackbarKtTest 2021-10-28 18:15:55 -04:00
Christian Sadilek
f4be38dafc Closes #21438: Ignore intermittently failing ExceptionsListItemViewHolderTest 2021-10-28 18:15:55 -04:00
Christian Sadilek
5d7bb70f55 Closes #22081: Ignore intermittently failing DefaultBrowsingModeManagerTest 2021-10-28 18:15:55 -04:00
Christian Sadilek
99f0aaa834 Closes #21332: Ignore intermittently failing WebPushEngineIntegrationTest 2021-10-28 18:15:55 -04:00
Christian Sadilek
3ffb11fd3b Closes #21952: Ignore intermittently failing FenixSnackbarDelegateTest 2021-10-28 18:15:55 -04:00
Gabriel Luong
09bd9e7ba2 For #21888 - Use Hero images for Jump back in 2021-10-28 21:02:13 +00:00
Arturo Mejia
d0d87a6d6d No issue update strings ids 2021-10-28 13:49:58 -04:00
AndiAJ
71d151ef18 For #18421 re-enable verifyContextCopyLink and verifyContextCopyImageLocation UI tests 2021-10-28 15:47:25 +00:00
Gabriel Luong
8f85ef2d5b For #21973 - Remove @color/top_site_title_text_light_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
28883384a7 For #21973 - Remove @color/inset_dark_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
9a85545da5 For #21973 - Remove @color/top_site_title_text_dark_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
59f725d2fb For #21973 - Remove @color/synced_tabs_separator_dark_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
35c7ef6bb6 For #21973 - Remove @color/toggle_off_knob_light_theme and @color/toggle_off_track_light_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
e2093f2054 For #21973 - Remove redirection of color variables for the collection color variables 2021-10-28 14:19:59 +00:00
Gabriel Luong
4001f4ee6f For #21973 - Remove redirection of color variables for the tabs tray color variables 2021-10-28 14:19:59 +00:00
Gabriel Luong
1a472c3507 For #21973 - Remove @color/caption_text_dark_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
78e90d5f0e For #21973 - Remove @color/contrast_text_dark_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
2456e9b5f5 For #21973 - Remove @color/secondary_text_dark_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
959a142c92 For #21973 - Use destructive_normal_theme in place of R.color.design_color 2021-10-28 14:19:59 +00:00
Mozilla L10n Automation Bot
b7bdd94e71 Import l10n. 2021-10-28 00:32:14 +00:00
Michael Comella
9721723af5 For android-components#11161: pass profiler into AwesomeBar. 
This will add two new markers:
- SuggestionFetcher.fetch
- Suggestion update

This is a profile with the markers: https://share.firefox.dev/3E4PbEk
 2021-10-27 22:02:12 +00:00
AndiAJ
4fe8921a82 For #18421 fix and re-enable verifyContextShareLink, verifyContextSaveImage and verifyContextMixedVariations UI tests 2021-10-27 14:05:35 +00:00
Arturo Mejia
a2c7dfb26e For #22170: Add telemetry for the auto-close prompt 2021-10-27 13:17:35 +00:00
Arturo Mejia
9154371ba5 For #21906 ⁃ Update strings removal version 2021-10-27 02:49:58 +00:00
Mozilla L10n Automation Bot
59a069882d Import l10n. 2021-10-27 00:46:32 +00:00
Grisha Kruglov
04a35c81b8 Closes #22083 - Match history groups to history pages by all items within the group 
When deciding if we should include a history group within the "page of
history" results on the History View UI, we used to look at the most
recent timestamp of the metadata items within the group, and see if that
falls within the range of the timestamps of the history page, +/- some
buffer.

This assumes that each metadata entry will have a corresponding history
item. However, that's not true - when restarting the app, the selected
tab will be restored, and when opening History View right after we'll
record some metadata for it. However, we won't record a history visit
during the app restore for the selected tab.

That's all correct, but the assumption around group matching to history is now incorrect.

This patch changes the logic to instead look at every item within the
group, and see if any of them match the time window of the current
history page. This has a side-effect of also displaying search groups
multiple times on diffenent pages of history, if it makes sense to do so chronologically.
I think that's fine, it reflects reality at least (e.g. items within the
group may have been visited at very different points in time).

Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
 2021-10-26 16:10:58 -07:00
Elise Richards
347f82f2f5
For #21313: Renew metrics for December - never expire updates (#21788) 
* For #21313: Renew metrics for December - never expire updates

* For #21313: data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-10-26 22:00:06 +00:00
Arturo Mejia
d943be0e53 For #22034: Inactive tabs prompt is redisplayed after dismissing by turning on Auto close 2021-10-26 21:34:50 +00:00
MickeyMoz
a4bcecf8c5 Update Android Components version to 95.0.20211026143215. 
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2021-10-26 20:21:03 +00:00
Gabriel Luong
44666ca2ca For #21776 - Call chain on collection type may be simplified 2021-10-26 18:26:50 +00:00
Gabriel Luong
100547130e For #21776 - Add package path to TabGroupViewHolder 2021-10-26 18:26:50 +00:00
Gabriel Luong
b04bf99b7d For #21776 - Remove unused symbols 2021-10-26 18:26:50 +00:00
Gabriel Luong
b54698a3f2 For #21776 - Class member can have 'private' visibility 2021-10-26 18:26:50 +00:00
Gabriel Luong
3115f1343f For #21776 - Replace Java static method with Kotlin analog 2021-10-26 18:26:50 +00:00
Gabriel Luong
660300f770 For #21776 - Replace 'isEmpty' with 'ifEmpty' 2021-10-26 18:26:50 +00:00
Gabriel Luong
603ba63962 For #21776 - 'protected' visibility is effectively 'private' in a final class 2021-10-26 18:26:50 +00:00
Gabriel Luong
da395d1038 For #21776 - Local 'var' is never modified and can be declared as 'val' 2021-10-26 18:26:50 +00:00
Gabriel Luong
5afe393b8f For #21776 - Remove unused imports 2021-10-26 18:26:50 +00:00
Gabriel Luong
76c746b982 For #21776 - Remove unnecessary type argument 2021-10-26 18:26:50 +00:00
Gabriel Luong
272d31b2b4 For #21776 - Remove unnecessary parentheses from function call with lambda 2021-10-26 18:26:50 +00:00
Gabriel Luong
6d1d4bea93 For #21776 - Remove redundant qualifier name 2021-10-26 18:26:50 +00:00
Gabriel Luong
1039a92281 For #21776 - Remove reductant SAM constructor 2021-10-26 18:26:50 +00:00
Gabriel Luong
ed48dc934a For #21776 - Remove reductant 'suspend' modifier from SecurePrefsTelemetry 2021-10-26 18:26:50 +00:00
Gabriel Luong
d854c282da For #21776 - Remove val from constructor parameter that are never used as a property 2021-10-26 18:26:50 +00:00
codrut.topliceanu
bba787e87e For #21732 - Adds inactive tabs survey on disable + telemetry 2021-10-26 17:50:22 +00:00
Mugurell
6d62aed35f For #21933 - Refresh history items everytime the fragment is opened 2021-10-26 17:24:13 +00:00
Mozilla L10n Automation Bot
c9e769544f Import l10n. 2021-10-26 02:55:02 +00:00
Jonathan Almeida
7666f0e4c2 No issue: Replace TabsTray.Tab with TabSessionState 
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2021-10-26 01:57:47 +00:00
Jonathan Almeida
b2a7877c83 No issue: Disable FenixSnackbarDelegateTest intermittents 2021-10-26 00:21:00 +00:00
Michael Droettboom
c1780cf332
For #21025: Set long term business-critical metrics as non-expiring (#21038) 
* Set long term business-critical metrics as non-expiring.

* Remove quotes around "never"

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-10-25 23:53:02 +00:00
AndiAJ
6149f9faf8 Use identifiers instead of hard coded strings 2021-10-25 17:37:54 +00:00
AndiAJ
d3651eb0fc For #21747 re-enable start on homepage UI test and refactoring work 2021-10-25 17:37:54 +00:00
AndiAJ
b10835992d For #21754 re-enable general settings UI test and refactoring work 2021-10-25 17:37:54 +00:00
AndiAJ
4c343b8b3a For #21004 fix and refactor verifyBasicNavigationToolbarFunctionality UI test 2021-10-25 17:13:13 +00:00
Roger Yang
367c5f42d8 No issue: Add external load flag 2021-10-25 18:02:51 +02:00
Sebastian Kaspari
170fa9705e Update Kotlin and Jetpack Compose versions. 2021-10-25 17:59:17 +02:00
Oana Horvath
52facc9723 For #21628: catch ComposeNotIdleException 2021-10-25 15:39:55 +00:00
Arturo Mejia
ee8c4de62d For #21986 Confirmation when people set tabs to auto-close 
For #22034 Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
 2021-10-25 10:42:22 -04:00
Mayank Agarwal
1a7b486808 Issue #21714: Login button visibility fix on saved logins page 2021-10-25 11:58:51 +02:00
Mugurell
e0bf4f31fa For #21771 - Show url when recent tab's title is not available 
This is the same previously used approach and the same used for tabs tray.
 2021-10-25 09:54:06 +00:00
Mozilla L10n Automation Bot
df2652f9b5 Import l10n. 2021-10-25 00:40:41 +00:00
Mozilla L10n Automation Bot
a8f42cd363 Import l10n. 2021-10-24 00:54:31 +00:00
Mozilla L10n Automation Bot
9e1f596c1e Import l10n. 2021-10-23 01:47:59 +00:00
Michael Comella
ec1a25dfcf For #21921 - post: switch generic marker skip to BaseBrowserFragment. 
Since we instrument the marker with the duration in BaseBrowserFragment,
we should skip on BaseBrowserFragment too, not its subclass,
BrowserFragment.
 2021-10-23 01:21:39 +00:00
Michael Comella
788eb2c5de For #21921: add duration for some BrowserFragment lifecycle markers. 
Here is a sample profile with all the new markers:
https://share.firefox.dev/3lCGoD2
 2021-10-23 01:21:39 +00:00
Michael Comella
3a3c39406a For #21921: add durations for some HomeFragment lifecycle markers. 2021-10-23 01:21:39 +00:00
Michael Comella
f65ea1e972 For #21921: add and register MarkersFragmentLifecycleCallbacks. 2021-10-23 01:21:39 +00:00
Michael Comella
99533626f1 For #21921: rename MarkersLifecycleCallbacks to ...ActivityLifecycle... 
This is to disamibugate with the MarkersFragmentLifecycleCallbacks that
we'll be adding.
 2021-10-23 01:21:39 +00:00
Michael Comella
623914bd89 For #22054: add marker for root view layout/measure. 
The onLayout marker may be redundant to onGlobalLayout marker but I'm not
sure yet so let's leave them both in and observe if that's the case.

Here's a profile with the markers: https://share.firefox.dev/3lZaOQb
 2021-10-23 00:06:37 +00:00
Oana Horvath
1234d8f518 For #22095: fix intermittent click failure in verifyRateOnGooglePlayRedirect UI test 2021-10-22 18:06:32 +00:00
Mugurell
acdde511d3 For #22070 - Prevent crash for when a selected topic does not exist anymore 
The list of selected topics overwrites old data whenever user selects or
deselects another so the old selections will not leak for long.
 2021-10-22 10:53:55 -04:00
Roger Yang
70fc6fc20f Close #22061: Let TabSorter decide if title header should be shown in tabs tray 2021-10-22 14:34:41 +00:00
Mozilla L10n Automation Bot
2d8492d33f Import l10n. 2021-10-22 01:18:49 +00:00
Roger Yang
b5c15280f7 No issue: Only report telemetry when tabs tray is first opened 2021-10-21 22:34:25 +00:00
Mugurell
c4278bfbf6 For #21841 - New telemetry for Google and Baidu top sites removal 2021-10-21 22:10:26 +00:00
Michael Comella
a1ace964de No issue - post: fix ProfilerMarkerFactProcessor tests. 2021-10-21 21:21:21 +00:00
Michael Comella
0faa61b744 No issue: use Fact.value as detailText for markers. 
This allows Facts emitted from ac to provide more details in markers.
 2021-10-21 21:21:21 +00:00
Michael Comella
01e3b4b984 No issue: cache SearchDialogFragment.InlineAutocompleteEditText. 
Assuming the InlineAutocompleteEditText is not being recreated (and I
did not verify this), it's unnecessary to traverse the view hierarchy
to find it more than once so this patch removes the unnecessary
traversals.
 2021-10-21 20:55:47 +00:00
Oana Horvath
34ca959661 For #20754: fix intermittent click failure in verifyAboutFirefoxPreview test 2021-10-21 20:24:15 +00:00
Andrei Joltan
3af6abff18
For #22065 fix flaky privateTabsTrayWithOpenedTabTest UI test (#22068) 
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
 2021-10-21 11:39:49 -04:00
AndiAJ
560de4f396 For #21207 fix flaky updateSavedLoginTest UI test 2021-10-21 13:37:15 +00:00
Mozilla L10n Automation Bot
c0ab0cb1c5 Import l10n. 2021-10-21 00:59:47 +00:00
Gabriel Luong
64ca94b8fa For #22022 - Composify Customize Home Button and update the background color 2021-10-21 00:15:19 +00:00
Gabriel Luong
ada3da59ec For #22022 - Update SelectableChip button background colors 2021-10-21 00:15:19 +00:00
xlog-null
edd1fd9f2c For #22032 - Fix horizontal margin on private home screen 2021-10-20 23:49:22 +00:00
Gabriel Luong
07a6a386f8 For #21753 - Refactor Pocket out of sessioncontrol 2021-10-20 23:08:14 +00:00
Noah Bond
826249497a
MR2 Inactive tabs telemetry (#21908) 
* For #21903 - Added telemetry for interacting with inactive tabs

* For #21903 - Added missing inactive tab delete count event to delete all event

* For #21903 - Added PR numbers to metrics

* For #21903 - Updated broken unit tests. Resolved critical lint warning.

* For #21903 - Fixed inactive tabs setting toggle metric

* For #21903 - Updated FenixApp unit test

* For #21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.

* PR: addendum for last commit that missed a file

* For #21903 - Changed logic check for reporting inactive tab count

* PR: fixed merge conflict

* For #21903 - Removed tab close tracking when the user closes ALL inactive tabs

* For #21903 - Removed individual tab close metric verify from CLOSE ALL test

* For #21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-10-20 22:30:59 +00:00
Gabriel Luong
af48553418 For #21935 - Use photonBlue40 in place of #0090ED 2021-10-20 20:11:52 +00:00
Gabriel Luong
8b3d39f0c0 For #21935 - Use photonDarkGrey20 in place of #4A4A55 2021-10-20 20:11:52 +00:00
Gabriel Luong
541ed5cec6 For #21935 - Use photonPink30 in place of #FF6BBA 2021-10-20 20:11:52 +00:00
Gabriel Luong
5a5ba1c095 For #21935 - Use photonBlue30 in place of #00B3F4 2021-10-20 20:11:52 +00:00
Gabriel Luong
a81912bd98 For #21935 - Use photonViolet30 in place of #C689FF 2021-10-20 20:11:52 +00:00
Gabriel Luong
475d59b781 For #21935 - Use photonYellow90 in place of #960E18 2021-10-20 20:11:52 +00:00
Gabriel Luong
5a7890497f For #21935 - Use photonRed40 in place of #FF6A75 2021-10-20 20:11:52 +00:00
Gabriel Luong
dfd9f7c1ea For #21935 - Use photonDarkGrey50 in place oof #32313C 2021-10-20 20:11:52 +00:00
Gabriel Luong
6010767da7 For #21935 - Use photonBlue50 in place of #0060DF 2021-10-20 20:11:52 +00:00
Gabriel Luong
0e8b797014 For #21935 - Use photonGreen70 in place of #.008787 2021-10-20 20:11:52 +00:00
Gabriel Luong
c379d75c7f For #21935 - Use photonInk20 in place of #312A64 2021-10-20 20:11:52 +00:00
Gabriel Luong
4d61277e88 For #21935 - Use photonViolet50 in place of #9059ff 2021-10-20 20:11:52 +00:00
Gabriel Luong
a31d638191 For #21935 - Use photonYellow70 in place of #C45A27 2021-10-20 20:11:52 +00:00
Gabriel Luong
a02d58dd48 For #21935 - Use photonYellow60 in place of #E27F2E 2021-10-20 20:11:52 +00:00
Gabriel Luong
cd6bcb3d47 For #21935 - Use photonGreen60 in place of #2AC3A2 2021-10-20 20:11:52 +00:00
Gabriel Luong
9048af04be For #21935 - Use photonPink60 in place of #E31587 2021-10-20 20:11:52 +00:00
Gabriel Luong
bd7ced5867 For #21935 - Use photonDarkGrey90 in place of #15141A 2021-10-20 20:11:52 +00:00
Gabriel Luong
e119b8b590 For #21935 - Use photonViolet40 in place of #AB71FF 2021-10-20 20:11:52 +00:00
Gabriel Luong
ff829f9f25 For #21935 - Use photonBlue60 in place of #0250BB 2021-10-20 20:11:52 +00:00
Gabriel Luong
26920baf47 For #21935 - Use photonRed70 in place of #C50042 2021-10-20 20:11:52 +00:00
Gabriel Luong
624afa9e53 For #21935 - Use photonPurple50 in place of #B833E1 2021-10-20 20:11:52 +00:00
Gabriel Luong
8d27963ace For #21935 - Use photonViolet60 in place of #7542E5 2021-10-20 20:11:52 +00:00
Gabriel Luong
20ddedd118 For #21935 - Use photonWhite in place of #FFFFFF 2021-10-20 20:11:52 +00:00
Gabriel Luong
a673305643 For #21935 - Use photonBlack in place of #FF000000 2021-10-20 20:11:52 +00:00
Gabriel Luong
0ae8e36248 For #21935 - Use photonBlue30 in place of #00B3F4 2021-10-20 20:11:52 +00:00
Mugurell
c54e75edec For #22005 - Ensure deleted items are removed from the list 2021-10-20 07:59:35 +00:00
Mozilla L10n Automation Bot
f2d5da4e91 Import l10n. 2021-10-20 00:39:06 +00:00
Mugurell
d3df7369e0
CI for 21827 (#22004) 
* Remove redundant calls to setHasOptionsMenu(false)

Fix memory leaks for credit card and login fragments

* Fixes:

Add link to issue tracker
Use activity?.invalidateOptionsMenu() instead of setHasOptionsMenu(false)
Move it inside of 'if' statement to avoid unintended issues when called improperly
Revert changes to AddLoginFragment.kt

* Fix call invocation to redirectToReAuth() from AddLoginFragment.kt
Fix 'when' statement in redirectToReAuth() to use AddLoginFragment

Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
 2021-10-19 10:52:01 +00:00
Mozilla L10n Automation Bot
4743146ac4 Import l10n. 2021-10-19 01:25:27 +00:00
Arturo Mejia
846aefc0f4 For #21723 Align the default value of the custom cookie setting with the UI 2021-10-19 00:40:55 +00:00
AndiAJ
9a3e94eb31 Improve tabsSettingsMenuItemsTest UI test coverage 2021-10-18 14:45:27 +00:00
Mozilla L10n Automation Bot
c56214453a Import l10n. 2021-10-18 00:37:31 +00:00
Mozilla L10n Automation Bot
91b719ed75 Import l10n. 2021-10-17 00:36:57 +00:00
Mozilla L10n Automation Bot
1c73fc8e20 Import l10n. 2021-10-16 00:34:46 +00:00
Roger Yang
60f7f766da Issue #21893: Keep search group when second to last search term tab is removed 2021-10-15 17:48:23 +00:00
Mozilla L10n Automation Bot
31a0d676ee Import l10n. 2021-10-15 00:35:47 +00:00
Christian Sadilek
c3ef16de61 Closes #21944: Top sites rendered slowly on first load of HomeFragment 2021-10-14 18:04:17 -04:00
Marc Leclair
8d5c6f6082 For #21700: linting fixes 
For #21700: nit fixes
 2021-10-14 21:03:05 +00:00
Marc Leclair
27cd609d0f For #21700: Added option to open in browser instead of automatically doing it 2021-10-14 21:03:05 +00:00
Marc Leclair
c5accf6b32 For #21700: fixed comments 2021-10-14 21:03:05 +00:00
Marc Leclair
c527decda1 For #21700: Created benchmark script runner and edited benchmark gradle file 2021-10-14 21:03:05 +00:00
Jonathan Almeida
625233f664 Close #21910: Fix intermittent failures in SelectTabUseCaseWrapperTest 2021-10-14 18:52:47 +00:00
Grisha Kruglov
0b5b1a738a Do less work while navigating Logins views 
Fetching a set of logins from the store is quite expensive. This commit
avoids doing that while navigating back and forth between the list and
detail views:

- retain processes logins state when navigating into detail view
- use the `get` storage api to obtain specific login, instead of
  `list().filter {...}`
- avoid re-sorting retained logins when navigating back into the list
  view
 2021-10-14 17:34:20 +00:00
Grisha Kruglov
97d93eb564 Make linters happy 2021-10-14 17:34:20 +00:00
Ben Dean-Kawamura
cc247c407f Register the logins key provider 
This is required for sync to work
 2021-10-14 17:34:20 +00:00
Ben Dean-Kawamura
34ec442961 Updating Fenix to work with the new logins API 
Switched to always using `Login` instead of the `SavedPassword` alias.

Made `MasterPasswordTipProvider.saveLogins()` call
`importLoginsAsync()`.  This is needed because it's the only method that
inputs a `Login` rather than a `LoginEntry`.

Moved the `SavedLoginsStorageController.kt.syncAndUpdateList` call
to inside `add()` and `update()`.  This simplifies the error handling a
bit.

Refactored dupe-checking code to use findLoginToUpdate()

Refactored `AddLoginFragment` / `EditLoginFragment` to put the username
error handling code all in 1 method.  I think it's easier to follow the
logic of showing/hiding the error labels when it's all in one place.
This fixes issues #24103 and #24104.  I would love to address #24102,
but I'm not sure what the correct behavior is there so I just kept that
the same.
 2021-10-14 17:34:20 +00:00
Arturo Mejia
25c784b684 For #21906 ⁃ Remove old copy form inactive tabs section 2021-10-14 16:01:59 +00:00
AndiAJ
db2946c78a Fix for ambiguous tabstray_title and with text matcher for audio page 2021-10-14 14:21:08 +00:00
AndiAJ
198f407dd2 For #21769 fix flaky tabMediaControlButtonTest Ui test 2021-10-14 14:21:08 +00:00
Jonathan Almeida
9780dac846 No issue: Always show Make inactive for debug builds 2021-10-14 07:52:39 +00:00
Gabriel Luong
e0991f0fe6 For #21887 - Update Home background color to LightGrey20 2021-10-14 03:40:40 +00:00
Roger Yang
4a8f01beea Close #21573: Add shadow to recent bookmarks section 2021-10-14 02:53:35 +00:00
Mozilla L10n Automation Bot
f4d026d906 Import l10n. 2021-10-14 00:38:56 +00:00
Roger Yang
2b92860966 Close #21917: Update pocket stories card elevation to match other cards 2021-10-13 22:53:56 +00:00
Jonathan Almeida
c554152fba Issue #21707: Correct search grouping logic in extensions 
At this moment, we have two extension methods that have duplicate
functionality to construct search term groupings. One on `List<Tab>` and
one on `List<TabSessionState>`. The former is used for everything
related to tabs piped through the `TabsFeature` and the latter is for
consumers of `BrowserState` directly.

The bug occurs because our implementation of search groupings was
updated only on the former extension, but the `HeaderBinding`, that
observes the BrowserState and updates the title visibility, was using
the latter.

Ideally, we remove this duplication when we no longer have separate data
classes for consumers of `TabsFeature`, but this intermediary fix should
suffice.
 2021-10-13 22:01:07 +00:00
Gabriel Luong
0b17b443dc For #21760 - Remove some unused resources 2021-10-13 20:42:49 +00:00
Grisha Kruglov
2967513083 Fix up HistoryMetadataController tests 2021-10-13 15:45:00 -04:00
Grisha Kruglov
233f0a8a1d Closes #21871 - Eagerly update UI state after search group removal 
Before this patch, this was the behavior - 'remove' button is clicked, we'd ask
the storage to remove metadata (on its IO thread), then navigate to Home
Screen.

This resulted in a race we could end-up on the Home Screen before delete
finishes, so the search groups do not appear to be removed (but,
refreshing the Home Screen again shows that they are removed).

This also resulted in an unnecessary navigation which felt very janky
(screen will "scroll" to the top) and was way more work than necessary.

After this patch, we:
 - dispatch two actions (on browserstore, on homefragmentstore) which
   remove the search groups from any relevant in-memory state; any UI bound to
   this state will be automatically "refreshed"
 - no longer navigate as part of the remove action, so the UI doesn't
   move and removal happens "in-place"
 2021-10-13 15:45:00 -04:00
Christian Sadilek
88fbcc05b7 Handle new OptimizedLoadUrlAction in history metadata middleware 
Upgrades to A-C 95.0.20211013154351
 2021-10-13 15:45:00 -04:00
Jonathan Almeida
722ab9f3ca Issue #21794: Remove rotation; rely on state activated 
It seems like we no longer need to use rotation for the chevron, since
we are now using two different icons within the `ic_chevon` that change
depending on the `state_activated`.
 2021-10-13 19:27:49 +00:00
sunil9211
05d0bca6a3 For #17393: Dead code removed around Delete downloads 2021-10-13 15:08:07 +00:00
AndiAJ
671dfa59c2 For #21540 fix and re-enable editCustomSearchEngineTest 2021-10-13 14:01:02 +00:00
Arturo Mejia
08256ac68c For #21791 Adds tab auto-close prompt 2021-10-13 12:08:59 +00:00
AndiAJ
58e12b18e6 Disable editCustomSearchEngineTest UI test 2021-10-13 06:37:00 +00:00
Arturo Mejia
9439a65e1e For #21838 wait until experiments have been completely opt-out on the nimbus SDK. 2021-10-12 19:31:35 -04:00
AndiAJ
979d99342b For #21620 fix for disabled toggleSearchSuggestions UI test 2021-10-12 16:06:09 +00:00
AndiAJ
64d010dcc8 For #19016 re-enable changeThemeSetting Ui test 2021-10-12 15:14:19 +00:00
Mugurell
e578226f7f For #21861 - Ignore the UnusedResources lint check for localized strings 2021-10-12 14:48:47 +00:00