Commit Graph

6585 Commits

Author SHA1 Message Date
Mozilla L10n Automation Bot
708b78d3a0 Import l10n. 2021-11-20 15:35:23 +00:00
AndiAJ
378ac03e30 Improve privateTabsTrayWithOpenedTabTest UI test coverage 2021-11-19 16:34:21 +00:00
AndiAJ
ec31faef7a Improve verifyOpenTabDetails UI test coverage 2021-11-19 16:34:21 +00:00
AndiAJ
4261ca7ea6 Refactor and improve coverage for empty tabs tray UI tests 2021-11-19 16:34:21 +00:00
Mozilla L10n Automation Bot
f0a3653d7b Import l10n. 2021-11-19 00:51:12 +00:00
Grisha Kruglov
63154a18f9 Closes #22484 - Track direct loads per tab; fix search term lookup
This patch fixes two problems:
1) We were treating "direct tab load" as an event which applies
   uniformally to all tabs, even though it's actually an event which
   happens for a specific tab. This lead to background tabs (pages opened as new tab)
   setting the direct load flag, and then a simultaneously loading
   parent tab would incorrectly interpret that flag for itself.

   The patch switches this tracking from a simple boolean (are we direct
   loading?) to a set of tab IDs that are currently direct loading.

2) In a case when a background tab was loading with a parent who's
   search terms were cleared by a direct load, we were not trying to
   lookup search terms on the background tab's historyMetadata key,
   which exists to capture search terms for this exact scenario.

   The patch adds an additional fallback lookup for that path.
2021-11-18 15:52:01 +00:00
Oana Horvath
4892f0ddbe For #21002: add missing steps to selectSearchEnginesShortcutTest, addPredefinedSearchEngineTest 2021-11-18 15:08:00 +00:00
Grisha Kruglov
77672dfa15 Post: move group removal logic into PagedHistoryProvider
This moves the group removal logic to the place where the groups are
actually formed. This helps clean-up the fragment code a bit, and
removes the awkward 'allow mutate some random internal state' API from
the provider.
2021-11-17 16:48:25 -05:00
Grisha Kruglov
45d4807bfe Closes #22472: Filter out redirects from History search groups 2021-11-17 16:48:25 -05:00
AndiAJ
2c9efac286 Improve mainMenuAddToHomeScreenTest UI test coverage 2021-11-17 18:29:02 +00:00
AndiAJ
e265da0cb4 startOnLastTab UI smoke test 2021-11-17 15:33:31 +00:00
AndiAJ
4ff64ad7ca recentBookmarksOption UI smoke test 2021-11-17 15:33:31 +00:00
AndiAJ
eee83c9cbd jumpBackInOption UI smoke test 2021-11-17 15:33:31 +00:00
AndiAJ
7460461e16 startOnHomepageTest refactoring work 2021-11-17 15:33:31 +00:00
Mozilla L10n Automation Bot
364fecf9d4 Import l10n. 2021-11-17 02:12:26 +00:00
Christian Sadilek
8c88561d4b Update lastAccess timestamp of selected tab when launching to home 2021-11-17 01:04:22 +00:00
Roger Yang
24e4452cb5 Close #22402: Add top placeholder for home 2021-11-16 23:05:45 +00:00
Noah Bond
dde916038d
MR2 Telemetry: Homescreen view count (#22377)
* For #22146 - Added counter for home screen views

* For #22146 - Added PR number to metrics

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-11-16 22:30:48 +00:00
Mugurell
d4a6facd81 For #22155 - Store inactive tabs count telemetry when user opens tabs tray
Setting this value in FenixApplication.onCreate was buggy because of a race
with restoring BrowserState.
Setting it here would ensure a better granularity of the events and so to more
accurate reporting.
2021-11-16 21:04:16 +00:00
Mugurell
17865bdf66 For #22147 - New search term groups telemetry 2021-11-16 16:40:07 +00:00
AndiAJ
f91285881d Improve homeThreeDotMenuItemsTest UI test coverage 2021-11-16 13:44:32 +00:00
Mozilla L10n Automation Bot
f466d65256 Import l10n. 2021-11-16 01:33:06 +00:00
Arturo Mejia
94a543a403 For #22271 Improve URL accessing from the clipboard for Android 12 and above. 2021-11-15 15:24:52 +00:00
Mugurell
c42ccb4966 For #22388 - Update content description of the delete button 2021-11-15 08:00:20 +00:00
Mozilla L10n Automation Bot
abcafa55f0 Import l10n. 2021-11-14 00:44:24 +00:00
Mozilla L10n Automation Bot
d29fd55c8b Import l10n. 2021-11-12 00:31:53 +00:00
Oana Horvath
ba91180e85 No issue: creates new SmokeTest annotation.
Updates smoke tests list according to the ones in TestRail.
2021-11-11 09:30:50 +00:00
Mozilla L10n Automation Bot
b0ad98a204 Import l10n. 2021-11-11 00:48:58 +00:00
Noah Bond
811f255b71
MR2 Telemetry: Opening screen preference (#22333)
* For #22145 - Added telemetry to the opening screen preference.

* For #22145 - Added PR number to metric

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-11-10 20:13:40 +00:00
Noah Bond
2e5555d034
MR2 telemetry - Inactive tabs CFR (#22301)
* For #22298 - Added telemetry to inactive tabs CFR

* For #22298 - added PR issue number to metrics

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-11-10 19:47:21 +00:00
Jonathan Almeida
e3b6e00331 Close #22223: Move to the selected page when switching modes 2021-11-10 18:25:44 +00:00
Mozilla L10n Automation Bot
210587b735 Import l10n. 2021-11-10 00:32:32 +00:00
Grisha Kruglov
9a4a4713ac No issue: clean up code duplication in PagedHistoryProvider 2021-11-09 23:41:54 +00:00
AndiAJ
1ade096145 For #22256 re-enable editCustomSearchEngineTest UI test 2021-11-09 17:23:31 +00:00
Ben Dean-Kawamura
df953b0021 Make findDuplicate() suspend
findLoginToUpdate() should be suspend, but I didn't get mark it that way
on the initial logins work.  Let's make this one suspend, then I can
update findLoginToUpdate() in a-c.
2021-11-09 15:59:33 +00:00
Mozilla L10n Automation Bot
e52000bb20 Import l10n. 2021-11-09 00:41:29 +00:00
Jonathan Almeida
8ced675817 No issue: Correct TabsTrayAction naming 2021-11-08 22:28:31 +00:00
Jonathan Almeida
08b15689b1 Close #22305: Use TabsTrayStore for populating adapters 2021-11-08 22:28:31 +00:00
Jonathan Almeida
f16300392d Close #22305: Add tab state into the TabsTrayStore 2021-11-08 22:28:31 +00:00
Michael Comella
c026d8b28a For #21084: put git hash on About screen in release builds. 2021-11-08 19:15:16 +00:00
AndiAJ
f4e7547190 Improve verifyEmptyTabTray Ui test coverage 2021-11-08 16:08:28 +00:00
Mugurell
953f6feb17 For #22155 - The inactiveTabsCount probe reports actualInactiveTabs number 2021-11-08 12:32:39 +00:00
Mugurell
f9b67091c6 For #22155 - New BrowserState.actualInactiveTabs public method
This allows querying from all throughout the app which of the current tabs are
inactive while taking into consideration whether the feature is enabled or not
such that when the feature is disabled it will always return an empty result.
2021-11-08 12:32:39 +00:00
Mozilla L10n Automation Bot
2089c29fea Import l10n. 2021-11-08 00:43:25 +00:00
Grisha Kruglov
81b70122d4 No issue: rename test resource file that was causing issues on Windows 2021-11-07 10:34:09 -08:00
Mozilla L10n Automation Bot
8c2cdaa3ff Import l10n. 2021-11-07 00:35:09 +00:00
Mozilla L10n Automation Bot
06f57fdcfe Import l10n. 2021-11-06 01:13:44 +00:00
mike a
d69b5ed456 For #21816: Filename in "Open" PDF dialog overflows screen
Changing the download file name length to the max allowed by AS (251 char, won’t compile if more; max would be 260 for latest windows versions, but generally it is 255), and changing the UI test to check if the long file name is fully visible.
Changing the downloaded dialog layout to properly display really long file names.
2021-11-06 00:23:41 +00:00
Grisha Kruglov
5b889fdb96 For #22342: Make layout constraint for 'recent bookmarks' the same as other sections 2021-11-05 16:49:42 -07:00
Sebastian Kaspari
8c9f0c835a Closes #21695: ThreadPenaltyDeathWithIgnoresListener: Ignore stack traces containing InstrumentationHooks class 2021-11-05 18:21:34 +00:00
Mozilla L10n Automation Bot
7e66c02363 Import l10n. 2021-11-05 00:48:20 +00:00
Roger Yang
04618983aa Close #22299: Add history search term group telemetry 2021-11-04 22:08:56 +00:00
Grisha Kruglov
294997e559 No issue: history view search group missing
Our boundary conditions for matching search groups to visits was wrong.

This change switches the boundary buffer to only be applied to history
items, not the metadata items.

In other words, when checking if any of the metadata items match the
current "page" of history, we'll be looking to see if the item falls
within this time window:
buffer - oldest history item <= metadata item <= newest history item +
buffer

There's a separate problem with buffer though: it's reset to 0 when requested
offset is >0, but that requires a larger refactor of this code, for a
separate PR.
2021-11-04 16:02:18 +00:00
Oana Horvath
4d88c521ac For #22304 & #22256: Disabled failing visitedUrlHistoryTest & editCustomSearchEngineTest tests 2021-11-04 15:18:47 +00:00
Mozilla L10n Automation Bot
ed0389abe3 Import l10n. 2021-11-04 14:44:09 +00:00
Michael Comella
7d67b84a92 For #22177: add SearchDialogFragmentConstraintLayout; has markers.
Here's a profile with these changes: https://share.firefox.dev/3vTpZha
2021-11-04 05:26:39 +00:00
Michael Comella
bc6d8be9c1 For #22177: change onMeasure/onLayout markers into a single track + draw.
When you want to look at one of these markers, you usually want to look
at all three so I found that having them on a single track was easier to
follow. Since they run in sequence, they should never overlap and that
should minimize confusion.
2021-11-04 05:26:39 +00:00
Michael Comella
ed8f2c0bc3 For #22177: rename RootLinearLayout -> HomeActivityRoot...
This is so we can be more specific with the detail text in our markers.
2021-11-04 05:26:39 +00:00
Elise Richards
6296ed939f
For #21313: Renew product telemetry expiring in December (#21316)
* For #21313: Product telemetry renewals for December

* For #21313: Data review for december product telemetry renewals

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-11-04 04:28:52 +00:00
Elise Richards
4f55f16bd7
For #21313: Remove expiring/unused metrics for December (#21789)
* Remove crash reporter metrics

* Remove tab counter menu item probe

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-11-04 03:54:18 +00:00
Christian Sadilek
76bb0c3b37 Closes #21659: Add SERPs to history search groups 2021-11-03 23:19:46 -04:00
Noah Bond
8caefbe2d5
Recent bookmark count telemetry (#22293)
* For #22075 - Added event to track the count of recent bookmarks

* For #22075 - Added data review issue number

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-11-04 00:14:21 +00:00
Arturo Mejia
cff78afe27 For #22078 Selecting search group in Jump back in switches active tab 2021-11-03 22:02:22 +00:00
Matt Boris
1809bea49d For #22281 Fix studies opt out learn more link 2021-11-03 20:19:49 +00:00
Gabriel Luong
6747e9d554 For #21973 - Remove @color/search_suggestion_indicator_icon_color_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
baa8c6582a For #21973 - Remove @color/accent_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
6770a70bdd For #21973 - Remove @color/foundation_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
f7f942f2d9 For #21973 - Remove @color/tab_tray_selected_mask_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
d6002f3307 For #21973 - Remove @color/tab_tray_item_thumbnail_icon_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
b7c3d0ec5a For #21973 - Remove @color/tab_tray_item_thumbnail_background_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
e304885581 For #21973 - Remove @color/tab_tray_heading_icon_menu_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
8d9550a6a7 For #21973 - Remove @color/tab_tray_item_media_background_dark_them redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
2b996a607c For #21973 - Remove @color/tab_tray_item_divider_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
19a947240b For #21973 - Remove @color/tab_tray_toolbar_background_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
3fd6f4c420 For #21973 - Remove @color/tab_tray_item_background_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
ee59848064 For #21973 - Remove @color/tab_tray_item_url_dark_theme redirection 2021-11-03 19:38:26 +00:00
Gabriel Luong
498d8ccc19 For #21973 - Remove @color/tab_tray_item_text_dark_theme redirection 2021-11-03 19:38:26 +00:00
Michael Comella
0c079fde91 Closes #22213: add marker for LayoutInflater.inflate.
Here is a profile with this change: https://share.firefox.dev/3mlQSHu
2021-11-03 19:06:48 +00:00
Arturo Mejia
5a11985d22 No issue: Address tracking protection exceptions breaking changes 2021-11-03 13:01:05 -04:00
AndiAJ
1066acbe1e Improve deleteBookmarkInEditModeTest UI test coverage 2021-11-03 06:34:52 +00:00
Mozilla L10n Automation Bot
3f7cd1be8c Import l10n. 2021-11-03 01:04:35 +00:00
Arturo Mejia
2061779938 For #22170 record auto-close prompt telemetry events 2021-11-03 00:26:17 +00:00
Roger Yang
930599407c No issue: Show snackbar when opening non-http URL 2021-11-02 23:44:15 +00:00
Noah Bond
a06b04ec6d
MR2 Telemetry: Recent tabs section probe (#22166)
* For #22107 - Added probe to track if the Recent tabs / jump back in section is visible

* For #22107 - Fixed lint errors

* For #22107 - added data review number to metric

* For #22166 - fixed expiration date

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-11-02 23:08:30 +00:00
Gabriel Luong
9a53a12c57 For #21973 - Remove @color/onboarding_illustration_deselected_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
e586d27983 For #21973 - Remove @color/search_suggestion_indicator_icon_bookmark_color_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
5c32efa9a3 For #21973 - Remove @color/preference_section_header_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
0cb91151b1 For #21973 - Remove @color/prompt_login_edit_text_cursor_color_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
f436d3ef02 For #21973 - Remove @color/add_on_private_browsing_interior_icon_background_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
90fd1ea363 For #21973 - Remove @color/add_on_private_browsing_exterior_circle_background_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
830ade29f9 For #21973 - Remove @color/sync_disconnected_background_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
eb6de2b21c For #21973 - Remove @color/sync_disconnected_icon_fill_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
c9afe46dd6 For #21973 - Remove @color/toolbar_[start|center|end]_gradient_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
6923a27be7 For #21973 - Remove @color/toolbar_divider_color_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
37058f596e For #21973 - Remove @color/swipe_delete_background_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
3cf985d09c For #21973 - Remove @color/onboarding_illustration_selected_dark_theme redirection 2021-11-02 22:35:46 +00:00
Gabriel Luong
d71447a691 For #21973 - Remove @color/onboarding_card_background_[start|end]_gradient_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
075f3a3dd9 For #21973 - Remove @color/disabled_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
25592dc25c For #21973 - Remove @color/shadow_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
35a235c598 For #21973 - Remove @color/neutral_faded_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
2f4e0e14ba For #21973 - Remove @color/neutral_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
b682f2d5c5 For #21973 - Remove @color/tab_ring_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
7019e32f40 For #21973 - Remove @color/scrimEnd_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
ee96021f19 For #21973 - Remove @color/scrimStart_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
d516eefb1d For #21973 - Remove @color/recently_used_share_menu_dark_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
ec259fbfd7 For #21973 - Remove @color/tab_history_item_selected_background_light_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
dff26e0ce1 For #21973 - Remove @color/menu_item_button_light_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
e50a2b3cb3 For #21973 - Remove @color/search_suggestion_indicator_icon_bookmark_color_light_theme redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
f5f96d8766 For #21973 - Remove @color/search_suggestion_indicator_icon_color_light_them redirection 2021-11-02 19:49:20 +00:00
Gabriel Luong
679d7e5161 For #21973 - Remove @color/prompt_login_edit_text_cursor_color_light_them redirection 2021-11-02 19:49:20 +00:00
Jonathan Almeida
9bb49585ea No issue: Merge our inactive tab interactor/controllers 2021-11-02 17:12:45 +00:00
Jonathan Almeida
f363b145f2 No issue: Remove unused InactiveTabState code 2021-11-02 17:12:45 +00:00
Mugurell
207e85e59d For #22155 - Inactive tabs count telemetry
A quantity probe in the metrics ping means we'll loose the granularity events
provided but it will be easier to extract the values.

For reporting whether the inactive tabs feature is enabled or not we already
have the "preferences.inactive_tabs_enabled" probe so I didn't duplicate this.
2021-11-02 16:32:00 +00:00
Roger Yang
a46905b5e7 Issue #22057: Add search term groups telemetry 2021-11-02 15:46:29 +00:00
Christian Sadilek
687209fee8 Introduce test rule to work around intermittent mockk failures 2021-11-02 15:14:18 +00:00
AndiAJ
ff0befdd1d Improve coverage for cancelCreateBookmarkFolderTest UI test 2021-11-02 11:55:33 +00:00
AndiAJ
979d8a79cd For #18421 re-enable verifyContextOpenImageNewTab, verifyContextOpenLinkNewTab & verifyContextOpenLinkPrivateTab UI tests 2021-11-02 11:16:33 +00:00
Mugurell
018fe15072 For #22138 - Install source metrics probe 2021-11-02 09:12:34 +00:00
Mugurell
9cce30b824 For #22226 - Open grouped history entries the same as individual ones 2021-11-02 07:59:13 +00:00
Roger Yang
4e5c9a3440 Close #22172: Add Recent searches telemetry 2021-11-02 04:17:10 +00:00
Roger Yang
9c970a5276 Close #22103: Add recent bookmarks telemetry 2021-11-02 01:35:36 +00:00
Mozilla L10n Automation Bot
b698d6ac77 Import l10n. 2021-11-02 00:47:31 +00:00
Elise Richards
7480e806c7 For #22175: Add data review link 2021-11-01 21:24:00 +00:00
Elise Richards
e4cc22fb71 For #22175: Telemetry event for deleting a search term group from the recent searches section on home 2021-11-01 20:40:05 +00:00
Jonathan Almeida
8c43ccc0f6 Issue #20704: Use AppStore for inactive expanded state 2021-11-01 19:23:42 +00:00
Jonathan Almeida
9cef9357b1 Close #20704: Add AppStore to Components 2021-11-01 19:23:42 +00:00
Oana Horvath
cee72a965b For #21397: disabled homescreen features to improve collections visibility 2021-11-01 15:52:42 +00:00
Arturo Mejia
940af156eb For #22192 add telemetry for studies 2021-11-01 14:08:52 +00:00
Mozilla L10n Automation Bot
f3bf56ac60 Import l10n. 2021-11-01 07:28:34 +00:00
Mozilla L10n Automation Bot
ef43107e67 Import l10n. 2021-10-31 17:18:08 +00:00
Mozilla L10n Automation Bot
57c375cea2 Import l10n. 2021-10-30 00:34:58 +00:00
Gabriel Luong
e3e0b9c207
For #21973 - Reduce redirection of colors variables between dark and light theme - Part 3 (#22220)
* For #21973 - Remove @color/disabled_light_theme redirection

* For #21973 - Remove @color/scrimStart_light_theme redirection

* For #21973 - Remove @color/scrimEnd_light_theme reddirection

* For #21973 - Remove @color/synced_tabs_separator_light_theme redirection

* For #21973 - Remove @color/toolbar_[start/center/end]_gradient_light_theme redirection

* For #21973 - Remove @color/toolbar_divider_color_light_theme redirection

* For #21973 - Remove @color/fill_link_from_clipboard_light_theme redirection

* For #21973 - Remove @color/sync_disconnected_icon_fill_light_theme redirection

* For #21973 - Remove @color/sync_disconnected_background_light_theme redirection

* For #21973 - Remove @color/swipe_delete_background_light_theme redirection

* For #21973 - Remove @color/onboarding_illustration_selected_light_theme redirection

* For #21973 - Remove @color/onboarding_illustration_deselected_light_theme redirection

* For #21973 - Remove @color/add_on_private_browsing_exterior_circle_background_light_theme redirection

* For #21973 - Remove @color/add_on_private_browsing_interior_icon_background_light_theme redirection

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-10-29 14:08:35 +00:00
Mozilla L10n Automation Bot
c2f0b574fd Import l10n. 2021-10-29 13:39:23 +00:00
Oana Horvath
f6b83e37b1 For #15624 & #17484: improves tab drawer locator & avoids homescreen refreshing 2021-10-29 16:13:19 +03:00
Gabriel Luong
a99b7d3f71 For #21973 - Remove @color/destructive_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
1eb41ff558 For #21973 - Remove @color/shadow_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
9331b971f8 For #21973 - Remove @color/neutral_faded_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
58e9d3dd08 For #21973 - Remove @color/neutral_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
7c9ae669aa For #21973 - Remove @color/tab_ring_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
00b4688fd5 For #21973 - Remove @color/accent_high_contrast_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
cb92e48c0d For #21973 - Remove @color/about_link_dark_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
fe0affa167 For #21973 - Remove @color/above_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
2336f9d9d6 For #21973 - Remove @color/caption_text_light_theme redirection 2021-10-29 00:50:09 +00:00
Gabriel Luong
b510a6d0ca For #21973 - Remove @color/secondary_text_light_theme redirection 2021-10-29 00:50:09 +00:00
Christian Sadilek
3e6cd7d821 Closes #21355: Fix intermittent test failures in BookmarkItemMenuTest 2021-10-28 18:15:55 -04:00
Christian Sadilek
75c70ff814 Closes #21952: Ignore intermittently failing FenixSnackbarKtTest 2021-10-28 18:15:55 -04:00
Christian Sadilek
f4be38dafc Closes #21438: Ignore intermittently failing ExceptionsListItemViewHolderTest 2021-10-28 18:15:55 -04:00
Christian Sadilek
5d7bb70f55 Closes #22081: Ignore intermittently failing DefaultBrowsingModeManagerTest 2021-10-28 18:15:55 -04:00
Christian Sadilek
99f0aaa834 Closes #21332: Ignore intermittently failing WebPushEngineIntegrationTest 2021-10-28 18:15:55 -04:00
Christian Sadilek
3ffb11fd3b Closes #21952: Ignore intermittently failing FenixSnackbarDelegateTest 2021-10-28 18:15:55 -04:00
Gabriel Luong
09bd9e7ba2 For #21888 - Use Hero images for Jump back in 2021-10-28 21:02:13 +00:00
Arturo Mejia
d0d87a6d6d No issue update strings ids 2021-10-28 13:49:58 -04:00
AndiAJ
71d151ef18 For #18421 re-enable verifyContextCopyLink and verifyContextCopyImageLocation UI tests 2021-10-28 15:47:25 +00:00
Gabriel Luong
8f85ef2d5b For #21973 - Remove @color/top_site_title_text_light_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
28883384a7 For #21973 - Remove @color/inset_dark_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
9a85545da5 For #21973 - Remove @color/top_site_title_text_dark_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
59f725d2fb For #21973 - Remove @color/synced_tabs_separator_dark_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
35c7ef6bb6 For #21973 - Remove @color/toggle_off_knob_light_theme and @color/toggle_off_track_light_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
e2093f2054 For #21973 - Remove redirection of color variables for the collection color variables 2021-10-28 14:19:59 +00:00
Gabriel Luong
4001f4ee6f For #21973 - Remove redirection of color variables for the tabs tray color variables 2021-10-28 14:19:59 +00:00
Gabriel Luong
1a472c3507 For #21973 - Remove @color/caption_text_dark_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
78e90d5f0e For #21973 - Remove @color/contrast_text_dark_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
2456e9b5f5 For #21973 - Remove @color/secondary_text_dark_theme redirection 2021-10-28 14:19:59 +00:00
Gabriel Luong
959a142c92 For #21973 - Use destructive_normal_theme in place of R.color.design_color 2021-10-28 14:19:59 +00:00
Mozilla L10n Automation Bot
b7bdd94e71 Import l10n. 2021-10-28 00:32:14 +00:00
Michael Comella
9721723af5 For android-components#11161: pass profiler into AwesomeBar.
This will add two new markers:
- SuggestionFetcher.fetch
- Suggestion update

This is a profile with the markers: https://share.firefox.dev/3E4PbEk
2021-10-27 22:02:12 +00:00
AndiAJ
4fe8921a82 For #18421 fix and re-enable verifyContextShareLink, verifyContextSaveImage and verifyContextMixedVariations UI tests 2021-10-27 14:05:35 +00:00
Arturo Mejia
a2c7dfb26e For #22170: Add telemetry for the auto-close prompt 2021-10-27 13:17:35 +00:00
Arturo Mejia
9154371ba5 For #21906 ⁃ Update strings removal version 2021-10-27 02:49:58 +00:00
Mozilla L10n Automation Bot
59a069882d Import l10n. 2021-10-27 00:46:32 +00:00
Grisha Kruglov
04a35c81b8 Closes #22083 - Match history groups to history pages by all items within the group
When deciding if we should include a history group within the "page of
history" results on the History View UI, we used to look at the most
recent timestamp of the metadata items within the group, and see if that
falls within the range of the timestamps of the history page, +/- some
buffer.

This assumes that each metadata entry will have a corresponding history
item. However, that's not true - when restarting the app, the selected
tab will be restored, and when opening History View right after we'll
record some metadata for it. However, we won't record a history visit
during the app restore for the selected tab.

That's all correct, but the assumption around group matching to history is now incorrect.

This patch changes the logic to instead look at every item within the
group, and see if any of them match the time window of the current
history page. This has a side-effect of also displaying search groups
multiple times on diffenent pages of history, if it makes sense to do so chronologically.
I think that's fine, it reflects reality at least (e.g. items within the
group may have been visited at very different points in time).

Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2021-10-26 16:10:58 -07:00
Elise Richards
347f82f2f5
For #21313: Renew metrics for December - never expire updates (#21788)
* For #21313: Renew metrics for December - never expire updates

* For #21313: data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-10-26 22:00:06 +00:00
Arturo Mejia
d943be0e53 For #22034: Inactive tabs prompt is redisplayed after dismissing by turning on Auto close 2021-10-26 21:34:50 +00:00
MickeyMoz
a4bcecf8c5 Update Android Components version to 95.0.20211026143215.
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2021-10-26 20:21:03 +00:00
Gabriel Luong
44666ca2ca For #21776 - Call chain on collection type may be simplified 2021-10-26 18:26:50 +00:00
Gabriel Luong
100547130e For #21776 - Add package path to TabGroupViewHolder 2021-10-26 18:26:50 +00:00
Gabriel Luong
b04bf99b7d For #21776 - Remove unused symbols 2021-10-26 18:26:50 +00:00
Gabriel Luong
b54698a3f2 For #21776 - Class member can have 'private' visibility 2021-10-26 18:26:50 +00:00
Gabriel Luong
3115f1343f For #21776 - Replace Java static method with Kotlin analog 2021-10-26 18:26:50 +00:00
Gabriel Luong
660300f770 For #21776 - Replace 'isEmpty' with 'ifEmpty' 2021-10-26 18:26:50 +00:00
Gabriel Luong
603ba63962 For #21776 - 'protected' visibility is effectively 'private' in a final class 2021-10-26 18:26:50 +00:00
Gabriel Luong
da395d1038 For #21776 - Local 'var' is never modified and can be declared as 'val' 2021-10-26 18:26:50 +00:00
Gabriel Luong
5afe393b8f For #21776 - Remove unused imports 2021-10-26 18:26:50 +00:00
Gabriel Luong
76c746b982 For #21776 - Remove unnecessary type argument 2021-10-26 18:26:50 +00:00
Gabriel Luong
272d31b2b4 For #21776 - Remove unnecessary parentheses from function call with lambda 2021-10-26 18:26:50 +00:00
Gabriel Luong
6d1d4bea93 For #21776 - Remove redundant qualifier name 2021-10-26 18:26:50 +00:00
Gabriel Luong
1039a92281 For #21776 - Remove reductant SAM constructor 2021-10-26 18:26:50 +00:00
Gabriel Luong
ed48dc934a For #21776 - Remove reductant 'suspend' modifier from SecurePrefsTelemetry 2021-10-26 18:26:50 +00:00
Gabriel Luong
d854c282da For #21776 - Remove val from constructor parameter that are never used as a property 2021-10-26 18:26:50 +00:00
codrut.topliceanu
bba787e87e For #21732 - Adds inactive tabs survey on disable + telemetry 2021-10-26 17:50:22 +00:00
Mugurell
6d62aed35f For #21933 - Refresh history items everytime the fragment is opened 2021-10-26 17:24:13 +00:00
Mozilla L10n Automation Bot
c9e769544f Import l10n. 2021-10-26 02:55:02 +00:00
Jonathan Almeida
7666f0e4c2 No issue: Replace TabsTray.Tab with TabSessionState
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2021-10-26 01:57:47 +00:00
Jonathan Almeida
b2a7877c83 No issue: Disable FenixSnackbarDelegateTest intermittents 2021-10-26 00:21:00 +00:00
Michael Droettboom
c1780cf332
For #21025: Set long term business-critical metrics as non-expiring (#21038)
* Set long term business-critical metrics as non-expiring.

* Remove quotes around "never"

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-10-25 23:53:02 +00:00
AndiAJ
6149f9faf8 Use identifiers instead of hard coded strings 2021-10-25 17:37:54 +00:00
AndiAJ
d3651eb0fc For #21747 re-enable start on homepage UI test and refactoring work 2021-10-25 17:37:54 +00:00
AndiAJ
b10835992d For #21754 re-enable general settings UI test and refactoring work 2021-10-25 17:37:54 +00:00
AndiAJ
4c343b8b3a For #21004 fix and refactor verifyBasicNavigationToolbarFunctionality UI test 2021-10-25 17:13:13 +00:00
Roger Yang
367c5f42d8 No issue: Add external load flag 2021-10-25 18:02:51 +02:00