ishan/fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
7,067 Commits 34 Branches 356 Tags 125 MiB
9bd6d298f1
Commit Graph

5906 Commits

Author SHA1 Message Date
Christian Sadilek
84fdf62240 Fix init order in TrackingProtectionExceptionsViewTest 2021-07-27 10:08:32 +02:00
Christian Sadilek
00d0ed53e0 Fix race condition in ShareViewModelTest 2021-07-27 10:08:32 +02:00
Christian Sadilek
9320700fd7 Remove unused imports in PwaOnboardingObserverTest.kt 2021-07-27 10:08:32 +02:00
Christian Sadilek
4d8d1b4ea2 Use MainCoroutineRule in PwaOnboardingObserverTest 2021-07-27 10:08:32 +02:00
Sebastian Kaspari
7840aac3ba Update Robolectric and mockk. 2021-07-27 10:08:32 +02:00
Sebastian Kaspari
781813ab50 Remove over-eager protobuf stripping. 2021-07-27 10:08:32 +02:00
Sebastian Kaspari
8d8b6e6d36 Issue #19662: Use Java 11. 2021-07-27 10:08:32 +02:00
Oana Horvath
f37abbe4ae For #20297: close tab to avoid saving the same tab to collection 2021-07-27 07:12:37 +00:00
Mozilla L10n Automation Bot
95f0c48dbf Import l10n. 2021-07-27 00:30:24 +00:00
codrut.topliceanu
302ad8ae85 For #20449 - Fixes Show most visited sites crash on disable 2021-07-26 21:23:56 +00:00
mcarare
a5a4a7f6d9 For #20425: Update AC version 2021-07-26 13:59:46 +00:00
mcarare
c094e1a457 For #20425: Do not show recent bookmarks older than 10 days. 2021-07-26 13:59:46 +00:00
Mozilla L10n Automation Bot
e60de9df5b Import l10n. 2021-07-26 00:30:01 +00:00
Mozilla L10n Automation Bot
4f7424ce4b Import l10n. 2021-07-25 00:35:01 +00:00
Mozilla L10n Automation Bot
67c9d74432 Import l10n. 2021-07-24 00:37:36 +00:00
Mugurell
52e152300d For #20420 - Re-enable shortcutButtonTest 
The issue affecting this was resolved in AC.
 2021-07-23 10:47:33 +00:00
Mugurell
2c8c6d29ea For #20402 - Re-enable "in progress media tab" 
The crash for when media starts playing in a custom tab is now resolved in AC.
 2021-07-22 22:28:54 +00:00
Gabriel Luong
973070ab50 For #20259 - Add HistoryMetadataSuggestionProvider in AwesomeBar 2021-07-22 22:28:54 +00:00
Gabriel Luong
9b22b2baa4 For #20438 - Display a list of history metadata groups 2021-07-22 19:19:50 +00:00
Mozilla L10n Automation Bot
ac0f3cc3ad Import l10n. 2021-07-22 16:24:18 +00:00
Michael Comella
30a6e29b25 For #19901: correct spacing in comment on how to run 
Co-authored-by: Jonathan Almeida <git@jonalmeida.com>
 2021-07-22 15:24:35 +00:00
Michael Comella
6d609bc651 For #19901: integrate Jetback Benchmark (microbenchmark). 2021-07-22 15:24:35 +00:00
Christian Sadilek
589f166b29 Issue #16330: Remove remaining usages of Sentry.capture 2021-07-21 20:07:30 +00:00
Mozilla L10n Automation Bot
43aff29816 Import l10n. 2021-07-21 14:36:56 +00:00
codrut.topliceanu
2040af6a5d For #20367 - Fixes removeAllTabs adding to recently closed 
`removeAllTabs` will now no longer allow `UndoMiddleware` from recovering the tabs.
 2021-07-20 22:00:04 +00:00
Arturo Mejia
87f73c0109 Fix search_add_custom_engine_search_string_example lint warning. 2021-07-20 22:00:04 +00:00
jhugman
097fa68964
Allow branch enrollment and unenrollment in Nimbus secret menu (#20050) 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-07-20 15:45:37 +00:00
codrut.topliceanu
bc723e0a9b For #15499 - Smoothly updates topSites list on remove 
To remove the flash on refresh of the topsites list we have to use submitList, however using this too high up in the hierarchy of our listAdapters within listAdapters will cause children to refresh at once. The solution to this is to use submitList lower. Using it in TopSitesPagerAdapter.kt to update the TopSitesAdapter is the way to go. I've also had to use a dummy item for the "removed" Topsite ( with id = -1) so I can manually diff that before using submitList.
 2021-07-20 15:07:16 +00:00
Mozilla L10n Automation Bot
55fc014071 Import l10n. 2021-07-20 00:40:11 +00:00
Mugurell
094413578c For #20420 - Temporarily disable SearchTest#shortcutButtonTest 2021-07-19 10:12:41 +00:00
Sebastian Kaspari
140274c192 Update to Kotlin 1.5.20, Android Gradle plugin 4.2.2 and Gradle 6.7.1. 2021-07-19 09:20:50 +00:00
Sebastian Kaspari
8b5aef7def Update Kotlin to 1.5.10 (and Coroutines to 1.5.0). 2021-07-19 09:20:50 +00:00
Jonathan Almeida
41ba94b951 Issue #20402: Disable LastMediaAccessMiddleware temporarily 
The reducer in this middleware assumes the SessionState is always a
TabSessionState which holds the lastMediaAccess. This is true for the
lastAccess long which is a persistent state.

The list of MediaSessionActions however can also come from Custom Tabs
which relies on a CustomTabSessionState.

For now, the temporary fix is to disable this feature by removing the
middleware and no longer adding the last accessed media to the
recent tabs list ("Jump back in") to avoid crashing users while we think
of a real fix.
 2021-07-17 01:21:13 +00:00
Mozilla L10n Automation Bot
9ef8515528 Import l10n. 2021-07-17 00:27:34 +00:00
Mozilla L10n Automation Bot
fb15f1774c Import l10n. 2021-07-16 00:34:42 +00:00
Roger Yang
c4347a9492 Closes #19847: Add telemetry for the default browser notification 2021-07-15 19:35:45 +00:00
Oana Horvath
81849ec6d0 No issue: adds warning comment to beta & release running tests 2021-07-15 19:03:13 +00:00
Roger Yang
049811fabb Issue #20307: Clear sharedViewModel selectedFolder when backing out of bookmark fragment 2021-07-15 15:28:29 +00:00
Roger Yang
80721e2d73 Issue #19989: Add rounded corners to recently tabs' icon 2021-07-15 14:20:11 +00:00
Mugurell
1251894933 For #19933 - Show a media tab item on homescreen for the last tab with media 2021-07-15 10:05:20 +03:00
Roger Yang
68b56ff240 Issue #19846: Make sure default browser notification only happens once 2021-07-15 02:17:24 +00:00
Mozilla L10n Automation Bot
317cbe9c7b Import l10n. 2021-07-15 00:29:47 +00:00
Mugurell
f95567912f For #20229 - Use the AC common implementation for ads/search telemetry 
Everything should work exactly as before.
 2021-07-14 17:55:24 +03:00
mcarare
b2a5723bad For #20292: Use tint for home button icon. 2021-07-14 07:48:13 +00:00
mcarare
b25f807eea For #17808: Remove deprecated systemUiVisibility and flags. 2021-07-14 07:19:25 +00:00
Mozilla L10n Automation Bot
9b3f312301 Import l10n. 2021-07-14 00:59:46 +00:00
Oana Horvath
df960c4187 For #10915: fix tests by removing existing session 2021-07-13 08:18:50 +00:00
Rohan Maity
f8599860dd For #1268 Add Unit test for PrivateShortcutCreateManager 2021-07-13 10:48:52 +03:00
Mozilla L10n Automation Bot
7975309952 Import l10n. 2021-07-13 00:39:50 +00:00
Mozilla L10n Automation Bot
41a6234765 Import l10n. 2021-07-12 23:27:16 +00:00
Jonathan Almeida
4b4c86551d Close #20320: Use scope from testDispatcher in RecentBookmarksFeatureTest 2021-07-12 23:05:03 +00:00
Jonathan Almeida
b877430bad Close #20267: Filter out network errors from Nimbus 2021-07-12 22:42:05 +00:00
Marc Leclair
298ec5cce1 For #19804: Restore logic to original behavior 2021-07-12 22:20:03 +00:00
Marc Leclair
871cde764e For #19804: checkDefaultBrowser moved to helper function 2021-07-12 22:20:03 +00:00
Marc Leclair
db01fab8a9 For 19804:Fixed call order in the 2021-07-12 22:20:03 +00:00
Marc Leclair
b8bbdb45bc For #19804: Changed var isDefaultBrowser to a function 
The change to the function makes it so when the Settings.kt class is initialized, the isDefaultBrowser, which calls the
BrowserCache, won't get called right away. `isDefaultBrowser()` is known to take quite a while on start up on the G5+ (approx
30-40ms).
 2021-07-12 22:20:03 +00:00
Michael Comella
79fcbcba83 Closes #20127: fix app_received_intent extras. 
Apparently, it had been using the wrong mapping this whole time. I can't
wrap my head around fenix's glean wrapper so I'm not sure if this
resulted in bugs or if my change changes the behavior. However, I don't
think anyone is using this probe so I'm requesting to remove it. If we
don't end up removing it, then we can check for bugs/changes in
behavior. This isn't ideal but I'd rather not spend the time on it if we
don't have to.
 2021-07-12 21:53:54 +00:00
Michael Comella
7f4ac14f66 For #20127: remove app_opened_all_startup from metrics.yaml. 2021-07-12 21:53:54 +00:00
Michael Comella
be64ee4159 For #20127: remove app_opened_all_startup integration. 2021-07-12 21:53:54 +00:00
Mozilla L10n Automation Bot
273d7ce947 Import l10n. 2021-07-11 00:30:23 +00:00
Mozilla L10n Automation Bot
64038252e6 Import l10n. 2021-07-10 00:33:37 +00:00
Roger Yang
142730faaa Closes #20285: Remove unused GeckoProvider 2021-07-09 22:40:26 +00:00
Elise Richards
9bfe9b0787
For FNX-22339: Recently saved bookmarks (#19835) 
* Title and button for home screen recently saved bookmarks section

Create bookmark item view with favicon and title

* View holders and interactors for recently saved bookmarks

Recent bookmark item view holder binding

Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items

Top level adapter for recent bookmarks section

Retrieve list of recent bookmarks on home

View holders and interactors for recently saved bookmarks

Recent bookmark item view holder binding

Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items

Top level adapter for recent bookmarks section

Retrieve list of recent bookmarks on home

Update list on app start and when bookmarks are added

View holders and interactors for recently saved bookmarks

Recent bookmark item view holder binding

Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items

Top level adapter for recent bookmarks section

Retrieve list of recent bookmarks on home

Update list on app start and when bookmarks are added

Make a use case for retrieving and updating the list of recently saved bookmarks

Add adapter items and define header viewholder binding

Use session interactor for header button clicks. Bind in the adapter

* Retrieve list of bookmarks asynchronously on home

Interactor and controller tests

Address review comments

Split up tests for recent bookmarks

Update to new interactors

Dark mode and light mode styles

Refactor bookmarks home stuff

* Add RecentBookmarksFeature to home

Move interactor to SessionControlInteractor

Clean up lint, styles, and dimens.

* Bookmarks use case tests for retrieving recently saved bookmarks. Linting.

* View holder tests

* Match ux to designs for colors, margins, and scrolling

* Clean up clean up

* Tests for the view bound feature

* Controller test

* Clean up: check state of store in feature tests; ellipsize textviews for bookmark item; remove unused attr; format

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2021-07-09 19:36:20 +00:00
Mozilla L10n Automation Bot
ff9aa36885 Import l10n. 2021-07-09 00:35:12 +00:00
Roger Yang
d4af9401d1 Closes #19846: Update default browser notification strings 2021-07-08 22:04:13 +00:00
Roger Yang
6d1a44e259 Closes #19846: Only add default browser notification work if work is not pending 2021-07-08 18:36:14 +00:00
Roger Yang
0133f42a15 Closes #19846: Show Default Browser Notification if browser is not default 2021-07-08 17:52:08 +00:00
codrut.topliceanu
3ae6472e16 For #20257 - Sets min no. of grid columns to 2 in TabsTray 2021-07-08 14:54:43 +00:00
codrut.topliceanu
083d50aafd For #20250 - Adds FLAG_SECURE to TabsTray dialog 2021-07-08 08:49:06 +00:00
codrut.topliceanu
d530f5b773 For #17855 - Stops SecureWindowFeature from removing FLAG_SECURE 2021-07-08 08:02:35 +00:00
Mozilla L10n Automation Bot
5e7b422433 Import l10n. 2021-07-08 00:38:02 +00:00
Grisha Kruglov
946fda55aa Closes #20276: Fall-back to URL parsing for tabs with parents to obtain search terms 2021-07-07 15:01:26 +00:00
Oana Horvath
ea3e4c9956 No issue: New UI smoke test for the Language menu 2021-07-07 12:18:16 +00:00
mcarare
b43db5f2b6 For #20029: Remove animations when recreating activity on locale change. 2021-07-07 10:12:51 +00:00
codrut.topliceanu
9693507ffb For #19131 - Adds kdoc to TopSitePagerPayload 2021-07-07 07:22:45 +00:00
codrut.topliceanu
a7f3d34538 For #19131 - Fixes top sites refresh and interactability 2021-07-07 07:22:45 +00:00
Mozilla L10n Automation Bot
4a0cd8a25a Import l10n. 2021-07-07 00:36:50 +00:00
Roger Yang
702e3e6886 Closes #20274: Limit about:config to Nightly and Beta 2021-07-06 23:32:16 +00:00
Roger Yang
e69f3dfbbb Closes #19090: Show snackbar on adding to bookmarks from tabs tray 2021-07-06 22:13:38 +00:00
mcarare
36b50ea8d9 For #17917: Use View binding in onboarding cards. 2021-07-06 16:29:09 +00:00
Christian Sadilek
7c57898c76 Closes #20123: PlacesException when recording history metadata 2021-07-05 17:12:54 -04:00
Jonathan Almeida
4bab66bb21 Move Nimbus strings to static_strings 
Goes with 6bb89f346e01edd431056bfcd7472bc3082a39a5
 2021-07-05 19:30:58 +00:00
mcarare
0c720ba500 For #20219: Fix constraints in sign-in onboarding card. 2021-07-05 08:38:30 +00:00
mcarare
a7a45df8fb For #20154: Override AC fill colors for icons. 2021-07-05 08:15:34 +00:00
Mozilla L10n Automation Bot
0a5be636f9 Import l10n. 2021-07-05 00:31:23 +00:00
Mozilla L10n Automation Bot
0e43a42c1e Import l10n. 2021-07-04 00:32:48 +00:00
Mozilla L10n Automation Bot
4bdd54d065 Import l10n. 2021-07-02 00:29:59 +00:00
codrut.topliceanu
ce0773fcdc For #19558 - Adds proper tint to "Report Site Issue" 2021-07-01 14:40:03 +00:00
Oana Horvath
d20bebc2a3 For #20000: Re-try swipe on collection items 2021-07-01 11:45:22 +00:00
Mozilla L10n Automation Bot
852034d77a Import l10n. 2021-07-01 00:35:28 +00:00
Codrut Topliceanu
af1c00a645
For #20195 - Adds tabsTray allowScreenshotsInPrivateMode check (#20203) 
* For #20195 - Adds tabsTray allowScreenshotsInPrivateMode check
 2021-06-30 18:37:16 +03:00
mcarare
4101974415 For #20190: Mirror back button in RTL. 2021-06-30 15:35:11 +03:00
mcarare
023e1b4b30 For #20154: Override AC fill colors for icons. 2021-06-30 15:04:08 +03:00
Mozilla L10n Automation Bot
cb5468cfe4 Import l10n. 2021-06-29 00:32:15 +00:00
Mozilla L10n Automation Bot
384e8f84df Import l10n. 2021-06-28 00:30:01 +00:00
Mozilla L10n Automation Bot
736789bd2a Import l10n. 2021-06-27 00:34:31 +00:00
Mozilla L10n Automation Bot
daa1767317 Import l10n. 2021-06-26 00:30:31 +00:00
Mozilla L10n Automation Bot
5921c631f2 Import l10n. 2021-06-25 13:01:07 +00:00
Oana Horvath
c830ed9986 For #20123: Disable historyMetadataFeature flag 2021-06-25 10:11:03 +00:00
Mozilla L10n Automation Bot
2c99bb8031 Import l10n. 2021-06-24 00:37:38 +00:00
Travis Long
a2984e6863 [SDK-279] Adds a way to switch to the "preview" collection in Nimbus 
This adds a toggle/switch to the debug settings menu that causes Nimbus to use the "preview" collection rather than the "main" collection when it initializes.  Since it is only applied during init, it does require a restart in order to take effect.
 2021-06-23 22:20:31 +00:00
Gabriel Luong
7aea29d57b For #19951 - Use Proton icon for new home button 2021-06-23 17:34:31 +00:00
Arturo Mejia
29f5567869 For #19922 Fix the default autoplay setting to be block audio only 2021-06-23 09:02:04 -04:00
Mozilla L10n Automation Bot
f24072c915 Import l10n. 2021-06-23 00:28:26 +00:00
Mugurell
5d62fe11a6 For #20046 - Show the last accessed tab in Jump back in 2021-06-22 22:03:33 +00:00
jhugman
8b32f7dcda
Add error reporting via sentry to Nimbus caught exceptions (#20049) 2021-06-22 13:27:32 +00:00
Roger Yang
cabd004390 Closes #19182: Close Tabs Tray when sharing completes 2021-06-22 02:53:02 +00:00
Roger Yang
74c1cc82fb Closes #19921: Update appcompat and fragment dependencies to 1.3.x 2021-06-22 01:39:52 +00:00
Mozilla L10n Automation Bot
7dbfca2d2e Import l10n. 2021-06-22 00:29:33 +00:00
Arturo Mejia
1d76bc7ca2 For #19922 Update the default autoplay setting to be block audio only 2021-06-21 16:46:54 -04:00
Jonathan Almeida
15df06b294 Issue #20054: Update recent tab on title or icon changes 2021-06-21 18:27:33 +00:00
Arturo Mejia
251bfc7fe9 Improvements to site permissions 2021-06-21 17:21:16 +00:00
codrut.topliceanu
37e2c6ceeb For #19739 - Adds start tabsTray with multiSelect support 2021-06-21 16:17:09 +00:00
codrut.topliceanu
2c538dbb5d For #16330 - Replaces Sentry.capture with submitCaughtException 2021-06-21 09:05:33 +00:00
Mozilla L10n Automation Bot
841265e39d Import l10n. 2021-06-21 00:59:30 +00:00
Mozilla L10n Automation Bot
cf0fab08f5 Import l10n. 2021-06-20 00:29:50 +00:00
Mozilla L10n Automation Bot
79229ebdbd Import l10n. 2021-06-19 00:31:15 +00:00
Mugurell
b3a6dcccd7 For #19797 - Remove FenixAccountManager#authenticatedAccount 
This api had a bug stemming from the property name - authenticatedAccount which
may return even an unauthenticated account.
After the recent refactorings it was left unused so best to remove it to
prevent from future misuses.
 2021-06-18 17:09:25 +03:00
Mugurell
ce64c2439d For #19797 - Use the FXA email only if the account is authenticated 
An account may exist but it may need to be re-authenticated.
In this case also the email should not be exposed to the app.
 2021-06-18 17:09:25 +03:00
Mugurell
19af5e9b15 For #19797 - Remove FenixAccountManager#signedInToFxa 
After the changes from this patch this api is not used anymore so to prevent
future misuses of it this is removed in favor of the new "accountState".
 2021-06-18 17:09:25 +03:00
Mugurell
1fc3bb84ca For #19797 - Home menu: go to problems page if account exists but not signed in 2021-06-18 17:09:25 +03:00
Mugurell
3d071dd049 For #19797 - Browser menu: go to problems page if account exists but not signed in 2021-06-18 17:09:25 +03:00
Mugurell
d663383cf7 For #19797 - New FenixAccountManager#getAccountState() 
This new method allows a single source of truth for getting the up-to-date
account status without clients interesting in this needing to know what to
check for.
 2021-06-18 17:09:25 +03:00
Elise Richards
80de7fd7ba
Define the width/height for homescreen empty collections button (#20082) 2021-06-17 17:57:21 -05:00
Grisha Kruglov
2198298df5 Obtain searchTerms from previous page in tab's history 
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
 2021-06-17 18:02:36 -04:00
Elise Richards
1a8ae21250
Define the width/height for sync sign in button on tabs tray (#20080) 2021-06-17 16:49:03 -05:00
bharat0to
6de3062738
For #18581 ETP Standard option is truncated (#18586) 2021-06-17 16:42:08 -05:00
Elise Richards
79af077b2f
Update glean notification emails to new email group (#20070) 2021-06-17 14:48:34 -05:00
Arturo Mejia
c2439914fa For #19881 add telemetry for start on Home. 2021-06-17 13:09:28 -04:00
Jonathan Almeida
aee14d8c19 Close #19950: Fix intermittent failure in SearchDialogControllerTest 2021-06-17 11:37:05 -04:00
Mihai Adrian Carare
9c9e26953f
For #19813: Invalidate tab tray adapter structure on screen rotation. (#20044) 2021-06-17 13:57:50 +03:00
Jonathan Almeida
854da1ac9d Issue #20053: Disabling collection smoke tests temporarily 
The changes from #19090 did not fix the issue consistently, and are
causing failures intermittently on-unrelated PRs.

Disabling these tests again until we have another fix for #19090.
 2021-06-17 10:25:08 +03:00
Christian Sadilek
b123b50df7 HistoryMetadataMiddleware: Use state ext. functions from A-C 2021-06-16 19:22:56 -07:00
Mozilla L10n Automation Bot
03b797efb7 Import l10n. 2021-06-17 00:28:28 +00:00
mcarare
df2efcf310 For #20024: Visit FAB after synced tabs in a11y traversal. 
This helps focus on FAB without going through whole tab lists.
 2021-06-16 19:01:24 -04:00
Jonathan Almeida
5be35df969 Revert "For #19739 - Adds start tabsTray with multiSelect support" 
This reverts commit d8288f5e89.
 2021-06-16 16:57:59 -04:00
Jonathan Almeida
aeb186f79c Revert "For #19739 - Moves argument to initial state init" 
This reverts commit f198e110d7.
 2021-06-16 16:57:59 -04:00
codrut.topliceanu
f198e110d7 For #19739 - Moves argument to initial state init 2021-06-16 13:16:18 -04:00
codrut.topliceanu
d8288f5e89 For #19739 - Adds start tabsTray with multiSelect support 2021-06-16 13:16:18 -04:00
Mihai Adrian Carare
83a5aa2838
For #20007: Multiselect title is important for a11y just in select mode. (#20008) 2021-06-16 13:13:42 +03:00
mcarare
77023db091 For #19820: Specify usage of labels for a11y services. 2021-06-16 08:49:12 +03:00
Mozilla L10n Automation Bot
e969afaed7 Import l10n. 2021-06-16 00:43:59 +00:00
Elise Richards
c32ae710dd
For #19923: renew telemetry probes (#19924) 2021-06-15 18:08:01 -05:00
Gabriel Luong
c0329f3c26 For #19988 - Part 2: Load tab icon from BrowserIcons cache if needed for the recent tab 
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2021-06-15 18:33:20 -04:00
Gabriel Luong
ad91f91eb6 For #19988 - Part 1: Move RecentTabsListFeature into recenttabs package 
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2021-06-15 18:33:20 -04:00
AndiAJ
78edf06a7a Text selection tests 2021-06-15 17:07:13 +03:00
Mugurell
a1fa1a5df6 For #19135 - Offer more context for why STATE_HALF_EXPANDED is not used 2021-06-15 10:01:49 +03:00
Mugurell
abeb8b5576 For #19135 - Set different offsets for expanded trays 
As in the previous version of tabs tray when tray is expanded while in portrait
it should have a 40dp offset and when the tray is expanded while in landscape
it should have a 0dp offset - effectively making it fullscreen.

These values were set in code, always overriding the xml set value so I
removed that xml declaration.
 2021-06-15 10:01:49 +03:00
Mugurell
3cbb67da5c For #19135 - Expand the tabs tray in landscape 
Track the current orientation and collapse / expand it the tabs tray depending
on the orientation and the number of opened tabs.
 2021-06-15 10:01:49 +03:00
Mugurell
d7544337b8 For #19135 - Refactor the behavior code to support more functionality later 
Setup a new TabSheetBehaviorManager with all the dependencies it needs to
set the initial tray's behavior.
This same manager will later be called to update behavior's properties.
 2021-06-15 10:01:49 +03:00
Sammy Khamis
950e36c053 changes required for uniffi-ing logins component= 2021-06-14 23:54:29 -07:00
Christian Sadilek
ba19960b7e Issue FNX-22435: Introduce History metadata 
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
 2021-06-14 16:30:00 -04:00
mcarare
d43acbd03d For #19938: Remove a11y workaround for tab tray new tab button. 
Historically, button was introduced in a3dc565c10,
because FAB was not selectable by a11y in previous implementation of tab tray.
 2021-06-14 22:34:58 +04:00
Jan-Erik Rediger
d55f55d70c Suppress deprecation warnings for now-deprecated Glean APIs 
Glean v39 allows to specify types for event extra keys.
The old API is therefore deprecated.
To avoid to much churn right now and keep the build going let's suppress
the deprecation warnings.
 2021-06-14 13:32:46 -04:00
mcarare
2d2be26fbc For #19915: Add telemetry for the toolbar Home screen button. 2021-06-14 19:23:24 +03:00
Mozilla L10n Automation Bot
8bd5ebfabc Import l10n. 2021-06-14 00:25:37 +00:00
Mozilla L10n Automation Bot
cc6bbcdf9c Import l10n. 2021-06-12 00:29:54 +00:00
Elise Richards
e373f507a1
For FNX-22339: UI components for recently added bookmarks (#19953) 
* Top level layout with recyclerview for recent bookmarks

* Add layout for recent bookmarked item, including strings and styles.

* Header layout for recently saved bookmarks

* Address review comments

* Include the header for recent bookmarks in the component layout

* Add dark theme colors for button and title styles

* Recent bookmark card title text color for dark mode/light mode
 2021-06-11 15:03:58 -05:00
Oana Horvath
6278a2b07d For #19090: Re-enable createFirstCollectionTest, shareCollectionTest, deleteCollectionTest 2021-06-11 15:25:40 +03:00
Oana Horvath
c5962b2502 For #10587: Fix and re-enable old CollectionTest.kt 2021-06-11 15:25:40 +03:00
AndiAJ
51517bea7e For #19585: disables failing restoreTabCrashedReporterTest UI test 2021-06-11 12:20:38 +03:00
Gabriel Luong
9d3cf79051 For #19916 - Add last viewed tab to home screen 
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
 2021-06-10 16:22:57 -04:00
Sebastian Kaspari
c0531ffa82
Update Android Components to 91.0.20210610143711. (#19946) 2021-06-10 15:36:44 -04:00
Christian Sadilek
0c1e712ca8 Issue #17800: Cleanup and fix request desktop site from home 2021-06-10 12:49:13 -04:00
Arturo Mejia
2f879f8e9d Fix site permissions breaking changes 2021-06-09 16:34:42 -04:00
Sebastian Kaspari
4753a1d494 Complete browser-state migration and remove browser-session dependency. 
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
 2021-06-09 18:30:21 +02:00
Oana Horvath
1e05e23b23 For #18986: re-enable changeAccessibiltySettings UI test, not failing anymore 2021-06-09 13:52:47 +03:00
Mozilla L10n Automation Bot
c523d28212 Import l10n. 2021-06-09 07:56:14 +00:00
Codrut Topliceanu
c74bf4e8fe
For #19815 - Keeps tabTray FAB from obstructing last tab (#19891) 
* For #19815 - Keeps tabTray FAB from obstructing last tab
 2021-06-09 10:16:47 +03:00
Gabriel Luong
ace835d1e8 For #19876 - Part 3: Add a FeatureFlag to keep the Home screen button in Nightly 2021-06-08 18:05:14 -04:00
Gabriel Luong
044c9a5b40 For #19876 - Part 2: Add a Home screen button to the browser toolbar 2021-06-08 18:05:14 -04:00
Gabriel Luong
86a9c56782 For #19876 - Part 1: Refactor BrowserToolbarInteractor 
- Renames `BrowserInteractor` to `DefaultBrowserTolbarInteractor`
- Renames `BrowserTooolbarViewInteractor` to `BrowserToolbarInteractor`
- Refactors `BrowserToolbarViewInteractor` interface from `BrowserToolbarView.kt` to  `BrowserToolbarInteractor` as `BrowserToolbarInteractor`
 2021-06-08 18:05:14 -04:00
Arturo Mejia
268df1906a
Address typos on start on home strings (#19903) 2021-06-08 18:04:54 -04:00
rxumoz
3a4f73be19
For #10300 - Fix Baidu search telemetry (#19127) 2021-06-08 17:59:14 -04:00
Jonathan Almeida
f06e3a6493 Issue #19178: Apply new styling to Synced Tabs list 2021-06-08 20:46:56 +04:00
codrut.topliceanu
5729137ddb For #19738 - Adds tests for SecureTabsTrayBinding.kt 2021-06-08 20:29:37 +04:00
codrut.topliceanu
0572cab97c For #19738 - Secure mode enabled in private tabs tray 
Prevents screenshots while tabs tray with private tabs page is open.
 2021-06-08 20:29:37 +04:00
Mozilla L10n Automation Bot
3327fc508c Import l10n. 2021-06-08 00:33:38 +00:00
Arturo Mejia
f0bb70e354 For #19789 Start on Home after some amount of time 2021-06-07 16:29:36 -04:00
Mihai Adrian Carare
f9428759db
For #19820 - Add labels for month and year spinners. (#19870) 
This follows the guidelines described in
developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/listbox_role
 2021-06-07 16:29:01 -04:00
Gabriel Luong
74a96905a3
For #19495 - Add validation for the name on card (#19836) 
- We want to ensure that name on card in the credit card is not empty when submitted. Display an appropriate error when the field is invalid.
 2021-06-07 15:44:49 -04:00
Oana Horvath
597c8812f4 Changes to #17416, #19686, #19770 UI smoke tests to remove flakiness 2021-06-07 17:20:25 +03:00
Mozilla L10n Automation Bot
6c19473c0e Import l10n. 2021-06-07 00:26:13 +00:00
Christian Sadilek
68a761388a Suppress TooGenericExceptionCaught for NimbusApi.withExperiment 2021-06-06 09:56:16 -04:00
James Hugman
5981a92148 Re-instate catch-all to withExperiment 2021-06-06 09:56:16 -04:00
Mozilla L10n Automation Bot
d53d21956b Import l10n. 2021-06-06 00:51:45 +00:00
Mozilla L10n Automation Bot
e19a428edd Import l10n. 2021-06-05 00:29:39 +00:00
Jonathan Almeida
a64cac6c7f Issue #19792: Add content description for tab tray action button 2021-06-05 02:44:33 +04:00
Roger Yang
2e4635334a
Closes #19090: Show snackbar on adding to bookmarks from tabs tray (#19807) 2021-06-04 14:45:20 -04:00
Jonathan Almeida
811dd3e618 Issue #19809: Change default tab tray view to grid layout 2021-06-04 22:26:22 +04:00
Jonathan Almeida
27280e6683 Issue #19809: Remove Grid layout info banner in tabs tray 2021-06-04 22:26:22 +04:00
codrut.topliceanu
85c438798e For #19191 - Fixes missing multi-select checkmarks 2021-06-04 19:56:10 +04:00
Oana Horvath
f901f7e92f For #18647: Fixed and re-enabled customTrackingProtectionSettingsTest UI test 2021-06-04 15:54:14 +03:00
Jonathan Almeida
bf3f81d271 Issue #19112: Remove old Synced Tabs code 2021-06-04 02:18:37 +04:00
Jonathan Almeida
dc11c334b6 Issue #19112: Remove old tab tray code 2021-06-04 02:18:37 +04:00
Neha Binwal
bf605c02d9
For #19307: Increased contrast ratio of chevron symbol in Collections (For Dark theme) (#19377) 
* For #19307: Increased contrast ratio of chevron symbol in Collections (Dark Theme)

- Made a code change in collection_home_list_row.xml which fixes the colour of the chevron symbol in Dark theme

* Replaced android:src with app:srcCompat to pass Lint check
 2021-06-03 13:54:55 -05:00
Neha Binwal
69e9e35fff
Increased text contrast ratio of TextViews in 'Share tab' (#18880) 
- Changed share_tab_url color to @color/photonLightGrey60
- Changed appName and recent_apps_link_header color to @color/photonDarkGrey10
 2021-06-03 13:54:05 -05:00
Mugurell
0455cc3cd4
For #18877 - Support updated PromptRequest AC APIs (#19767) 
* For #18877 - Support updated PromptRequest AC APIs

This issue stemming from a race condition is fully resolved in AC by adding
support for having multiple prompts at a time.
Fenix needs just a small change to support the AC refactoring.

* Update Android Components version to 91.0.20210603145049

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2021-06-03 12:13:43 -04:00
Gabriel Luong
a5110f8c0a
For #19746 - Remove FeatureFlags.nimbusExperiments (#19771) 2021-06-03 11:35:05 -04:00
ZianeA
e4fa71fde7 For #[15083]: Add multi select to recently closed tabs 2021-06-03 05:23:59 +04:00
Mozilla L10n Automation Bot
7d5582a5bf Import l10n. 2021-06-03 00:39:39 +00:00
Elise Richards
6dbe5acc5b
For #19746 - Remove feature flag for the three-dot menu redesign (#19750) 
* Remove feature flag for the three-dot menu redesign

* Remove menu feature flag from unit tests
 2021-06-02 14:19:00 -05:00
codrut.topliceanu
13f9a35131 For #19571 - Adds gdprForgetMe when stopping Adjust 2021-06-02 19:02:28 +04:00
Mihai Adrian Carare
318aace1eb
For #19419 - Label edit boxes for a11y services. (#19762) 2021-06-02 10:56:30 -04:00
Oana Horvath
e48d285114 No issue: Add more smoke tests coverage 2021-06-02 10:30:59 +03:00
Oana Horvath
f3e3f86388 No issue: Change hardcoded package and app name in tests 2021-06-02 10:30:59 +03:00
Mozilla L10n Automation Bot
63eec5dfec Import l10n. 2021-06-02 00:33:12 +00:00
Mozilla L10n Automation Bot
ea049ca801 Import l10n. 2021-06-01 00:32:28 +00:00
Gabriel Luong
33b2789270
For #19734 - Enable Credit cards autofill for Release (#19735) 2021-05-31 17:40:04 -04:00
Gabriel Luong
172a118a51
For #18711 - Refactor credit card telemetry under the Metrics ping (#19733) 2021-05-31 17:35:47 -04:00
Jonathan Almeida
fc46ab2804 Close #19731: Track metrics before we dismiss the tabs tray 2021-05-31 21:46:13 +04:00
Mihai Adrian Carare
e69bf4e26a
For #19564: Explicitly update switch state for a11y event announcements. (#19589) 2021-05-31 16:50:23 +03:00
Mozilla L10n Automation Bot
e035cba4b1 Import l10n. 2021-05-31 00:29:30 +00:00
Mozilla L10n Automation Bot
5219da71d9 Import l10n. 2021-05-29 01:35:38 +00:00
Gabriel Luong
d30ebf86f9
For #19693 - Display a biometric prompt when a credit card is selected to autofill (#19697) 
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2021-05-28 20:10:03 -04:00
Gabriel Luong
b1f7b04332
For #19693 - Add new string for the prompt to authenticate to use a stored credit card (#19708) 2021-05-28 19:04:26 -04:00
Grisha Kruglov
daba5595f6 Enable addresses sync for nightly/debug builds 2021-05-28 00:22:32 -07:00
Grisha Kruglov
e891139db9 Minor cleanup of the account settings 2021-05-28 00:22:32 -07:00
Elise Richards
e0b410efdf
For #18711: Telemetry for credit card autofill (#19548) 2021-05-27 23:54:11 -05:00
Mozilla L10n Automation Bot
a2b2cd42d6 Import l10n. 2021-05-28 00:29:28 +00:00
Jonathan Almeida
c50ed5684c
Close #19459: Use Store.waitUntilIdle in intermittent failing test (#19683) 2021-05-27 18:51:00 -04:00
Gabriel Luong
89a1b0016c
For #19492 - Provide the correct CreditCardNumber type to UpdatableCreditCardFields when updating a credit card (#19692) 
We were crashing because we were specifying the wrong `CreditCardNumber` type when constructing the `UpdatableCreditCardFields`.
We only had the plaintext card number from the user input, but was placing it off as an encrypted card number, which resulted in the crash.
 2021-05-27 18:44:00 -04:00
Christian Sadilek
965a211fc3 Migrate test code to no longer use Nimbus FeatureConfig 2021-05-27 16:09:44 -04:00
Christian Sadilek
9d1e51dfff Fix breaking change in MetricController 2021-05-27 16:09:44 -04:00
Christian Sadilek
3a57188c35 Fix lint/detekt issues 2021-05-27 16:09:44 -04:00
James Hugman
ab678a21ff Add an experiment to demontrate the Feature API 
This is not visible in production, but only debug. It shows three variables
being used to change the settings screen (title, icon and title-punctuation).
 2021-05-27 16:09:44 -04:00
Oana Horvath
4851bf7545 No issue: cleanup of unused tabs related code in HomeScreenRobot.kt 
Deleted SmokeTest#selectTabsButtonVisibilityTest, feature removed
 2021-05-27 11:13:56 +03:00
Oana Horvath
60a752f75c No issue: added smoke tests from MediaNotificationTest.kt 2021-05-27 11:13:56 +03:00
Elise Richards
279d59897c
For #18264 - Add biometric prompt to credit card settings (#19505) 2021-05-27 03:45:35 -04:00
Oana Horvath
bca8b74263 No issue: Added custom tab UI smoke test 2021-05-27 10:22:30 +03:00
Jonathan Almeida
758700cbb0 Issue #19647: Navigate to browser from home via Synced Tabs page 2021-05-27 05:21:57 +04:00
Mozilla L10n Automation Bot
b046982744 Import l10n. 2021-05-27 00:48:18 +00:00
Gabriel Luong
338c488fae
For #19680 - Show the card number when editing a credit card (#19681) 2021-05-26 20:22:11 -04:00
Gabriel Luong
c11335fafc
For #18271 - [Saved cards] Display the credit card provider icon and report the correct card type (#19652) 2021-05-26 16:44:05 -04:00
Mugurell
bd8facb025 For #18263 - Allow dynamically toggling credit cards autofill 2021-05-26 19:38:16 +03:00
Ionut Cristian Bedregeanu
ac71b47c61 For #19653 - Address 19643 PR comments 
Rename handleAddCreditCard to handleAddCreditCardClicked
Rename onClickAddCreditCard to onAddCreditCardClick
Format layout_add_credit_card.xml
 2021-05-26 19:06:37 +03:00
Mugurell
272e631b62
For #19638 - Don't show extracted text UI for name when editing cards (#19673) 
This comes to ensure consistency with the behavior for when editing the card
number.
 2021-05-26 12:05:21 -04:00
Bedregeanu Ionut
bf25951a62
For #19654 - Add RTL support for the "Add credit card" button from "Saved cards" (#19666) 
Co-authored-by: Ionut Cristian Bedregeanu <ionut.bedregeanu@softvision.ro>
 2021-05-26 11:58:49 -04:00
Codrut Topliceanu
02079cd567
For #19569 - Decrease the credit card expiry year width to ensure the month is fully visible (#19582) 2021-05-26 11:16:29 -04:00
Mugurell
3fb40e1f40 For #19475 - Introduce a DefaultTabsTrayInteractor 
Refactored the TabsTrayFragment to not implement the TabsTrayInteractor which
among other advantages allowed for easier testing.
 2021-05-26 15:45:54 +03:00
Mugurell
dc26272381 For #19475 - Cleanup - respect naming scheme in TabsTrayController 
In our current MVI implementation the View Interactors are first called in
response to a direct user action and contain methods following the
"onXXHappened" naming scheme and then delegate other Interactors / Controllers
for specific actions.

Controllers contain the business logic for actually updating the app's state
and offer methods following the "handleXXAction" naming scheme.
 2021-05-26 15:45:54 +03:00
isabelrios
727d0256e0 Stop depending on JCenter - Screengrab and Falcon 2021-05-26 11:04:58 +02:00
Mozilla L10n Automation Bot
72ac23ddb9 Import l10n. 2021-05-26 00:43:20 +00:00
Sebastian Kaspari
84f4ff0d86 Issue #17819: Update detekt to 1.17.1 2021-05-25 17:19:57 -04:00
Ionut Cristian Bedregeanu
0a226962bb For #18881 - Create a new layout for 'Add credit card' button 
Add functionality for 'Add credit card' button

Add unit tests for 'Add credit card' functionality
 2021-05-25 20:34:49 +03:00
Mugurell
d02db131f0 For #19620 - Have MenuScreenShotTest screenshot DefaultBrowser setting again 
As a regression from #19590 which added a new setting above the existing
"Set as default browser" setting the settingsTest() needed to be updated to
allow clicking and screenshot of what happens after clicking on the
"Set as default browser" setting which can now be pushed offscreen.
 2021-05-25 16:04:39 +03:00
Codrut Topliceanu
5f2b3fec38
For #18270 - Adds ellipses+last 4 digits to CC display (#19420) 
* For #18270 - Adds ellipses+last 4 digits to CC display
 2021-05-25 14:32:17 +03:00
Oana Horvath
0877e4cbb7 For #19415: fixed private browsing button visibility issue 2021-05-25 10:49:13 +03:00
mcarare
0141d96465 For #19554: Add SyncEngine.CreditCards to sync supportedEngines. 2021-05-25 09:44:03 +03:00
Mozilla L10n Automation Bot
d9c34e68c3 Import l10n. 2021-05-25 00:32:09 +00:00