ishan/fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
7,572 Commits 34 Branches 356 Tags 125 MiB
ff0befdd1d
Commit Graph

6320 Commits

Author SHA1 Message Date
Michael Comella
9721723af5 For android-components#11161: pass profiler into AwesomeBar. 
This will add two new markers:
- SuggestionFetcher.fetch
- Suggestion update

This is a profile with the markers: https://share.firefox.dev/3E4PbEk
 2021-10-27 22:02:12 +00:00
AndiAJ
4fe8921a82 For #18421 fix and re-enable verifyContextShareLink, verifyContextSaveImage and verifyContextMixedVariations UI tests 2021-10-27 14:05:35 +00:00
Arturo Mejia
a2c7dfb26e For #22170: Add telemetry for the auto-close prompt 2021-10-27 13:17:35 +00:00
Arturo Mejia
9154371ba5 For #21906 ⁃ Update strings removal version 2021-10-27 02:49:58 +00:00
Mozilla L10n Automation Bot
59a069882d Import l10n. 2021-10-27 00:46:32 +00:00
Grisha Kruglov
04a35c81b8 Closes #22083 - Match history groups to history pages by all items within the group 
When deciding if we should include a history group within the "page of
history" results on the History View UI, we used to look at the most
recent timestamp of the metadata items within the group, and see if that
falls within the range of the timestamps of the history page, +/- some
buffer.

This assumes that each metadata entry will have a corresponding history
item. However, that's not true - when restarting the app, the selected
tab will be restored, and when opening History View right after we'll
record some metadata for it. However, we won't record a history visit
during the app restore for the selected tab.

That's all correct, but the assumption around group matching to history is now incorrect.

This patch changes the logic to instead look at every item within the
group, and see if any of them match the time window of the current
history page. This has a side-effect of also displaying search groups
multiple times on diffenent pages of history, if it makes sense to do so chronologically.
I think that's fine, it reflects reality at least (e.g. items within the
group may have been visited at very different points in time).

Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
 2021-10-26 16:10:58 -07:00
Elise Richards
347f82f2f5
For #21313: Renew metrics for December - never expire updates (#21788) 
* For #21313: Renew metrics for December - never expire updates

* For #21313: data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-10-26 22:00:06 +00:00
Arturo Mejia
d943be0e53 For #22034: Inactive tabs prompt is redisplayed after dismissing by turning on Auto close 2021-10-26 21:34:50 +00:00
MickeyMoz
a4bcecf8c5 Update Android Components version to 95.0.20211026143215. 
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2021-10-26 20:21:03 +00:00
Gabriel Luong
44666ca2ca For #21776 - Call chain on collection type may be simplified 2021-10-26 18:26:50 +00:00
Gabriel Luong
100547130e For #21776 - Add package path to TabGroupViewHolder 2021-10-26 18:26:50 +00:00
Gabriel Luong
b04bf99b7d For #21776 - Remove unused symbols 2021-10-26 18:26:50 +00:00
Gabriel Luong
b54698a3f2 For #21776 - Class member can have 'private' visibility 2021-10-26 18:26:50 +00:00
Gabriel Luong
3115f1343f For #21776 - Replace Java static method with Kotlin analog 2021-10-26 18:26:50 +00:00
Gabriel Luong
660300f770 For #21776 - Replace 'isEmpty' with 'ifEmpty' 2021-10-26 18:26:50 +00:00
Gabriel Luong
603ba63962 For #21776 - 'protected' visibility is effectively 'private' in a final class 2021-10-26 18:26:50 +00:00
Gabriel Luong
da395d1038 For #21776 - Local 'var' is never modified and can be declared as 'val' 2021-10-26 18:26:50 +00:00
Gabriel Luong
5afe393b8f For #21776 - Remove unused imports 2021-10-26 18:26:50 +00:00
Gabriel Luong
76c746b982 For #21776 - Remove unnecessary type argument 2021-10-26 18:26:50 +00:00
Gabriel Luong
272d31b2b4 For #21776 - Remove unnecessary parentheses from function call with lambda 2021-10-26 18:26:50 +00:00
Gabriel Luong
6d1d4bea93 For #21776 - Remove redundant qualifier name 2021-10-26 18:26:50 +00:00
Gabriel Luong
1039a92281 For #21776 - Remove reductant SAM constructor 2021-10-26 18:26:50 +00:00
Gabriel Luong
ed48dc934a For #21776 - Remove reductant 'suspend' modifier from SecurePrefsTelemetry 2021-10-26 18:26:50 +00:00
Gabriel Luong
d854c282da For #21776 - Remove val from constructor parameter that are never used as a property 2021-10-26 18:26:50 +00:00
codrut.topliceanu
bba787e87e For #21732 - Adds inactive tabs survey on disable + telemetry 2021-10-26 17:50:22 +00:00
Mugurell
6d62aed35f For #21933 - Refresh history items everytime the fragment is opened 2021-10-26 17:24:13 +00:00
Mozilla L10n Automation Bot
c9e769544f Import l10n. 2021-10-26 02:55:02 +00:00
Jonathan Almeida
7666f0e4c2 No issue: Replace TabsTray.Tab with TabSessionState 
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2021-10-26 01:57:47 +00:00
Jonathan Almeida
b2a7877c83 No issue: Disable FenixSnackbarDelegateTest intermittents 2021-10-26 00:21:00 +00:00
Michael Droettboom
c1780cf332
For #21025: Set long term business-critical metrics as non-expiring (#21038) 
* Set long term business-critical metrics as non-expiring.

* Remove quotes around "never"

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-10-25 23:53:02 +00:00
AndiAJ
6149f9faf8 Use identifiers instead of hard coded strings 2021-10-25 17:37:54 +00:00
AndiAJ
d3651eb0fc For #21747 re-enable start on homepage UI test and refactoring work 2021-10-25 17:37:54 +00:00
AndiAJ
b10835992d For #21754 re-enable general settings UI test and refactoring work 2021-10-25 17:37:54 +00:00
AndiAJ
4c343b8b3a For #21004 fix and refactor verifyBasicNavigationToolbarFunctionality UI test 2021-10-25 17:13:13 +00:00
Roger Yang
367c5f42d8 No issue: Add external load flag 2021-10-25 18:02:51 +02:00
Sebastian Kaspari
170fa9705e Update Kotlin and Jetpack Compose versions. 2021-10-25 17:59:17 +02:00
Oana Horvath
52facc9723 For #21628: catch ComposeNotIdleException 2021-10-25 15:39:55 +00:00
Arturo Mejia
ee8c4de62d For #21986 Confirmation when people set tabs to auto-close 
For #22034 Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
 2021-10-25 10:42:22 -04:00
Mayank Agarwal
1a7b486808 Issue #21714: Login button visibility fix on saved logins page 2021-10-25 11:58:51 +02:00
Mugurell
e0bf4f31fa For #21771 - Show url when recent tab's title is not available 
This is the same previously used approach and the same used for tabs tray.
 2021-10-25 09:54:06 +00:00
Mozilla L10n Automation Bot
df2652f9b5 Import l10n. 2021-10-25 00:40:41 +00:00
Mozilla L10n Automation Bot
a8f42cd363 Import l10n. 2021-10-24 00:54:31 +00:00
Mozilla L10n Automation Bot
9e1f596c1e Import l10n. 2021-10-23 01:47:59 +00:00
Michael Comella
ec1a25dfcf For #21921 - post: switch generic marker skip to BaseBrowserFragment. 
Since we instrument the marker with the duration in BaseBrowserFragment,
we should skip on BaseBrowserFragment too, not its subclass,
BrowserFragment.
 2021-10-23 01:21:39 +00:00
Michael Comella
788eb2c5de For #21921: add duration for some BrowserFragment lifecycle markers. 
Here is a sample profile with all the new markers:
https://share.firefox.dev/3lCGoD2
 2021-10-23 01:21:39 +00:00
Michael Comella
3a3c39406a For #21921: add durations for some HomeFragment lifecycle markers. 2021-10-23 01:21:39 +00:00
Michael Comella
f65ea1e972 For #21921: add and register MarkersFragmentLifecycleCallbacks. 2021-10-23 01:21:39 +00:00
Michael Comella
99533626f1 For #21921: rename MarkersLifecycleCallbacks to ...ActivityLifecycle... 
This is to disamibugate with the MarkersFragmentLifecycleCallbacks that
we'll be adding.
 2021-10-23 01:21:39 +00:00
Michael Comella
623914bd89 For #22054: add marker for root view layout/measure. 
The onLayout marker may be redundant to onGlobalLayout marker but I'm not
sure yet so let's leave them both in and observe if that's the case.

Here's a profile with the markers: https://share.firefox.dev/3lZaOQb
 2021-10-23 00:06:37 +00:00
Oana Horvath
1234d8f518 For #22095: fix intermittent click failure in verifyRateOnGooglePlayRedirect UI test 2021-10-22 18:06:32 +00:00
Mugurell
acdde511d3 For #22070 - Prevent crash for when a selected topic does not exist anymore 
The list of selected topics overwrites old data whenever user selects or
deselects another so the old selections will not leak for long.
 2021-10-22 10:53:55 -04:00
Roger Yang
70fc6fc20f Close #22061: Let TabSorter decide if title header should be shown in tabs tray 2021-10-22 14:34:41 +00:00
Mozilla L10n Automation Bot
2d8492d33f Import l10n. 2021-10-22 01:18:49 +00:00
Roger Yang
b5c15280f7 No issue: Only report telemetry when tabs tray is first opened 2021-10-21 22:34:25 +00:00
Mugurell
c4278bfbf6 For #21841 - New telemetry for Google and Baidu top sites removal 2021-10-21 22:10:26 +00:00
Michael Comella
a1ace964de No issue - post: fix ProfilerMarkerFactProcessor tests. 2021-10-21 21:21:21 +00:00
Michael Comella
0faa61b744 No issue: use Fact.value as detailText for markers. 
This allows Facts emitted from ac to provide more details in markers.
 2021-10-21 21:21:21 +00:00
Michael Comella
01e3b4b984 No issue: cache SearchDialogFragment.InlineAutocompleteEditText. 
Assuming the InlineAutocompleteEditText is not being recreated (and I
did not verify this), it's unnecessary to traverse the view hierarchy
to find it more than once so this patch removes the unnecessary
traversals.
 2021-10-21 20:55:47 +00:00
Oana Horvath
34ca959661 For #20754: fix intermittent click failure in verifyAboutFirefoxPreview test 2021-10-21 20:24:15 +00:00
Andrei Joltan
3af6abff18
For #22065 fix flaky privateTabsTrayWithOpenedTabTest UI test (#22068) 
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
 2021-10-21 11:39:49 -04:00
AndiAJ
560de4f396 For #21207 fix flaky updateSavedLoginTest UI test 2021-10-21 13:37:15 +00:00
Mozilla L10n Automation Bot
c0ab0cb1c5 Import l10n. 2021-10-21 00:59:47 +00:00
Gabriel Luong
64ca94b8fa For #22022 - Composify Customize Home Button and update the background color 2021-10-21 00:15:19 +00:00
Gabriel Luong
ada3da59ec For #22022 - Update SelectableChip button background colors 2021-10-21 00:15:19 +00:00
xlog-null
edd1fd9f2c For #22032 - Fix horizontal margin on private home screen 2021-10-20 23:49:22 +00:00
Gabriel Luong
07a6a386f8 For #21753 - Refactor Pocket out of sessioncontrol 2021-10-20 23:08:14 +00:00
Noah Bond
826249497a
MR2 Inactive tabs telemetry (#21908) 
* For #21903 - Added telemetry for interacting with inactive tabs

* For #21903 - Added missing inactive tab delete count event to delete all event

* For #21903 - Added PR numbers to metrics

* For #21903 - Updated broken unit tests. Resolved critical lint warning.

* For #21903 - Fixed inactive tabs setting toggle metric

* For #21903 - Updated FenixApp unit test

* For #21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.

* PR: addendum for last commit that missed a file

* For #21903 - Changed logic check for reporting inactive tab count

* PR: fixed merge conflict

* For #21903 - Removed tab close tracking when the user closes ALL inactive tabs

* For #21903 - Removed individual tab close metric verify from CLOSE ALL test

* For #21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-10-20 22:30:59 +00:00
Gabriel Luong
af48553418 For #21935 - Use photonBlue40 in place of #0090ED 2021-10-20 20:11:52 +00:00
Gabriel Luong
8b3d39f0c0 For #21935 - Use photonDarkGrey20 in place of #4A4A55 2021-10-20 20:11:52 +00:00
Gabriel Luong
541ed5cec6 For #21935 - Use photonPink30 in place of #FF6BBA 2021-10-20 20:11:52 +00:00
Gabriel Luong
5a5ba1c095 For #21935 - Use photonBlue30 in place of #00B3F4 2021-10-20 20:11:52 +00:00
Gabriel Luong
a81912bd98 For #21935 - Use photonViolet30 in place of #C689FF 2021-10-20 20:11:52 +00:00
Gabriel Luong
475d59b781 For #21935 - Use photonYellow90 in place of #960E18 2021-10-20 20:11:52 +00:00
Gabriel Luong
5a7890497f For #21935 - Use photonRed40 in place of #FF6A75 2021-10-20 20:11:52 +00:00
Gabriel Luong
dfd9f7c1ea For #21935 - Use photonDarkGrey50 in place oof #32313C 2021-10-20 20:11:52 +00:00
Gabriel Luong
6010767da7 For #21935 - Use photonBlue50 in place of #0060DF 2021-10-20 20:11:52 +00:00
Gabriel Luong
0e8b797014 For #21935 - Use photonGreen70 in place of #.008787 2021-10-20 20:11:52 +00:00
Gabriel Luong
c379d75c7f For #21935 - Use photonInk20 in place of #312A64 2021-10-20 20:11:52 +00:00
Gabriel Luong
4d61277e88 For #21935 - Use photonViolet50 in place of #9059ff 2021-10-20 20:11:52 +00:00
Gabriel Luong
a31d638191 For #21935 - Use photonYellow70 in place of #C45A27 2021-10-20 20:11:52 +00:00
Gabriel Luong
a02d58dd48 For #21935 - Use photonYellow60 in place of #E27F2E 2021-10-20 20:11:52 +00:00
Gabriel Luong
cd6bcb3d47 For #21935 - Use photonGreen60 in place of #2AC3A2 2021-10-20 20:11:52 +00:00
Gabriel Luong
9048af04be For #21935 - Use photonPink60 in place of #E31587 2021-10-20 20:11:52 +00:00
Gabriel Luong
bd7ced5867 For #21935 - Use photonDarkGrey90 in place of #15141A 2021-10-20 20:11:52 +00:00
Gabriel Luong
e119b8b590 For #21935 - Use photonViolet40 in place of #AB71FF 2021-10-20 20:11:52 +00:00
Gabriel Luong
ff829f9f25 For #21935 - Use photonBlue60 in place of #0250BB 2021-10-20 20:11:52 +00:00
Gabriel Luong
26920baf47 For #21935 - Use photonRed70 in place of #C50042 2021-10-20 20:11:52 +00:00
Gabriel Luong
624afa9e53 For #21935 - Use photonPurple50 in place of #B833E1 2021-10-20 20:11:52 +00:00
Gabriel Luong
8d27963ace For #21935 - Use photonViolet60 in place of #7542E5 2021-10-20 20:11:52 +00:00
Gabriel Luong
20ddedd118 For #21935 - Use photonWhite in place of #FFFFFF 2021-10-20 20:11:52 +00:00
Gabriel Luong
a673305643 For #21935 - Use photonBlack in place of #FF000000 2021-10-20 20:11:52 +00:00
Gabriel Luong
0ae8e36248 For #21935 - Use photonBlue30 in place of #00B3F4 2021-10-20 20:11:52 +00:00
Mugurell
c54e75edec For #22005 - Ensure deleted items are removed from the list 2021-10-20 07:59:35 +00:00
Mozilla L10n Automation Bot
f2d5da4e91 Import l10n. 2021-10-20 00:39:06 +00:00
Mugurell
d3df7369e0
CI for 21827 (#22004) 
* Remove redundant calls to setHasOptionsMenu(false)

Fix memory leaks for credit card and login fragments

* Fixes:

Add link to issue tracker
Use activity?.invalidateOptionsMenu() instead of setHasOptionsMenu(false)
Move it inside of 'if' statement to avoid unintended issues when called improperly
Revert changes to AddLoginFragment.kt

* Fix call invocation to redirectToReAuth() from AddLoginFragment.kt
Fix 'when' statement in redirectToReAuth() to use AddLoginFragment

Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
 2021-10-19 10:52:01 +00:00
Mozilla L10n Automation Bot
4743146ac4 Import l10n. 2021-10-19 01:25:27 +00:00
Arturo Mejia
846aefc0f4 For #21723 Align the default value of the custom cookie setting with the UI 2021-10-19 00:40:55 +00:00
AndiAJ
9a3e94eb31 Improve tabsSettingsMenuItemsTest UI test coverage 2021-10-18 14:45:27 +00:00
Mozilla L10n Automation Bot
c56214453a Import l10n. 2021-10-18 00:37:31 +00:00
Mozilla L10n Automation Bot
91b719ed75 Import l10n. 2021-10-17 00:36:57 +00:00