ishan/fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
2,794 Commits 34 Branches 356 Tags 125 MiB
ee7f16b2b4
Commit Graph

2389 Commits

Author SHA1 Message Date
mcarare
b115a00589 For #7155 Align custom tabs overflow menu to original mocks 
Reverse menu items order when toolbar position is top
 2020-01-08 11:50:17 -07:00
mcarare
6aa8c98e00 For #7519 Navigate up from search fragment to handle all entry points 2020-01-08 11:49:17 -07:00
mawen7
a2e0af3194 Only close tab on back press if it has a parent tab 2020-01-08 11:33:49 -07:00
kglazko
8ed14ac062
Issue 5736 Improve pop behavior after deleting tabs in settings (#7478) 2020-01-08 10:27:14 -08:00
Emily Kager
7d613b72ae For #7181 - Adjust ETP onboarding for toolbar positions 2020-01-08 11:06:38 -07:00
Josh Vocal
31da69a311 For #7282 - Add more visibility to Turn On Sync card (#7284) 
* Change background of card to make elevation more visible
* Change icon white fill to become transparent
 2020-01-08 10:26:48 -05:00
Will Hawkins
9c28cb632c Issue #7425 (et al): Cache the list of installed browsers 
Cache the list of installed browsers. Calling `Browsers.all`
the application directly redundantly recalculates the list.
Accessing the list of installed browsers through this cache
will reduce that overhead.
 2020-01-07 18:40:07 -08:00
Mugurell
8454f208af For #4977: Migrate fennec shortcuts (#7251) 
* For #4977 - Support opening Fennec pinned website shortcuts in Fenix

Fennec's pinned website shortcuts are set to open the BrowserApp activity.
So we need a new activity alias to actually catch such Intents. Otherwise they
would open "org.mozilla.firefox/.App" without any way to inform that this is
the result of the user clicking on a pinned shortcut.
For actually checking if the newly received Intent is of a Fennec pinned
shortcut we introduce a new FennecBookmarkShortcutsIntentProcessor which will
prepare the Intent to open the shortcut's URL in a new tab.

* For #4977 - Don't keep IntentReceiverActivity on the back stack

For successive Fennec pinned shortcuts to create a new IntentReceiverActivity
and be processed as normal we need to not keep this as our task root.

* For #4977 - Test the FennecBookmarkShortcutsIntentProcessor
 2020-01-07 09:07:51 -08:00
Jeff Boek
fdb1f505cc For #5552 - Reverts temporary fix for #5552 2020-01-07 12:24:20 +02:00
Tiger Oakes
75b87334fa
Change type for OnboardingAutomaticSignIn (#7474) 2020-01-06 14:25:52 -08:00
Michael Comella
4bab493487 No issue: remove useless @MenuRes annotation in History Fragment. 
This annotation was not applied correctly and lint was unable to ensure
it was used properly: it declared an error in lint saying so but that
error was ignored. I did not know how to apply the annotation - and I
felt it had limited utility - so I removed it entirely in order to
permit the lint baseline file to be removed (it was the only error).
 2020-01-06 18:27:51 +02:00
Michael Comella
c0f689a68d No issue: remove lint baseline file. 
This will enable folks to see the existing warnings.
 2020-01-06 18:27:51 +02:00
mcarare
8aa04c048e For #6851 Update text copy of option to add custom search engine 2020-01-06 14:32:02 +02:00
Mihai Branescu
ea2411a88b Feature/#220 language menu (#7070) 
* For #220
- Added advanced header + locale settings item in the settings fragment

* For #220
- Added locale selection page with lib state + handling of locale changes

* For #220
- Removed registering for locale changes in the manifest, allow system
to restart activity in that scenario

* For #220
- Added unit tests for locale settings page

* For #220: fixed an outdated unit test
ga-a

Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
 2020-01-03 18:15:35 -08:00
Severin Rudie
9cbc3f7a4a
7410 remove rxjava (#7426) 
* For #7410: rewrite updateBookmarkFromObservableInput with coroutines

* For 7410: remove RxJava from project. :(

* For 7410: converted updateBookmarkFromTextChanges to Flow per review
 2020-01-03 14:37:12 -08:00
mozilla-l10n-automation-bot
ab4f4bd4d8 Import l10n. (#7476) 2020-01-03 14:59:08 -05:00
Jonathan Almeida
0768fde945 No issue: Use SendTabFeature and FxaPushSupportFeature 2020-01-03 10:20:53 -05:00
Sawyer Blatz
c7c4ad051a
For #6413: Adds more snackbar positioning logic (#7444) 
* For #6413: Adds more snackbar positioning logic

* Refactor
 2020-01-02 14:31:52 -08:00
Roger Yang
f6e286fd9c
Closes #7346: Enable dynamic app links in Fenix (#7361) 2020-01-02 13:08:11 -05:00
Michael Comella
93e677e11b No issue: remove unused Anko dependencies. 2019-12-31 10:46:39 -05:00
Sawyer Blatz
3fb060f682
For #6413: Fixes snackbar positionining for bottom toolbar (#7415) 
* For #6413: Fixes snackbar positionining for bottom toolbar

* For #6413: Cleans up snackbar usage
 2019-12-30 14:43:15 -08:00
Emma Malysz
13f73c2d2c
For issue 7192: move unsetOpenLinksInAPrivateTabIfNecessary off main thread. (#7246) 
Move method to Settings. There are two instances when we want to call this method: either
processing an intent, or within DefaultBrowserPreference
 2019-12-30 14:42:13 -08:00
Michael Comella
cf143489e1 For #6464: Replace use of BuildConfig.DEBUG with ReleaseChannel.channel.isDebug. 
This fixes performance issues where StrictMode would greatly slow down
startup in the forPerformanceTest variants.
 2019-12-30 10:31:33 -08:00
Michael Comella
ac97dd72b1 For #6464: Set "forPerformanceTest" to ReleaseChannel.FenixProduction. 
This fixes a perf measurement issue where Sentry would capture an event when
using the forPerformanceTest variants.
 2019-12-30 10:31:33 -08:00
Michael Comella
37bafda602 For #6464: Add ReleaseChannel test to document assumptions. 2019-12-30 10:31:33 -08:00
Michael Comella
f11ddf8038 For #6464: Add ReleaseChannel.isDebug. 2019-12-30 10:31:33 -08:00
Severin Rudie
f562c81fb2 For 5334: test NotificationSessionObserver 2019-12-30 11:40:07 +02:00
Severin Rudie
a8c47c8805 For #5334: disable notification for private custom tabs 2019-12-30 11:40:07 +02:00
Richard Pappalardo
a441f55d7a
Temp disable UI test verifyAboutFirefoxPreview (#7390) 2019-12-27 15:46:55 -08:00
Sawyer Blatz
9a693f6c11
For #7000: Fix inverted media telemetry (#7368) 2019-12-27 13:46:47 -08:00
Severin Rudie
26b7909214
For #7352: integrate highlightable browser menu changes (#7353) 
* For #7352: integrate highlightable browser menu changes

* For 7352: invalidate menu when reader mode availability changes

* For 7352: removed highlight from reader mode appearance per UX
 2019-12-27 12:15:21 -08:00
Kadeem M
e22d092f5d Added UI tests for the About Settings page (#6161) 2019-12-27 07:55:35 -08:00
isabelrios
491a198fae For #5074 - Add UI tests for logins and passwords setting menu (#7291) 
* For #5074 - Add UI tests for logins and passwords setting menu

* fix detekt failure

* remove old file

* fix scroll small screens

* fix reviewer comments
 2019-12-26 14:22:40 -08:00
Sawyer Blatz
faa4136685 For #7347: Fixes background of search field 2019-12-23 10:07:54 -08:00
Sawyer Blatz
4fd3eb53d1 For #6666: Adds back button to search screen 2019-12-23 10:07:02 -08:00
Mihai Adrian
4fa6edc86e For #7122 Fix icons for saved logins screen (#7268) 2019-12-23 12:46:52 -05:00
Suraj Shah
6344a8892d For #7041 - Respect current mode when opening library items (#7311) 
* Fixes #7041
Consumes `browserMode` from home activity for tap method of bookmark

* Fixes spaces

* Cleaning tests

* Cleaning tests
 2019-12-23 12:26:47 -05:00
mozilla-l10n-automation-bot
a50d8552ac Import l10n. (#7009) 2019-12-20 14:01:18 -05:00
Roger Yang
dd1433733a
Closes #7156: Update app links feature usage to include app links interceptor (#7275) 2019-12-20 08:27:19 -05:00
Richard Pappalardo
f85961d9a9 Temp disable flaky UI testDownloadPrompt (#7304) 2019-12-20 10:31:43 +02:00
Josh
593981fa4b Fix parameterized message in search engine (#7302) 2019-12-20 10:27:05 +02:00
Jeff Boek
740572b6d9 For #5334 - Override custom tab styling in private mode (#7305) 2019-12-19 18:17:52 -08:00
Josh
a40af5b134 Closes #7254 - Replace Anko applyConstraintSet (#7286) 
* For #7254: Replace anko applyConstraintSet

* Anko has been deprecated and will not be continued

* Refactor ConstraintSet changes

* Replace applyConstraintSet in SearchLayouts

* Refactor HomeFragment ConstraintSet

* Define anonymous ConstraintSet
* Remove ConstraintSet prefix from PARENT_ID
 2019-12-19 18:16:50 -08:00
Mihai Adrian
c5a142aa14 For #6992, for #6897, for #6889: Disable multitouch in app (#6999) 2019-12-19 19:32:47 -05:00
Tiger Oakes
b85673acac Clean up settings fragments 2019-12-19 14:29:28 -08:00
Josh Vocal
43354489a1 For #7253 - Replace anko setters 2019-12-19 13:42:50 -08:00
Jeffrey Starke
59a021f3a3 Consolidate duplicate mock initialization in intent processor tests. (#6374) 
* Consolidate duplicate code in intent processor tests

* Resolve ktlint errors
 2019-12-19 12:33:59 -05:00
Mihai Adrian
33ac75d166 For #3574 Allow all screen readers to read onboarding items one-by one (#7292) 2019-12-19 09:53:53 -05:00
Tiger Oakes
76c83ba805
For #7085 - Remove anko px2dip (#7252) 2019-12-19 00:05:51 -08:00
Tiger Oakes
7c9a5c1f14
For #768 - Add PWA install option to menu (#6882) 2019-12-18 23:59:30 -08:00
mcarare
907d96e39f For #6709, for #6849 Handle default engine deletion and undo operation 
Uninstall engine immediately and allow reinstall in onCancel.
Set previous list with default engine in onCancel.
Keep default engine change in operation and remove now unnecessary view refresh.
 2019-12-18 23:00:42 -08:00
Tiger Oakes
f439c8110e For #7183 - Fix bottom margin in PWAs 2019-12-18 22:57:54 -08:00
Rushab Kumar
562eb89356 For #7250 - Replace anko.dimen 2019-12-18 15:39:14 -08:00
Sebastian Kaspari
e789d8ebe3 Issue #4978: Reuse widget package name of Fennec. 2019-12-18 15:23:43 -08:00
Emily Kager
5ac79f59a3 For #7219 - Polish Download Notification Dialog. (#7224) 
* For #7219 - Use accent color for downloads dialog positive button

* For #7219 - Fixes gap beneath download notification dialog

* switch to setimageresource
 2019-12-18 12:26:41 -05:00
Roger Yang
1a739db5b1 Closes #7260: Pass in GeckoView version information to MozillaSocorroservice 2019-12-18 10:45:57 +01:00
Grisha Kruglov
52334f9121 Closes #6937: Disable runStorageMaintenance during startup 
This call will acquire a "write" lock at the storage layer (sqlite's reserved+),
which may interfere with migrations that run during startup as well (they need to
write to storage, and so also need to acquire a lock). If these operations clash,
we get a SQLITE_BUSY crash. For now, just disable the maintenance operation.
 2019-12-17 14:24:30 -08:00
Tiger Oakes
ea486d7c66
Split out CustomTabToolbarIntegration (#7107) 2019-12-17 12:26:46 -08:00
David Walsh
b4e10965b7 Use localized strings in the quick settings panel (#7249) 2019-12-17 10:47:21 -08:00
Colin Lee
c0b9ad77be
For #4064: Update R8/ProGuard config for new Kotlin coroutines library (#7218) 2019-12-17 10:41:54 -06:00
Sebastian Kaspari
16b4680c06 Closes #4976: Use dynamic launcher entry in manifest. 2019-12-17 16:00:15 +01:00
Suraj Shah
6cb3879caf For #7048: Network info migration (#7091) 
* Fixes #7048.
Adds extension function to check if online or not based on capabilities
Modified `buildDeviceList`
Modifies tests

* Fixing lint error for max length
Fixing test in AppRequestInterceptorTest.kt

* Adds suppression for deprecation
Moving away from using anko for ConnectivityManager instance

* Creates ConnectivityManager extension component

* Fixes #7180
Refactors test cases to fix static mocks
 2019-12-16 22:03:11 -08:00
David Walsh
e727ae5d7e Fix 5366 - Use VectorDrawableCompat for all imagery (#7221) 
* Fix 5366 - Use VectorDrawableCompat for all imagery

* Fix detekt lint issues

* Restore previous comment contents
 2019-12-16 20:35:36 -08:00
Severin Rudie
cd53e9778a For 6795: expands toolbar whenever a new session is selected 
This ensures that the bar is expanded when opening a link in a new tab
 2019-12-16 14:09:29 -08:00
Jeff Boek
49f07554e7 No Issue - Removes some search engines 2019-12-16 14:09:14 -08:00
mcarare
90c77519a6 For #7194 Set snackbar anchor depending on browser toolbar position 2019-12-16 12:21:54 -08:00
Aaron Train
757c9577e0
No issue: Fixes breakage with unused import in 4a2cb91 (#7205) 2019-12-16 11:55:44 -05:00
Aaron Train
4a2cb91ad9
For #6697: Add Tracking Protection UI Tests (#6825) 
Add tests for verifying basic UI functionality of Enhanced Tracking Protection
 2019-12-16 10:12:43 -05:00
Patrick Martin
71880705df For #5711 - Onboarding colours have contrast issues 2019-12-13 17:52:55 -08:00
Afzal Najam
b9656a978e Hide add folder option when in Desktop Bookmarks folder 2019-12-13 17:51:15 -08:00
Ryan Kelly
31f2e80ab0 Use feature-accounts-push, which replaces feature-sendtab. 2019-12-13 16:42:28 -08:00
mcarare
bc6b7725e9 For #6968 Close response stream to allow use of caching 2019-12-13 12:35:25 -08:00
mcarare
d2abac78eb For #7075 Update passwords preference visibility and string 
Set visibility for feature flags before settings screen it's displayed.
Change string for preference to match existing header string.
Update UI Tests
 2019-12-13 12:19:14 -08:00
mcarare
ef53e1ff8e Reverts #6925: Make home screen full screen 2019-12-13 11:29:53 -08:00
Colin Lee
a8f895cb5c
For #4064: Replace prerelease R8 with improved Kotlin coroutines library (#7153) 2019-12-13 13:29:27 -06:00
Will Hawkins
116f7b3d65 No Issue: Create a method to "finish onboarding" in CI 
If the intent that starts the HomeActivity includes an extra
boolean flag named finishonboarding and it is set to true,
Fenix will "finish onboarding".
 2019-12-13 11:28:57 -08:00
Emily Kager
686facffc6 For #6946 - Get engine margins without assuming top/bottom toolbar 2019-12-13 11:09:30 -08:00
Emily Kager
dcb39b0a44 For #7124 - Match toolbar location for ETP/security panel gravity 2019-12-13 11:09:30 -08:00
Vlad Filippov
a3f2f55548 Closes #5913: Add new sessionToken scope (#6155) 2019-12-12 12:00:20 -08:00
Emily Kager
558f90da00 No issue: Scroll to remote debugging text in UI Tests (#7117) 2019-12-12 12:00:02 -08:00
Tiger Oakes
32985af882 For #6830 - Fix "Open in" text size for custom tab (#7010) 2019-12-12 11:49:54 +02:00
ValentinTimisica
8b8f3d1b56 For #4776: Refactored UI tests. 
After removing the 'Privacy notice' and 'Help' items from the Settings screen
the UI tests for them became unneeded.
 2019-12-12 11:34:10 +02:00
ValentinTimisica
b819cb11c9 For #4776: Added Unit tests for About Page. 2019-12-12 11:34:10 +02:00
ValentinTimisica
c6c827f693 For #4776: Redesign and refactor the About Page 
Added new items to be displayed.
 2019-12-12 11:34:10 +02:00
Grisha Kruglov
72d8dfb976 Enable Fennec settings (telemetry) migration 2019-12-11 19:16:55 -08:00
mcarare
1c9c8f590a For #7066 Increase space below checkbox preference 2019-12-11 11:23:14 -08:00
Mihai Adrian
bfc65e0614 For #6710 Update custom search engine images with better resolution (#7084) 2019-12-11 16:09:32 +02:00
Sawyer Blatz
de6469e198 For #7073: Makes logo on about page not important for accessibi… (#7074) 2019-12-10 12:15:11 -08:00
Mihai Branescu
c46bf84ac9 For #6330 Collections Numbering (#6453) 
* For #6330 - Added logic for getting the recommended default collection name

* For #6330 - Added unit test for default collection number method
 2019-12-10 12:10:01 -08:00
Tiger Oakes
fe034226a3
For #5783 - Web Share with Fenix share sheet (#6883) 2019-12-10 10:57:06 -08:00
Mihai Adrian
6e9769a81b For #7031 - Hide progress bar when leaving DeleteBrowsingDataFragment (#7056) 2019-12-10 11:17:45 -05:00
isabelrios
1d04736884 Re-enable Screenshots tests (#6617) 
disabling setting test options due to different screen sizes

name screenshots according to robots

fix kotlin style

update settings tests with new Toolbar option

screenshots tests in different package than ui tests
 2019-12-10 13:05:47 +02:00
Sebastian Kaspari
a83717dd7b Run migration in background service. 
In order to avoid a half done migration we are moving the migration to a background service (that is
running in the "foreground").

This is the Fenix part of:
https://github.com/mozilla-mobile/android-components/issues/4879
 2019-12-10 11:31:32 +01:00
Tiger Oakes
3f7205e3cb
Extract IntentProcessorType to its own file and add tests (#7012) 2019-12-10 00:02:23 -08:00
Severin Rudie
7477de83e9 For #4844: fix file prefix url shortening 2019-12-10 05:07:53 +01:00
Severin Rudie
957ed8aa88 For #5334: fix ETP shield coloring on custom private tabs 2019-12-10 03:22:55 +01:00
Mihai Adrian
45ae8cb35a For #6997 Avoid overwriting empty_search_string error (#6998) 
Setting error twice also clips error message
 2019-12-09 18:10:24 -08:00
Emily Kager
76e9200304 For #6922 - Check current destination is logins fragment before navigation (#6924) 2019-12-09 15:42:40 -08:00
Michael Comella
2a4aa24195 For perf-frontend-issues#33: Clarify VERBOSE logging motivation. 2019-12-09 15:11:52 -08:00
Michael Comella
eef080a46c For perf-frontend-issues#33: Add HotStartPerformanceMonitorTest. 
We really don't want our startup tests to subtlely change so I thought
it was worth writing some quick tests.
 2019-12-09 15:11:52 -08:00