Commit Graph

1898 Commits

Author SHA1 Message Date
Sebastian Kaspari
61e84c161d Rename SearchStore/State/Action to SearchFragmentStore/State/Action. 2019-09-03 10:09:06 -07:00
Sebastian Kaspari
22446263f1 Rename ExceptionsStore/State/Action to ExceptionsFragmentStore/State/Action. 2019-09-03 10:09:06 -07:00
Sebastian Kaspari
ac32a88d45 Rename BrowserStore/State/Action to BrowserFragmentStore/State/Action. 2019-09-03 10:09:06 -07:00
Sebastian Kaspari
76063e307a Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action. 2019-09-03 10:09:06 -07:00
mihai-adrian
3171f3a1a7 Fixes #4997: Changed navigation to ShareFragment
Changed test for new global navigation to share fragment.
2019-09-03 07:08:08 -10:00
mihai-adrian
fc8fc2b33d Fixes #4997: Changed navigation to ShareFragment
Added global navigation action to share fragment in navigation graph
Changed share action to use global navigation to ShareFragment
2019-09-03 07:08:08 -10:00
Sebastian Kaspari
389b85f783 Issue #4907: Link to usage of sharedUserId in Fennec code. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
be8b789e62 Issue #4907: Config: Get rid of "floating pow()". 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
be76a383b6 Issue #4907: Config: Update commment explaining fennec versioning scheme. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
3fb22a12b6 Issue #4873: Use manifest placeholder to inject sharedUserId. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
754c577682 Issue #4873: Reuse sharedUserId from Fennec for fennecProduction build type. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
10143858cb Issue #4873: Use Fennec version code mechanism for fennecProduction build type. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
00ead7e31f Issue #4873: Only build fennecProduction build types with GeckoView Beta. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
4f51af07ae Issue #4873: Reuse Firefox application id for fennecProduction build type. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
c7216d1bd7 Issue #4873: Introduce "fennecProduction" build type. 2019-09-03 17:10:06 +02:00
Colin Lee
709588572a
For #5055: Crash when opening bookmarks (#5058) 2019-08-31 17:41:50 -05:00
liuche
ac950f6b97
Closes #5007 - Add PR guidelines to README. (#5008)
* Closes #5007 - Add PR guidelines to README.

* No issue: Add codecov and task status
2019-08-30 17:38:55 -07:00
Christian Sadilek
946be9e9ac Use Mozilla Application Services 0.38.1 2019-08-30 18:32:25 -04:00
Christian Sadilek
4cf03be236 For #2088: Use new async API to load default search engine in HomeFragment 2019-08-30 17:56:18 -04:00
Christian Sadilek
9dd9503db9 Use Mozilla Android Components 11.0.0-SNAPSHOT 2019-08-30 17:56:18 -04:00
Sebastian Kaspari
9b633f7f0f Move creation of GeckoRuntime to flavor-specific source set.
Since we are now able to build against GeckoView Nightly and GeckoView Beta,
we should create the GeckoRuntime from a flavor-specific source set.

Creating the runtime is not covered by the AC abstraction and so API changes
in GeckoView Nightly can break the build and leaves us with no option to fix
it from a shared code base. Separating the creation of GeckoRuntime
allows us to adapt individually and also to configure the runtimes
differently.
2019-08-30 15:16:12 +02:00
Will Hawkins
3abffd5d77 Use new async API to load and access search engines
Use the new asynchronous features of the search engine
manager from a-c to avoid the latency required to load
the default search engine.
2019-08-29 18:16:02 -07:00
Richard Pappalardo
ab57bfd46f fix: dex error on UI test job 2019-08-29 18:14:20 -07:00
Mugurell
bf5b0e5cda For 4007 - Add unit tests for the Share Interactor, Controller and list Adapters 2019-08-29 18:12:50 -07:00
Mugurell
e165868a53 For #4007 - Add ShareController for handling ShareFragment's business logic
`ShareController` defines a contract with all possible `ShareFragment`'s
behavior changes and comes with a default implementation -
`DefaultShareController`.
It is to be delegated by all `ShareFragment`s contained Views' Interactors
following any user interactions.
2019-08-29 18:12:50 -07:00
Mugurell
16eba61b25 For #4007 - ShareFragment will set the contained Views' state
ShareFragment which acts as a container would contain all business logic needed
for populating it's Views.
Data initialization should be done only once since the app state has no reason
to change after the ShareFragment is created and is done as soon as possible,
in onAttach().
Because of the expected short lifespan of this fragment, given the fact that
the state has no reason to change and we handle orientation changes ourselves
to keep things simple I didn't use a ViewModel to persist the state.
2019-08-29 18:12:50 -07:00
Mugurell
095870145f For #4007 - Refactor AppShareView in standalone Share Views
In an effort to respect the initial MVI architecture I've broken the
complex `AppShareView` in 3 separate Views
- `ShareCloseView`
- `ShareToAccountDevicesView`
- `ShareToAppsView`
They are standalone Views (extending LayoutContainer) which know nothing about
each other or their parent and so offer their container the possibility to
order or display them in any form later.
According to the lib-state contract they are only responsible to
- inflate themselves in their injected containerView
- render a certain state (to be added in later commits)
- delegate all user interaction to an associated Interactor
2019-08-29 18:12:50 -07:00
Mugurell
5e19741ddd For #4007 - Use camelCase for views referenced from code
As per #4341.
Also reformatted layouts to have a more consistent style.
Also refactored `AppShareRecyclerView` and `AccountDevicesShareRecyclerView` by
defining their LayoutManager in XML to reduce code complexity.
2019-08-29 18:12:50 -07:00
Tiger Oakes
fb907033bb Add comments to AuthCustomTabActivity 2019-08-29 15:06:34 -07:00
Sawyer Blatz
cea18f31c4
For #3892: Fixes help link on nightly (#4956) 2019-08-29 13:27:50 -07:00
Mihai Adrian
9b911f3276 Fixes #4894: added workaround for SDK<24 vector drawable with gradient color (#4944)
Removed drawableStart and added ImageView in layouts
Set ImageView logo programmatically: bitmap for SDK<24, vector for SDK>=24
Added onClickPendingIntent for ImageView in large and medium layouts
2019-08-29 12:55:51 -07:00
Tiger Oakes
f740d4382a Closes #773 - Add shortcuts to homescreen (#4925) 2019-08-29 14:45:11 -05:00
Colin Lee
ca118033a2
Updated CODEOWNERS file to let A-C review Fenix PRs (#5013) 2019-08-29 14:26:16 -05:00
Colin Lee
66b2969077
For #4064: Old R8 & keep rules are inhibiting optimizations (#4930) 2019-08-29 10:16:26 -05:00
mihai-adrian
5e78420cce Fixes #3602:navigate to top of home screen after tapping "start browsing"
After onboarding.finish(), scrolled homeLayout to top
2019-08-29 07:45:04 -07:00
Jonathan Almeida
f25a9660e8 Closes #4218: Remove forced registration renewal for push 2019-08-28 21:14:12 -04:00
Jonathan Almeida
18ca62b887 For #4063: Remove SendTab feature flags 2019-08-28 21:14:12 -04:00
Colin Lee
04f364a883
For #4631: Make sure reviewers can access a PR APK (#5004) 2019-08-28 17:46:46 -05:00
Yeon Taek Jeong
d87b8a8a5c
For #4658: Add some private browsing mode telemetry (#4968) 2019-08-28 14:41:37 -07:00
Sawyer Blatz
09ed721015 For #4969: Removes erroneous FxA sign up ping (#4970) 2019-08-28 14:32:43 -07:00
Colin Lee
040a6ad7c6
For #4222: Fix another Nimbledroid upload path (#5000) 2019-08-28 15:24:02 -05:00
Yeon Taek Jeong
cc5408d717
For #2053: Add persistent notification to close all private browsing tabs (#4913) 2019-08-28 12:55:24 -07:00
Johan Lorenzo
de6dcd59f4 Restrict Taskcluster to collaborators on PR (#4996) 2019-08-28 14:16:04 -05:00
Michael Droettboom
ad80317fc8 1577253: Remove writing dependencies to an artifact (#4999) 2019-08-28 14:10:11 -05:00
Sebastian Kaspari
aa5069caca Closes #4215: CustomTabActivity: Remove attached session if activity is finishing. (#4985) 2019-08-28 11:03:04 -07:00
Emily Kager
7b5ed2673b For #4863 - Remove delay in HomeFragment onPreDraw 2019-08-28 13:48:14 -04:00
Suraj Shah
66a8c04967 Fixes #4488: Shows snackbar on bookmark deletion from edit fragment (#4792)
* Fixes #4488
Updates changelog

* Removes wildcard imports.

* Removes custom label in use, replaces with let
2019-08-28 10:12:39 -07:00
Sebastian Kaspari
8608375eac Use Mozilla Android Components 10.0.1. 2019-08-28 15:31:25 +02:00
Jonathan Almeida
681257bea7 For #4960: Initialize push only if available (#4964) 2019-08-27 14:15:38 -07:00
Mitchell Hentges
76761242f1 Fixes #4949 - raptor not being able to find APKs (#4952) 2019-08-27 14:08:17 -07:00