ishan/fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
6,225 Commits 34 Branches 356 Tags 125 MiB
51df37cde5
Commit Graph

5258 Commits

Author SHA1 Message Date
Mozilla L10n Automation Bot
0f4735dad9 Import l10n. 2021-02-26 00:39:00 +00:00
Gabriel Luong
9cca1b93b5 Replace TopSitesUseCases.renameTopSites with TopSitesUseCases.updateTopSites 2021-02-25 17:46:23 -05:00
Christian Sadilek
dc002f0508 Remove Session[Manager] references from Fennec intent processors 2021-02-25 11:54:21 -05:00
Mozilla L10n Automation Bot
2ddcc90293 Import l10n. 2021-02-25 00:41:07 +00:00
Arturo Mejia
0e8dc6164d Target Android 11 2021-02-24 14:26:08 -05:00
mcarare
9e20de21a8 For #16044: Suggest search engines based on typed text. 2021-02-24 17:32:04 +02:00
Arturo Mejia
a16f554799 For issue #10428 Improve download dialog error message. 2021-02-24 09:35:30 -05:00
Mozilla L10n Automation Bot
b1f05f7654 Import l10n. 2021-02-24 08:04:35 +00:00
mcarare
2ead66f5c2 For #18102: Temporary ignore failing test. 2021-02-23 17:58:02 +01:00
Mozilla L10n Automation Bot
0eefce52d8 Import l10n. 2021-02-23 14:26:58 +00:00
Mugurell
d0cb6c0c00 For #18027 - Document shouldUseFixedTopToolbar 2021-02-23 13:13:44 +02:00
Mugurell
0a0f75d2ab For #18027 - Also fix the bottom toolbar in place when a11y is enabled 
We previously only set the top toolbar as fixed if an a11y service was running.
 2021-02-23 13:13:44 +02:00
rxu
c9ed8a5b92 Add MOZILLA_ONLINE_ADDON_EXCLUSIONS for Mozilla Online builds 2021-02-22 10:00:57 -05:00
mcarare
cb246ed4bb For #18075: Add SaveVideoAudioCandidate for custom tabs context menu. 2021-02-22 10:05:46 +02:00
Mozilla L10n Automation Bot
6fd93dfe15 Import l10n. 2021-02-21 00:28:51 +00:00
Jonathan Almeida
2f6fcbf196 Close #13892: Remove Synced Tabs appended to tabs tray 2021-02-20 23:02:18 +04:00
Mozilla L10n Automation Bot
516a6a343f Import l10n. 2021-02-20 00:35:38 +00:00
Michael Comella
359f27abc1 For #17972: split frameworkStart into two metrics. 
We do this in order to make it easier to analyze in GLAM: see the metric
descriptions for more details.

Additionally, we change the time unit to milliseconds to make it easier
to analyze in GLAM.
 2021-02-19 13:21:31 -08:00
Michael Comella
012cc21521 For #17972: add client id to startup-timeline ping, update docs. 
This addresses the root problem we're experiencing for this issue - data
not showing up in GLAM.
 2021-02-19 13:21:31 -08:00
Michael Comella
993428cd0f For #17969: add duration probes for App.onCreate and HomeActivity.onCreate. 2021-02-19 13:20:34 -08:00
Mugurell
6e0a64897b For #17899 - Expand toolbar when returning from fullscreen video 
This was the previous behavior for both the top and bottom toolbars.
Regressed when changing to use a new custom behavior for the top toolbar.

When entering fullscreen we will now collapse and hide the toolbar, allow the
browser to expand to the entire screen estate and then, when exiting fullscreen
expand the toolbar.
Collapsing and then expanding the toolbar will trigger the
EngineViewBrowserToolbarBehavior to place the browser below the toolbar.
 2021-02-19 17:46:49 +02:00
Roger Yang
64f32b9d95
Closes #17089: Add metric to track both normal and private URI opened (#17935) 2021-02-19 10:37:07 -05:00
Sebastian Kaspari
a2566f9e9e Issue #12731: Collect telemetry about the content process of tabs getting killed. 2021-02-19 11:32:56 +01:00
Sebastian Kaspari
fc80dbfb57 Update Kotlin to 1.4.30 and Coroutines to 1.4.2. 2021-02-19 11:31:15 +01:00
Mozilla L10n Automation Bot
666833c2e5 Import l10n. 2021-02-19 00:31:43 +00:00
Arturo Mejia
21d10aa931 Update toolbar autoplay strings 2021-02-18 16:40:43 -05:00
Christian Sadilek
e07f4ac590 Deprecate SessionManager component 2021-02-18 14:28:28 -05:00
Christian Sadilek
2d87307144 Remove remaining usages of Session[Manager] in BrowserFragment 2021-02-18 14:28:28 -05:00
Christian Sadilek
c9b8f57f96 Refactor BrowserToolbarMenuController to use browser store 2021-02-18 14:28:28 -05:00
Arturo Mejia
b6ac5079b2 For issue #18049 Download complete dialog is not showing in custom tab. 2021-02-18 12:43:52 -05:00
Victor
2193be27b2 Solves Leaks on SavedLoginFragment 
disables options menu to avoid leak
 removes on click listener to avoid leak
 2021-02-18 19:00:44 +02:00
Sebastian Kaspari
9b65e63422 Closes #18006: DefaultSessionControlControllerTest: Correctly unmock SearchStateKt class. 
The test class left SearchStateKt mocked and caused other tests to fail intermittently when
running after it.
 2021-02-18 15:49:31 +01:00
mcarare
af9c32983f For #17807: Fix systemWindowInset deprecation. 2021-02-18 09:14:53 -05:00
Oana Horvath
d7f1117e17 For #16317 UI tests: save longTap preference to restore it 2021-02-18 13:46:09 +02:00
Mozilla L10n Automation Bot
7e70eccca0 Import l10n. 2021-02-18 00:36:55 +00:00
Ryan Kelly
56914cd42d Reset experiment telemetry identifiers on data prefs change. 
When the user opts out of telemetry, we need to reset the user identifiers
used by the experiment system, so that there's no risk of tracking the
user across the reset event if they later decide to re-enable telemetry.
 2021-02-17 16:07:57 -05:00
Oana Horvath
4e4bbcc334 For #16317: resets long press delay at the end of UI tests 2021-02-17 16:39:44 +02:00
Mozilla L10n Automation Bot
dfc5628ca1 Import l10n. 2021-02-17 00:39:54 +00:00
Jan-Erik Rediger
3e9ab1b150 Glean: Check for renamed reason 2021-02-16 16:32:14 -05:00
Mugurell
611ff8f25b For #17195 - Don't try setting an idle resource if the View is already off screen 
Speculative fix based on the Firebase logs which shows that on a second check
of R.id.tab_wrapper it is not found the screen.
It may be because after `advanceToHalfExpandedState` and before getting a
reference to it in `waitForTabTrayBehaviorToIdle` it was already animated off
the screen.
With this in mind I've added a null check for the view reference before trying
to register an idling resource on it's Behavior.

Also added and used a way to click at a specific location in a View, not just
in the default middle in the View.
It was observed from the Firebase videos that a "click" on the topBar actually
selected the private tabs section. This would leave us to believe that the
"click" was caught by that other View which was placed above the x,y middle of
the topBar.
 2021-02-16 16:26:17 +02:00
Mugurell
32493491fa For #17195 - Test a potential fix for the test 2021-02-16 16:26:17 +02:00
Oana Horvath
23cc3522aa For #17484, #18003 UI tests: retry closing tab if it fails 2021-02-16 14:28:26 +02:00
Mozilla L10n Automation Bot
f5cb3a9920 Import l10n. 2021-02-16 00:29:18 +00:00
Christian Sadilek
5a5cf9cd12 Refactor BrowserToolbarController to use browser store 2021-02-15 15:01:29 +01:00
Codrut Topliceanu
ec54397637
For #17352 - Fixes deleted downloads reappearing (#17930) 
* For #17352 - Fixes deleted downloads reappearing

The `getDeleteDownloadItemsOperation` job would check fragment context not null after the fragment was stopped. Removing that check and only passing the downloadUseCase as a parameter fixes the problem.
 2021-02-15 11:22:09 +02:00
Mozilla L10n Automation Bot
9fee349600 Import l10n. 2021-02-15 00:40:59 +00:00
Mozilla L10n Automation Bot
ed0a188e7e Import l10n. 2021-02-14 00:36:56 +00:00
Mozilla L10n Automation Bot
3c54562504 Import l10n. 2021-02-13 01:55:06 +00:00
Elise Richards
bab7693b9d
Remove unneeded temporary UI test ignores (#17980) 2021-02-12 17:01:38 -06:00
Mugurell
3311e68d14 For #17686 - Use a custom behavior to scroll InfoBanner with the top toolbar 
Previously when the toolbar was on top the banner was inflated in the toolbar's parent - an AppBarLayout.
After migrating to use a custom behavior for scrolling the toolbar and not use
anymore the AppbarLayout for this we needed a new solution.
Using a new behavior to keep this banner in sync with the y translation of the
toolbar gives us most of the old behavior back.
 2021-02-12 16:05:19 +02:00
Elise Richards
d0fd3e82c5
For #17771: three-dot menu reorder (#17838) 
* Feature flag for toolbar menu redesign. Add new items to menu and reorder.

* Handle toolbar items in menu controller

* Menu controller tests

* Make icons invisible

* Lint

* UI tests reflect design change

* Refactor test names

* Lint fixes

* UI tests
 2021-02-11 18:55:12 -06:00
Mozilla L10n Automation Bot
eabde04679 Import l10n. 2021-02-12 00:24:31 +00:00
Michael Comella
b41041c739 For #17920: move manufacturer StrictMode exception to ignores function. 
I think this is more consistent and centralizes the violation ignores.
 2021-02-11 15:22:50 -08:00
Michael Comella
5cb296b098 For #17920: use StrictMode penaltyDeathWithIgnores. 2021-02-11 15:22:50 -08:00
Michael Comella
a86b4ef1bd For 17920: add ThreadPenaltyDeathWithIgnoresListener, tests, helpers. 2021-02-11 15:22:50 -08:00
Michael Comella
e9e067615a For #17920: add ManufacturerCodes. 2021-02-11 15:22:50 -08:00
Michael Comella
2e45483eb0 For #17816: add ProfilerFactProcessor and register it, tests. 2021-02-11 14:52:36 -08:00
Mugurell
41f9388380 For #17803 - Use the main looper for Handler()s 
This was already the one inferred.
Targeting Android 11 means we need to pass it explicitly.
 2021-02-11 19:42:33 +02:00
Codrut Topliceanu
d56b4a2b92
For #17418 - Added telemetry for Google Default Top Site (#17637) 
* For #17418 - Adds channel "ts" to TrackKey

This is used to track if the `InContentTelemetry` is a result of the user using the Google Top Site. It looks for `&channel=ts` within the uri.

* For #17418 - Adds TopSite PerformedSearch back in

* For #17418 - Check now looks for equality with GOOGLE_URL

* For #17418 - Adds test for topSite changes
 2021-02-11 11:31:01 -05:00
Mozilla L10n Automation Bot
9d07b7ae03 Import l10n. 2021-02-11 09:45:42 +00:00
Sebastian Kaspari
a3b556aa35 ToolbarIntegration: Use global public suffix list instance. 2021-02-11 09:33:40 +02:00
Roger Yang
8dfa4525ca
Fix OpenSpecificTabIntentProcessorTest to remove AbstractMediaService (#17955) 2021-02-10 13:33:39 -05:00
Sebastian Kaspari
f4f5e4b663 Issue #17174: Remove usage of old media APIs. 2021-02-10 16:42:58 +01:00
Christian Sadilek
88facc4608 Closes #17889: Wrong tab selected/reloaded when restored from collection 2021-02-10 10:46:13 +01:00
Mozilla L10n Automation Bot
ca57a132c7 Import l10n. 2021-02-10 00:29:59 +00:00
ekager
08a1e0f728 For #17906 - Allow screenshots for private home screenshot test 2021-02-09 12:52:46 -07:00
Oana Horvath
a98b40896d For #15259 UI test: waits for home screen to be visible 2021-02-09 17:22:24 +02:00
AndiAJ
e31b4f49e9 For #17195 Fix Intermittent UI test verifyTabTrayNotShowingStateHalfExpanded 2021-02-09 16:46:31 +02:00
AndiAJ
e0c70582b8 For #17852 Change and Fix Intermittent UI test openNewTabTest 2021-02-09 16:43:56 +02:00
Michael Comella
b3ef8a11e8 For #17816: add profiler marker for onPreDraw via HomeActivity.onStart. 
This may be useful for MAIN start up to determine when the user begins
seeing content.
 2021-02-08 17:46:32 -08:00
Michael Comella
4de49c7585 For #17816: add profiler marker for 2x Activity.onCreate. 
The IntentReceiverActivity one is particularly useful to quickly determine
when we can begin executing code in the WARM VIEW case (i.e. "Set selection
begin here").

The HomeActivity one is useful for COLD start up analysis in similar
ways and to see the Activity transitions in WARM VIEW.
 2021-02-08 17:46:32 -08:00
Mozilla L10n Automation Bot
4084664d30 Import l10n. 2021-02-09 00:42:20 +00:00
ekager
5e9fb855f5 For #17915 - Do not launch system settings on Role Request Intent cancel 2021-02-08 09:56:38 -07:00
AndiAJ
46888cc70f For #14523 Fix Intermittent tests verifyContextOpenLinkNewTab & verifyContextOpenLinkPrivateTab 2021-02-08 18:15:14 +02:00
Oana Horvath
c6bf949a03 For #17847: Removes editCustomSearchEngineTest UI test 2021-02-08 17:47:05 +02:00
Mozilla L10n Automation Bot
e24580f0b7 Import l10n. 2021-02-08 00:34:20 +00:00
Arturo Mejia
3a1d56d7c8 For #17817 Change the feature prompt references from fragment to activity. 2021-02-07 08:10:57 -05:00
Mozilla L10n Automation Bot
b057dead45 Import l10n. 2021-02-07 00:39:01 +00:00
Abhinav Gupta
13f5df33a1 Hiding the usernameview if the data item.username is blank. 2021-02-06 13:20:22 -07:00
ekager
f6455b0148
Closes #17871 - use viewLifecycleOwner for TopSitesFeature owner on HomeFragment (#17873) 2021-02-05 19:47:25 -05:00
Mozilla L10n Automation Bot
dc8c88fa50 Import l10n. 2021-02-06 00:25:11 +00:00
Roger Yang
993cf74e72
Closes #17174: Remove the New Media Session API Feature Flag (#17863) 2021-02-05 18:54:37 -05:00
ekager
0defc54449 Closes #13089 - Adds correct animations for account settings 2021-02-05 14:03:18 -07:00
ekager
f5b068a453 For #17785 - Use screenshots setting when adding secure flag 2021-02-05 13:17:47 -07:00
jhugman
1ef4102e13
Fixes #17738 - Early initialization of Nimbus (#17834) r=christian 2021-02-05 18:54:47 +00:00
Mugurell
8bf1cae2ca For #10686 - Use the AC custom behavior for both the top and bottom toolbars 
This comes to unify the experience (with improvements but also specific issues)
for the url toolbar irrespective of it being placed at the bottom or at the top
Going further this will ease development and ensure the best UX for users.
 2021-02-05 18:23:32 +01:00
Gabriel Luong
a3d401a3b7
For #17418 - Add event ping telemetry for the Google Top Site click (#17862) 
Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2021-02-05 12:06:32 -05:00
jhugman
0b764fd3e4
Fixes #17833 - increment A/A experiment id (#17835) r=christian 2021-02-05 16:41:46 +00:00
Christian Sadilek
50e66b469d Remove SessionManager reference from FenixApplication 2021-02-05 14:16:35 +01:00
Oana Horvath
f0b7b3b987 For #17847: disables editCustomSearchEngineTest 2021-02-05 11:11:33 +02:00
MickeyMoz
378e68f3a6 Update Android Components version to 73.0.20210204143136. 2021-02-04 18:21:26 +01:00
Andrei Joltan
936966596a
For #16020 Fix Intermittent tests caused by the Menu Button (#17829) 2021-02-04 11:42:58 -05:00
Oana Horvath
9783930ac5 For #16615: UI smoke test customTrackingProtectionSettingsTest 2021-02-04 12:17:23 +02:00
AndiAJ
a4a2a59b7d For #12895 Fix Intermittent test navigateBookmarksFoldersTest 2021-02-04 10:06:39 +02:00
hwinnemo
c488bb0e11 For #17724: Wait for tab to be fully created before showing ETP Onboarding if ETP is active 2021-02-03 17:24:23 -07:00
Sebastian Kaspari
f4a7b4c066 Remove TabsUseCases methods that take a Session object. 2021-02-03 15:16:39 -05:00
Grisha Kruglov
3ce9bf93bc Exclude separators from the bookmarks UI 2021-02-03 11:09:01 -08:00
Grisha Kruglov
ebca575e26 Reuse helper functions in bookmark tests 2021-02-03 11:09:01 -08:00
Mugurell
40fc9c1085 For #12414 - Support sharing images through ShareDownloadFeature 
Register a ViewBoundFeatureWrapper<ShareDownloadFeature> that will respond to
"Share image" from the browser contextual menu
 2021-02-03 18:35:20 +02:00
Michael Droettboom
fedc2e1187 Update bug numbers to URLs for activation ping 
Earlier versions of Glean supported bug numbers of the metadata, but this causes
ambiguity, particularly for Fenix where issues exist in both Bugzilla and
Github. This just updates the Bugzilla numbers to full URLs.

We made the use of numbers an error sometime ago, but neglected to enforce this
on "pings" in addition to "metrics".  A future version of `glean_parser` [1] will make
this an error and this will set Fenix up to be ready for that.

[1] https://github.com/mozilla/glean_parser/pull/262
 2021-02-03 09:45:28 -05:00
mcarare
994ec4d55a For #17364: Make hint scrollable and do not overlap other elements. 2021-02-03 14:54:03 +02:00
mcarare
d7ad203544 For #17364: Do not show search suggestion hint before starting to type. 2021-02-03 14:54:03 +02:00
rxu
542071a344 Add mozcn safebrowsing for release variant 2021-02-03 10:35:32 +01:00
Christian Sadilek
e76445b299 Refactor WebAppSiteControlsBuilder to use browser store 2021-02-03 10:16:06 +01:00
Mozilla L10n Automation Bot
dca0cb8c10 Import l10n. 2021-02-03 00:27:35 +00:00
Christian Sadilek
3dc638700f Refactor tryReloadTabBy to use browser store 2021-02-02 17:13:13 -05:00
Sebastian Kaspari
28c105dcb3 Remove SessionManager dependency from CustomTabsIntegration. 2021-02-02 14:17:46 -05:00
Elise Richards
854a5e676f
Increase date on expired metrics (#17766) 2021-02-02 12:27:10 -06:00
Arturo Mejia
e3b6f060ae For #12822 - Opt-in of scoped storage 2021-02-02 12:58:44 -05:00
Jonathan Almeida
824f3fd821 Issue #1340: Forward Activity results to the fragment 2021-02-02 19:46:20 +04:00
Oana Horvath
f180d932c8 For #16959: verify page url not content in swipeToSwitchTabTest 2021-02-02 15:19:00 +02:00
AndiAJ
c8c0131d00 Go Forward Test Fix 2021-02-02 10:23:29 +02:00
AndiAJ
5eb1a3d210 For #17641 Fix Intermittent test addPredefinedSearchEngineTest 2021-02-02 10:23:22 +02:00
AndiAJ
23e6f7aa91 For #16615: UI Smoke Tests for Tab Crash Reporter 2021-02-02 10:23:04 +02:00
Mozilla L10n Automation Bot
4c2a4f4d2e Import l10n. 2021-02-02 01:48:13 +00:00
jhugman
72f977771d
Re-enable Nimbus with Off the main thread I/O and non-blocking networking (#17684) 
* Moved Nimbus setup from Analytics to its own file

* Change experiment identifiers to fit new run of the experiment

* Re-enable nimbus for debug and nightly builds

* ./gradlew ktlint && detekt
 2021-02-01 23:50:07 +00:00
Christian Sadilek
d8085480ad Increase AMO collection cache timeout to 2 days 2021-02-01 17:08:34 -05:00
Michael Comella
cdc008f6a3 For #17553: renew storage.stats metrics. 2021-02-01 16:33:08 -05:00
Christian Sadilek
89ad370eb2 Remove SessionManager references from UI tests 2021-02-01 10:58:46 -05:00
mawen7
1df656cd0e
Include selected session in session suggestions if opened from home fragment (#17127) 2021-02-01 10:17:49 +02:00
MickeyMoz
4bc6b85237 Update Android Components version to 73.0.20210129195412. 2021-01-31 02:55:37 +00:00
Mozilla L10n Automation Bot
4507560325 Import l10n. 2021-01-31 00:36:55 +00:00
Mozilla L10n Automation Bot
9afb78de3f Import l10n. 2021-01-30 00:29:45 +00:00
Michael Comella
d48bb2a4cc Revert "For #17447: add intentional delay to cold start up in debug and nightly." 
This reverts commit 093470a8b3. This
intentional regression was only intended to be temporary so now we're
removing it.
 2021-01-29 14:59:27 -08:00
Roger Yang
d434ff13a5
For #17092: Dismiss toolbar menu when configuration change occurs (#17682) 2021-01-29 15:16:21 -05:00
Jonathan Almeida
66b94ced14 Close #1340: Add support for WebAuthnFeature 2021-01-29 22:57:49 +04:00
rxu
be0382fca7 Pop out privacy notice in first launch in MozillaOnline builds 
Add privacy notice related strings

Pop out privacy notice with onboarding

Using embeded geckoview to display details about privacy

Present or hide privacy pop window according to isMozillaOnline

Add activity_privacy_content_display.xml into layoutNotToTest due to EngineView
 2021-01-29 09:35:57 -05:00
Codrut Topliceanu
e188185b15
For #16828 - Adds telemetry for open in app banner (#17049) 
* For #16828 - Adds telemetry for open in app banner

Specifically: Banner displayed, Dismiss action, Go to Settings action.
 2021-01-29 10:14:32 +02:00
Jonathan Almeida
81e08b2e7f Close #15979: Add MOZILLA_OFFICIAL flag for release builds 
When we build release APKs on Mozilla infrastructure, we want a way to
know this in code for features that would only work on them.
 2021-01-29 10:51:33 +04:00
Mozilla L10n Automation Bot
41e6c7247e Import l10n. 2021-01-29 00:29:36 +00:00
Elise Richards
43b0b27819
Update metrics when an addon is installed or enabled (#17669) 2021-01-28 14:30:59 -06:00
Oana Horvath
d7b8af78c9 For #9188: wait for page content to appear in Reader mode tests 2021-01-28 17:33:40 +02:00
Mozilla L10n Automation Bot
f3d332dd8b Import l10n. 2021-01-28 00:32:43 +00:00
Mihai Adrian Carare
8993a0acb2
For #17655: Do not pass threshold if showTopFrecentSites is false. (#17657) 
* For #17655: Do not pass threshold if showTopFrecentSites is false.

* For #17655: Add unit tests for getTopSitesConfig.
 2021-01-27 16:54:48 -05:00
Christian Sadilek
45c0ac85ec Remove SessionManager from BrowserFragment/ToolbarGestureHandler 2021-01-27 16:24:25 -05:00
Roger Yang
124c2baf30
Closes #17531: Use top sites count fact for top sites telemetry (#17664) 2021-01-27 12:46:16 -05:00
Oana Horvath
67ff4d460a For #9188: wait for page load in Reader mode 2021-01-27 18:14:27 +02:00
Roger Yang
eaef276345
Closes #17530: Update has open tabs metrics when tabs are opened or closed (#17557) 2021-01-27 10:51:03 -05:00
mcarare
780e3362a5 For #17464: Handle selected item background programmatically. 2021-01-27 09:14:42 -05:00
Mozilla L10n Automation Bot
4877b77073 Import l10n. 2021-01-27 01:14:34 +00:00
Christian Sadilek
ef8d07fadf Fix breaking API change in FennecMigrator 2021-01-26 19:06:02 -05:00
Gabriel Luong
171c466ada For #14302 - Skip one time pages visit from frecent top sites 2021-01-26 19:06:02 -05:00
mcarare
278ed658b6 For #17635: Check if id corresponds to a custom tab before removing it. 2021-01-26 13:10:45 -05:00
Christian Sadilek
87d6f32374 Refactor HomeFragment to use browser store 2021-01-26 10:08:02 +01:00
Mozilla L10n Automation Bot
009bb89003 Import l10n. 2021-01-26 00:27:53 +00:00
Elise Richards
39f79778a2
For #17084: Use in-app browser switching dialog (#17628) 
Co-authored-by: hakkikaancaliskan <caliskanhkaan@gmail.com>
 2021-01-25 16:16:24 -06:00
Elise Richards
f7b7b25213
For #16485: Tabs tray grid view telemetry (#17442) 
* Tabs tray CFR telemetry interactions

* Create CFR events and implementation

* Tests for tab tray controller
 2021-01-25 15:25:56 -06:00
Sebastian Kaspari
023ddcc131 Refactor ExternalAppBrowserActivity and ExternalAppBrowserFragment to not use Session(Manager). 2021-01-25 13:13:26 -05:00
Arturo Mejia
b419ff82af Remove external download manager FeatureFlags 2021-01-25 13:00:22 -05:00
Arturo Mejia
f99c175ceb Remove autoplay indicator FeatureFlags 2021-01-25 12:04:06 -05:00
Oana Horvath
46487105d5 For #16615 & #11191: re-enabled ReaderViewTest and added a UI smoke test 2021-01-25 16:16:43 +02:00
Mozilla L10n Automation Bot
c21b41c1b2 Import l10n. 2021-01-25 00:30:42 +00:00
Mozilla L10n Automation Bot
48419633be Import l10n. 2021-01-24 00:26:08 +00:00
Mozilla L10n Automation Bot
ea7e8e4581 Import l10n. 2021-01-23 00:34:07 +00:00
Jonathan Almeida
65c69c6b9f Fix breaking APIs in ActivityResultHandler 2021-01-22 16:45:35 -05:00
Christian Sadilek
7001fa1735 Closes #17473: Intermittent failues of PwaOnboardingObserver 2021-01-22 16:44:36 -05:00
Gabriel Luong
70dc975299
For #17304 - Implement top site search engine attribution (#17580) 2021-01-22 14:23:46 -05:00
Sebastian Kaspari
0c41316c31 Revert "For #17044: Explicitly set a new default engine when default is deleted." 
This reverts commit 633bf384e2.
 2021-01-22 20:10:03 +01:00
Oana Horvath
d202daf47e For #16615: UI smoke test mainMenuInstallPWATest 2021-01-22 10:25:03 +02:00
Mozilla L10n Automation Bot
5f1b177bd7 Import l10n. 2021-01-22 00:28:04 +00:00
Michael Comella
d711874285 Closes #17451: remove verbose logs with proguard. 2021-01-21 18:31:25 -05:00
ekager
083fe26f57 For #17542 - Removes flash on renaming top site and fixes title not being updated 2021-01-21 16:10:04 -07:00
William Durand
0537594810 Add new BuildConfig variables to support AMO non-production envs 2021-01-21 17:42:55 -05:00
fevziomurtekin
ddd49170d6 For issue: #16394 Fix UI for consider increasing some elements from ETP-Exceptions page 2021-01-21 16:59:42 -05:00
Jonathan Almeida
d32b3015c4 Use a smaller request code for WebAuthnFeature 
We can't see the private API that we interact with on the OS, but after
some internal investigation it appears that there might be an upper
limit to the request code we can use.

For now, let's try a value similar to that use in the GVE code to see
our requests are failing because of that.
 2021-01-21 11:37:18 -05:00
Christian Sadilek
c34d68d915 Closes #17548: Remove SessionManager reference from TabTrayDialogFragment 2021-01-21 11:12:16 -05:00
Christian Sadilek
0de948e8ae Issue #17548: Remove SessionManager reference from TabHistoryDialog 2021-01-21 11:12:16 -05:00
Christian Sadilek
7358a313bf Issue #17548: Remove SessionManager reference from FenixTabsAdapter 2021-01-21 11:12:16 -05:00
Oana Horvath
7c56df41df For #17309, #13447, #14534 UI tests: changed the way page Url is verified 2021-01-21 10:07:13 +02:00
Codrut Topliceanu
928ad21c51
For #17481 - Remove unused long_press_tapped metric (#17544) 2021-01-21 10:02:26 +02:00
Mozilla L10n Automation Bot
9f5838ecda Import l10n. 2021-01-21 00:31:24 +00:00
AndiAJ
c8c19077ed For #16615: UI Smoke Tests for No history in PB and Add to home screen 2021-01-20 18:08:43 +02:00
mcarare
633bf384e2 For #17044: Explicitly set a new default engine when default is deleted. 2021-01-20 17:33:35 +02:00
Codrut Topliceanu
20f2135578
For #17377 - Fix for empty awesomeBar on searchFragment open (#17435) 
The awesomeBar was set to stay hidden for the first consumeFrom(store) if the SearchDialogFragment.kt. However, recent changes send an additional store update when the view is created. To work around it we can take a look at AwesomeBarView.update(), we see that the awesomeBar suggestions get provided only if the query != url. So we can use the same method to keep the awesomeBar hidden until the user changes anything in the url.
 2021-01-20 14:18:59 +02:00
Mozilla L10n Automation Bot
959dcd2854 Import l10n. 2021-01-20 00:36:23 +00:00
Kate Glazko
ae528e5ab2 For #15181: Remove All Downloads From Settings 2021-01-19 14:21:44 -08:00
Christian Sadilek
54da078bd3 Refactor QuickSettingsDialog to use browser store 2021-01-19 17:19:51 -05:00
Arturo Mejia
570383a54d Add dot notification for autoplay blocked content 2021-01-19 15:04:58 -05:00
mcarare
af1af358a3 For #14011: Remove new line character and spaces from string. 2021-01-19 15:41:10 +02:00
Jonathan Almeida
6dfd7ef757 Add experimental WebAuthn support for Nightly only 
When testing out WebAuthn support with the privileged API,
we need our app to be signed by an allowed signing key.

We're seeing our tests fail with this error when testing locally:

```
  [FidoApiImpl] updateTransaction is called for stop
  [FidoApiImpl] finishSecurityKeyRequestController should not be called when SecurityKeyRequestController is null.
```

Our theory is that if we try this code on our signed APK, we should see
it work.
 2021-01-19 07:54:58 -05:00
AndiAJ
f8ea4c5ca1 For #16615: UI Smoke Tests for Tabs Tray 2021-01-19 11:38:18 +02:00
Christian Sadilek
d8c5f8887a Refactor OpenSpecificTabIntentProcessor to use browser store 2021-01-18 17:54:47 -05:00
Christian Sadilek
be9b478906 Remove SessionManager from TrackingProtectionPanelDialogFragment 2021-01-18 15:55:42 -05:00
Christian Sadilek
f96fdc34eb Refactor CrashReporterFragment to use browser store 2021-01-18 15:33:57 -05:00
Christian Sadilek
810200f2ab Switch to use case when selecting tab for extensions 2021-01-18 15:12:34 -05:00
Christian Sadilek
c03e6377ae Remove unused NotificationsIntentProcessor 2021-01-18 15:12:34 -05:00
Christian Sadilek
eb4beb252f Remove unused SessionManager reference from RecentlyClosedController 2021-01-18 15:12:34 -05:00
Jonathan Almeida
d3dcf69064 A-C 71.0.20210118134928: Fix breaking API in TabCounterToolbarButton 2021-01-18 13:03:21 -05:00
Sebastian Kaspari
fb64c7c076 SearchDialogController: Pass tab ID instead of Session instance. 2021-01-18 12:57:40 -05:00
MickeyMoz
d945cdc4c8 Update Android Components version to 71.0.20210117143132. 2021-01-18 13:56:48 +01:00
AndiAJ
eb910ff5e8 For #16615: UI Smoke Tests for Bookmarks 
For #16615: UI Smoke Tests for Bookmarks
 2021-01-18 14:55:05 +02:00
Oana Horvath
58cefbbb94 For #16615: Collections UI smoke tests 2021-01-18 10:08:43 +02:00
Michael Comella
093470a8b3 For #17447: add intentional delay to cold start up in debug and nightly. 
I validated:
- that the log statement appeared in Nightly but not in Beta.
- that the local runtimes of our perftest increased (the median diff is 124ms)
 2021-01-17 18:38:12 -08:00
Arturo Mejia
b9bdc288cb For issue: #16846 Add ui for controlling exceptions for auto play 2021-01-15 15:51:31 -05:00
Sebastian Kaspari
0035417616 Add unit tests for FennecWebAppIntentProcessor. 2021-01-15 14:35:16 -05:00
Mugurell
d8dc1c4803
For #16519: Add space above Delete History button (#17492) 
add space above Delete History button

Co-authored-by: Jocelyne Abi Haidar <jocelyne.ah1@gmail.com>
 2021-01-15 11:20:49 -05:00
Sebastian Kaspari
051988ecff Migrate some "selected tab" reads from SessionManager to BrowserStore. 2021-01-15 16:52:59 +01:00
Arturo Mejia
a6495347fd For issue #17457: Prevent page refresh when tapping the security icon 2021-01-15 10:18:59 -05:00
codrut.topliceanu
90575e6dd7 For #16238 - Back button now dismisses Suggested Logins 
By using PromptFeature's onBackPressed the user can now press back to dismiss the Suggested Logins prompt without inadvertently navigating back
 2021-01-15 10:17:05 -05:00
Mozilla L10n Automation Bot
2a19967a32 Import l10n. 2021-01-15 14:33:24 +00:00
mcarare
8fa83a7bab For #10417: Improve reload collection tab testing. 2021-01-15 15:30:48 +02:00
mcarare
edcee71287 For #17400: Select tab opened from collection. 2021-01-15 15:30:48 +02:00
mcarare
e110bb322f For #16393: Don't show divider above general category when not signed in 2021-01-15 15:28:58 +02:00
Christian Sadilek
978b555387 Closes #17443: IllegalStateException in startPostponedEnterTransition on HomeFragment 2021-01-14 12:55:00 -05:00
isabelrios
d8584ed632
Changes to run tests on beta builds (#16786) 
* Changes to run tests on beta builds

* remove dontoptime and fix bookmarks tests

* fix ktlint and smokeTest

* add variable for package name

* rebase and fix conflicts

* add yml files and modify script to run tests

* fix yml file indentation

* changes in kind file and add try_task

* fix error kind file

* fix error kind file 2

* fix error kind file 3

* fix reviewer comments

* remove mockwebserver implementation as per reviewer comment

* run beta tests only on releases branches

* reg exp for master branch

* reg exp for master branch2

* modify try_task with release branch

* remove try file

* let's start by running only one test

* address latest reviewers comments

* double check correct tasks for release branch

* remove try file after confirming beta build run

Co-authored-by: isabel rios <isabelrios@MBP-de-isabel-2.home>
 2021-01-14 15:47:36 +01:00
Christian Sadilek
53f77e422b Closes #17441: NPE when invalidating toolbar in response to reader changes 2021-01-13 16:52:52 -05:00
jhugman
7a3524fae5
SDK-158 Use disabled/no-op version of Nimbus object to eliminate unnecessary Rust call (#17372) r=christian 2021-01-13 18:26:06 +00:00
Arturo Mejia
00d971e9d3 For #16847: Allow autoplay to controlled via the toolbar. 2021-01-13 15:51:49 +01:00
Sebastian Kaspari
0761f391fc Update to latest feature-intent and feature-recentlyclosed APIs (and update Android Components). 2021-01-13 15:51:49 +01:00
Oana Horvath
7983a7fc89 For #16615: UI smoke test editCustomSearchEngineTest 2021-01-13 14:39:20 +02:00
hakkikaancaliskan
542bc89284 For #12732: Match notification accent color with app theme 2021-01-12 10:31:38 -05:00
Mihai Adrian Carare
3bb074b133
For #13522: Also remove history entries from tab history. (#17392) 
* For #13522: Also remove history entries from tab history.

* For #13522: Test that deleting history also removes it from tab history.
 2021-01-12 09:13:24 -05:00
AndiAJ
fc964862e0 For #16615: UI Smoke Tests for Recently Closed Tabs 2021-01-12 14:38:09 +02:00
Mozilla L10n Automation Bot
837eaa3282 Import l10n. 2021-01-12 00:25:09 +00:00
Oana Horvath
7ac4af46bc For #10798 & #14526: Apply auto-download test file fix for download UI tests 2021-01-11 18:42:11 +02:00
Oana Horvath
23789c86c4 For #16615: UI smoke test manageDownloadsInDownloadsMenuTest 2021-01-11 18:42:11 +02:00
mcarare
4e736625bd For #8716: Authentication custom tab now considers browsing mode. 2021-01-11 17:28:10 +02:00
Mozilla L10n Automation Bot
6a84eed552 Import l10n. 2021-01-11 12:43:17 +00:00
Mozilla L10n Automation Bot
7fc0ef5379 Import l10n. 2021-01-10 00:27:09 +00:00
Christian Sadilek
cef56bef17 Update Android Components version to 71.0.20210108190105 2021-01-08 16:10:23 -05:00
Suraj Shah
15f3743ca0
For #16271 - Fixes ripple being cut-off in Saved logins sort toolbar (#16741) 2021-01-08 13:06:15 -05:00
Mugurell
484f167714 For #16249 - ClipboardHandler cleans up returned text 2021-01-08 11:14:56 +02:00
mcarare
d110464a91 For #17117: Use proper custom tab session for custom tab toolbar menu. 2021-01-08 09:27:02 +02:00
Mozilla L10n Automation Bot
1fbf227a61 Import l10n. 2021-01-08 00:25:50 +00:00
Arturo Mejia
0aa44c93cd Closes issue #16945 Refactor TrackingProtectionOverlay to observe session via store. 2021-01-07 17:23:13 -05:00
Christian Sadilek
9a53054b28 Use new RestoreUseCase in A-C to handle tab timeouts 2021-01-07 15:50:54 -05:00
Mozilla L10n Automation Bot
9966a85bd5 Import l10n. 2021-01-07 00:31:02 +00:00
Arturo Mejia
743ba6918f Closes issue #16944 Refactor TrackingProtectionPanelDialogFragment to observe session via store. 2021-01-06 12:36:02 -05:00
mcarare
156dee29d8 For #15464: Always dismiss search dialog on url committed. 2021-01-06 08:58:17 +02:00
Hakkı Kaan Çalışkan
e41cc5a414 For #17303: Move ext fun runIfFragmentIsAttached to utils 
move to ext
 2021-01-05 21:55:45 -08:00
Gabriel Luong
d0fc086fc4
For #16790 - Allow top sites to have an empty name when renamed (#17290) 2021-01-05 16:59:41 -05:00
Roger Yang
afa0454f2b
Closes #16603: Disable pull down when in fullscreen (#17314) 2021-01-05 15:34:44 -05:00
Marcello Galhardo
381f22449b
Closes #17118: Fix font spacing when long pressing a URL (#17164) 2021-01-05 13:26:14 -06:00
Sebastian Kaspari
1b6cebf4d4 Switch to new SessionStorage / session restore API. 2021-01-05 17:11:57 +01:00
Oana Horvath
d7a35ed6bd For #16966: Remove unnecessary step from mainMenuAddToHomeScreenTest 2021-01-05 10:31:59 +02:00
ekager
d5f625c945 For #17177 - Do not show PBM CFR if entering search on home, make sure fragment attached before showing 2021-01-04 20:23:43 -08:00
Mozilla L10n Automation Bot
f95547c271 Import l10n. 2021-01-05 00:29:50 +00:00
Roger Yang
7527851cf0
Closes #17298: Turn on new MediaSession feature for all builds (#17302) 2021-01-04 15:12:43 -05:00
Marcello Galhardo
e3a77cb750
Closes #14009: Fix onboarding 'Sign in to Firefox' ripple effect (#17169) 
* Closes #14009: Fix onboarding 'Sign in to Firefox' ripple effect

* For #14009: Add 'onboarding_padded_background_color' instead of rely on OS theme/color

Both previous solution, '?android:attr/colorControlHighlight' and '@color/ripple_material_light' were using a OS theme attr or color, which caused problems. To fix it, we introduced a 'onboarding_padded_background_color' which manually define the ripple effect color of the onboarding manual sign in button.
 2021-01-04 11:55:47 -05:00
MarcLeclair
24bce64e0b
16373 Count the # of inflations done on startup (#16778) 
* For #16373: Added performance Inflater to counter # of inflations

This class is quite straight forward. The only thing that I have to point out is the onCreateView method. It usually
calls its super if you don't override it. The problem with that is that the super.onCreateView actually uses
android.view. as a prefix for the XML element it tries to inflate. So if we have an element that isn't part
of that package, it'll crash. As I said in the code, a good example is ImageButton. Calling android.view.ImageButton
will make the app crash. The method is implemented the same way that PhoneLayoutInflater does (Another example
is the AsyncLayoutInflater)

* For #16373: Added test for PerformanceInflater

This test got quite awkward / complicated fast.  I wanted to test the  to make sure we don't break *any* of our layouts
and to do so, I decided to just retrieve all our XML in our /res/layout folder. However, this gets quite a bit outside of a unit test scope.
The point was to get every layouts and get their LayoutID through the resources using the testContext we have. It gets even weirder, since some
of the XML tags have special implementation in android. One of them is the <fragment> tag. That tag actually is inflated by the OS using the Factory2
that the Activity.java implements. In order to get around the fragment issue, we just return a basic FrameLayout since the system LayoutInflater doesn't deal
won't ever get a <fragment> tag to inflate. Another issue was the <merge> tag. In order to inflate those, you need 1) a root view and 2) attach your view to it.
In order to be able to test those layouts file, I had to create an empty FrameLayout and use it as the root view for testing. Again, I know this is beyond the spirit of a unit test but if we use this inflater, I think it should make sure that no layouts are broken by it.

* For #16373: Overrode getSystemService to return PerformanceInflater

This allows PerformanceInflater to be called in every inflation to keep track of the number of inflations we do.

* For #16373: Added UI test for # of inflations

* For #16373: Lint fix

* For #167373: Changed the LayoutInflater cloneInContext to take this instead of inflater

The inflater parameter is set on the first call from the OS from  the Window object. However, the activity itself sets multiple factories on the inflater
during its creation (usually through AppCompatDelegateImpl.java). This means that, once we initially set the inflater with a null check, we pass an inflater
that has no factory initially. However, since we keep a reference to it, when cloneInContext was called, it cloned the inflater with the original inflater
which didn't have any factories set up. This meant that the app would crash on either browserFragment creation or any thing that required appCompat (such as
ImageView and ImageButton). Now, passing itself with a cloneInContext means we keep all the factories initially set by the activity or the fragment.

* For #16373: Fixed code issues for PR. No behavior change

* For #16373: fixed some code nits
 2021-01-04 11:00:34 -05:00
mcarare
251d652833 For #16027: Allow elements to be selected separately by a11y services. 2021-01-04 17:50:26 +02:00
Gabriel Luong
487ba32441
For #17292 - Remove unused static_strings (#17293) 2021-01-04 10:36:25 -05:00
mcarare
2d1df018ff For #15061: Fix error text color in SyncedTabsFragment. 2021-01-04 16:42:30 +02:00
Codrut Topliceanu
c0f0c401f3
For #11580 - Tracks text selection context menu usage (#16968) 
* For #11580 - Tracks text selection context menu usage

Tracks Copy, Search, Select All and Share items from the text selection context menu. Uses AC's DefaultSelectionActionDelegate to achieve this.

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2021-01-04 16:28:01 +02:00
Marcello Galhardo
b34cc24f88
For #9778 - Site permission settings item height set to 48dp (#17134) 2021-01-04 08:55:08 -05:00
Mozilla L10n Automation Bot
9c776f1d7f Import l10n. 2021-01-02 00:28:19 +00:00
Mozilla L10n Automation Bot
bad65b5017 Import l10n. 2021-01-01 00:29:19 +00:00
Mozilla L10n Automation Bot
f8f677ce7f Import l10n. 2020-12-30 00:34:22 +00:00
Mozilla L10n Automation Bot
96be55067d Import l10n. 2020-12-29 00:32:57 +00:00
Mozilla L10n Automation Bot
16ab8bf1ab Import l10n. 2020-12-28 00:25:24 +00:00