ishan/fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
5,394 Commits 34 Branches 356 Tags 125 MiB
2fb7383684
Commit Graph

1788 Commits

Author SHA1 Message Date
Kainalu Hagiwara
bef98698cb For #12904 - Conditionally inflate SwipeGestureLayout in BaseBrowserFragment. 
Changing the root view of BaseBrowserFragment from a CoordinatorLayout
to a SwipeGestureLayout has caused some regressions, particularly in
snackbar behavior. Lets prevent those regressions from occuring in
builds where the feature flag for gestures is off by only adding the
SwipeGestureLayout when the feature flag is on.
 2020-07-28 14:54:18 -07:00
Leonardo Murça
0c8c87e56d For #12755 - Replace @+id by @id when referencing already declared ids 
When referencing an Android resource ID, you do not need the
plus-symbol if you declared before.
Caution: make sure that the resource you are referring to
is defined EARLIER and not LATER.
 2020-07-28 14:46:09 -07:00
amkcpu
af020d0af1 For #12706 - Add vertical scrollbar to bookmarks screen 2020-07-28 16:47:18 -04:00
amkcpu
791eac50f3 For #12704 - Add vertical scrollbar to history screen 2020-07-28 16:47:09 -04:00
amkcpu
210f1ab898 For #12707 - Add vertical scrollbar to search suggestions 2020-07-28 16:46:51 -04:00
Jonathan Almeida
239e3de5e9 For #12856: Add save to collections button to Tabs Tray 
Using the ConcatAdapter, we're now able to insert multiple data sources
of information into one RecyclerView and preserve layout/scrolling in
addition to adding the 'Save to Collection' button.
 2020-07-28 11:14:08 -07:00
Hakkı Kaan Çalışkan
12e68ac18d For #12622: Visually indicate different types of suggestions in the search screen 2020-07-28 11:08:35 -07:00
Mozilla L10n Automation Bot
33db252797 Import l10n. 2020-07-27 21:05:00 -04:00
ekager
0657bf41d3 For #12991 - Set height to recommended touch target size for collect button 2020-07-27 20:17:48 -04:00
Elise Richards
b7325a3833
For #12571: Rename shortcuts to search engine on search screen (#12839) 
* Rename shortcuts to search engine on search screen

* Remove deprecated pref key

* Re-add deprecated string
 2020-07-27 17:19:31 -05:00
Tiger Oakes
57ac6fc36d Extract navigation subgraphs 2020-07-27 15:04:28 -04:00
Mihai Eduard Badea
b1e7e60665 For issue #12181 - Convert String to sentence case 
Changed the string values capitalization to sentence case.
 2020-07-27 12:31:13 -04:00
Mihai Branescu
1cbc4eec52 For #7716 - modified xml to let 'Learn more' button have min 48dp for a11y 
Added a margin top of 20dp as well on the buttons so as not to change UI
 2020-07-27 10:16:31 +03:00
Hakkı Kaan Çalışkan
b3b7566fcf For #12804: Set min height for search engine radio button 2020-07-24 22:10:24 -04:00
ekager
46511d6f8e For #10163 - Adds tab multiselect mode 2020-07-24 18:18:26 -04:00
Jonathan Almeida
d15b8381a6 For #10925: Fix breaking APIs in tabs tray 2020-07-24 16:52:06 -04:00
Mozilla L10n Automation Bot
7f829e1752 Import l10n. 2020-07-23 10:40:10 +03:00
Kainalu Hagiwara
58ccc64386 Fix UI tests. 
We need to pass a CoordinatorLayout instead of a SwipeGestureLayout to
FenixSnackbar.make() in BaseBrowserFragment to prevent UI tests from
breaking. We also need to remove a few view IDs from the tab preview.
 2020-07-22 11:26:15 -07:00
Kainalu Hagiwara
e7dc5580b2 For #3481 - Implement swipe on toolbar to switch tabs. 2020-07-22 11:26:15 -07:00
Mozilla L10n Automation Bot
9a2da5bb0f Import l10n. 2020-07-22 11:25:16 -07:00
Kainalu Hagiwara
921b16233b For #1048 - Add ability to view tab history by long-pressing the back or forward button. 2020-07-22 11:20:47 -07:00
Hakkı Kaan Çalışkan
2a0a11f740 For #12571: Rename 'Shortcuts' to 'Search engines' 
Co-Authored-By: Khushraj Rathod <khushrajrathod@gmail.com>
 2020-07-22 11:05:04 -07:00
Jonathan Almeida
99354174a9 For #12797: Use measured height/width for loading a thumbnail 
Using `onNextLayout` has the side-effect of showing the thumbnail with
the tab.id from a recycled view.

The root cause of needing that call is to retrieve the measured
height/width from the view first before requesting. A simpler solution
to avoid the complexity is to retrieve these values from the dimen
resources.

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2020-07-21 16:38:49 -04:00
mcarare
8826f99ef7 For #9722: Refactor onboarding buttons with text. 
Add title and description to button text, remove extra Textviews.
 2020-07-21 10:28:45 -07:00
mcarare
9a7154e95e For android-l10n #241: Mark a11y link type as not translatable. 2020-07-21 17:59:17 +03:00
mozilla-l10n-automation-bot
80b3b2dd82
Import l10n. (#12766) 2020-07-20 18:26:00 -07:00
Sawyer Blatz
284ec7b58f For #12461: Add tab count to tab tray 2020-07-20 19:16:47 -04:00
Tiger Oakes
f73411b924
For #5499 - Unify CFR drawables and dimens (#12749) 2020-07-20 16:00:57 -07:00
Hakkı Kaan Çalışkan
aeabd3e91b
For #12532: Quick fix for radio button alignment (#12691) 2020-07-20 15:33:32 -07:00
Kainalu Hagiwara
cd2532349d For #12551 - Implement swipe to delete for bookmarks. 2020-07-20 14:54:20 -07:00
Kainalu Hagiwara
313e5abf6a Rename tab_tray_background.xml 2020-07-20 14:54:20 -07:00
Kainalu Hagiwara
1121d844e6 For #12730 - Fix ripple for font size setting. 2020-07-20 13:00:59 -07:00
mozilla-l10n-automation-bot
c66480d6dd
Import l10n. (#12687) 2020-07-19 21:30:11 -07:00
Tiger Oakes
499f185fc0
Fix lint issues (#12683) 2020-07-17 16:20:08 -07:00
Elise Richards
37af9df3ad
For #12532: Align Settings -> Site permissions -> Sub-pages to 72dp keyline (#12680) 
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
 2020-07-17 15:54:57 -05:00
Mihai-Eduard Badea
1823fdb66d
For issue #9949 - Bookmarks/History deletion inconsistencies (#12630) 
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.

 - Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in #8648.

Co-authored-by: Mihai Eduard Badea <mihai.badea@softvision.ro>
 2020-07-17 15:13:18 -05:00
Hakkı Kaan Çalışkan
aa7655f4d6 For #12509: Set height of remove add on button to 36dp 2020-07-17 12:55:36 -07:00
ekager
e358f95eed For #12364 - Only show PWA prompt the third time a user visits installable site 2020-07-17 12:37:03 -04:00
Kainalu Hagiwara
2fe17a6220
For #12531: Align Settings -> Private browsing to 72dp keyline (#12654) 
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
 2020-07-16 22:26:49 -07:00
Elise Richards
023a4983fa
For #10173: login duplicates and save (#11208) 
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
 2020-07-16 17:08:04 -05:00
Hakkı Kaan Çalışkan
b997fba953 No issue: Move dp's to dimens.xml 2020-07-16 13:08:55 -04:00
Hakkı Kaan Çalışkan
cdd5d206fd For #12105: Follow ux mock on Settings --> Accessibility screen 2020-07-16 10:37:20 -04:00
James Hugman
8130aaa2cc Add deep links for settings and home screens 2020-07-16 10:37:03 -04:00
ekager
9ed85510ae For #7094 - Adds save login exceptions 2020-07-14 14:47:37 -04:00
Hakkı Kaan Çalışkan
f424656575 For #12107: Follow ux mock on Settings --> Account screen 2020-07-14 12:25:21 +03:00
Mozilla L10n Automation Bot
07e01c5b86 Import l10n. 2020-07-14 11:40:19 +03:00
ekager
88af736065 For #11099 For #12189 For #7532 - Clean up bottom navigation bar colors 2020-07-13 13:46:35 -04:00
Hakkı Kaan Çalışkan
ca30fef579 For #12106: Follow ux mock on Settings --> Logins screen 2020-07-13 11:14:32 -04:00
Mozilla L10n Automation Bot
ca352c555b Import l10n. 2020-07-13 07:59:10 +03:00
ekager
0add94e353 For #11324 - Adds trash icon to swipe to delete 2020-07-10 20:16:57 -04:00
Mihai Eduard Badea
9aab1d1678 For issue #12339 - Collection delete dialog string update 
Set the collection delete dialog title text to "Delete %1$s?"
 2020-07-10 11:38:39 -04:00
Mozilla L10n Automation Bot
c3b06374a1 Import l10n. 2020-07-09 21:39:49 -04:00
ekager
ad265be672 For #11303 - Change copy login origin to open in browser 2020-07-09 18:09:41 -04:00
Emily Kager
63eb7b3e4e
For #12010: Follow ux mock on Settings --> ETP --> Info screen (#12429) 
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
 2020-07-09 09:47:09 -07:00
Mozilla L10n Automation Bot
cba27a3883 Import l10n. 2020-07-09 11:29:38 -04:00
mozilla-l10n-automation-bot
6f49e08725
Import l10n. (#12404) 2020-07-08 18:56:37 -07:00
Hakkı Kaan Çalışkan
d76d8d1881 For #11563: Set ic_close.xml to use full width and height 2020-07-08 17:21:25 -04:00
Mozilla L10n Automation Bot
bedd1d452c Import l10n. 2020-07-07 21:27:37 -04:00
amkcpu
fab64229a5 Closes #11873 - Add scrollbar in tabs tray 2020-07-07 17:50:56 -04:00
Mozilla L10n Automation Bot
f838049e97 Import l10n. 2020-07-07 11:12:02 -04:00
ValentinTimisica
e39d5b6de7 For #11763: Shows confirmation dialog when deleting last tab from collection 2020-07-06 17:06:10 -04:00
ValentinTimisica
c3acde438a For #11889: Changes collection creation confirmation snackbar strings 
Also I changed the adding tabs to collection confirmation string from
tabtray to take into account the number of tabs.
Example: 1 tab-"Tab saved!"; multiple tabs-"Tabs saved!"
 2020-07-06 17:02:02 -04:00
Hakkı Kaan Çalışkan
426a1ba57d For #12078: Follow ux mock on Settings --> Language screen 2020-07-06 15:47:42 -04:00
mcarare
9bc4f443f5 For #9775: Increase touch target of elements in add search engine screen 2020-07-06 15:47:25 -04:00
ekager
170ae1aa33 For #12263 - Adds end margin to synced tabs header 2020-07-06 15:37:53 -04:00
Hakkı Kaan Çalışkan
331090d1e6 For #12007: Fix add search engine items using wrap content for height 2020-07-06 15:37:28 -04:00
Hakkı Kaan Çalışkan
296bdc5967 For #12016: Follow ux mock on Settings --> Data Collection 2020-07-06 15:27:46 -04:00
Emily Kager
90f43bf350
For #12086: Follow ux mock on Settings --> Customize screen (#12324) 
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
 2020-07-06 12:25:54 -07:00
Mozilla L10n Automation Bot
2668a68678 Import l10n. 2020-07-06 14:06:24 -04:00
ekager
822d50192a For #12316 - Allow text wrap on buttons 2020-07-06 20:56:54 +03:00
ekager
8533d96ee2 For #11320 - Expose login autofill setting to beta dimension 2020-07-03 06:40:06 -04:00
mozilla-l10n-automation-bot
321ba02832
Import l10n. (#12175) 2020-07-02 08:29:18 -07:00
liuche
ad8e28ae02
For #12007: Follow ux mock on Settings --> Search screen (#12177) 
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
 2020-07-02 00:48:31 -07:00
Mozilla L10n Automation Bot
d17e91cc2e Import l10n. 2020-07-01 08:48:18 +03:00
Mozilla L10n Automation Bot
7b3fe9bab4 Import l10n. 2020-06-30 10:25:21 +03:00
Tiger Oakes
50c3c9a9dd
Fix ignored XML lint issues (#12094) 2020-06-29 16:36:52 -07:00
Mozilla L10n Automation Bot
f77bfdc2f2 Import l10n. 2020-06-28 20:41:02 -04:00
Mozilla L10n Automation Bot
a07f31375e Import l10n. 2020-06-28 09:59:49 -04:00
Mihai Eduard Badea
e0fa1c0db4 For issue #11835 - Update text fonts 
Updated the fonts and colors for several texts throughout the application.
 2020-06-26 23:18:52 -04:00
Tiger Oakes
ed334788e8 For #11903: Enforce private theme in custom tabs 2020-06-26 22:59:43 -04:00
Michael Comella
5ef6b49aa1
For #8795: remove redundant ConstraintLayout around BrowserToolbar. (#12014) 
This is functionally equivalent to the code before this patch but should
be slightly more performant in theory because ConstraintLayout is
expensive to inflate.

The elevation and layoutParams set dynamically appeared to have no effect
with the wrapping view but broke the view when used by itself so I had
to remove them. I also updated a few other unnecessary params.

Theoretically this may have some perf benefits but I didn't see anything
outside noise levels after I took the numbers (but I didn't try very
hard).
 2020-06-26 21:31:02 -04:00
Jonathan Almeida
f89b157c23
For #12002: Show default tab background when thumbnail not available (#12041) 2020-06-26 20:46:23 -04:00
Sawyer Blatz
8a08cb941e
For #11479: Record open tabs count in metrics ping (#12024) 2020-06-26 17:15:43 -07:00
MarcLeclair
c6415ce18f
For 11616: removed black flicker with placeholder animation (#11796) 
Increasing duration removed second "light" flicker
 2020-06-26 20:10:22 -04:00
Tiger Oakes
7287b5579f
Test settings about/advanced (#12023) 2020-06-26 15:53:30 -07:00
mozilla-l10n-automation-bot
e71e7fb9c6
Import l10n. (#12022) 2020-06-26 15:44:57 -07:00
Hakkı Kaan Çalışkan
2cbd969e34 For #11641: Update synced tabs view 2020-06-26 18:11:13 -04:00
Gabriel Luong
e6a56aec36
For #12026 - Update default top sites for new users (#12028) 2020-06-26 17:51:18 -04:00
mcarare
64947a8686 For #10285: Swap TextView for a LinkTextView to improve links a11y 2020-06-26 18:11:11 +03:00
mcarare
0626384baf For #10285: Swap TextView for a LinkTextView to improve a11y. 2020-06-26 09:15:44 +03:00
mcarare
216da0c64b For #10285: Add a custom TextView for links with a11y improvements. 2020-06-26 09:15:44 +03:00
mozilla-l10n-automation-bot
ebd9efc769
Import l10n. (#11981) 2020-06-25 18:03:19 -07:00
person808
ad90625b48 For #2165 - Add swipe to refresh gesture to bookmarks view. 2020-06-25 14:50:24 -07:00
David Walsh
77ed670558 For #11860 - Conditionally show add to collection button on Home screen 2020-06-24 21:41:19 -04:00
mcarare
7b20bb9976 For #11562: Align overflow menu button with close buttons. 2020-06-24 21:40:57 -04:00
mcarare
4aaa54c994 For #11880: Provide default text color for errors in a TextInputLayout 2020-06-24 21:40:10 -04:00
Mihai Branescu
632b64971f For #10467 - removed unused tests and resources related to blue dot notification 2020-06-24 21:33:32 -04:00
Jeff Boek
2c39d3ebca For #11430 - Gives enough padding to the tab tray give adequate space for the fab 2020-06-24 21:16:24 -04:00
Mozilla L10n Automation Bot
fe023e1a74 Import l10n. 2020-06-24 21:16:07 -04:00
Tiger Oakes
183ba1bce0 For #11903: fix custom tab private gradient 2020-06-24 20:33:16 -04:00
Tiger Oakes
ce31a620d5 Minify XML path 2020-06-24 14:05:44 -04:00
mozilla-l10n-automation-bot
673507d9b3
Import l10n. (#11870) 2020-06-23 19:02:50 -07:00
Jeff Boek
1cc259169d For #11042 - Make it slightly harder to accidently dismiss the tabs tray 2020-06-23 08:19:00 -07:00
Jeff Boek
2861421312 For #11112 - Adds save tabs to collection button to the no collections message 2020-06-23 08:17:55 -07:00
Mozilla L10n Automation Bot
dc36c9a6b5 Import l10n. 2020-06-22 22:08:59 -04:00
ekager
761d253f59 For #8649 - Fixes overlapping bookmark sign in button 2020-06-22 18:19:47 -04:00
Hakkı Kaan Çalışkan
c8d36ddc36 For #8649: No bookmarks here strings are close to the top 2020-06-22 16:04:20 -04:00
mcarare
00862708ae For #10551: Increase touch target for link. 2020-06-22 13:58:02 -04:00
ValentinTimisica
c75ab3f720
For #10462: Removes back button from bookmarks and history fragments (#11721) 2020-06-22 13:15:33 -04:00
ValentinTimisica
0b57f5e71b Fixes #10551: Removes the increased touch target for learn more link 2020-06-22 16:40:15 +03:00
ValentinTimisica
e9bb11e22d Fixes #9205: Changes add-ons and 'Open links in apps' icons from menus 2020-06-22 12:09:19 +03:00
Mozilla L10n Automation Bot
b635af8244 Import l10n. 2020-06-21 21:40:24 -04:00
Sachin
988513aa89
for #10568 moved awesomebar and toolbar into fragment_search (#11744) 2020-06-21 14:56:49 -07:00
Mozilla L10n Automation Bot
56ff4e4797 Import l10n. 2020-06-20 08:57:51 +03:00
ValentinTimisica
3ad7795a2d Fixes #11134: Removes margin to allow collection title to expand 2020-06-19 17:27:57 +03:00
mcarare
4bebc56c50 For #9229: Remember options for delete browsing data. 2020-06-19 09:32:37 +03:00
mcarare
e7bc266578 For #11665: Adjust visual design for delete browsing data screens. 2020-06-19 09:32:37 +03:00
mozilla-l10n-automation-bot
99f1f6732a
Import l10n. (#11752) 2020-06-18 19:49:18 -07:00
Emily Kager
44ff29bdc0 Revert "For issue #9949 - Bookmarks/History deletion inconsistencies" 
This reverts commit 3feab90b19.
 2020-06-18 19:31:49 -04:00
Mozilla L10n Automation Bot
d009b106dc Import l10n. 2020-06-18 11:18:34 +03:00
Mihai Eduard Badea
0ce4aa1e60 For issue #10764 - Onboarding toggle color 
- Removed the theme from the toggle so that the default colors from the themes are used instead
 2020-06-18 10:16:36 +03:00
MarcLeclair
5f7bb68a51
For #11666: TopSites layout from Constraint to Linear (#11669) 2020-06-17 19:18:14 -04:00
Hakkı Kaan Çalışkan
56b00d0625 For #11456: AddonDetailsFragment should use ConstraintLayout, not RelativeLayout 2020-06-17 15:51:29 -04:00
David Walsh
3feab90b19 For issue #9949 - Bookmarks/History deletion inconsistencies 
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.

 - Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in #8648.
 2020-06-17 14:42:51 -04:00
Mugurell
fb505ed0d4 For #1871 - BrowserMenu minWidth will be 112dp. 
Following user requests and UX recommendations we'll have all menus have a
dynamic width between 112dp and 314dp, automatically wrapping the widest
element.
 2020-06-17 12:17:59 +03:00
Mozilla L10n Automation Bot
7e3795242c Import l10n. 2020-06-17 11:10:19 +03:00
Kainalu Hagiwara
291a29b334
For #11651 - Fix top site favicon size and dark theme border color. (#11652) 2020-06-16 14:10:15 -07:00
ekager
37ccc52d35 For #11558 - Fix double click required for tabs tray 2020-06-16 15:59:38 -04:00
Sören Hentzschel
396cd61efa For #9712 - show "AC: " before AC version on "About" screen 2020-06-16 15:29:00 -04:00
Mozilla L10n Automation Bot
6b4c46fdfb Import l10n. 2020-06-16 10:58:13 +03:00
Mozilla L10n Automation Bot
af64d93832 Import l10n. 2020-06-15 09:53:06 +03:00
Jonathan Almeida
e6da2bd910 Fix breaking APIs in TabsAdapter and ViewHolder 2020-06-13 16:02:31 -04:00
David Walsh
149efc1683
For 9640 - Focus on last selected tab in tab tray with a11y turned on (#11487) 2020-06-12 18:15:13 -05:00
David Walsh
8b24cdec42
For 11428 - Focus on home screen address bar when tab tray new tab is tapped (#11429) 2020-06-12 17:55:07 -05:00
David Walsh
063cf457ba
For #11291 - Provide New Tab button when accessibility enabled (#11441) 2020-06-12 17:52:06 -05:00
liuche
35fa445165
Issue #11112 - Update empty collections string + tests. (#11538) 2020-06-12 18:01:38 -04:00
ekager
e71ed31ed9 For #11498 #11499 - preland new synced tabs strings 2020-06-12 16:04:19 -04:00
Sawyer Blatz
0a9afbed42 For #11380: Update migration tip text 2020-06-12 15:17:53 -04:00
Gabriel Luong
a2f087b816 For #8312 - Land strings for limiting how many top sites you can add 2020-06-12 15:15:34 -04:00
Elise Richards
68017e5a00 Edit saved login duplicate error. 2020-06-12 12:12:37 -04:00
person808
a937bae2e9 Followup for #11081 - Fix top site colors for light theme. 2020-06-12 12:10:36 -04:00
mcarare
eb3e4fc415 For #11504: Rectify action bar button descriptions in bookmarks screen. 2020-06-12 09:33:20 -04:00
mcarare
724ca2fca9 For #10281: Reduce logo margin to compensate top site padding increase. 2020-06-12 09:31:23 -04:00
mcarare
852720f8c6 For #10281: Change margin with padding to allow flexbox to stretch. 2020-06-12 09:31:23 -04:00
mozilla-l10n-automation-bot
0c514f5f1c
Import l10n. (#11495) 2020-06-11 17:30:11 -07:00
Jeff Boek
1639b1d3a1 For #11342 - Fixes missing space for the FAB 2020-06-11 18:25:57 -04:00
person808
d14b39a56e For #2165 - Implement pull-to-refresh gesture to sync history. 2020-06-11 10:23:27 -07:00
Mugurell
f163861b47 For #11177 - Load all share targets in the horizontal share menu 
This was previously regressed by having the RecyclerViews for "recent" and
"all" items put inside a HorizontalScrollView which would then prevent the
RecyclerViews from actually scrolling, recycling, showing new items.

As a quick solution that would keep the desired behavior the "all" items list
is now a child of a RelativeLayout which will allow it to load all items at
once and so all the share targets will be available to the user but which also
means no recycling.

The RecyclerView for the "recent" items uses a `RECENT_APPS_LIMIT = 6` so this
does not need the same "fix" as all the items would fit the screen without
any issue.
 2020-06-11 15:08:36 +03:00
person808
3ff20c0b25 For #11081 - Add dark theme colors for top sites. 2020-06-10 19:42:34 -07:00
Mozilla L10n Automation Bot
53e984ec7a Import l10n. 2020-06-10 21:20:10 -04:00
Jeff Boek
cd3b6181b3 For #10374 - Adds quick contextual menu to tab switcher 
Co-authored-by: person808 <kainaluh808@gmail.com>
 2020-06-10 16:50:28 -07:00
Elise Richards
137d66a511
For 10172: Set edit text listeners (#11196) 
* Set edit text listeners

* Set clearable icons and change with error states

* Clear text buttons show and hide

* Move error checks to afterTextChanged. Refactor. Remove unused color.
 2020-06-10 16:52:47 -05:00
Christian Sadilek
d16c70d8be Wire up UI to make add-on installation cancelable 2020-06-10 18:52:06 +03:00
ValentinTimisica
bc53296603 For #11365: Reorganizes 'SettingsFragment' items 
Moved all the functionality form 'DefaultBrowserSettingsFragment' to
'SettingsFragment'.
 2020-06-10 11:09:03 +03:00
David Walsh
1356b3e426 For 11271 - Provide useful tab counter message for accessibility 2020-06-09 22:37:46 -04:00
ValentinTimisica
3a28704fa6 For #11132: Replaces wrong icons from menus 2020-06-09 22:19:43 -04:00
Mozilla L10n Automation Bot
2c418de0a3 Import l10n. 2020-06-09 17:30:35 -07:00
ValentinTimisica
32bfba5b36 For #11201: Updates 'synced tabs' and account settings 'tabs' strings 2020-06-09 18:05:51 -04:00
Jeff Boek
d8ef0722e3 For #11175 - Moves tab tray strings to be translated, fixes description of the fab string 2020-06-09 13:06:02 -04:00
ekager
29e1a9c670 For #7911 - Updates ETP shield assets with new size 2020-06-09 11:57:40 -04:00
Mozilla L10n Automation Bot
5373a75f57 For #10502 - Show snackbar after adding tabs to collection from tab tray 2020-06-09 08:29:06 -07:00
Mozilla L10n Automation Bot
eebc1f936a Import l10n. 2020-06-08 22:43:25 -04:00
Sawyer Blatz
e9189dc089 For #11045: Add reader mode to urlView 2020-06-08 15:12:03 -07:00
Tiger Oakes
1a19b06227
Simplify PhoneFeature code (#10810) 2020-06-08 13:02:42 -07:00
Mozilla L10n Automation Bot
04a436d30e Import l10n. 2020-06-07 20:44:39 -04:00
Mozilla L10n Automation Bot
01ade6e62a Import l10n. 2020-06-07 12:57:03 -04:00
Mozilla L10n Automation Bot
e28f9d49d1 Import l10n. 2020-06-05 21:03:20 -04:00
David Walsh
d33080571b
For #11267 - Announce "Your open tabs will be shown here (#11272) 2020-06-05 17:27:45 -05:00
mcarare
c8b40fa617 For #11246: Align text to viewStart to support RTL layouts. 2020-06-05 14:29:00 -04:00
person808
d66ccb8631 For #11277 - Set textAlignment to viewStart to fix RTL layout in empty ETP exceptions screen. 2020-06-05 14:27:54 -04:00
person808
a57d76eb4f For #6180 - Set textAlignment to viewStart to fix RTL layouts. 2020-06-05 14:27:26 -04:00
mcarare
512aa46224 For #11229: Update ETP cfr string and behaviour. 2020-06-05 14:18:25 -04:00
mcarare
91c27a023e For #11229: Update settings ETP copy. 2020-06-05 14:18:25 -04:00
mcarare
a0d9189321 For #11229: Update onboarding ETP copy. 2020-06-05 14:18:25 -04:00
Jeff Boek
52c2fdb310
Remove tab tray feature flag (#11176) 
* For #11171 - Removes feature flag for the new tab tray

* For #11171 - Removes all tab references from homeFragment

* For #11171 - Fixes unit tests

* For #11171 - Gets UI tests to compile and HomeScreenTest to pass

* For #11171 - Fixes `deleteMultipleSelectionTest`

* For #11171 - Fixes `openHistoryItemInNewPrivateTabTest`

* For #11171 - Fixes `openHistoryInPrivateTabTest`

* For #11171 - Fixes `openHistoryInNewTabTest`

* For #11171 - Fixes `openNewPrivateTabTest`

* For #11171 - Fixes tabbedBrowsingTests

* For #11171 - Fixes SettingsPrivacyTest

* For #11171 - Fixes TopSitesTest

* For #11171 - Fixes lint errors

* Ignore
 2020-06-05 12:59:08 -05:00
mcarare
741fa799ad For #7752, #7753: Adjust touch targets for elements in crash reporter. 2020-06-05 12:04:58 +03:00
mcarare
f47c80d10b No issue: Fix xml indentations. 2020-06-05 12:04:58 +03:00
mcarare
2d24369362 For #7725: Increase info button touch target while keeping size. 
Also removed unnecessary touch delegate.
 2020-06-05 11:57:17 +03:00
mcarare
8f3274eba9 For #9590: Increase widget elements touch target while keeping size. 2020-06-05 11:49:35 +03:00
person808
8c47b988b8 For #10525 - Remove tab tray item dividers. 2020-06-04 23:17:16 -07:00
ekager
094f3d0c97 Closes #10629 - Update Content Description of Edit Login Menu Item 2020-06-05 08:12:43 +03:00
Mozilla L10n Automation Bot
06d9133cb9 Import l10n. 2020-06-04 20:59:50 -04:00
mcarare
886c1882c5 For #11230: Set default to false for allow screenshots in private setting 2020-06-04 18:24:26 -04:00
Dennis Schubert
d046d908fc Bug 1643132 - Remove native "Report site issue" functionality. 
This will be replaced by the WebCompat team's system extension that ships as an android-component.
 2020-06-04 18:23:11 -04:00
Sawyer Blatz
42f58a1984 For #9488: Add experimentation support 2020-06-04 14:10:22 -07:00
Mozilla L10n Automation Bot
cda6995ca7 Import l10n. 2020-06-03 21:37:44 -04:00
David Walsh
7013e8198b For 11114 - Correct landscape tab tray buttons 2020-06-02 23:09:05 -07:00
Jonathan Almeida
803ed6cde3 For #11154: Fix button color on migration UI 2020-06-02 18:08:45 -07:00
Mozilla L10n Automation Bot
0df27742a3 Import l10n. 2020-06-02 17:50:39 -07:00
ekager
ead3194d86 For #8759 - Allow recently used in share fragment to scroll 2020-06-02 16:46:08 -04:00
Jeff Boek
2dd0a3cb9e
Implement tab tray design improvements and fix close functionality. 2020-06-02 15:03:58 -05:00
mcarare
7d50834a90 For #11139:Constrain title to start of checkbox and ellipsize. 2020-06-02 12:08:05 -04:00
mcarare
ad829115ef For #9545: Split button to allow distinct focus for a11y services. 2020-06-02 09:33:32 -04:00
ValentinTimisica
1c367080a5 Fixes #10113: Changes login prompt editText cursor color 
This patch uses `mozacPromptLoginEditTextCursorColor` attribute defined in AC.
Check PR: https://github.com/mozilla-mobile/android-components/pull/7056
 2020-06-02 09:29:59 -04:00
mcarare
7562e06b25 For #9595: Increase search pill touch target height to container height. 
Adjust background to fit new dimensions.
 2020-06-02 09:27:23 -04:00
mcarare
c4f7a32eae For #9583: Increase touch targets for onboarding elements. 2020-06-02 09:26:38 -04:00
mcarare
713b004488 For #9805: Increase touch target for build date. 2020-06-02 09:26:07 -04:00
mcarare
0aeb89400b For #9805: Increase touch target for etp panel switch. 2020-06-02 09:25:51 -04:00
mcarare
7b6e1e1d69 For #11136:Move voice search preference above search suggestions. 2020-06-02 09:25:28 -04:00
Jeff Boek
5fe007b723 For #10577 - Adds elevation for the browser toolbar popup 2020-06-02 11:26:46 +03:00
Mozilla L10n Automation Bot
e396f35a7b Import l10n. 2020-06-02 00:26:45 -04:00
Tiger Oakes
50441e28f1 Tests and cleanup for tracking protection 2020-06-01 22:08:52 -04:00
Vishwa Patel
4da22c605a For #10834 - Adding Sync Tabs Feature in Fenix 2020-06-01 16:52:40 -04:00
Gabriel Luong
60b68a265a
For #10921 - Integrate BrowserThumbnails feature into the tabs tray (#11093) 2020-06-01 14:36:44 -04:00
Mozilla L10n Automation Bot
ef40710404 Import l10n. 2020-06-01 10:11:13 -04:00
Jeff Boek
c8e8566668 For #10848 - Fixes navigationbar colors on tab dialog fragment 2020-05-30 10:38:48 -07:00
Jeff Boek
f05890efec For #10848 - Fixes bug where selected index wouldnt be properly calculated in private mode 2020-05-30 10:38:48 -07:00
Jeff Boek
917609aa36 For #10848 - Fixes FAB color when in private mode 2020-05-30 10:38:48 -07:00
Jeff Boek
19a709a04d For #10848 - Fixes tab tray colors 2020-05-30 10:38:48 -07:00
Jeff Boek
91402f9b38 For #10848 - Fixes icon colors and missing divider 2020-05-30 10:38:48 -07:00
Jeff Boek
8b24970aaf For #10848 - Fixes 3 dot menu color in tab tray 2020-05-30 10:38:48 -07:00
David Walsh
56de4c4c65 reduce opacity of inactive non-private/private icon in light mode 2020-05-30 10:38:48 -07:00
David Walsh
b9370640a2 Update multi-task, private, 3-dot icon and hairline in light mode to ink_20 (#312A65) and in dark mode to violet_50 (#9059FF) 2020-05-30 10:38:48 -07:00
David Walsh
51ea68f4bd For 10848 - Add divider under tab headings 2020-05-30 10:38:48 -07:00
Mozilla L10n Automation Bot
2e4766dfa2 Import l10n. 2020-05-29 17:44:35 -07:00
Jeff Boek
8662164b8a
Refactors the TabTrayDialogFragment to ditch that weird interactor (#11061) 
* For #11056 - Removes unused argument when navigating to the collection creation fragment

* For #11056 - Moved the collection creation navigation logic to the TabTrayDialogFragment

* For #11056 - Moves navigating to the share screen from home/browser to the TabTrayDialogFragment

* For #11056 - We moved tab selection logic from home/browser to the tab tray dialog

* For #11056 - Moved new tab tapped logic to the tab tray dialog fragment

* For #11056 - Removes all interactor logic for the TabTrayDialogFragment

* For #11056 - Migrates the presentation / navigation around the TabTrayDialog to the androidx navigation library
 2020-05-29 17:17:56 -05:00
Jeff Boek
3946ec11de
Polish homescreen (#11065) 
* For #10505 - Adjusts wordmark margins

* For #10505 - Removes topsite header, fixes collections header size and removes divider

* For #10505 - Restyle the top site items on the homescreen
 2020-05-29 17:09:12 -05:00
ekager
20e358228e For #11015 - Switch Default ETP Setting to Standard 2020-05-29 16:39:47 -04:00
mcarare
906d72c894 For #9594: Increase touch target for snackbar action button button. 2020-05-28 19:41:28 -07:00
David Walsh
a70ba76cc9 Provided unique no tabs message per mode 2020-05-28 19:38:41 -07:00
Mozilla L10n Automation Bot
c9722c65a2 Import l10n. 2020-05-28 18:18:20 -07:00
apoorv9990
97704bfdbd Closes #9529: changed styling for permissions dialog to set proper padding 
- Changed the visibility check to check just for the permissions shown instead of all the permissions in WebsitePermissionsState
- Added bottom padding to the permissions root view so there is balanced padding on top and bottom
 2020-05-28 16:08:07 -07:00
Sawyer Blatz
b06be1fcde For #9488 Add telemetry for search widget CFR 2020-05-28 15:15:25 -07:00
Sawyer Blatz
94d741864e For #9488: Add search widget CFR 2020-05-28 15:15:25 -07:00
Jonathan Almeida
63b4fcd4c4 For #11004: Fix invisible text on migration UI 
For some text and colors, we were using the default styling where
possible. These styles contain references that react to theme changes
like dark mode. Since the migration UI does not respect these changes,
we should not use them.
 2020-05-28 15:48:42 -04:00
David Walsh
ea4c342797
For #10877 - Show 'no tabs' message when no tabs are open (#10960) 2020-05-28 10:17:55 -05:00
Mihai Eduard Badea
610409862b For issue #10725 - Truncated account details 
- Set the textview's height to "wrap_content" and added top/bottom padding to account for the size difference and maintain the original height
 2020-05-28 13:41:29 +03:00
mcarare
9ec6ebc92a For #10969: Fix and clarify logic for checking showing PWA dialog. 2020-05-28 13:18:25 +03:00
Mozilla L10n Automation Bot
aa487bf4c3 Import l10n. 2020-05-28 08:31:41 +03:00
David Walsh
424598946a For #10962 - Remove tab tray tab text labels 2020-05-27 16:40:49 -07:00
David Walsh
58a7e63105 For 10965 - Implement content description and fix border for add button 2020-05-27 16:40:26 -07:00
David Walsh
248237290e
For #10865 - Implement 3 dot menu for tab tray (#10869) 2020-05-27 13:07:03 -05:00
mcarare
a59917cdc0 For #9626: Swap margin for padding and remove use of touch delegate. 
Also remove text margin to maintain visual appearance.
 2020-05-27 08:43:43 -07:00
Mozilla L10n Automation Bot
d54dbce7ba Import l10n. 2020-05-26 18:32:04 -07:00
Mozilla L10n Automation Bot
a50aa839f3 Import l10n. 2020-05-26 08:47:03 +03:00
mcarare
6e325d6242 For #6198: Update copy and position of pair QR code scan message. 2020-05-25 17:53:20 -04:00
mcarare
44d9dc9237 For #10705: Update copy of auto font sizing preference. 2020-05-25 17:50:35 -04:00
mcarare
a62f4b2caa For #10851: Add end constraint for text view. 2020-05-25 17:49:39 -04:00
mcarare
ce46a96742 For #10706: Update copy of deleting open tabs preference. 2020-05-25 17:37:29 -04:00
Mozilla L10n Automation Bot
7c7d860293 Import l10n. 2020-05-25 09:51:40 +03:00
David Walsh
ebb562a789 For #10859 - Use dark or light mode colors for tab tray in private mode 2020-05-22 13:34:30 -07:00
Mozilla L10n Automation Bot
e21352144b Import l10n. 2020-05-22 16:48:52 +03:00
sraturi
703a8ed565 added a onTouch listener to scrollview in search fragment to make it disappear on scroll 2020-05-21 18:54:50 -07:00
Jeff Boek
601aedda46 For #10504 - Removes "old" TabTrayFragment 2020-05-21 15:17:20 -07:00
Jeff Boek
a674c5dfe7 For #10504 - cleans up tabLayout colors 2020-05-21 15:17:20 -07:00
Jeff Boek
90cef752b0 For #10504 - Fixes up tab tray dialog styles 2020-05-21 15:17:20 -07:00
Jeff Boek
dd2a26fc7c For #10504 - Added the tab tray to the TabTrayDialogFragment and wired up dismiss actions 2020-05-21 15:17:20 -07:00
Jeff Boek
34ac9df481 For 10504 - Adds dialog style and fab 2020-05-21 15:17:20 -07:00
codrut.topliceanu
7feae98944 For #9044 - Replace DownloadNotificationBottomSheetDialog with unobtrusive view 
- Renamed DownloadNotification and removed DownloadState.dismissed dependency
- Improved DynamicDownloadDialog behaviour when scrolling
- DynamicDownloadDialog remains attached to tab until dismissed
- Fixed onTryAgain not working for resumed DownloadDialogs
 2020-05-21 10:02:51 -04:00
David Walsh
346b4aa3fd
For #10321: Wire up play and pause buttons in tab tray (#10422) 2020-05-20 16:50:58 -05:00
Mozilla L10n Automation Bot
3b866d4da4 Import l10n. 2020-05-20 10:14:19 -07:00
Sawyer Blatz
011a9e7d96 For #1216: Add voice search 2020-05-19 13:04:11 -07:00
Mozilla L10n Automation Bot
fe3a67ac68 Import l10n. 2020-05-18 20:22:37 -07:00
ekager
28a6b1f9d5 For #10691 - Turn on LeakCanary by default for debug builds 2020-05-18 15:08:09 -07:00
Mozilla L10n Automation Bot
dc92ddb0e5 Import l10n. 2020-05-18 14:04:23 -07:00
Emily Kager
9b16017d1d Revert "For #7032: Add scroll to dismiss keyboard in search fragment" 
This reverts commit 536921bcea.
 2020-05-15 21:14:55 -07:00
partha2000
124b21d209 For #10632 - Update Content Description for X icon in collection 2020-05-15 10:31:05 -07:00
Sachin
536921bcea
For #7032: Add scroll to dismiss keyboard in search fragment 
* added a onTouch listener to scrollview in search fragment to make it disappear on scroll

* fixed lint issues
 2020-05-15 10:30:00 -07:00
mcarare
b244fd53ac For #10656: Adjust etp checkbox dimensions for a11y. 2020-05-15 17:39:51 +03:00
Mozilla L10n Automation Bot
a3c6492d5f Import l10n. 2020-05-14 22:11:38 -07:00
Mozilla L10n Automation Bot
62e68c579a Import l10n. 2020-05-13 18:54:28 -07:00
Vishwa Patel
06aada251d
Issue 7266 fenix remove line (#10630) 2020-05-13 10:36:58 -07:00
Mozilla L10n Automation Bot
7fc006a5a8 Import l10n. 2020-05-13 10:58:48 +03:00
Elise Richards
edc75c3ad0
Fixes #9504: Edit logins (#9693) 
* Create editable view and fragment. Update login info page to display options menu with edit and delete.

* Create feature flag for edit. Check flag in the login detail fragment and default to just delete.

* Add three-dot kebab options menu in login detail fragment. Add title to the login item.

* Nav to and from edit view on save and back pressed.

* Save login through AC login manager. Clear text in editable field on button click.

* Match colors, fonts, dimens to UX specs for edit logins. Enable password reveal/hide and clearing text fields.

* Refactoring logins fragments. Using component Login object for consistency.

Fetch login list when saved logins are opened. Fetch login details when detail view is opened.

Revert "Fetch login list when saved logins are opened. Fetch login details when detail view is opened."

This reverts commit 44fe17166c3332b330229258b2e8982832672e3b.

* Using parcelable login and Login component class to pass ids and items between fragments

* Retrieve login from storage when viewing login details.

Rename login logic for consistency.

Ktlint cleanup

Fix nits and naming consistency.

* UX consistency for login detail and edit login pages

* Rebasing with logins sort - updating logins store.

* Rebasing with logins sort - merging fragments and controllers.

* Lint and removing unused files.

* UX cleanup.

* Update string description
 2020-05-12 17:32:01 -05:00
Sebastian Kaspari
d58c022619 Integrate activity for showing past crashes. 2020-05-12 09:14:20 +02:00
mcarare
a7ff8cafc7 For #7887: Increase touch target height for learn more link. 2020-05-11 22:50:41 -07:00
mcarare
ff6447b755 No issue: Fix xml indentations. 2020-05-11 22:50:41 -07:00
Mozilla L10n Automation Bot
65f30c75e8 Import l10n. 2020-05-11 17:34:32 -07:00
Jeff Boek
a249334976
🎲 For #10332 - Adds undo snackbar when closing tabs in the tab tray (#10456) 2020-05-11 17:18:09 -05:00
ValentinTimisica
b2e5820364 For #10343: Remove 'Library' functionality from the app 
Also adds Bookmarks and History items to browser menu.
 2020-05-11 10:22:19 -07:00
Simon Chae
ca7695854a
For #10552: Set initial add-on details fragment visibility to false (#10565) 2020-05-11 12:44:18 -04:00
Mihai Branescu
dd843b4989 For #10501 - use theme instead of tint to support older APIs 2020-05-11 19:22:00 +03:00
Mozilla L10n Automation Bot
55a8bf7ff9 Import l10n. 2020-05-10 19:42:20 -07:00
Simon Chae
d58e7d3138 For #10473: Fetch the addon from addon manager instead of the store 2020-05-08 16:03:22 -07:00
codrut.topliceanu
d1005dd236 For #8589 - Fix for accessibility navigation in ETP panel 2020-05-08 09:57:59 -07:00
Mozilla L10n Automation Bot
824022c28d Import l10n. 2020-05-08 08:44:39 -07:00
ValentinTimisica
f63cb4e09f For #10244: Creates drawable for add-ons private browsing label. 
The drawable is sent to AddonsManagerAdapter.Style constructor and is displayed
near the add-on name if it is allowed to run in private browsing
 2020-05-07 17:27:46 -07:00
Sawyer Blatz
a01881067f For #8643: Updates colors of onboarding accents 2020-05-07 17:24:54 -07:00
Sawyer Blatz
5f11c5e648 For #9857: Updates onboarding button styles 2020-05-07 17:24:54 -07:00
Mihai Branescu
eef5cf3469 For #10482 - made SVG gradient compatible with API < 22 2020-05-07 10:39:58 -07:00
ValentinTimisica
24ba9f2fc8 For #9505: Adds possibility to sort saved logins 
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
 2020-05-07 08:43:59 -07:00
Mozilla L10n Automation Bot
c8d8a700fe Import l10n. 2020-05-06 18:14:28 -07:00
David Walsh
8b27a48635 For #10329 - Implement tab tray divider 2020-05-06 14:13:39 -07:00
Mihai Branescu
cde31cf785 For #8643 and #7606 - Changed toolbar picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu
16b7a9399b For #8643 and #7606 - Changed theme picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu
03726384de For #8643 and #7606 - Changed styles for most onboarding cards 2020-05-06 09:18:27 +03:00
Mihai Branescu
048d22dbcf For #8643 and #7606 - added styles and new colors 2020-05-06 09:18:27 +03:00
Mihai Branescu
18b6c29b4a For #8643 and #7606 - added new svgs for onboarding illustrations 
RTL for toolbar are still missing
 2020-05-06 09:18:27 +03:00
Mihai Branescu
fab52c9702 For #8643 - removed all onboarding-related PNGs 2020-05-06 09:18:27 +03:00
Mihai Branescu
77912b29fb For #8643 - Replaced onboarding theme/toolbar assets 2020-05-06 09:18:27 +03:00
Mozilla L10n Automation Bot
0b82f8e996 Import l10n. 2020-05-05 17:34:05 -07:00
Mihai Adrian
43d30793f5
For #9794: Announce installing state for screen readers (#10111) 2020-05-05 11:22:15 -07:00
David Walsh
5087bcf9f6
For #10395 - Improve alignment of close buttons with menu in tab tray (#10405) 2020-05-05 11:16:47 -07:00
David Walsh
249e0cd4e8
For #10159 - Tab tray bottom toolbar colors (#10326) 2020-05-05 11:16:09 -07:00
Mozilla L10n Automation Bot
d2a3613b73 Import l10n. 2020-05-05 09:11:03 +03:00
Michael Comella
2773a9e0a9 No issue: losslessly compress image assets. 
Using ImageOptim. Results: 110 KB out of 1.9 MB (5.7%).
 2020-05-04 14:54:46 -07:00
Jeff Boek
81d0db76e9
For #10395 - Fixes tab tray bar dimensions to better align with the browser toolbar (#10400) 2020-05-04 12:44:37 -05:00
Mozilla L10n Automation Bot
34f2350ada Import l10n. 2020-05-04 10:31:35 +03:00
Mozilla L10n Automation Bot
5abe3ac877 Import l10n. 2020-05-01 18:34:10 -07:00
Jeff Boek
94cd195dc7
Adds swipe to delete tab (#10355) 
* No Issue - Increases tap area of close button

* For #10331 - Adds swipe to delete to the tab tray
 2020-05-01 15:45:51 -05:00