Commit Graph

6048 Commits

Author SHA1 Message Date
Jan-Erik Rediger
2198c0f014 Don't manually exclude glean-native
The latest geckoview-omni package correctly declares its capabilities,
including the `glean-native` one.
Additionally it is able to pick geckoview-omni over glean-native in all
configurations.
2021-09-30 19:51:29 +00:00
Noah Bond
25d0696101
Inactive tabs changes (#21524)
* Issue mozilla-mobile#21319 - Moved inactive tabs to the top of the normal tabs tray.

* Issue mozilla-mobile#21319 - Added a delete icon to delete ALL inactive tabs.

* Issue mozilla-mobile#21319 - Changed default inactive time period to 14 days

* Issue mozilla-mobile#21319 - Hooked inactive tabs setting to UI code

Inactive tabs setting is also disabled when the user has selected the one day or week auto-close tab setting.

* Issue mozilla-mobile#21319 - File and Lint cleanup

* PR: Fixed bug causing grouped tabs to also show in "Other" when marked as inactive but inactive is OFF in Settings

* PR: Fixed lint warnings

* PR: Removed redundant feature check

* PR - Ignore test until search term tab groups switch is done
2021-09-30 19:01:31 +00:00
Mugurell
53d4336939 For #21592 - Don't topup with general stories 2021-09-30 15:54:21 +00:00
Mugurell
ea6d5e3d38 For #21562 - Snap to next item when scrolling
This works by replacing the fling animation with snapping to the next item in
the scroll direction.
2021-09-30 14:57:17 +00:00
Aaron Train
2bde49f911 No issue: Fix AssertionError in openThreeDotMenu
fix: ktlint
2021-09-30 14:06:13 +00:00
AndiAJ
f72ab0a4f3 For #21540 fix flaky editCustomSearchEngineTest UI test 2021-09-30 10:30:27 +00:00
Michael Comella
365983d4b0 For #21294: suppress MaxLineLength in Fact.toEvent.
These double comparisons are easier to read and see the pattern of on one line
so I'd rather keep them on one line. Additionally, it's difficult to
test each change individually so I'd rather not make additional changes.
To do this, I suppressed the max line length warning.
2021-09-30 09:13:53 +00:00
Michael Comella
c10f41164d For #21294: remove allocations in Fact.toEvent.
This commit was generated primarily by a macro that:
- appends `== component &&`
- appends `== item`
- (if applicable) Skips to the ending brace
- Go down one line and move cursor to the front of the line to prep for repeat

My only intervention was to skip extra lines to line it up to run again
and specify how many times in a row it should run.

---

The `to` in this code is an infix function that calls instantiates a
Pair under the hood. Subjectively observed, when this method is called
it generally hits the else case so 35 Pairs are instantiated each call -
that's 560 bytes. This method is called frequently - for example, an estimated
4 times each time a letter is typed on the homescreen and a measured 116 times
in a simple navigation (see the issue). The latter generates an estimated
63.4 KiB.

It was straightforward to remove these allocations so that's what this
change does.

The primary risk from this change is that it's difficult to test each
case to ensure it's working.
2021-09-30 09:13:53 +00:00
Michael Comella
d33e38e020 For #21294: change when (condition) { when { in Fact.toEvent.
This will not compile. However, it enables the subsequent PR to remove
allocations from Fact.toEvent.
2021-09-30 09:13:53 +00:00
Michael Comella
4c33b1b75c For #21294: add partial test for existing factToEvent code.
When we refactor, this will help ensure we've done it correctly.
2021-09-30 09:13:53 +00:00
codrut.topliceanu
0e88c25df1 For #20762 - Adds grey border to inactive tabs 2021-09-30 08:42:46 +00:00
Mozilla L10n Automation Bot
f8edee649a Import l10n. 2021-09-30 00:43:30 +00:00
Elise Richards
02614eb889 For #21574: Move the homescreen onboarding card behind a feature flag 2021-09-29 22:52:42 +00:00
Mugurell
e72b7f7cc8 For #21561 - Enable/Disable the feature from the customization menu 2021-09-29 19:55:26 +00:00
Mugurell
0c632dbbdb For #21391 - Final design composables
Fonts are not exactly following the Figma design but do better suit the overall
design since the other fonts are also not respecting the latest specs.
2021-09-29 19:15:07 +00:00
Andrei Joltan
d30583e0e7
For #21442 fix flaky deleteMultipleSelectionTest UI test (#21563)
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-09-29 13:45:08 -04:00
Roger Yang
ddd472d143 No issue: Improve rendering of jump back in 2021-09-29 11:43:49 -04:00
AndiAJ
37e342fd92 For #21478 fix flaky verifyOpenTopSiteNormalTab UI test 2021-09-29 15:21:34 +00:00
Oana Horvath
0ac23486c1 Fixed verifyAboutFirefoxPreview test according with new steps 2021-09-29 16:01:35 +03:00
Oana Horvath
1015072db6 Fixed disabled UI test openExternalLinksInPrivateTest 2021-09-29 16:01:35 +03:00
Roger Yang
53206df9b6 Close #21552: Remove Extra Subtitle In Jump Back In Item 2021-09-29 02:46:34 +00:00
Roger Yang
8193138015
Fix recent tabs intermittent tests (#21557)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-09-28 22:10:47 -04:00
Elise Richards
777f2d1f12
For #21339: update styles for homescreen show all buttons and jump back in spacing (#21342)
For #21339: Add ignores for intermittent ui tests

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-09-28 14:40:22 -07:00
Mugurell
c1f0e5a611 For #21275 - Sort items by how many times they were actually shown 2021-09-28 20:25:25 +00:00
Christian Sadilek
4596d4f905
Do not capture search terms when user navigates away via app (#21527)
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>

Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
2021-09-28 14:20:58 +00:00
AndiAJ
bf3b669151 Delete browsing data tests UI tests 2021-09-28 09:50:00 +00:00
AndiAJ
06292ac8d6 Fix disabled toggleSearchSuggestions UI Tets and refactoring work 2021-09-28 07:49:22 +00:00
Elise Richards
ab13ae09f2
For #21313: renewing performance awesomebar metrics (#21315) 2021-09-27 15:40:21 -07:00
Roger Yang
8a15e8a681 Close #21451: Add active search term tab groups on home 2021-09-27 21:10:57 +00:00
Arturo Mejia
f15291757b For #21493 show onboarding dialog for home sections 2021-09-27 19:22:34 +00:00
codrut.topliceanu
f338d64a4c For #20762 - Fixes NPE crash with nullchecks for binding 2021-09-27 13:32:06 -04:00
AndiAJ
10f2074749 Fix disabled shortcutButtonTest UI test 2021-09-27 11:15:28 +00:00
Mugurell
ba4c44afcf For #21045: Add categories support 2021-09-27 09:57:15 +00:00
Mugurell
ccc0f17e4f For #21045: Cleanup
- stick to one naming scheme: rename articles to stories and use this all
throughout the app.
- add some spacing above the new section (as per the current design)
2021-09-27 09:57:15 +00:00
Mozilla L10n Automation Bot
27d319bc56 Import l10n. 2021-09-27 00:38:26 +00:00
Mozilla L10n Automation Bot
009f2a97b8 Import l10n. 2021-09-26 00:30:23 +00:00
Mozilla L10n Automation Bot
8426c399ad Import l10n. 2021-09-25 00:44:49 +00:00
codrut.topliceanu
e8c332964d For #21087: Updates Recently Saved design 2021-09-24 07:42:29 +00:00
Christian Sadilek
54549c49ec Fix mapping between history visits and groups to use createdAt
We currently have a 15s buffer to match metadata to its corresponding
visit. However, a existing metadata record can be updated more than
15s after it was created e.g. when closing the tab and updating
the view time.
2021-09-23 21:15:48 +00:00
Aaron Train
1418d3f2bd Closes #21441: Fix changeAccessibiltySettings 2021-09-23 19:59:59 +00:00
Jonathan Almeida
26dc3ea47e Issue #21366: Speculative fix for failing test in TitleHeaderBindingTest 2021-09-23 18:42:53 +00:00
Christian Sadilek
d830006984 For #20893: Dedupe urls/site in history groups 2021-09-23 16:09:43 +00:00
Gabriel Luong
976dd6ebe1 For #21460 - Rename "Delete from history" to "Remove" for recent visit dropdown menu 2021-09-23 14:26:46 +00:00
Oana Horvath
43d1cb233e For #17847: adding back editCustomSearchEngineTest UI test 2021-09-23 08:58:52 +00:00
AndiAJ
d534adc932 Improve coverage verifyEmptyBookmarksMenuTest and undoDeleteMultipleSelectionTest UI tests 2021-09-23 08:04:40 +00:00
AndiAJ
3ad0ec1302 Fix for disabled saveLoginFromPromptTest 2021-09-23 07:09:15 +00:00
Mozilla L10n Automation Bot
74989db239 Import l10n. 2021-09-23 01:06:49 +00:00
Gabriel Luong
90d7927b2f Issue #21117 - Modify layout for items displayed under "Recently Visited" in the HomeScreen to follow latest UX designs 2021-09-22 21:30:45 +00:00
Arturo Mejia
c05fbfb6c3 For #21239 improve telemetry values for Allow users to customize their home screen 2021-09-22 16:28:43 +00:00
Oana Horvath
83e3e0b19d No issue: re-enabled swipeToSwitchTabTest 2021-09-22 15:59:28 +00:00