Gabriel Luong
779660f615
For #24246 - Refactor Tab from HomeFragmentStore
2022-03-14 18:59:59 +00:00
MatthewTighe
10d5bf0e66
no issue: update layer3 dark pallete color to match token
2022-03-14 18:31:56 +00:00
Alexandru2909
ef678b4d17
Fixes #24188 - Use app_name for InactiveTabAutoClose message
2022-03-14 09:05:24 +00:00
Alexandru2909
7e1edc828e
For #23719 - Replace preference framework strings with string resources
2022-03-14 07:12:57 +00:00
Roger Yang
d45543ec40
Close #14313 : Always add copy to clipboard action in share actions
2022-03-12 16:24:15 +00:00
Grigory Kruglov
5daa06f7dc
For #23697 : Avoid NPEs while pasting URLs from the clipboard
...
It's possible for clipboard contents to have changed in the time between we've constructed
the onClick listeners and when they're actually invoked. Code before assumed that 'text'
will be not-null, and would crash otherwise. With this change, we're capturing contents of
the clipboard before constructing onClick handlers (while also asserting correct behaviour
of 'ClipboardHandler').
With this change, we'll log an error if we were told that clipboard contains a URL, but immediately
after that check 'text' was actually null. This would indicate one of two things:
- issues within the ClipboardHandler
- changing contents of the ClipboardHandler within a tiny time window between our check and querying
2022-03-11 22:23:54 +00:00
Gabriel Luong
c9a47d08a8
For #24130 - Change Shortcuts setting to toggle the display of Top Sites
2022-03-11 19:48:08 +00:00
Noah Bond
2ea99c9a1c
For #23219 - Add favicons to synced tabs list
2022-03-11 18:54:59 +00:00
Mugurell
06ffc33ca2
For #23415 - Add support for GeckoView Screen Orientation APIs
2022-03-11 18:18:12 +00:00
Gabriel Luong
ef0db6fd12
For #24141 - Add Icon Action Primary and Secondary design tokens
2022-03-10 18:17:06 +00:00
Grigory Kruglov
02dd67b8d1
Remove duplicate 'start' call for the account manager
...
We are already starting the account manager in BackgroundServices,
so this call is a no-op (its gets dropped by the state machine).
2022-03-09 14:39:41 -08:00
Arturo Mejia
ba5a4affb7
For #23489 : Update SentryService reference to use legacy component.
2022-03-09 19:22:46 +00:00
Alexandru2909
c1431c5c12
For #22189 - Replace app name with 'Firefox' for Sync strings
2022-03-09 18:01:17 +00:00
Grigory Kruglov
7ca7190199
Bump Android-Components version to 100.0.20220309001717
2022-03-08 22:05:32 -08:00
Grigory Kruglov
6c793e035b
Closes #15882 : check for account state abnormalities after account manager is ready
2022-03-08 22:05:32 -08:00
Gabriel Luong
90e49c71d6
For #24107 - Use Layer1 for tab tray list item background color
2022-03-09 00:05:48 +00:00
Gabriel Luong
a0f8c2a1a5
For #24102 - Use Layer Accent Opaque color for the selected tab tray item background in list view
2022-03-04 21:15:30 +00:00
Gabriel Luong
11b440f8f1
For #24102 - Add Layer Accent Opaque design token
2022-03-04 21:15:30 +00:00
Gabriel Luong
ab74d55cfe
For #24102 - Rename layerNonOpaque to layerAccentNonOpaque in FirefoxThemes
2022-03-04 21:15:30 +00:00
Gabriel Luong
65b1716495
For #23990 - Allow for Nimbus experimentation for Contile top sites
2022-03-04 17:20:38 +00:00
mcarare
094cd63242
For #24075 : Add PDF download metrics.
2022-03-04 06:17:57 +00:00
mcarare
653f149cc2
For #24075 : Add PDF download metrics.
2022-03-04 06:17:57 +00:00
Gabriel Luong
50a7a8499c
For #24080 - Use layer accent non opaque for the tabs tray and history selected background color
2022-03-03 22:13:20 +00:00
Gabriel Luong
56022546f2
For #23893 - Add telemetry for Contile services
2022-03-03 20:56:44 +00:00
mcarare
597cc84a76
For #23399 : Add tabs tray multi-select telemetry.
2022-03-03 09:32:38 +00:00
Gabriel Luong
bd3f1a420e
For #24069 - Use the correct design tokens for Powered by Pocket text
2022-03-03 00:45:31 +00:00
Gabriel Luong
691e303677
For #24062 - Remove showHomeBehindSearch feature flag
2022-03-02 18:25:18 +00:00
Gabriel Luong
09101eb787
For #24051 - Remove showStartOnHomeSettings feature flag
2022-03-02 15:22:35 +00:00
Gabriel Luong
ae59f5a7a7
For #23388 - Update scrim to match design system
2022-03-02 00:16:49 +00:00
Arturo Mejia
1c66804c0b
Add remote wallpapers
2022-03-01 22:16:52 +00:00
Gabriel Luong
b6f066c9ed
For #24042- Remove inactive tabs survey
2022-03-01 18:16:05 +00:00
mcarare
1aac79357a
For #22189 : Replace placeholder with app name.
2022-03-01 14:27:54 +00:00
Alexandru2909
19d1e227ed
For #23936 - Show dialog on credit card delete
2022-03-01 09:29:07 +00:00
mcarare
47077fe2ec
For #21743 : Use isNumericAddress to validate Ipv4 and Ipv6 for SDK>=29.
2022-03-01 07:57:19 +00:00
Mugurell
4cc9a74c3d
Revert "For #23871 - Update compose to 1.1.0 and kotlin to 1.6.10"
...
This reverts commit 23f41c9c68
.
2022-03-01 06:50:28 +00:00
Noah Bond
ae9f3ab074
For #23238 - Refactor synced tabs sections to be collapsible
2022-02-28 21:38:15 +00:00
Noah Bond
e3037ad767
For #23991 - Fix synced tabs error text mapping
2022-02-28 19:38:01 +00:00
Gabriel Luong
a6b5ab6726
For #24006 - Return a null change payload if the new top sites list is larger than the old
2022-02-28 18:41:20 +00:00
Gabriel Luong
6fbffa3807
For #24008 - Only refresh the contile top sites cache if feature is enabled
2022-02-28 15:43:57 +00:00
Gabriel Luong
9834e818cb
For #24017 - Replace @color/foundation_private_theme with @color/fx_mobile_private_layer_color_1
2022-02-28 07:43:48 +00:00
MatthewTighe
9b4a85942d
fixes #23981 : open download function and override for test
2022-02-25 18:34:22 +00:00
Sarah541
a222ea521d
For #23821 - Add telemtry for RecentlyVisted Homepage ( #23909 )
...
Add test
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Ryan VanderMeulen <rvandermeulen@mozilla.com>
2022-02-25 09:03:25 -05:00
Roger Yang
c4c263abcb
Close #23894 : Simplify distinct history algorithm
2022-02-24 22:46:39 +00:00
Gabriel Luong
dfdf386f0b
For #23957 - Rename toolbarDivider attribute to borderPrimary
2022-02-24 12:21:32 -05:00
Roger Yang
77c2ad90b4
Close #13336 : Open bookmark in current tab if browsing mode is not private or previous fragment is not home
2022-02-24 00:40:18 +00:00
Gabriel Luong
783d2037b6
For #23738 - Integrate the Contile top sites updater
2022-02-23 22:54:12 +00:00
Gabriel Luong
2f30442610
For #23905 - Update onboarding icons to use Icon Active color
2022-02-23 21:25:33 +00:00
Gabriel Luong
d71e31188f
For #23888 - Replace @color/white_color with @color/fx_mobile_[icon|text]_color_oncolor
...
@color/white_color and @color/fx_mobile_[icon|text]_color_oncolor are equivalent
2022-02-23 20:14:22 +00:00
Gabriel Luong
f71edcd309
Update Android Components version to 99.0.20220223143136. ( #23942 )
2022-02-23 13:43:37 -05:00
MatthewTighe
9b54df4145
closes #23912 : remove sentry reporting from WallpaperDownloader
2022-02-23 18:17:44 +00:00
Christian Sadilek
5ebd4e1569
Revert "For #14321 - Dismiss search dialog buttons on edit cancel"
...
This reverts commit 2d75ff7d47
.
2022-02-23 16:30:27 +00:00
mcarare
9a5cd634ab
For #23408 : Fix pinned top sites count from the cached list.
2022-02-23 14:48:35 +00:00
Roger Yang
d1c0e9bf9b
Revert "For #13336 : Open bookmarks in current tab ( #23169 )"
...
This reverts commit e73deb23ac
.
2022-02-23 01:17:47 +00:00
MatthewTighe
2cc9ca3773
for #23069 : add blocklist middleware for home
2022-02-22 22:25:04 +00:00
Mugurell
23f41c9c68
For #23871 - Update compose to 1.1.0 and kotlin to 1.6.10
2022-02-22 16:55:22 +00:00
Noah Bond
15c58b7261
For #23808 - Add secret setting for enabling Task Continuity feature
2022-02-18 17:37:19 +00:00
Alexandru2909
5153cee0e0
For #22189 - Replace the 'Firefox' word in all strings with placeholder
2022-02-18 15:59:03 +00:00
Gabriel Luong
f47a428f44
For #23771 - Set correct destructive text color for card editor error messages ( #23803 )
...
Co-authored-by: tristan-jea <>
Co-authored-by: Tristan <99796140+tristan-jea@users.noreply.github.com>
2022-02-17 23:44:53 -05:00
Noah Bond
bd4742004c
For #19942 - Add support for sticky headers to the synced tabs list
2022-02-17 20:12:47 +00:00
Geordan Neukum
7271f33eff
For #23500 : creditcards: focus cardNumberInput in createView
...
Right now, when the user navigates to the "Add Card" screen, the "Card Number"
title will be focused by default. Instead, let's make it so that the first
field for data entry is focused.
Since we're focusing the first field, let's also make sure that the soft
keyboard opens and that the cursor is placed at the end of whatever text has
already been input.
2022-02-17 18:39:05 +00:00
Geordan Neukum
6b78fa3295
For #23500 : creditcards: hide keyboard when pausing fragment
...
Right now, the soft keyboard will remain open when we exit the "Add Card"
screen. Let's make it so that the soft keyboard is automatically closed when
leaving this screen.
2022-02-17 18:39:05 +00:00
Arturo Mejia
64ae748835
For #23752 : Address switch is off the screen in the Wallpaper settings.
2022-02-17 16:29:23 +00:00
sunil9211
de4ea0a086
For #23551 - Change the spacing between Pocket header and content to 16dp
2022-02-17 10:50:22 -05:00
Roger Yang
7dc969103b
No issue: Renew/remove metrics set to expire in March 2022
2022-02-16 19:43:36 -05:00
Roger Yang
20094cd1e9
No issue: Renew/remove metrics set to expire in April 2022 ( #23786 )
2022-02-16 18:34:48 -05:00
Gabriel Luong
c3a2c355a2
For #23769 - Replace @color/destructive_normal_theme with @color/fx_mobile_text_color_warning
2022-02-16 18:06:26 +00:00
Gabriel Luong
37683531e7
For #23456 ⁃ Use lifecycleScope in TopSiteItemViewHolder
2022-02-16 15:02:08 +00:00
Roger Yang
1559afe7b9
No issue: Update history search string ID
2022-02-16 01:56:44 +00:00
Gabriel Luong
4281dda447
For #23761 - Add Icon Warning Button design token
2022-02-15 22:26:38 +00:00
Gabriel Luong
e568f2e151
For #23761 - Add Text Warning Button design token
2022-02-15 22:26:38 +00:00
Gabriel Luong
2ec29b8101
For #23761 - Update Text Warning, Icon Warning and Border Warning light theme to Red70
2022-02-15 22:26:38 +00:00
Gabriel Luong
35212ae6ca
For #23761 - Update Action Secondary light theme to LightGrey30
2022-02-15 22:26:38 +00:00
Gabriel Luong
bdb6f18d8f
For #23761 - Add Text On Color Secondary design token
2022-02-15 22:26:38 +00:00
Gabriel Luong
99d636c23c
For #23761 - Rename Text On Color to Text On Color Primary
2022-02-15 22:26:38 +00:00
Roger Yang
3f0b5799f8
Close #23657 : Add voice search for history search
2022-02-15 20:43:01 +00:00
Roger Yang
7d8bad05cd
Close #23694 : Add telemetry for history search
2022-02-15 20:08:54 +00:00
Matt Tighe
96cda67806
closes #23727 : Add a fenix.git tag of the current hash to Sentry reports
2022-02-15 17:46:37 +00:00
Gabriel Luong
869f4c89ee
For #23731 - Use the disk cache for the Contile top sites
2022-02-15 16:05:32 +00:00
Mugurell
42282987f8
For #22722 - Rename fragment_crash_reporter to view_crash_reporter
...
Rename in a separate patch for git to not merge this to previous changes and in
such think that the the old file was deleted and a new one was created.
2022-02-15 08:46:41 +00:00
Mugurell
efc57762f6
For #22722 - Rename CrashReporterFragment to CrashContentView
...
Rename in a separate patch for git to not merge this to previous changes and in
such think that the the old file was deleted and a new one was created.
2022-02-15 08:46:41 +00:00
Mugurell
bc59ede073
For #22722 - Reacting to the crashed flag
...
Whenever the ".crashed" property of the currently displayed
TabSessionState -> EngineState is true we will show an in-app crash reporter
with the usual close tab / restore tab options and also the option to report
all current non-fatal crashes to Mozilla if the setting for sending the crash
reports is enabled in app settings.
This closely mimics the previous crash reporter UI but there might be some
subtle differences stemming from migrating to using a ComposeView.
Whenever the ".crashed" property of the currently displayed
TabSessionState -> EngineState is false we will set the in-app crash reporter
to have a View.GONE visibility effectively removing it from the layout.
The functionality for receiving the non-fatal crashes from the AC CrashReporter
through an Intent is still kept and these crashes will be persisted in memory
until the user closes / restores a tab and so also makes a decision about
sending or not these crashes.
Currently more tabs can crash following just one since more share the same
process and as such there is no way to differentiate between them or link a
certain Crash to a certain tab.
They will all be acted upon at once from any tab the user chooses to close or
restore.
2022-02-15 08:46:41 +00:00
Grigory Kruglov
a42018f124
Convert recently closed tabs code to use light-weight TabState
...
To lighten-up our memory usage and startup performance, all of the RecentlyClosed
machinery was converted to use a light-weight TabState - specifically, it's missing
EngineSessionState, which is expensive to obtain during startup, and potentially
very costly to keep in-memory.
When we actually need EngineSessionState (at the point of restoration of a tab), we
read and rehydrate it using provided storage implementation.
2022-02-15 01:45:35 +00:00
Noah Bond
48141b25a9
For #21900 - Delete files from Synced Tabs XML implementation
2022-02-15 00:01:57 +00:00
Noah Bond
584b2cd83c
For #21900 - Delete files from Synced Tabs XML implementation
2022-02-15 00:01:57 +00:00
Gabriel Luong
bf70616d93
For #23713 - Replace @color/secondary_text_normal_theme with @color/fx_mobile_text_color_secondary
2022-02-14 21:15:40 +00:00
Matt Tighe
f146cefcb8
closes #23662 : replace wallpaper thumbnail lazyverticalgrid with manual scroll layout
2022-02-14 19:14:28 +00:00
Gabriel Luong
5bbf8437b3
For #23711 - Replace @color/primary_text_normal_theme with @color/fx_mobile_text_color_primary
2022-02-14 18:42:11 +00:00
Rohan Maity
df0d196759
For #20634 remove some lint issues from baseline
2022-02-14 11:52:37 +00:00
Matt Tighe
9643e96244
fixes #23644 : reload wallpapers on orientation change
2022-02-11 18:25:11 +00:00
Arturo Mejia
11601770eb
For #23679 Update the wallpaper settings switch text
2022-02-11 17:51:20 +00:00
Gabriel Luong
37a0edceb6
For #23431 - Display the order of Contile Top Sites correctly
2022-02-10 00:54:24 +00:00
Mugurell
5bd6f1cb8c
For #21854 - Split the big ComposeView in 3 smaller ones
...
This would shorten the time needed to layout all Pocket recommended stories
content in one go, though it may lead to shorten hiccups over a bigger period
of time.
2022-02-09 15:56:27 +00:00
mcarare
18f785ddb9
For #22958 : Set content description only when view is visible.
...
This avoids additional processing.
2022-02-09 14:44:58 +00:00
Alexandru2909
2d75ff7d47
For #14321 - Dismiss search dialog buttons on edit cancel
2022-02-09 09:29:15 +00:00
Alexandru2909
d7803e6dc7
For #14954 - Use TabSessionState.id to check if tab is selected
2022-02-09 09:04:08 +00:00
Noah Bond
c0942eadb2
For #23526 - Add telemetry for Contile interactions
2022-02-08 21:45:16 +00:00
jhugman
b230c39a7f
Fixes #23492 : Perf regression of calling isFirefoxDefault from main thread ( #23556 )
...
* Fixes #23492 — Fixup perf regression of calling isFirefoxDefault from the main thread
* Tightening of near defunct default browser message
* Fixup early crash in debug build
* ktlint
2022-02-08 12:44:07 +00:00
Matt Tighe
0c297dcee2
closes #23540 : scale wallpaper and translate to bottom of image
2022-02-08 03:46:41 +00:00
Roger Yang
1d1412c766
Close #23626 : Do not exit edit mode in history search toolbar
2022-02-08 01:40:42 +00:00
Matt Tighe
24d2abd2b2
fixes #23619 : use well-defined name for fetching remote wallpaper assets
2022-02-07 23:26:45 +00:00