ishan/fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "For #13336: Open bookmarks in current tab (#23169)"

Browse Source 
This reverts commit e73deb23ac.
This commit is contained in:
Roger Yang 2022-02-22 14:25:52 -05:00 committed by mergify[bot]
parent 1b44f47cd8
commit d1c0e9bf9b
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkController.kt
View File

@ -77,7 +77,7 @@ class DefaultBookmarkController(
val flags = EngineSession.LoadUrlFlags.select(EngineSession.LoadUrlFlags.ALLOW_JAVASCRIPT_URL)
openInNewTabAndShow(
item.url!!,
false,
true,
BrowserDirection.FromBookmarks,
activity.browsingModeManager.mode,
flags

6
app/src/test/java/org/mozilla/fenix/library/bookmarks/BookmarkControllerTest.kt
View File

@ -110,7 +110,7 @@ class BookmarkControllerTest {
}
@Test
fun `handleBookmarkTapped should load the bookmark in the current tab`() {
fun `handleBookmarkTapped should load the bookmark in a new tab`() {
var invokePendingDeletionInvoked = false
val flags = EngineSession.LoadUrlFlags.select(EngineSession.LoadUrlFlags.ALLOW_JAVASCRIPT_URL)
@ -124,7 +124,7 @@ class BookmarkControllerTest {
verify {
homeActivity.openToBrowserAndLoad(
item.url!!,
false,
true,
BrowserDirection.FromBookmarks,
flags = flags
)
@ -290,7 +290,7 @@ class BookmarkControllerTest {
verify {
homeActivity.openToBrowserAndLoad(
item.url!!,
false,
true,
BrowserDirection.FromBookmarks,
flags = flags
)