For #9533 - Switch to using enum for Library Item Selected Telemetry
This commit is contained in:
parent
8d3d030feb
commit
fd60270da8
|
@ -236,9 +236,10 @@ sealed class Event {
|
|||
)
|
||||
}
|
||||
|
||||
data class LibrarySelectedItem(val item: String) : Event() {
|
||||
data class LibrarySelectedItem(val item: LibraryItem) : Event() {
|
||||
enum class LibraryItem { BOOKMARKS, HISTORY }
|
||||
override val extras: Map<Library.selectedItemKeys, String>?
|
||||
get() = mapOf(Library.selectedItemKeys.item to item)
|
||||
get() = mapOf(Library.selectedItemKeys.item to item.name)
|
||||
}
|
||||
|
||||
data class ErrorPageVisited(val errorType: ErrorType) : Event() {
|
||||
|
|
|
@ -41,7 +41,7 @@ class LibraryFragment : Fragment(R.layout.fragment_library) {
|
|||
|
||||
libraryHistory.setOnClickListener {
|
||||
requireComponents.analytics.metrics
|
||||
.track(Event.LibrarySelectedItem(view.context.getString(R.string.library_history)))
|
||||
.track(Event.LibrarySelectedItem(Event.LibrarySelectedItem.LibraryItem.HISTORY))
|
||||
nav(
|
||||
R.id.libraryFragment,
|
||||
LibraryFragmentDirections.actionLibraryFragmentToHistoryFragment()
|
||||
|
@ -50,7 +50,7 @@ class LibraryFragment : Fragment(R.layout.fragment_library) {
|
|||
|
||||
libraryBookmarks.setOnClickListener {
|
||||
requireComponents.analytics.metrics
|
||||
.track(Event.LibrarySelectedItem(view.context.getString(R.string.library_bookmarks)))
|
||||
.track(Event.LibrarySelectedItem(Event.LibrarySelectedItem.LibraryItem.BOOKMARKS))
|
||||
nav(
|
||||
R.id.libraryFragment,
|
||||
LibraryFragmentDirections.actionLibraryFragmentToBookmarksFragment(BookmarkRoot.Mobile.id)
|
||||
|
|
Loading…
Reference in New Issue
Block a user