From fd60270da847d43ac7c50f94358d739f14b323f6 Mon Sep 17 00:00:00 2001 From: ekager Date: Mon, 30 Mar 2020 22:42:13 -0700 Subject: [PATCH] For #9533 - Switch to using enum for Library Item Selected Telemetry --- .../java/org/mozilla/fenix/components/metrics/Metrics.kt | 5 +++-- .../main/java/org/mozilla/fenix/library/LibraryFragment.kt | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt index 46ff83a59..efec097f2 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt @@ -236,9 +236,10 @@ sealed class Event { ) } - data class LibrarySelectedItem(val item: String) : Event() { + data class LibrarySelectedItem(val item: LibraryItem) : Event() { + enum class LibraryItem { BOOKMARKS, HISTORY } override val extras: Map? - get() = mapOf(Library.selectedItemKeys.item to item) + get() = mapOf(Library.selectedItemKeys.item to item.name) } data class ErrorPageVisited(val errorType: ErrorType) : Event() { diff --git a/app/src/main/java/org/mozilla/fenix/library/LibraryFragment.kt b/app/src/main/java/org/mozilla/fenix/library/LibraryFragment.kt index ed9d02dae..da8112fd6 100644 --- a/app/src/main/java/org/mozilla/fenix/library/LibraryFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/library/LibraryFragment.kt @@ -41,7 +41,7 @@ class LibraryFragment : Fragment(R.layout.fragment_library) { libraryHistory.setOnClickListener { requireComponents.analytics.metrics - .track(Event.LibrarySelectedItem(view.context.getString(R.string.library_history))) + .track(Event.LibrarySelectedItem(Event.LibrarySelectedItem.LibraryItem.HISTORY)) nav( R.id.libraryFragment, LibraryFragmentDirections.actionLibraryFragmentToHistoryFragment() @@ -50,7 +50,7 @@ class LibraryFragment : Fragment(R.layout.fragment_library) { libraryBookmarks.setOnClickListener { requireComponents.analytics.metrics - .track(Event.LibrarySelectedItem(view.context.getString(R.string.library_bookmarks))) + .track(Event.LibrarySelectedItem(Event.LibrarySelectedItem.LibraryItem.BOOKMARKS)) nav( R.id.libraryFragment, LibraryFragmentDirections.actionLibraryFragmentToBookmarksFragment(BookmarkRoot.Mobile.id)