fenix/app
Michael Comella cc380695b8 No issue: remove unnecessary robolectric annotations.
Theoretically, this should marginally decrease the duration of our unit
test suite. In my testing, for 1 iteration each (i.e. noise is very
possible), the duration changed from 9m 32s to 8m 21s – a 71s
improvement.

---

To identify tests that were running with robolectric that didn't need to
be, I removed the @RunWith(FenixRobo... from all relevant files:
    sed -i '' "/@RunWith(FenixRobolectric/d" app/src/test/**/*.kt

I ran the tests and discovered which ones failed from the Classes tab of
the index.html test result file. Something like:
    tests = document.querySelectorAll('table')[3].querySelectorAll('tr');
    failureElements = tests.querySelectorAll('.failures');
    // TODO: extract the test names

Then I copied these results to a text file and compared them to all the
files that had robolectric test runners to figure out which ones still
pass:
    comm -1 -2 failures.txt changed_files.txt > robolectric_not_needed.txt

And undid the changes to the failing files:
    for i in $(cat robolectric_not_needed.txt); do git checkout $i; done

Then I removed the import statements on those files:
    for i in $(cut changed_files.txt); do sed -i '' "/import.*RunWith/d" $i; done
    for i in $(cat changed_files.txt); do sed -i '' "/import.*RobolectricTestRunner/d" $i; done
2021-08-10 00:22:44 +00:00
..
sampledata For #7092: Add initial Migration UI 2020-01-15 21:41:01 -08:00
src No issue: remove unnecessary robolectric annotations. 2021-08-10 00:22:44 +00:00
.gitignore Initializes Android project 2018-12-07 15:25:38 -05:00
benchmark.gradle For #19901: correct spacing in comment on how to run 2021-07-22 15:24:35 +00:00
build.gradle Closes #20679: revert allowaccessmodification proguard disabling. 2021-08-06 20:07:32 +00:00
lint-baseline.xml For #17917 - Add a Kotlin synthetics Lint detector 2021-08-06 14:09:15 +00:00
lint.xml #7346 update lint-baseline.xml and remove activity_addons.xml as unused resource 2021-08-02 10:22:34 +02:00
metrics.yaml Correct search_count telemetry after revert 2021-08-06 21:26:43 +00:00
pings.yaml Update glean notification emails to new email group (#20070) 2021-06-17 14:48:34 -05:00
proguard-rules.pro Closes #17451: remove verbose logs with proguard. 2021-01-21 18:31:25 -05:00