b1ab6e49da
16741: Fixes #16271 - Fixes ripple being cut-off in Saved logins sort toolbar r=eliserichards a=shahsurajk For #16271 ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not - [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features. In addition, it includes a screenshot of a successful [accessibility scan](https://play.google.com/store/apps/details?id=com.google.android.apps.accessibility.auditor&hl=en_US) to ensure no new defects are added to the product. ### To download an APK when reviewing a PR: 1. click on Show All Checks, 2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark, 3. click on the "Fenix - assemble" task, then click "Run Artifacts". 4. the APK links should be on the left side of the screen, named for each CPU architecture <hr> @ekager , i'm not sure of the fix. One thing that needs to be carefully reviewed is the height of the toolbar view, i'm explicitly setting it to `?actionbarSize` as we need fixed height to fix this, when using a bordered item drawable. could be wrong here. 🤞 PS: Unable to take screenshot cause of security constraints. Co-authored-by: Suraj Shah <shah.suraj.k@gmail.com> |
||
|---|---|---|
| .. | ||
| sampledata | ||
| src | ||
| .gitignore | ||
| build.gradle | ||
| lint-baseline.xml | ||
| lint.xml | ||
| metrics.yaml | ||
| pings.yaml | ||
| proguard-android-optimize-3.5.0-modified.txt | ||
| proguard-rules.pro | ||