ishan/fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
5,521 Commits 34 Branches 356 Tags 125 MiB
eab87555dc
Commit Graph

4717 Commits

Author SHA1 Message Date
Jonathan Almeida
666781aa62 Fix lint warnings and test in site permissions 2020-10-08 19:37:56 -04:00
Arturo Mejia
de521192e0 Add support for local storage permission 2020-10-08 19:37:56 -04:00
Gabriel Luong
5153a3f2c5 For #15115 - Part 9: Fix ui tests for the tabs settings 2020-10-08 12:50:43 -04:00
Gabriel Luong
2dd019c05f For #15115 - Part 8: Add a feature flag for showing the grid view in the tabs setting 2020-10-08 12:50:43 -04:00
Gabriel Luong
af0af7f88a For #15115 - Part 7: Draw a border around the selected tab 2020-10-08 12:50:43 -04:00
Gabriel Luong
5fcc486caa For #15115 - Part 6: Display the tab's favicon in the grid view 2020-10-08 12:50:43 -04:00
Gabriel Luong
5fa72cf48c For #15115 - Part 5: Don't draw any background when swiping to delete a tab 2020-10-08 12:50:43 -04:00
Gabriel Luong
a001004add For #15115 - Part 4: Formatted TabTrayView.kt 2020-10-08 12:50:43 -04:00
Gabriel Luong
6c77cdab41 For #15115 - Part 3: Implement a grid view layout for the tabs 
Co-authored-by: Abhijit Valluri avalluri2@bloomberg.net
 2020-10-08 12:50:43 -04:00
Gabriel Luong
2117dfb524 For #15115 - Part 2: Remove unused xmlns:mozac in component_tabstray.xml 2020-10-08 12:50:43 -04:00
Gabriel Luong
ed3986662f For #15115 - Part 1: Convert the CloseTabsSettingsFragment to a general TabsSettingsFragment 
- Renames CloseTabsSettingsFragment.kt to TabsSettingsFragment.kt
- Renames close_tabs_preferences.xml to tabs_preferences.xml
- Adds preference options for the switching between the Grid and List tab views
 2020-10-08 12:50:43 -04:00
Michael Comella
7c0d00c800 No issue: fix tests related to inline change. 
The difficulty in mocking StrictMode.resetAfter is concerning.
I'm starting to second-guess whether or not making strict mode manager a class
was a good idea.
 2020-10-08 07:24:21 -07:00
Michael Comella
7b5cd8c165 No issue: remove inline from StrictModeManager.resetAfter. 
I believe this was a premature optimization: it's unclear that it would
actually improve performance and yet  we had to add several weird
workarounds to make it work that broke encapsulation. It's also
possible it would be worse for the APK size because of excessive
inlining.
 2020-10-08 07:24:21 -07:00
Mozilla L10n Automation Bot
a72b5b0dd6 Import l10n. 2020-10-07 21:56:24 -07:00
Jonathan Almeida
ee673348bf Issue #15754: Disable failing notification UI tests 2020-10-07 20:01:35 -04:00
Jonathan Almeida
23d9951e78 Upgrade to Android Component 62.0.20201006190820 with breaking changes 2020-10-07 20:01:35 -04:00
Chenxia Liu
fe0ea19b1d Adding link data review request 2020-10-07 11:02:42 -07:00
Chenxia Liu
6e522436b5 startup.timeline 2020-10-07 11:02:42 -07:00
Chenxia Liu
05f37e75fb sync, sync_items, telemetry, theme, toolbar_position, 
tracking_protection, default_engine
 2020-10-07 11:02:42 -07:00
Chenxia Liu
8892a6ec85 accesssibility, open_links, remote_debugging, search_suggestions, 
show_search
 2020-10-07 11:02:42 -07:00
Chenxia Liu
5f74e18bca search_count, search_widget, tabs_count, toolbar_position 2020-10-07 11:02:42 -07:00
Chenxia Liu
29970f5cb2 has, count: open_tabs, pwa, top_sites 2020-10-07 11:02:42 -07:00
Chenxia Liu
0b9c50f62e default*browser, mozilla_products 2020-10-07 11:02:42 -07:00
Chenxia Liu
03e6167b5f browser.search, events.total_uri_count, metrics.adjust* 2020-10-07 11:02:42 -07:00
Chenxia Liu
ca57a2d3ab first_session 2020-10-07 11:02:42 -07:00
Chenxia Liu
815e159183 user_specified_search_engine, voice_search 2020-10-07 11:02:42 -07:00
Chenxia Liu
2edb812663 top_sites, tracking_protection 2020-10-07 11:02:42 -07:00
Chenxia Liu
bf381a6a7c tab, tabs_tray, toolbar_settings 2020-10-07 11:02:42 -07:00
Chenxia Liu
bb7515f76e syenc_account, sync_auth 2020-10-07 11:02:42 -07:00
Chenxia Liu
68ba986fd2 search_suggestions, search_shortcuts, search_widget 2020-10-07 11:02:42 -07:00
Chenxia Liu
965af504ad private_browsing, qr_scanner 2020-10-07 11:02:42 -07:00
Chenxia Liu
04d0e59468 pocket, onboarding 2020-10-07 11:02:42 -07:00
Chenxia Liu
ac28667995 logins, media_notification, media_state 2020-10-07 11:02:42 -07:00
Chenxia Liu
d50fbd062d Issue #14142 - find_in_page, history, reader_mode, tip 2020-10-07 11:02:42 -07:00
mcarare
9845626eca For #15711: Also add custom engines to fallback list. 2020-10-07 10:19:26 -07:00
mozilla-l10n-automation-bot
0ac7feacb4
Import l10n. (#15738) 2020-10-06 18:19:11 -07:00
Elise Richards
13f3304912
For #8765: Use shared list widget in collections (#15733) 
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
 2020-10-06 16:24:08 -05:00
Michael Comella
4302cd20b2 For #13959 - post: decrement expected suppression count. 
Running locally, I get the same error: I think that there legitimately
was an reduction in the number of StrictMode suppressions on start up.
 2020-10-06 14:11:53 -07:00
Michael Comella
3e96f6b385 For #13959 - review: add clarifying comments. 2020-10-06 14:11:53 -07:00
Michael Comella
50959d997e For #13959: add marker when StrictMode is suppressed. 2020-10-06 14:11:53 -07:00
Michael Comella
3b5d6d58d9 For #13959: add MozillaStrictModeSuppression detekt check. 2020-10-06 14:11:53 -07:00
Michael Comella
b222376cb0 For #13959: add test to prevent increasing StrictMode suppression count. 2020-10-06 14:11:53 -07:00
Michael Comella
c33aafb024 For #13959: add HomeActivityTestRule.skipOnboarding. 
This is more correct, faster, and results in less copy-paste duplication
than the current behavior:
  homeScreen { }.dismissOnboarding()

Which opens settings to dismiss onboarding.
 2020-10-06 14:11:53 -07:00
Michael Comella
4a4edeb184 For #13959: count StrictMode suppressions on startup. 2020-10-06 14:11:53 -07:00
Jocelyne Abi Haidar
a5de2c0352 For #15675: Disable Save button when editing saved login until something has been changed 
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
 2020-10-06 11:47:12 +03:00
mozilla-l10n-automation-bot
5fed37cf45
Import l10n. (#15712) 2020-10-05 18:08:06 -07:00
Mozilla L10n Automation Bot
ad2b99f9f9 Import l10n. 2020-10-05 12:19:48 +02:00
mcarare
07748f69b7 For #15632: Improve checking open tabs logic to show collection button. 
Check now considers selected tab tray mode.
 2020-10-02 20:46:29 -04:00
ekager
ec3595d4fc For #15600 - Move removal of timed out sessions to immediately after restoration 2020-10-02 13:22:49 -07:00
ekager
01eedd159a No issue: Update biometric, core, and recyclerview libraries 2020-10-02 08:47:40 -07:00
mcarare
b696fc4c4b For #13031: Show size in KB for smaller downloaded files. 2020-10-02 11:04:48 -04:00
Mozilla L10n Automation Bot
ee4a5283a4 Import l10n. 2020-10-01 17:46:57 -07:00
Jocelyne
0154c81f81
For #10107: Show Today and Yesterday labels in History (#15415) 2020-10-01 16:42:50 -07:00
Michael Comella
f690f8736d No issue: replace LintUnitTestRunner with detekt implementation. 
This should be more performant and easier to maintain.
 2020-10-01 16:06:53 -07:00
Jeff Boek
41a92a8d8b For #15593 - Reverts back to simple UUID creation without Fenix side caching 2020-10-01 15:51:30 -07:00
Jocelyne
e74a12b442
For #15471: Show Delete button in red in multi-select overflow menu (#15576) 2020-10-01 13:10:33 -07:00
Mozilla L10n Automation Bot
97adee3bd9 Import l10n. 2020-10-01 20:13:40 +02:00
Grisha Kruglov
51dab196c4 Closes #15443: Use fragment's lifecycleScope for AlertDialog actions 2020-09-30 17:42:40 -07:00
Christian Sadilek
ced92d69d1 Issue #15555: Set channel to Nightly explicitly for SettingsFragmentTest 2020-09-30 18:35:20 -04:00
mcarare
67310061a3 For #15559: Allow tabs to stretch in landscape mode for tablets. 
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
 2020-09-30 14:46:22 -07:00
Christian Sadilek
4a06e40e70 Closes #15555: Intermittent failures in SettingsFragmentTest 2020-09-30 14:53:18 -04:00
Stefan Arentz
ff930175de
For #15537 - Be more verbose about leanplum identifiers (#15538) 2020-09-30 13:05:28 -04:00
mcarare
19b377c021 For #15535: hasOpenTabs now considers the selected tab mode in tray tab. 2020-09-30 08:33:38 -07:00
Michael Comella
56f78cb30c No issue: elaborate on Components class doc. 
This is to clarify a misunderstanding I found in PR review.
 2020-09-29 15:39:10 -07:00
Sebastian Kaspari
2fda22e857 Revert "For #12565: Pass metrics to share controller" for debug test failures. 
This reverts commit bbaca06274.
 2020-09-29 10:59:31 +02:00
Sebastian Kaspari
4de466883b Revert "For #12565: Pass bookmark storage to controller" for debug test failures. 
This reverts commit 3c22100b84.
 2020-09-29 10:59:17 +02:00
Andrew Gaul
cfbad1dae9 Show undo snackbars with padding with static bottom toolbar 
This specifically fixes the close tab snackbar.  This commit mirrors
the logic when not using Undo from
9e876ebc44.  References #14982.
 2020-09-29 10:15:30 +02:00
ekager
01e802fef0 For #15324 - Show tab settings and recently closed items in menu when no tabs 2020-09-28 21:09:30 -07:00
ekager
e49cd9c558 For #15503 - Change recently closed max to 10 2020-09-29 00:03:49 -04:00
TrianguloY
b07af9ccd3
For #13856 - Prevent overscroll in swipe to switch tabs gesture 2020-09-28 20:43:44 -07:00
Tiger Oakes
25f62f1c76 Extract locale settings initial state 2020-09-28 20:39:49 -07:00
Tiger Oakes
acbad66f45 Add test for initial logins list state 2020-09-28 20:39:49 -07:00
Tiger Oakes
f2a6aa4f25 Add tests for initial collection creation state 2020-09-28 20:39:49 -07:00
Sören Hentzschel
01fdb4ac3f For #11561 - changed inactive heading and menu icon color in dark mode 2020-09-28 20:24:12 -07:00
Mozilla L10n Automation Bot
863b135723 Import l10n. 2020-09-28 20:18:50 -07:00
Tiger Oakes
3c22100b84 For #12565: Pass bookmark storage to controller 2020-09-28 20:05:50 -07:00
Tiger Oakes
bbaca06274 For #12565: Pass metrics to share controller 2020-09-28 20:05:50 -07:00
Michael Comella
d767cd199e For #13959: fix startup crash by using arg Context. 
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
 2020-09-28 18:01:19 -07:00
Michael Comella
42cca072e2 For #13959: remove resetAfter & port tests to StrictModeManager. 2020-09-28 18:01:19 -07:00
Michael Comella
dd73cb628b For #13959: clean up existing StrictMode test names. 2020-09-28 18:01:19 -07:00
Michael Comella
f19c9920f9 For #13959: move resetAfter into StrictModeManager. 
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.

Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```

We're going to have to add a lint check to prevent them from doing that.
 2020-09-28 18:01:19 -07:00
Michael Comella
6abeb2d9e7 For #13959: change StrictModeManager to class from object. 
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
 2020-09-28 18:01:19 -07:00
Christian Sadilek
d4ab728cff For #14034: Add debug preference to override AMO collection in Nightly 2020-09-28 17:25:52 -04:00
Michael Comella
a92356fe00 For #13959: comment about duplication in logic in StrictMode. 
I had to drop a commit that addressed the issue because it was too hard
to fix.
 2020-09-28 13:52:40 -07:00
Michael Comella
e1bd6191c7 For #13959: add comment to explain why we only resetAfter in certain build modes. 2020-09-28 13:52:40 -07:00
Michael Comella
3bf71ef655 For #13959: use ac StrictMode.resetAfter rather than duplicating functionality. 2020-09-28 13:52:40 -07:00
Michael Comella
2c1befaa25 For #13959: rename to attachListenerToDisablePenaltyDeath for clarity. 2020-09-28 13:52:40 -07:00
Michael Comella
c03c7ef793 For #13959: remove unused penaltyDialog parameter. 
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
 2020-09-28 13:52:40 -07:00
Michael Comella
f05a542060 For #13959: always enable detectNonSdkApiUsage. 
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
 2020-09-28 13:52:40 -07:00
Sebastian Kaspari
3983c509dc Use "undo" implementation from Android Components. 
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.

Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
 2020-09-28 10:04:46 -07:00
Mozilla L10n Automation Bot
d287e6e9e0 Import l10n. 2020-09-28 17:16:11 +02:00
mcarare
daced89387 For #15310: Add test for ActivityNotFoundException when sharing to app. 2020-09-28 13:29:17 +03:00
mcarare
6289da892c For #15310: Also catch ActivityNotFoundException when sharing to app. 2020-09-28 13:29:17 +03:00
ekager
0d0a28d551 No issue: Update AC to 61.0.20200925190057 2020-09-26 12:21:10 +02:00
ekager
7d5c199e51 For #12383 #15407 #12860 - Switch to using shared view model for session to delete on home 2020-09-25 16:54:54 -07:00
Grisha Kruglov
2999f64d0a Closes #15434: Don't try to display a 'signed in' snackbar in a 'headless' mode 2020-09-25 15:31:07 -07:00
Grisha Kruglov
d98eba1d64 Closes #15432: Invoke UI updates on main thread in response to account events 2020-09-25 15:30:48 -07:00
Grisha Kruglov
24985d54fa Closes #15436: Auto-close tabs during startup on the main thread 2020-09-25 15:11:21 -07:00
Christian Sadilek
81aaacda61 Configure M5 AMO collection for Nightly/Debug 2020-09-25 11:18:07 -04:00
mcarare
cd53b8fdaf For #15130: Remove "what's new card" check in UI test. 2020-09-25 18:04:48 +03:00
mcarare
04e59e0ac5 For #15130: Remove "what's new card" from onboarding screen. 2020-09-25 18:04:48 +03:00
Mozilla L10n Automation Bot
f32d2011df Import l10n. 2020-09-24 18:03:47 -07:00
Kate Glazko
e8855c09e6 For #15320: Ensure Mimetype Other PDF Shows PDF Icon 2020-09-24 13:49:51 -07:00
Elise Richards
1adf467248
For #14280, #14743: Remove old search fragment (#15169) 
* Remove search fragment

* Use new folder to search dialog

* Rebase and lint

* Update tests with search dialog nav directions

* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
 2020-09-24 15:46:42 -05:00
Jonathan Almeida
add60611b4 For #15349: Fixes SyncedTabs suggestion not clicking 2020-09-24 15:35:06 -04:00
Grisha Kruglov
f1b0827a0b For #15296: Allow excluding bookmark subtrees when editing parent folder 
I'm really not a fan of how title overwriting and structure processing are mangled together,
but will leave clearing that up for another day.
 2020-09-23 23:22:44 -07:00
Mozilla L10n Automation Bot
4fad099b23 Import l10n. 2020-09-23 21:16:24 -07:00
Sawyer Blatz
0fa2509bef
For #14243: Pre-land visuals for Close Tabs CFR (#15171) 2020-09-23 14:57:52 -07:00
Grisha Kruglov
71b51146cb Update breaking changes in the FxA/Sync integration 2020-09-23 14:51:04 -07:00
Jocelyne
d45e482373
For #11800: Hide reveal and clear password icons if the password is empty when editing a saved login (#15244) 
Co-authored-by: Jocelyne Abi Haidar <jocelyne.abihaidar@gotocme.com>
 2020-09-23 12:10:49 -07:00
Sebastian Kaspari
943455658b Issue #13270: Do not launch into Fennec's task anymore. 
Initially we did this to avoid a duplicated task right after the migration from Fennec. We'd end up
with the original task from Fennec and the new one from Fenix; with the Fennec task still showing
Fennec in the app switcher, but launching Fenix once selected.

Anyhow, now on Android 11 this causes the Fenix task to get duplicated. The simple fix is to not
do any of that anymore. This may re-introduce the problem with the Fennec migration, but:
* We are at 100% rollout for quite some time. There are still users migrating, but the impact
  of the bug is much lower.
* The bug after the migration was only temporary. This bug here is happening every time you
  launch Fenix. So I'd rather fix this than a possible inconvenience right after the migration.
 2020-09-23 18:05:05 +02:00
mcarare
c1bf66618e #274-android-l10n: Update create account string to avoid partial translations. 2020-09-23 08:49:23 -07:00
Christian Sadilek
601e847094 Configure M4 AMO collection for all builds 2020-09-22 19:01:37 -04:00
person808
baccb153b7 For #15219 - Fix tab tray handle size. 
Also use dimens for the tab history handle.
 2020-09-22 15:24:22 -07:00
aprabhakara
657ce60f8d For #15262: Updated margins 2020-09-22 14:57:53 -07:00
ekager
24983af94e For #15291 - Limit current CFRs to show max one every 3 days 2020-09-22 10:43:14 -07:00
mcarare
94d9a2a1ed For #15263: Properly update open links in app preference. 2020-09-22 09:44:32 -07:00
ekager
a9075ff87b For #15272 - Remove bottom margin for toolbar on enter fullscreen 2020-09-22 08:34:29 -07:00
ekager
030d6a5b36 For #15121 - Ensure tabs removed while on browser select an available parent session 2020-09-22 08:33:39 -07:00
mcarare
e3b5dcbfec For #15268: Update unit tests for safe navigation to details fragment. 2020-09-22 18:23:17 +03:00
mcarare
896c1b7875 For #15268: Use safe navigation to addon details fragments. 2020-09-22 18:23:17 +03:00
Oana Horvath
108666c277 Closes #14524, #12896, #13830: re-enabled strict ETP tests after code bug fix 2020-09-22 13:42:30 +03:00
Grisha Kruglov
f51b570654 For #15284: Process root titles when creating new folders 
This also simplifies how we do this. We're no longer creating instances of `DesktopFolder` class
nor creating copies of BookmarkNodes just to display root titles correctly for the 'edit folder' UI.
 2020-09-21 20:03:04 -07:00
ekager
f16ade33df For #15089 - Disable recently closed in multiselect 2020-09-21 18:35:08 -07:00
ekager
b5f1e772bd For #15112 - Still show recently closed when history empty 2020-09-21 18:35:08 -07:00
Grisha Kruglov
5691088787 For #15286: Don't crash when separators are long-touched 2020-09-21 18:34:08 -07:00
Mozilla L10n Automation Bot
c326be9fd3 Import l10n. 2020-09-21 18:17:38 -07:00
ekager
9a2103a9a7 For #13934 - Make TabHistory work on PWA/Custom Tabs 2020-09-21 16:07:56 -07:00
ekager
407c31fdb3 No issue: Fixes strict mode death in debug custom tab 2020-09-21 12:59:33 -07:00
ekager
9e876ebc44 For #14982 - Show snackbars with padding with static bottom toolbar 2020-09-21 10:05:28 -07:00
ekager
18ca211434 For #14458 - dismiss keyboard on fill link from clipboard 2020-09-21 08:27:46 -07:00
Mozilla L10n Automation Bot
7cad83f64b Import l10n. 2020-09-20 20:19:09 -07:00
ekager
e162aefbc6 For #15245 - Remove margin for toolbar on toolbar-less PWA 2020-09-20 19:41:29 -07:00
Mozilla L10n Automation Bot
1f6a22a340 Import l10n. 2020-09-19 21:33:21 -07:00
Grisha Kruglov
b7b3ee5ce6 For #2792: Display bookmark folders at the top of the bookmarks UI 2020-09-18 22:01:17 -07:00
Grisha Kruglov
078843675b For #15211: Make sure bookmarks are moved to the end of folders 2020-09-18 21:52:58 -07:00
Grisha Kruglov
027c1f9ea7 Closes #15206: Only track 'move' event if bookmark parent was changed 2020-09-18 21:52:58 -07:00
Grisha Kruglov
b5b32ba6ea For #11502: Make sure to always process root titles for parent folders during edit 
This also switches to a simpler bookmarks query API ('getBookmark') which doesn't fetch
children. We don't need 'children' for this dialog, and so don't need to do the extra work.
 2020-09-18 21:16:57 -07:00
Grisha Kruglov
958474f9fb For #13157: Filter out folder being edited from 'select folder' dialog 2020-09-18 20:13:45 -07:00
Grisha Kruglov
fe288edb5d Rename 'visitedAddBookmark' arg to a less confusing name 2020-09-18 20:13:45 -07:00
Grisha Kruglov
24de85f805 Remove unused nav arg from 'select folder' 2020-09-18 20:13:45 -07:00
Mozilla L10n Automation Bot
af03b88f1e Import l10n. 2020-09-18 19:01:38 -07:00
Tiger Oakes
b563576335
Closes #14131: Move constants to dimens.xml (#14135) 
Co-authored-by: Elise Richards <erichards@mozilla.com>
 2020-09-18 16:13:57 -07:00
Tom Klein
dc9bc534db For #13300 - Adjust the 'Sharing a Collection' layout to prevent overlapping of the close icon and 'Share' label in RTL 
Note that the "Share" title is still constrained to start at the end of the
close button - I don't know why the previous extra constraint was causing the
differing behavior in LTR and RTL, but this seems to fix it.
 2020-09-18 14:04:03 -07:00
Elise Richards
a4ff782565
For #13812: add ETP category for redirect trackers (#15139) 
* Feature flag for ETP cookie purging

* Strings for new ETP description

* Remove icons from ETP info screeen and add category for redirect trackers

* ETP policy factory tests

* Remove icons from ETP panel and add cross tracking allowed field.

* Remove icons on ETP panel. Add blocked category for redirect trackers to panel.

* Add margins to tracking protection settings
 2020-09-18 14:03:51 -05:00
Jeff Boek
6781018556 For mozilla-mobile/android-components#8429 - Dont initialize MLS if token is null 2020-09-18 11:51:50 -07:00
Jeff Boek
8bdc9d0431 Revert "For #12544 - Prevent search engines mixup" 
This reverts commit 0a4a170f7e.
 2020-09-18 11:51:50 -07:00
Hakkı Kaan Çalışkan
0afb7a3f25 For #13922: Add indicator to synced tabs suggestions in awesomebar 2020-09-18 09:54:19 -07:00
Jonathan Almeida
d063cd5396 For #14230: Stop redrawing all top sites when one is removed 2020-09-18 12:53:23 -04:00
mcarare
5b33044999 For #12829: Add create account option on the the sign in screen. 2020-09-18 09:04:54 -07:00
mcarare
81985f4179 For #12829: Update addUnderline extension function to accept parameters. 2020-09-18 09:04:54 -07:00
mcarare
cc9667f722 For #15150: Do not show open banner if open in app is ON in settings. 2020-09-18 10:47:02 +03:00
Mozilla L10n Automation Bot
80a573a62c Import l10n. 2020-09-18 10:26:22 +03:00
mcarare
79135b1df5 For #13943: Change strict mode penalty to penaltyDeath. 
Also, keep dialogPenalty as replacement option for penaltyDeath.
 2020-09-18 09:45:08 +03:00
Oana Horvath
abe06da6e2 Closes #13829: Added idling resources to the addon details view" 2020-09-18 09:43:06 +03:00
mcarare
f793c3a5f9 For #14727: Add content description to resync tabs button. 2020-09-17 16:44:36 -07:00
Sören Hentzschel
55b5a452d1 For #14933 - Fixed private browsing icon color in preferences fragment 2020-09-17 16:41:02 -07:00
Tiger Oakes
b927b688c9 Merge bookmark item and folder view holders 2020-09-17 15:59:42 -07:00
Tiger Oakes
3059a57747 Change separator to use its own view holder 2020-09-17 15:59:42 -07:00
Elise Richards
9afe9679d8
For #15079: handle QR permissions when changed in Android settings (#15097) 
* Define intent data for activity

* Search dialog shows permissions for allow and deny camera

* Check camera permissions for fxa pairing

* Check camera permissions for old search

* Tests for pairing sync interactor and controller.

* Cleanup

* Use bool pref for setting. Use interfaces and default implementations for the sync interactor and controller.

* Lint
 2020-09-17 16:41:28 -05:00
Sawyer Blatz
8a81c1ee1d For #15123: Fix top sites text color 2020-09-17 11:35:51 -07:00
Sawyer Blatz
1f17371df6 For #14565: Add telemetry for top sites 2020-09-17 10:06:39 -07:00
Arturo Mejia
19f0c543fe Fix add-ons permissions breaking change 2020-09-17 09:48:57 -07:00
mcarare
e5a9311613 For #15116: Also do not expand or set bottom toolbar behavior on TWA tabs. 2020-09-17 09:30:27 -07:00
mcarare
83478b9db4 For #15116: Do not set bottom toolbar behavior on PWA tabs. 2020-09-17 09:30:27 -07:00
mcarare
c5a2e2e5a0 For #15116: Do not expand toolbar on PWA tabs. 2020-09-17 09:30:27 -07:00
mcarare
1f004aff8c For #15116: Use safe cast for layout params. 2020-09-17 09:30:27 -07:00
Sebastian Kaspari
ee3384ac52 Issue #14225: Remove task when finishing ExternalAppBrowserActivity. 2020-09-17 18:13:47 +02:00
Mozilla L10n Automation Bot
f036d3db67 Import l10n. 2020-09-16 18:31:50 -07:00
Mozilla L10n Automation Bot
f6684862a4 Import l10n. 2020-09-16 09:31:34 +03:00
Hakkı Kaan Çalışkan
f87ca730a9 For #11245: Integrate Synced Tabs AwesomeBar suggestions 
fix pr
 2020-09-15 13:58:29 -04:00
mozilla-l10n-automation-bot
2059156193
Import l10n. (#15099) 2020-09-14 18:08:22 -07:00
Jeff Boek
c632b6b0a1
For #15007 - Puts swipe to delete behind a feature flag (#15009) 2020-09-14 15:20:46 -07:00
Mozilla L10n Automation Bot
0a8b9e378c Import l10n. 2020-09-14 12:02:00 -07:00
codrut.topliceanu
b892af773e For #14546 - Speculative fix for ANR 2020-09-14 09:10:28 -07:00
Gabriel Luong
05857ba55d For #14145 - Add pinned badge for pinned sites 2020-09-11 20:42:40 -04:00
Mugurell
75aa2d413a For #14974 - Ensure website bottom elements stay at bottom 
engineView.setDynamicToolbarMaxHeight(0) vs
engineView.setDynamicToolbarMaxHeight(toolbarHeight)
ensures webpage's bottom elements are aligned to the bottom of the browser.

We also need to make sure that when the toolbar is static it does not cover the
bottom of the page - something desired when the toolbar was dynamic.
For this the engineView will have a toolbarHeight bottom margin.
 2020-09-11 16:39:34 -07:00
codrut.topliceanu
b5cf484360 For #14559 - Persist searchFragment keyboard status 2020-09-11 13:58:47 -07:00
Elise Richards
4afaf34a78
Access shared prefs in fxa pairing (#14997) 2020-09-11 14:56:03 -05:00
Jeff Boek
79180250ea For #14283 - Fixes overlapping search suggestions and hint 2020-09-11 12:25:09 -07:00
ekager
09fbb43f80 For #2486 - Adds Recently Closed Tabs 2020-09-11 12:02:30 -07:00
codrut.topliceanu
cce58e7d51 For #14725 - Resize search engine radio button 2020-09-11 09:53:55 -07:00
ekager
b986730031 No issue - Updates AC to 58.0.20200910190642 and fixes imports 2020-09-11 10:57:24 +03:00
Mugurell
b54949e58f
For #14902 - Disabling bottom toolbar animation now works (#14927) 2020-09-10 18:06:38 -07:00
Jeff Boek
f9b2d65993 For #5745 - Create preference to disable domain autocompletion 2020-09-10 17:39:42 -07:00
Mozilla L10n Automation Bot
8e7d10c33c Import l10n. 2020-09-10 17:34:03 -07:00
Elise Richards
87bd44145f
For #14239: Notification for QR scan when permissions have been denied (#14553) 
* Show dialog when permissions are denied

* Add qr permissions dialog to search dialog fragment

* Add qr permissions dialog to the pairing screen

* Show dialog after permissions have been denied

* Reset focus after denying permissions

* Show dialog after permissions denied in search frag and par frag

* Use shared preferences to store camera permission state

* Move dialog creation into the search controller and add tests

* Dialog controller implementation and test

* Route to intent with correct activity. Set focus when dismissing dialog

* Get preferences in old search
 2020-09-10 19:09:38 -05:00
Abhijit Kiran Valluri
b0729f655c
Fix #14950 - Make the "Add new tab" button visible in private mode on light theme (#14951) 2020-09-10 16:53:05 -07:00
Mugurell
a6a50d78e0 For #14903 - Prevent BrowserFragment's view leak 2020-09-10 18:25:54 +03:00
Oana Horvath
2e38635781 For #13829: Disables verifyAddonsCanBeUninstalled UI test 2020-09-10 15:58:11 +03:00
ekager
82d7313add For #13467 For #14910 - Dismiss dialog on blank URL commit 2020-09-09 20:51:54 -07:00
ekager
806f74abe7 For #14680 - Revert ObserverRegistry changes to WifiConnectionMonitor 2020-09-09 20:49:56 -07:00
Michael Debertol
4142c36820 For #14212: Pass historyStorage to ToolbarView 2020-09-09 20:47:43 -07:00
Michael Debertol
cc8aa1f381 For #13423: Pass isPrivate flag to ToolbarView 2020-09-09 20:47:43 -07:00
Mozilla L10n Automation Bot
c7a25cd8aa Import l10n. 2020-09-09 18:31:50 -07:00
Sijan Rijal
18de605ac4 Closes #14053 
Set the padding on the download action button as it didn't have a padding as the numbers of characters in the text of the button grew.
 2020-09-09 14:42:03 -07:00
Sören Hentzschel
103c183265 For #14194 - avoid leak when opening the "Libraries that we use" screen 2020-09-09 14:40:15 -07:00
Jeff Boek
66ecc15b40 For #14543 - Prevents IllegalStateException by not moving to another thread 2020-09-09 13:21:49 -07:00
mcarare
4de80a0493 For #14540: Fix updating list and item info for a11y services. 2020-09-09 11:31:52 -07:00
Gabriel Luong
6d133c8d0c For #14529 - Show a dialog when the top sites limit has been reached 2020-09-09 14:12:55 -04:00
ekager
de7e6663ce Closes #14895 - Adds paste to context menu ordering preference 2020-09-09 10:51:59 -07:00
codrut.topliceanu
21cbbdc7c8 For #13949 - Turn off tip regarding beta/nightly 2020-09-09 08:42:40 -07:00
Mugurell
d8d896c500 For #10240 - New preferences to control gesture based features 
Three new settings and one for which this patch just pre-lands the strings.
The behavior for the "Swipe toolbar up to open tabs" is to be added as part of
a later ticket.
 2020-09-09 08:21:05 -07:00
mcarare
f7217021da For #14718: Increase touch target for resync button. 2020-09-09 10:06:05 +03:00
Tiger Oakes
4b6a589f24
Extract checkbox selected mask (#14308) 2020-09-08 18:10:35 -07:00
mozilla-l10n-automation-bot
0e8cd65d48
Import l10n. (#14867) 2020-09-08 18:09:54 -07:00
Tiger Oakes
53d16e78e1
For #14460: Fix PBM notification tint (#14699) 2020-09-08 17:56:25 -04:00
Tiger Oakes
043e061087
For #14376: Reverse items with bottom toolbar (#14451) 2020-09-08 13:55:10 -07:00
Tiger Oakes
113241e8ce
Enforce IO thread inside of components (#14704) 
* Automatically run PermissionStorage on IO thread

* Run TabCollectionStorage on dedicated scope + IO

* Update findSitePermissionsBy calls
 2020-09-08 13:55:01 -07:00
Gabriel Luong
7aa6514499
For #14629 - Enable showing frequently visited sites ON by default (#14630) 2020-09-08 11:30:13 -07:00
Sebastian Kaspari
e0071341c7 Update to new state API and update Mozilla Android Components version. 
The EngineSessionState of a tab is now always accessible through tab.engineState.engineSessionState. It will
never get cleared.
 2020-09-08 18:08:01 +02:00
Oana Horvath
100cc7c088 Closes #14277: Ads idling resources for History UI tests 2020-09-08 17:41:31 +03:00
Oana Horvath
cf69058ce8 Closes #12645: Re-enable mediaSystemNotificationInPrivateModeTest 2020-09-08 13:49:13 +03:00
Mozilla L10n Automation Bot
b94a6c244b Import l10n. 2020-09-08 10:26:33 +03:00
Mozilla L10n Automation Bot
4a1c1addb5 Import l10n. 2020-09-07 16:05:41 +02:00
mcarare
c350a5f3b9 For #9506: Add session observer to check conditions for displaying banner. 2020-09-07 10:22:14 +03:00
mcarare
d7668b16fc For #9506: Create show open in app banner preference. 2020-09-07 10:22:14 +03:00
mcarare
653a279101 For #9506: Implement banner custom view based on material design specs. 2020-09-07 10:22:14 +03:00
mcarare
20794296dc For #9506: Add possibility to navigate to a preference in settings. 2020-09-07 10:22:14 +03:00
codrut.topliceanu
fe3ef74d71 For #11153 - String for private mode scr shot warning 2020-09-04 16:40:40 +03:00
Oana Horvath
bf9f6794e9 For #14524: Disable ETP tests failing on AC 58 update 2020-09-04 13:31:30 +03:00
Mugurell
33fc520468 For #10241 - Use VerticalSwipeRefreshLayout for pull to refresh 
And so resolve many of the issues found in the platform's SwipeRefreshLayout.
 2020-09-04 11:46:49 +03:00
Mozilla L10n Automation Bot
022bc5f5ff Import l10n. 2020-09-03 18:45:11 -07:00
ekager
09d1dba133 For #14679 For #14676 - Dismiss MP Migration tip, init in disabled state 2020-09-03 13:24:48 -07:00
ekager
e80b46ced0 For #14609 - Correct nav from new search experience to browser 2020-09-03 13:24:31 -07:00
mcarare
85cb74a3c9 For #14665: Replace hardcoded label with string resource. 2020-09-03 10:56:55 -07:00
Shane Synan
2231fe2d52
For #14642: Use correct 'Close tabs' summary text (#14644) 
For "closeTabsAfterOneMonth", use the correct summary string of
"close_tabs_after_one_month" instead of "close_tabs_after_one_week".

This fixes the Settings page "Close tabs" summary showing the wrong
tab duration when "Close tabs" is set to "After one month".

Closes #14642
 2020-09-02 19:07:27 -07:00
Dennis Schubert
abfc91519a
Bug 1645844 - Add label to reports sent via the webcompat-reporter. (#14625) 2020-09-02 17:48:37 -07:00
mozilla-l10n-automation-bot
fea7c2651e
Import l10n. (#14650) 2020-09-02 17:48:10 -07:00
Christian Sadilek
a2368e2a1e Configure M4 AMO collection for Nightly/Debug 2020-09-02 18:25:23 -04:00
liuche
408000e450
Issue #7620 - Remove Nightly flag for external download manager (#14632) 2020-09-02 13:59:00 -07:00
Sören Hentzschel
81dd1a9192
For #8343, #9709 - replace "phone" with "device" in translations (#14083) 2020-09-02 10:55:35 -07:00
Arturo Mejia
6f5e9bad26
Pin AC TO 57.0.0 and remove feature flag for view downloads (#14592) 
* Update Android Components version to 57.0.0.

* Remove feature flag for "View Downloads".

* Update search enginer list from changes by #13452

Co-authored-by: Chenxia Liu <liuche@mozilla.com>
 2020-09-01 20:04:31 -07:00
Tiger Oakes
d762dea49d Gradle configuration avoidance 2020-09-01 18:58:52 -07:00
mozilla-l10n-automation-bot
0413d3c91f
Import l10n. (#14599) 2020-09-01 18:26:25 -07:00
ekager
83ffcac57e For #13926 - MP migration 2020-09-01 16:27:51 -07:00
Jeff Boek
0c748c0500 For #14279 - Prevent GeckoView from resizing while searching 2020-09-01 14:32:15 -07:00
ekager
2d67e4b748 For #4118 - Creates setting for auto closing tabs 2020-09-01 13:04:12 -07:00
ekager
7c7aa46811 Closes #14254 - Removes Login select feature flag 2020-09-01 13:02:24 -07:00
Codrut Topliceanu
72edaaf067
For #11465 - Fix default engine for widget voice search (#14015) 
For #11465  - Fix default engine for widget voice search
 2020-09-01 12:22:16 +03:00
Tiger Oakes
bf2ac22d03
Simplify media state drawables (#13474) 2020-08-31 19:42:27 -07:00
Kainalu Hagiwara
d668a82f14
For #13498 - Use custom long press back handling for Huawei devices. (#14387) 2020-08-31 18:47:16 -07:00
Sören Hentzschel
2532cecf6c
for #13329 - removed unused feature flag (#14438) 2020-08-31 17:54:42 -07:00
Mozilla L10n Automation Bot
e86143c50d Import l10n. 2020-08-31 17:49:44 -07:00
Michael Debertol
351d66230c
For #14354: Update the search shortcuts icon on state update (#14355) 2020-08-31 16:59:33 -07:00
Tiger Oakes
9fc37281bb
For #14346: Fix min height on site list item (#14370) 2020-08-31 15:55:46 -07:00
Codrut Topliceanu
cfd799a6af
For #13765 - Fix TopSites layout and item sizes (#14278) 2020-08-31 13:13:27 -04:00
Oana Horvath
4a00131fa1 Closes #13218: adds IdlingResources for the Addons list 2020-08-31 19:59:49 +03:00
Oana Horvath
1e7faa693f Closes #14522: item 'Open link in apps' moved 2020-08-31 19:59:49 +03:00
Michael Droettboom
8f71704c1f
Fix a typo in metric expiry. (#14530) 
This was changed to 2020-04-01 in b01dbeeebf

I assume this was just a typo, since a lot of metrics got changed to 2021-04-01
in the same commit.
 2020-08-31 09:39:39 -07:00
Gabriel Luong
dcb99856f9
For #13264 - Scroll to the tab above the selected tab in the tabs tray (#14372) 2020-08-31 11:14:37 -04:00
mcarare
2f1b903005 For #14289: Check if toolbar is initialised before setting flags. 2020-08-31 10:40:36 +03:00
Mozilla L10n Automation Bot
0a15314c33 Import l10n. 2020-08-30 22:48:28 -04:00
Mozilla L10n Automation Bot
aae8236478 Import l10n. 2020-08-30 11:13:51 -04:00
Arturo Mejia
c63fd3f9ac Add support for restoring downloads 2020-08-29 12:04:23 -04:00
Mozilla L10n Automation Bot
487eeb6b88 Import l10n. 2020-08-28 23:10:21 -04:00
Tiger Oakes
e93a8b7d34
For #14376: Use concept-menu with tab counter menu (#14374) 2020-08-28 13:28:15 -07:00
Tiger Oakes
a8291bf641
Remove un-needed nullables (#13816) 2020-08-28 13:28:08 -07:00
Jeff Boek
ff805e53ed For #14318 - Use old API to try to fix startup crash without GPS 2020-08-28 13:04:22 -07:00
Tiger Oakes
ace6b99c89
Split toolbar controller into two classes (#13854) 2020-08-28 12:13:59 -07:00
Tiger Oakes
f81b401738
Remove unneeded tint for ic_link (#14381) 2020-08-28 14:52:07 -04:00
Tiger Oakes
75e7cd3c64
FNX-14583 ⁃ Extract and test preference helpers for Settings (#13402) 2020-08-28 11:02:07 -07:00
ekager
4854ff2ae7 No issue: Add strings for tab management 2020-08-28 12:46:32 -04:00
Suraj Shah
5dfc9cb699
Fixes #4840 - - Adds dark search widget based on system theme (#13975) 
* Fixes #4840

* Fixes #4840 - Adds dark search widget based on system theme
 2020-08-28 11:22:47 +03:00
Mugurell
acdef76b71 For #12980 - Clear icons when deleting browsing data 2020-08-28 10:28:48 +03:00
Mugurell
aa7283def9 For #12980 - Unify deleteBrowsingData() and deleteHistoryAndDOMStorages() 
The two methods are serving the same purpose, with one calling the other.
This prepares the ground for adding a method to delete icons in only one place
and remove confusion about what that place should be.
 2020-08-28 10:28:48 +03:00
Mozilla L10n Automation Bot
4a73993259 Import l10n. 2020-08-27 22:02:02 -04:00
Tiger Oakes
50ac4fe17d
Use shared list widget in tab history (#13884) 2020-08-27 18:27:57 -07:00
Tiger Oakes
0102e03d75
Add tests for collection creation (#13909) 2020-08-27 18:27:34 -07:00
Tiger Oakes
9777b8fad6
FNX-14661 ⁃ Delete drawables (#13481) 
* Delete unused drawabled

Mostly leftovers from quick action bar

* Remove duplicate drawables using tints
 2020-08-27 18:26:35 -07:00
Tiger Oakes
5f652ea0c3 Add tools: attributes for preview 2020-08-27 21:11:13 -04:00
Hakkı Kaan Çalışkan
dc377dd742
For #12673: Adjust top and left alignment of logo on homescreen (#12676) 
align collection title
 2020-08-27 17:16:19 -07:00
Jeff Boek
50c955723c No Issue - Add prompt to secret settings 2020-08-27 15:32:50 -07:00
mozilla-l10n-automation-bot
80dc3f574e
Import l10n. (#14258) 2020-08-27 15:21:10 -07:00
Gabriel Luong
31455070b1
For #14119 - Add a setting to toggle the display of frequently visited top sites (#14183) 2020-08-27 16:17:57 -04:00
Jeff Boek
4cbbc52ad0 No Issue - Fixes bug where shortcuts and hint are visible at the same time 2020-08-27 10:47:01 -07:00
Tiger Oakes
e067ad5363
For #8157: Redirect about:addons search (#13990) 2020-08-27 09:49:32 -07:00
Oana Horvath
9e47d9e70d
Closes #10911: idling resource registration timing issues (#14231) 2020-08-27 11:40:22 -04:00
mcarare
91a9200fe3 For #13911: Fix resolving color attribute for title and description. 
For SDK < 23 color attr cannot be resolved in selectors.
 2020-08-27 12:42:20 +03:00
mcarare
50948ef06e For #12905: Update dialog title so it won't be read by a11y services. 2020-08-27 12:28:44 +03:00
mcarare
9903fe855e For #12905: Just code rearrange, no changes. 2020-08-27 12:28:44 +03:00
mcarare
410980fe27 For #11425: Improve editing bookmarks flow. 2020-08-27 12:27:25 +03:00
Oana Horvath
4ebb070ed7 [Ui Tests] Closes #11944: changes the way the system notifications are verified according to their visibility 2020-08-27 10:02:48 +03:00
Sachin
316b70940f
for #12573, added startup type and hasSavedInstance keys to app_startup_type telemetry (#13494) 2020-08-26 23:14:13 -07:00
Jeff Boek
3713b5a63a For #14251 - Dont show CFR if were navigating to Search 2020-08-26 21:18:19 -07:00
Jeff Boek
c73870b794 For #13507 - Performance fixes for the ReviewPromptController 2020-08-26 21:02:02 -07:00
Jeff Boek
c6687d976e For #13507 - Adds tests for ReviewPromptController 2020-08-26 21:02:02 -07:00
Jeff Boek
56b730f0e8 For #13507 - Extracts review prompt behavior into ReviewPromptController 2020-08-26 21:02:02 -07:00
Elise Richards
e96eb25682 Allow play store in app review to be shown to users 2020-08-26 21:02:02 -07:00
Jeff Boek
4b997c1334 No Issue - Fixes UI Tests with new search experience 2020-08-26 18:00:47 -07:00
Jeff Boek
f734509ac4 No Issue - Removes pref, toggles new search based on feature flag only 2020-08-26 18:00:47 -07:00
ekager
179a86ce64 Puts login selection behind a nightly feature flag 2020-08-26 20:07:56 -04:00
ekager
53eebd681b For #5551 - Adds select login prompts 2020-08-26 20:07:56 -04:00
Jonathan Almeida
5f92de58ae Disabling StrictMode policy for Top Sites changes 2020-08-26 18:39:05 -04:00
Christian Sadilek
8b9c3e0108 Fixes for A-C 57.0.20200826190111: Move EngineSession to BrowserState 2020-08-26 18:39:05 -04:00
Tiger Oakes
0b333fe48a For #9056: Search from custom tab 2020-08-26 18:39:05 -04:00
Gabriel Luong
0cc1d32e56 For #10342 - Part 7: Fix TopSiteViewHolderTest and TopSiteItemViewHolderTest 2020-08-26 18:39:05 -04:00
Gabriel Luong
4f76699ab7 For #10342 - Part 6: Show "Delete from history" instead of "Remove" for top frecent sites in the top site menu 2020-08-26 18:39:05 -04:00
Gabriel Luong
40120ac98f For #10342 - Part 5: Fix DefaultSessionControlControllerTest and DefaultBrowserToolbarControllerTest 2020-08-26 18:39:05 -04:00
Gabriel Luong
1f564c10ce For #10342 - Part 4: Use the TopSitesFeature in the HomeFragment for displaying top sites 2020-08-26 18:39:05 -04:00