Commit Graph

16 Commits

Author SHA1 Message Date
Sebastian Kaspari
2b759e9d6f Integrate new search code from Android Components into Fenix. 2020-11-20 17:45:45 +01:00
Michael Comella
c647679e4d No issue: move relevant :mozilla-detekt-rules to perf/ pkg. 2020-11-13 16:07:59 -08:00
Michael Comella
0f770ca39b For #15279: add MozillaUseLazyMonitored custom detekt rule. 2020-11-05 07:48:17 -08:00
MarcLeclair
7b1af41b40
15278 detekt rule runblocking (#15942)
* For #15278: added CoroutineManager to count runBlocking calls

* For #15278: Added actual detekt rule for runblocking and its config to the yaml

* For #15278: Added unit test for RunblockingCounter

* For #15278: renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test

* Lint fix

* For #15278: made runblocking a Long to prevent overflow

* For #15278: fixed MozRunblocking name, description and moved RunBlockingCounter to perf package

* For #15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck

* For #15278: Added setup for unit test, since it failed without restting counter

* For #15278: Fixed naming for RunBlocking lint check

* For #15278: removed changes made to test to use runBlockingIncrement

* For #15728: added test exclusion for runBlocking check

* For #15278: changed null check and added Synchronized to count setter

* For #15278: fix for nits

* For #15278: added StartupExcessiveResourceUseTest to CODEOWNERS

* For #15278: fixed for nits

* For #15278: Moved increment function to extension function and fixed indentation

* For #15278: Added tests for Atomic Integer extension and nit fix
2020-11-02 12:49:17 -05:00
Michael Comella
6a635c479b For #15707: add MozillaStrictModeSuppressionTest. 2020-10-30 18:23:35 -07:00
Michael Comella
12e856ca11 For #15707: correctly configure JUnit for mozilla-detekt-rules.
Without this, the tests would not run from the command line though they
could run in Android Studio.
2020-10-30 18:23:35 -07:00
Michael Comella
0a63362f95 For #15707: clean up lint rules dependencies.
For mozilla-detekt-rules, the tests didn't compile at all so apparently
they haven't been running in testing.

mozilla-lint-rules worked but they were not clean.
2020-10-30 18:23:35 -07:00
Michael Comella
3e96f6b385 For #13959 - review: add clarifying comments. 2020-10-06 14:11:53 -07:00
Michael Comella
3b5d6d58d9 For #13959: add MozillaStrictModeSuppression detekt check. 2020-10-06 14:11:53 -07:00
Michael Comella
66f220c22a For #13959: improve custom detekt violation output.
Before it used to output the violations all one one line. Now it looks
like:
```
MozillaStrictModeSuppression:
    'import mozilla.components.support.ktx.android.os.resetAfter' at
(17,1) in /StrictModeManager.kt
    Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.

MozillaStrictModeSuppression:
    'setThreadPolicy(threadPolicy.build())' at (56,24) in
/StrictModeManager.kt
    Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.

MozillaStrictModeSuppression:
    'setVmPolicy(builder.build())' at (71,24) in /StrictModeManager.kt
    NOT YET IMPLEMENTED: please consult the perf team about
implementing`StrictModeManager.resetAfter`: we want to understand the
performance implications of suppressing setVmPolicy before allowing it.
```
2020-10-06 14:11:53 -07:00
Michael Comella
f690f8736d No issue: replace LintUnitTestRunner with detekt implementation.
This should be more performant and easier to maintain.
2020-10-01 16:06:53 -07:00
Tiger Oakes
5a4c391b52 Suppress YamlConfig deprecation 2020-07-27 13:56:03 -04:00
Michael Comella
f1159f3558 No issue: remove assertJ.
It was only used for 3 checks so it's not worth having a dependency on
it.
2020-04-02 07:57:19 -07:00
Emily Kager
b94ac93ce9
Upgrade to detekt 1.6.0 (#9306)
Changelog:

https://arturbosch.github.io/detekt/changelog.html

Fixes #7360.  Also use more exact test glob.

Co-authored-by: Andrew Gaul <andrew@gaul.org>
2020-04-01 15:42:46 -07:00
Sawyer Blatz
20396f78a9
For #7698: Adds search back button animation (#7840)
* For #7698: Adds search back button animation

* Refactor for searchController
2020-01-22 11:15:30 -08:00
Will Hawkins
f69009aa9e No Issue: Add custom detekt rule to blacklist certain properties
Add a custom detekt rule to blacklist certain properties. This is
immediately useful for making sure that developers do not configure
runtime behavior using the `BuildConfig.DEBUG` property but it is
useful in a wider context.
2020-01-17 15:46:32 -08:00