Commit Graph

22 Commits

Author SHA1 Message Date
Mugurell 0fa9363f99 For #17917 - Remove the Kotlin synthetics Lint detector
Since all usages of Kotlin synthetics are removed and no such code is generated
anymore there is no need to keep around this Detector anymore.
2021-08-24 10:26:36 +00:00
Mugurell 0bc64e8ca8 For #17917 - Add a Kotlin synthetics Lint detector
This would help ease the current refactoring effort by ensuring no new
synthetics usages.
2021-08-06 14:09:15 +00:00
Sebastian Kaspari 287dfaf92d Allow insecure protocol usage when using local Nexus in CI. 2021-07-27 10:08:32 +02:00
Sebastian Kaspari 21c023d001 Use new lint API. 2021-07-27 10:08:32 +02:00
Michael Comella 99600247bb No issue: move relevant files in :mozilla-lint-rules to perf pkg. 2020-11-13 16:07:59 -08:00
Michael Comella 5ba5ab9e6f For #15707: add ConstraintLayoutPerfDetectorTest.
I had to ignore one of the tests because the linter test API seemed to
be broken. All of these APIs are beta so I didn't think it was worth
trying to force it to work.
2020-10-30 18:23:35 -07:00
Michael Comella 4b94215f59 For #15707: remove super.visitElement for ConstraintLayout lint.
It caused a test to fail because super.visitElement asserted false
because it expected to be overriden. It was correctly overridden - we
were just still calling through to super anyway.
2020-10-30 18:23:35 -07:00
Michael Comella 0a63362f95 For #15707: clean up lint rules dependencies.
For mozilla-detekt-rules, the tests didn't compile at all so apparently
they haven't been running in testing.

mozilla-lint-rules worked but they were not clean.
2020-10-30 18:23:35 -07:00
ekager f1cc9faed0 No issue - Update lint detector tests to run 2020-10-26 15:09:54 -07:00
Juan C. Goncalves eb0712d9b4
For #11397 - Add lint rule for AppCompatResources instead of ContextCompat (#16011) 2020-10-20 13:23:43 -07:00
Sebastian Kaspari 2da24cd91d
Update Android Components, Kotlin, Gradle plugin (#16021)
* Closes #13262: Update AGP to 4

* Update to Mozilla Android Components 63.0.20201019090011.

* Update Kotlin to 1.4.10 and Coroutines to 1.3.9.

* Fix new compiler warnings.

* Fix compilation of lint rules module.

* Pin JNA version.

* Fix new lint errors.

Co-authored-by: Tiger Oakes <toakes@mozilla.com>
2020-10-19 14:07:47 -04:00
Juan C. Goncalves 6d699105ad
For #8947 - Lint check for licenses in Kotlin/Java source files (#15639) 2020-10-16 17:41:08 -07:00
ekager 4d348dd26a Fixes existing lint errors 2020-10-15 09:53:13 -07:00
Michael Comella aeb0205ea5 For #15644: update Android Gradle Plugin version.
This ensures our custom lint rules are running on the command line.
2020-10-15 09:53:13 -07:00
Michael Comella 8893468102 For #15280: add ConstraintLayoutPerfDetector custom lint rule. 2020-10-14 15:20:28 -07:00
Michael Comella 1cc2ecdc7c No issue: minimize Button...Detector violation location.
This changes the error highlighting from being the entire contents of
<Button ...> to just the first line of <Button>.
2020-10-07 09:39:13 -07:00
TangHuaiZhe 76f240bad0 Update mozilla-lint-rules/src/main/java/org/mozilla/fenix/lintrules/TextViewAndroidSrcXmlDetector.kt
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
2020-08-21 20:07:18 -07:00
Tang HuaiZhe 16b3b7a1b5 Fix the comment of TextViewAndroidSrcXmlDetector. 2020-08-21 20:07:18 -07:00
Elise Richards 4fe1fb8f4a
No issue: Delete unnecessary to-dos (#12603)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 13:38:07 -05:00
Mihai Branescu 048d22dbcf For #8643 and #7606 - added styles and new colors 2020-05-06 09:18:27 +03:00
Sawyer Blatz 8185ba793e
For #9857: Create button style (#9858)
* For #9857: Creates text button style

* Adds lint check

* Fixes onboarding cards
2020-04-15 15:49:02 -07:00
ekager 414e905b76 Closes #8944 - Adds custom lint checks 2020-03-27 13:59:51 -07:00