Commit Graph

5305 Commits

Author SHA1 Message Date
Oana Horvath
358a3a3d4c Fix screenshots tests: showDefaultHomeScreen, bookmarksManagementTest 2021-04-12 16:21:35 +03:00
Mozilla L10n Automation Bot
d7f7f817c9 Import l10n. 2021-04-12 00:38:10 +00:00
Mozilla L10n Automation Bot
5a2a61330d Import l10n. 2021-04-11 00:25:07 +00:00
Mozilla L10n Automation Bot
aa4d0b84db Import l10n. 2021-04-10 00:31:18 +00:00
Jonathan Almeida
d702af5a53
For #15372 - Correct one more instance of the onboarding string (#18906) 2021-04-09 15:21:26 -04:00
Gabriel Luong
7cc4a8a4d8
For #18742 - Resize the top site item sizes (#18751) 2021-04-09 11:47:35 -04:00
Mugurell
660f0609cb For #18122 - Update browser layout for find in page bar with bottom toolbar
With a dynamic bottom toolbar the  browser extends all the way to the bottom of
the screen and so when the find in page bar is shown it will be so above the
bottom part of the browser which may contain exactly the searched for items.

To fix the browser must effectively be placed at the top of the newly shown
find in page bar.
2021-04-09 14:48:51 +03:00
Mugurell
b36431a6df For #18616 - Update browser and toolbar layout when toolbar is at top
FindInPageIntegration which already updated the toolbar to make room for the
find in page bar now receives more data based on which it will be able to
better update the layout of BrowserFragment to to support showing the find in
page bar.
2021-04-09 14:48:51 +03:00
Sebastian Kaspari
dfb3c4c9bf Introduce process lifecycle observer to collect metrics about tabs when app goes to foreground/background. 2021-04-09 12:36:27 +02:00
Sebastian Kaspari
54d46c7e94 Move TelemetryMiddleware to telemetry sub package. 2021-04-09 12:36:27 +02:00
mcarare
c30d0f9240 For #18829: Adjust bookmark item color to UX specs. 2021-04-09 10:32:33 +03:00
Jonathan Almeida
9170ee3621 Update kdocs of navigation interactor 2021-04-09 06:50:05 +04:00
Jonathan Almeida
e422016367 Call stop in deattach for feature binding 2021-04-09 06:50:05 +04:00
Jonathan Almeida
6d09a8757c Close #18845: Adds swipe-to-delete to tabs tray refactor
Copied the TabsTouchHelper from the `tabtray` package here so we don't
need to re-write our own because there's nothing more to add.

We can hook this up with our tabs tray here by putting it in the
`BaseBrowserTrayList` for our normal and private tabs list.
2021-04-09 06:50:05 +04:00
Mozilla L10n Automation Bot
d6652785e9 Import l10n. 2021-04-09 00:27:10 +00:00
Arturo Mejia
db9b3676d3 For #18608 Add experiment for set default browser MenuItem. 2021-04-08 15:58:43 -04:00
MarcLeclair
9d728ec168
For #17759: Added min SDK 23 to avoid crashes on android 5.0 and 5.1 (#18832)
* For #17759: Added min SDK 23 to avoid crashes on android 5.0 and 5.1

* For #17759: fixed Android code from INT to actual version name
2021-04-08 15:20:18 -04:00
Elise Richards
10f75a3606
For #17870 - Enable new three-dot menu redesign on nightly builds (#18883) 2021-04-08 15:19:05 -04:00
Elise Richards
e5e9ceba5a
Settings menu item should be tinted if there is an account issue (#18849) 2021-04-08 13:10:55 -05:00
Elise Richards
ba111dabaa
PWA install to homescreen is available in main menu (#18850) 2021-04-08 12:14:28 -05:00
Gabriel Luong
37b6079d83
For #18268, #18269 - [Saved cards] Display a list of Saved cards fetched from the credit card storage (#18808) 2021-04-08 12:09:57 -04:00
Gabriel Luong
15fc01c7f9 Update app/src/main/java/org/mozilla/fenix/ext/Activity.kt 2021-04-08 14:23:06 +03:00
Arturo Mejia
be7318f608 For #18608 made set a default browser functionality publicly available. 2021-04-08 14:23:06 +03:00
rxu
efdb30483a Add domestic China FxA service for Mozilla Online builds
China fxa related string

Add switch preference in settings to use local/global fxa server

inherit fennec FxA settings

Present or hide fxa switch according to isMozillaonline

Allow China fxa server auto login during migration
2021-04-07 23:40:59 -07:00
Mozilla L10n Automation Bot
cb62f98717 Import l10n. 2021-04-08 00:39:56 +00:00
Jonathan Almeida
80a3475b30
No issue - Enable the tabs tray refactor in nightly (#18858) 2021-04-07 19:02:15 -04:00
codrut.topliceanu
9219a1b35b For #18515 - Added Icon and sync functionality
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
2021-04-08 02:45:16 +04:00
codrut.topliceanu
d961d7ba38 For #18515 - Adds FAB to TabsTray rewrite 2021-04-08 02:45:16 +04:00
Gabriel Luong
c31d507e19
For #18743 - Change the top sites label colour and size (#18752) 2021-04-07 17:39:11 -04:00
Roger Yang
10eace2f99
Closes #18068: Track custom fill link from clipboard clicked (#18827) 2021-04-07 16:31:41 -04:00
Jonathan Almeida
b1727416f3 No issue: Move UseCase wrappers to the interactor; it's only usage 2021-04-07 21:23:09 +04:00
Jonathan Almeida
2e3086ac40 No issue: Move menu to separate integrations class 2021-04-07 21:23:09 +04:00
Jonathan Almeida
dd3e95b4cf No issue: Add test for share tab in navigation interactor
Co-authored-by: Roger Yang <royang@mozilla.com>
2021-04-07 21:23:09 +04:00
Jonathan Almeida
729acdba39 No issue: Observe only normal tabs when updating counter 2021-04-07 21:23:09 +04:00
Jonathan Almeida
09e9561600 Issue #18774: Fix long parameter warnings in detekt 2021-04-07 19:14:54 +04:00
Jonathan Almeida
9078139e40 Close #18774: Migrate mutli-selection to store
Removes the recyclerview-selection library and replaces it with the
SelectionHolder/SelectionInteractor with a Store.

This is an implementation that's similar to what we have in other UI
lists (library).
2021-04-07 19:14:54 +04:00
Jonathan Almeida
499aa858b2 Issue #18774: Move SelectionInteractor to new package
The interactor and holder are useful outside of the `library` package, so
let's move it up a package level for other components.
2021-04-07 19:14:54 +04:00
Arturo Mejia
8ca9f94abb For issue #16557 set autoplay block audio only
by default
2021-04-07 07:04:59 -04:00
Mozilla L10n Automation Bot
ae5ab1c6fa Import l10n. 2021-04-07 00:26:52 +00:00
Elise Richards
547a843c5c
For #18770 - Correct addons position in three dot menu based on toolbar position (#18828) 2021-04-06 15:40:32 -04:00
Grisha Kruglov
3e37426375 Closes #17361: Extend perf.awesomebar.* metrics 2021-04-06 11:50:08 -07:00
Gabriel Luong
db993196c6
For #18819 - Hide the Credit Card preference by default (#18820) 2021-04-06 13:43:51 -04:00
Mozilla L10n Automation Bot
568bad0f48 Import l10n. 2021-04-06 17:28:45 +00:00
Roger Yang
01568d5859
Closes #18513: Re-add menu to tabs tray (#18756) 2021-04-06 10:26:41 -04:00
Jonathan Almeida
a443509c8b Issue #18535: Set the span count for grid view 2021-04-06 09:57:33 +04:00
Jonathan Almeida
2c6395cafe Issue #18535: Do not animate first scroll to position
This looks less that ideal with a grid layout that swings by from the
normal tabs to private tabs.
2021-04-06 09:57:33 +04:00
Jonathan Almeida
8ccc4648a9 Issue #18535: Move list/grid viewholders to browser package 2021-04-06 09:57:33 +04:00
Kate Glazko
841dacb69e For 17798: Sync Menu Item 2021-04-05 14:34:34 -07:00
Jonathan Almeida
92a99542e6
Close #17821: Add TabsTrayStore with actions and reducer (#18773) 2021-04-05 15:12:07 -04:00
Jonathan Almeida
af3a5b0a17
No issue - Make TabLayoutMediator lifecycle aware (#18779) 2021-04-05 15:10:29 -04:00
Travis Long
c17594c745
[SDK-246] Change Nimbus channel input to use the same method as Glean (#18766)
* [SDK-246] Change Nimbus `channel` input to use the same method as Glean

* Update app/src/main/java/org/mozilla/fenix/experiments/NimbusSetup.kt

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2021-04-05 12:30:25 -04:00
VaishnaviShri
3260cbd986 For #8545: Fix unnecessary scroll in home screen
Changed the height of the recycler view inside the home fragment
to ‘wrap_content’ to avoid scrolling if the viewport is not filled
with elements.

Closes #8545
2021-04-05 09:15:06 +03:00
Mozilla L10n Automation Bot
8916e567bc Import l10n. 2021-04-05 00:28:16 +00:00
Mozilla L10n Automation Bot
10d2623bb6 Import l10n. 2021-04-04 00:29:06 +00:00
Gabriel Luong
fe06d88e7e
Use photon colors from ui-color (#18760) 2021-04-03 10:26:53 -04:00
Gabriel Luong
1f320fd2ad
No issue - Remove generic strings for more specificity (#18769) 2021-04-02 15:24:28 -04:00
Mugurell
0f0c319896 For #17772 - Collapse browser menu to "Add to Home screen"
The menu will start as collapsed.
Users can then swipe up to expand it.
2021-04-02 18:45:27 +03:00
Gabriel Luong
1008ca2b4a
For #18265 - [Add card] Integrate the credit card storage and handle adding a new credit card (#18719) 2021-04-02 10:40:44 -04:00
Michael Comella
6e5b4b3ce6 For #18731: remove anonymous classes from StrictModeManager.
After this change, I took 3 profiles: the new code appeared in the profiler
only once and only for one sample (i.e. possibly just got unlucky). It
seems to be improved. Profiles:
- https://share.firefox.dev/3wifiV2 (captured it)
- https://share.firefox.dev/39xgdHz
- https://share.firefox.dev/2QMdlA0
2021-04-01 13:19:49 -07:00
Gabriel Luong
3f21a63c3c
For #18729 - Use consistent string naming for generic strings (#18730) 2021-03-31 18:20:04 -04:00
Elise Richards
ca33aef036
For #17770: New tab three-dot menu reorder (#18427)
* Create new menu order for new tab

* Add new tab menu navigation. Dynamically update menu when sync auth is needed. Make new tab menu and browser menu consistent.

* Lint

Lint and refactoring tests

* Tests for default toolbar menu

* Feature flag for request desktop site

Add todos for UI test issue 17979

Add todos for UI tests
2021-03-31 16:05:44 -05:00
mcarare
2687092f90 For #18717: Use normal theme color for tab tray synced tabs. 2021-03-31 18:30:05 +04:00
Mugurell
304e471801 For #18617 - Use the new EngineView#getInputResultDetail()
All functionality should remain the same.
2021-03-31 15:36:38 +03:00
AndiAJ
e03ffff3b8 Disable failing UI Tests 2021-03-31 13:06:18 +03:00
mcarare
6f17e329c4 For #17797: Add bookmarks menu item. 2021-03-31 11:12:58 +03:00
Roger Yang
c7cb0fd5a0
Closes #18706 - Remove unneeded add-on telemetry calls (#18707) 2021-03-30 16:19:00 -04:00
rxumoz
51c41f84d5
Closes #18386 - Change language display name to traditional/simplified Chinese for Chinese locale (#18387) 2021-03-30 16:18:31 -04:00
Mihai Adrian Carare
ccfb275b03
For #17800 - Request desktop site from home screen. (#18653) 2021-03-30 16:12:46 -04:00
Roger Yang
caf8ac8207
Closes #18514: Re-add tab counter in tabs tray (#18659) 2021-03-30 15:43:07 -04:00
Michael Comella
89088aa595 For #18426: add data review links. 2021-03-30 10:38:44 -07:00
Michael Comella
ac34432176 For #18426: warn about flaw in app_opened_all_startup probe. 2021-03-30 10:38:44 -07:00
Michael Comella
ade38246be For #18426: record cold start duration telemetry. 2021-03-30 10:38:44 -07:00
Michael Comella
2be9fb61d0 For #18426: add StartupActivityStateProvider.
This will be used to filter conditions for the start up telemetry we're
adding.
2021-03-30 10:38:44 -07:00
Michael Comella
edd49b286d For #18426: add ApplicationStartReasonProvider.
We need to know this state to add a correct COLD MAIN probe.
2021-03-30 10:38:44 -07:00
Michael Comella
520634165e For #18426: add DefaultActivityLifecycleCallbacks.
We'll extend this in subsequent commits.
2021-03-30 10:38:44 -07:00
Oana Horvath
246348501c For #18644: fix metod to verify system notifications 2021-03-30 18:19:02 +03:00
Jonathan Almeida
d167bc7b67 Issue #14117: Add Synced Tabs as a page in the tabs tray 2021-03-30 19:09:50 +04:00
Oana Horvath
aacb5e3ebb For #18421: Ignore the ContextMenusTest class because of test failures 2021-03-30 17:12:49 +03:00
Gabriel Luong
ae625e60cf For #18247 - [Add card] Populate the Credit card expiry year drop down 2021-03-29 21:37:03 -04:00
Gabriel Luong
4763d8c9e5 For #18246 - [Add card] Populate the Credit card expiry month drop down 2021-03-29 21:37:03 -04:00
Gabriel Luong
46a267a494 For #18243 - Add a credit card editor screen 2021-03-29 21:37:03 -04:00
Jonathan Almeida
cb1fb95a3a Issue #18521: Focus on page corresponding to selected tab
This first part of #18521 is to focus on the correct pager item first
before we land a patch for `scrollToPosition` of the selected tab.
2021-03-30 03:08:01 +04:00
Jonathan Almeida
e41344aa1f Close #18668: Add stable ID cache for TabAdapter.getItemId 2021-03-30 02:58:54 +04:00
yichiehc
7c46f5e74f
For #16830: Increase the Show in private sessions option in Search Preferences Settings (#18689)
* For #18242 - Wire up "Sync cards across devices" preference with SyncPreferenceView (#18605)

* For #16830: Increase the Show in private sessions option in Search Preferences Settings

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2021-03-29 17:06:29 -05:00
Aaron Klotz
0a0d48f48c Explicitly set android:extractNativeLibs to true in ApplicationManifest.xml
The Android Gradle Plugin's default for android:extractNativeLibs changed from
true to false beginning with version 3.6.0. Based on GeckoView's needs, we
should ensure that this attribute is explicitly set to true.
2021-03-29 12:52:34 -07:00
Michael Droettboom
50ae7826ad
Bug 1689162: Update Glean metrics.yaml schema (#18683) 2021-03-29 11:53:45 -04:00
Kershan
02d70d3837
For #18453 - Show SUMO for default browser deeplink on Android <N
Lower Android versions don't offer the possibility of opening system settings
at a specific preference. In this cases we already shown a sumo article
detailing the manual steps each user is expected to perform to change the
system set default browser.
2021-03-29 18:14:15 +03:00
Arturo Mejia
367413cd20 For #15372 Improve Onboarding strings 2021-03-27 08:48:13 -04:00
Jonathan Almeida
26c176a75e Issue #18443: Move viewholders to separate files and package 2021-03-27 03:42:34 +04:00
Jonathan Almeida
917783a141 Issue #18443: Fix changes between grid/list viewholders 2021-03-27 03:42:34 +04:00
Jonathan Almeida
9ce4adaa32 Close #18443: Use recyclerview-selection for multi-select mode in tray
Add multi-select mode to the BrowserTabsAdapter. It has the
functionality to:
 - Enable multi-select mode on long-press.
 - Enable multi-select mode when changed by an external function.
 - Only works for normal tabs (as we currently have it).

Co-authored-by: "codrut.topliceanu" <codrut.topliceanu@softvision.ro>
2021-03-27 03:42:34 +04:00
Gabriel Luong
5d0af34537
For #17291 - Display a list of all active Nimbus experiments (#17515) 2021-03-26 13:58:30 -04:00
yichiehc
dd09ba64c4
For #18594: Highlight the "Default browser" system setting on Android >= N
Although not public APIs we can use specific extras in the Intent used to open
system settings such that the "Default browser" setting is highlighted to
provide a better UX for users looking to set Fenix as default.
2021-03-26 18:25:56 +02:00
rxumoz
46af52d254
Update top sites to add PDD for MozillaOnline builds (#18615) 2021-03-26 12:18:46 -04:00
Mihai Adrian Carare
a539f69cb2
For #18260 - Add pin to default sites. (#18618) 2021-03-26 11:36:27 -04:00
Roger Yang
c21b44e0a3
Closes #18535: Re-add grid layout to tabs tray (#18638) 2021-03-26 10:33:46 -04:00
Oana Horvath
1c0360af7b Disable customTrackingProtectionSettingsTest 2021-03-26 16:25:14 +02:00
Oana Horvath
11d410de0b Re-enable working UI tests from #18644 2021-03-26 16:25:14 +02:00
Mozilla L10n Automation Bot
cc0fdd1109 Import l10n. 2021-03-26 11:39:00 +00:00
Mugurell
060b986f1c For #18644 - Temporarily disabling UI tests that fail on Firebase.
This is a quick solution to resume PR merges.
Investigations and a proper fix is to follow on this same ticket.
2021-03-26 13:06:05 +02:00