ishan/fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
4,020 Commits 34 Branches 356 Tags 125 MiB
af7b414db2
Commit Graph

3440 Commits

Author SHA1 Message Date
Christian Sadilek
87c95a64d3 Configure M2 AMO collection for all builds 2020-04-27 18:33:31 -04:00
Mozilla L10n Automation Bot
88f4e5f217 Import l10n. 2020-04-28 00:28:46 +03:00
Arturo Mejia
a8843def6c Fix CrashReporterService breaking changes 2020-04-27 16:43:05 -04:00
Arturo Mejia
e55a4fd274 No issue: Partially update the add-on manager list 2020-04-27 16:43:05 -04:00
mcarare
1aa473b112 For #9913, For #9914: Remove touch delegate when button is disabled. 2020-04-27 11:57:51 -07:00
Oana Horvath
21894a3cea
Added new bookmarks tests (#9878) 
Fix for #7417: Fix and re-enable disabled tests
 2020-04-27 18:15:27 +03:00
ekager
a9692d9bce For #10204 - Address viewLifecycleOwner IllegalStateException crashes 2020-04-24 17:12:08 -07:00
Mihai Branescu
a16bfb27ef For #6557 - added unit tests 2020-04-24 15:47:48 -07:00
Mihai Branescu
0c2d22f595 For #6557 - add in_content telemetry class 2020-04-24 15:47:48 -07:00
Mihai Branescu
28496fecc0 For #6557 - split base extension functionality from ads 2020-04-24 15:47:48 -07:00
Mihai Branescu
f09bc4566c For #6557 - added metric for in_content 2020-04-24 15:47:48 -07:00
Mihai Branescu
f10e202a1e For #6557 - added web-extension for cookies 2020-04-24 15:47:48 -07:00
mcarare
996dabae8b For #10188: Fix layout constraints. 2020-04-24 13:28:53 -07:00
mcarare
0f3d4e4cbe For #10188: Fix xml indentations and properties order. 2020-04-24 13:28:53 -07:00
mcarare
e830da59b7 For #10180: Remove touch delegate when button is disabled. 
Also refactored multiple if's into a when.
 2020-04-24 13:28:29 -07:00
mcarare
3e13927c25 For #10180: Add extension to remove touch delegate from parent. 2020-04-24 13:28:29 -07:00
ekager
59484208d6 No issue: Update Private Browsing placeholder string 2020-04-24 11:39:14 -07:00
Mihai Branescu
8a80fbe14c For #6558 - change from modifying event to event listener 
The initial design replaced the onload method, which was used by others such as Bing.
With listeners it's additive, we do not replace anything.
 2020-04-24 09:28:40 -07:00
Mihai Branescu
8e66e19dbb For #6558 - remove baidu and yahoo from monitored pages 
These two do not contain ad servers, so we don't need to unnecessarily monitor them
 2020-04-24 09:28:40 -07:00
Mihai Branescu
c4d76dce5a For #6558 - cleanup + added unit tests 2020-04-24 09:28:40 -07:00
Mihai Branescu
f03d65b13d For #6558 - added logic for ad_clicked metric 2020-04-24 09:28:40 -07:00
Mihai Branescu
93ca1f6d9f For #6558 - added handling of web extension + sending metric for has_ads 2020-04-24 09:28:40 -07:00
Mihai Branescu
c4f7972f2b For #6558 - added web extension for extracting document urls 2020-04-24 09:28:40 -07:00
Simon Chae
f1559ed2da
For #10162: Set switch back to prev state when failed to enable/disable addon (#10164) 2020-04-24 11:54:16 -04:00
Oana Horvath
e4764592fd
fix private notification text (#10192) 2020-04-24 17:55:46 +03:00
mcarare
2edd4b39a4 For #9913, For #9914: Remove button when disabling it. 
Setting visibility to GONE allows clicks to parent view in that space.
 2020-04-24 16:42:47 +03:00
Arturo Mejia
956bf01cd5 For issue #9493: Reload after cleaning individual site permissions exceptions 2020-04-24 06:16:32 -04:00
David Walsh
6f5f48c30e
For #10148 - Add basic tab tray implementation without exposing to rest of app (#9934) 2020-04-23 15:38:35 -05:00
Vlad Filippov
e51e1c878b Add 'useEmail' and 'useEmailProblem' metrics event 
Fixes #9834
 2020-04-23 10:33:36 -07:00
Simon Chae
b3248ec769 For #6123: Expose WebExtensions in private browsing control 2020-04-23 12:28:57 -04:00
mcarare
cc67de29bf For #10091 Also disable play/pause button when hiding it. 2020-04-23 09:22:01 -07:00
mcarare
9dd8314d14 For #10091 Add extension to remove and disable button 2020-04-23 09:22:01 -07:00
mcarare
932fd44823 For #7387: Change ETP onboarding from popup to a dialog. 
Recalculated dialog position and offsets.
Changed ETP onboarding dialog to show only once.
 2020-04-23 08:17:42 -07:00
mcarare
72fe52fcb8 For #9987: Set FLAG_SECURE to dialog when flag set in activity. 2020-04-23 08:16:25 -07:00
ValentinTimisica
da3fca0f29 Fixes #10109: Adds content description for browse privately card content 2020-04-23 16:59:42 +03:00
JLRoberts
26e8d9bcca For #9550 - Don't overlap search with shortcuts text 
Private mode search with suggestion onboarding was overlapping "This time, search with: " text. Adjust constraints to allow it to show under onboarding when present.
 2020-04-23 11:21:53 +03:00
mcarare
e11f1b62dc For #10027: Make toolbar context menu popup dismissible on SDK<23 2020-04-22 22:47:46 -07:00
ekager
c4e83367f6 For #6832 - Fix various fragment not attached to a context crashes 2020-04-22 20:56:35 -07:00
ekager
6457a02a82 For #2818 - Enable PiP for all builds 2020-04-22 20:55:00 -07:00
Sawyer Blatz
95f26f1fdc
For #9946: Update FennecBeta branding (#10066) 2020-04-22 15:19:24 -07:00
Roger Yang
0227e953ae Close #9760: Add external app links context menu candidate 2020-04-22 14:45:49 -07:00
Sawyer Blatz
dce16964c0
For #9208: Adds in-product prompt to homescreen (#9836) 2020-04-22 14:29:43 -07:00
Arturo Mejia
0a23d66756 For issue #7566 Handle deny & don't ask again for site permissions 2020-04-22 11:33:32 -04:00
Arturo Mejia
995da59fa8 For issue #9493: Reload after cleaning all site permissions exceptions 2020-04-22 08:53:07 -04:00
ekager
70755adf6e For #10036 - Workaround for System Theme changes with config change 2020-04-22 00:01:54 -07:00
Michael
1f8b7ff962 Closes #8541: Hide find bar when entering fullscreen 2020-04-22 00:01:35 -07:00
Jeff Boek
164e6cd079 For #9816 - Adds SessionObserver to session on selection 2020-04-21 14:08:58 -07:00
Jonathan Almeida
6ad046714d Close #9338: Enable WebPush engine integration in all builds 2020-04-21 09:38:13 -04:00
ekager
f3847d0d7c For #8735 - Adjust fontInflation engine setting when toggling useAutoSize 2020-04-21 09:05:25 +03:00
Mozilla L10n Automation Bot
c702de05f9 Import l10n. 2020-04-21 09:04:12 +03:00
ekager
a1554834f9 Adds destructive colors for private theme 2020-04-20 23:00:41 -07:00
codrut.topliceanu
d80005235f For #8546 - Overrides for new TextInputLayout colors 2020-04-20 23:00:41 -07:00
ekager
66d9a24b28 Closes #9928 - Updates private browsing text description 2020-04-21 09:00:06 +03:00
ekager
5d51c4f059 Don't use ProcessLifecycleOwner for view-tied consume 2020-04-20 12:07:37 -07:00
ekager
f801f32027 No issue: Fix leaks in BookmarkFragment 2020-04-20 12:07:37 -07:00
ekager
5014cd78ec No issue: Fix leaking sessionControlInteractor 2020-04-20 12:07:37 -07:00
isabelrios
587bdfbd7b
For #8081 - UI screenshots tests update (#10023) 2020-04-20 10:39:56 -04:00
Ryan Kelly
8ebb891bf8 Some cleanups for running the sync integration tests 2020-04-18 02:30:44 -07:00
Grisha Kruglov
853a0acab4 Closes #4046: Always display 'Desktop' bookmarks folder 
See https://github.com/mozilla-mobile/fenix/issues/4046 for a detailed discussion of this.

In short, this patch removes code that would conditionally hide desktop bookmarks depending
on the signed-in state of the browser.
 2020-04-17 23:57:43 -07:00
Jonathan Almeida
c16283a923 For #9932: Fix navigation icon theme missing from migration UI 
Setting the `navigationBarColor` is done in the ThemeManager for the
attached activity. Since the migration UI is separate from that, we did
not get this for free.
 2020-04-17 22:45:30 -07:00
Sawyer Blatz
89cfa3ea9a For #9808: Fix scrolling cutoff on homescreen 2020-04-17 19:58:22 -07:00
Sawyer Blatz
a8e624959e
For #6940: Fixes top dynamic toolbar behavior (#9900) 2020-04-17 13:32:20 -07:00
Roger Yang
40550e88de
Close #9960: Launch URI in Fenix if failed to launch in custom tab (#9964) 2020-04-17 16:24:20 -04:00
Christian Sadilek
ec1d4e8fca For #8399: Hide keyboard to prevent content resizes 
This hides the keyboard after committing a URL in the
Toolbar right before we navigate from the SearchFragment
to the BrowserFragment. If the BrowserFragment is being
displayed before the keyboard is gone an expensive
resize of the engine view (content) is triggered when the
keyboard finally goes away. This is to prevent that.
 2020-04-17 12:07:44 -07:00
Emily Kager
d3093e4afe
For #8428 - move about text from static_strings.xml to strings.xml and fix comment (#10009) 
Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
 2020-04-17 11:50:56 -07:00
Jonathan Almeida
cab0bfc073 For #8422: Add more misc migration UI fixes 2020-04-17 14:22:25 -04:00
Michael Comella
909ee734bf For #8803 - post: update metrics & pings data review URL. 2020-04-17 09:11:58 -07:00
Michael Comella
f3ed207bdb For #8803 - review: Add clarifying comments to onAppInit capture methods. 2020-04-17 09:11:58 -07:00
Michael Comella
2888d66ce0 For #8803 - review: move forward metric expiration date. 
We primarily want to determine if this is a problem area for us to
investigate rather than a long term measurement to keep so we should set
the expiration date accordingly. Furthermore, this code executes before
crash reporting is init so it's ideal to remove it sooner rather than
later.
 2020-04-17 09:11:58 -07:00
Michael Comella
f49fc6dad2 For #8803: hook up frameworkStart metric. 2020-04-17 09:11:58 -07:00
Michael Comella
dbf733d70a For #8803: add StartupFrameworkStartMeasurement. 
This class controls the central logic around the metrics we want to
record.
 2020-04-17 09:11:58 -07:00
Michael Comella
7f618a6a7c For #8803: add Stat and test. 
We need to access the data in stat to get the process start time, so we
can calculate the time from process start until application.init for the
frameworkStart probe.
 2020-04-17 09:11:58 -07:00
Michael Comella
a0c4b33b0f For #8803: add StartupTimeline ping type and framework_start metrics. 2020-04-17 09:11:58 -07:00
Emily Kager
39107b4036
For #9703 - Exit fullscreen in onPause and onSessionSelected (#10016) 
* For #9703 - Call fullScreenChanged in onPause

* For #10015 - Exit full screen if new session selected
 2020-04-17 08:57:36 -07:00
ekager
6f77ec5951 Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver 2020-04-16 21:00:27 -07:00
Grisha Kruglov
0ec6d266e8 Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry 
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
 2020-04-16 21:00:27 -07:00
Mihai Adrian
72fe9fad0c
For #9987: Set FLAG_SECURE to dialog when flag set in activity. (#9998) 
* For #9987: Add extension to secures dialog if parent activity is secured

* For #9987: Set FLAG_SECURE to dialog when flag set in activity
 2020-04-16 20:33:57 -07:00
mozilla-l10n-automation-bot
dbbd048b6c
Import l10n. (#10011) 2020-04-16 20:32:21 -07:00
Emily Kager
1df9c53b9f
Fix: Set correct height for EditText (#10014) 
Created a dimension for the correct height that the EditText in the
fragment_edit_bookmark.xml has to have.

Co-authored-by: DrCesar <josuejacobstercero@gmail.com>
 2020-04-16 20:31:25 -07:00
Mihai Eduard Badea
725ba1e856 For #9951 - Removed the extra empty spaces that were causing the spacing issue 2020-04-16 20:12:18 -07:00
mcarare
5a2a779ef5 For #9565: Adjust padding and height to allow longer text 2020-04-16 20:10:45 -07:00
mcarare
e87ea301ab For #9536: Update tests to check opened tab is in same browsing mode 2020-04-16 19:50:25 -07:00
mcarare
83d2208c6b For #9536: Open report issue tab depending on current browsing mode. 
Checking if session is private uses the new browser state API.
 2020-04-16 19:50:25 -07:00
mcarare
8440f1867a For #9989: Add start & end margin to button. 2020-04-16 19:43:34 -07:00
Sawyer Blatz
1f8f69548a For #7158: Fixes browser to search animation fade 2020-04-16 14:03:26 -07:00
ekager
6df11619fd No issue: Uses NeutralButton for Migration Activity 2020-04-16 13:14:34 -07:00
Jonathan Almeida
2bb1b6edad For #8422: Add misc migration UI fixes 2020-04-16 12:02:02 -07:00
Jonathan Almeida
25d5b0d31c For #8422: Add spacing between migration items 2020-04-16 12:02:02 -07:00
ekager
4a06a228f3 For #9981 - Make Bookmark Menu UI respond to session selection 2020-04-16 10:49:16 -07:00
mcarare
25e12e2f77 For #9984: Update addon before settings visibility check 2020-04-16 10:25:37 -04:00
Mozilla L10n Automation Bot
3e8836f71a Import l10n. 2020-04-16 10:13:30 +03:00
ekager
688a33522b For #9516 - Adds selectable background to dialog and snackbar buttons 2020-04-16 10:13:08 +03:00
Sawyer Blatz
8185ba793e
For #9857: Create button style (#9858) 
* For #9857: Creates text button style

* Adds lint check

* Fixes onboarding cards
 2020-04-15 15:49:02 -07:00
Jonathan Almeida
997f6c72d6 For #9409: Add app icon to Leanplum push notifications 2020-04-15 17:55:12 -04:00
Jonathan Almeida
e97904662c Remove duplicate FirebasePushService 
When we moved push to it's own component the class was supposed to have
been moved but git might have only picked it up as an addition.
 2020-04-15 17:55:12 -04:00
Mihai Branescu
bded28a017
For #9420 - relaxed custom engine rules (#9967) 
Allow websites that return 404 to be added
Change long query param with one with higher changes of being found
 2020-04-15 13:20:06 -07:00
Michael Comella
f0464b9e72
For #9644: restrict deps to specific repositories (#9649) 
* For #9644: remove unnecessary leanplum maven repository.

The docs say it is [1] "only needed for Android SDK versions below 4.3.0".
That is API 18 and our min SDK is 21.

[1]: https://docs.leanplum.com/reference#android-setup

* For #9644: move buildscript block from :app to root project.

This will reduce the amount of duplication we need in specifying
restricted dependencies and centralize repository definitions. Since
we're a one project app, it shouldn't have a significant impact on
performance.

* For #9644: restrict dependencies following FFTV config.

However, there is a resolution error to be fixed in the next commit.

This is verbatim from FFTV except I removed the no-op "improve security
if code is refactored incorrectly" lines: these lines rarely changed and
I'm not that concerned. It might be better to simplify the
configuration.

Source:
  62a2fa680c/buildSrc/src/main/java/org/mozilla/gradle/Dependencies.kt (L7)
  62a2fa680c/build.gradle (L31)

* For #9644: restrict firebase deps to google repo.

This fixes the resolution error from the previous PR.
 2020-04-15 10:54:36 -07:00
ValentinTimisica
c7b123cfea
Fixes #9710: Vertically aligns users_count with rating (#9950) 2020-04-15 10:51:55 -07:00
ekager
aef827e607 For #9887 - Respect screenshot setting when resetting window flags in logins 2020-04-15 09:03:26 -07:00
Jeff Boek
06f1b6c992
No Issue - Fixes nav_graph issues (#9926) 2020-04-15 08:34:45 -07:00
Arturo Mejia
37a277febb For issue #9930 Do not assume all add-ons have a settings page 2020-04-15 06:20:34 -04:00
Mozilla L10n Automation Bot
9a298ea6ba Import l10n. 2020-04-15 03:50:48 +03:00
ekager
2056b6f2ff Update UI test to match Support Page title 2020-04-14 11:34:55 -07:00
ekager
55b04b9885 Update Server.dev to Server.stage to fix A-S upgrade breaking change 2020-04-14 11:34:55 -07:00
Arturo Mejia
8872baef39 Update Android Components version 2020-04-14 11:34:55 -07:00
Arturo Mejia
7c279b6e1f No issue: Fix add-on translate() breaking change 2020-04-14 11:34:55 -07:00
ekager
5b1cdbd8bf For #3194 - Pause media while undo snackbar appears 2020-04-14 09:55:39 +03:00
ekager
9c56a8b387 For #204 - Remove PWA Feature Flag 2020-04-14 09:55:14 +03:00
Mozilla L10n Automation Bot
69c7196e77 Import l10n. 2020-04-14 09:54:30 +03:00
Jeff Boek
4cbb9aebaf
Cleans up nav_graph.xml (#9829) 
* For #9751 - Cleans up homeFragment directions

* For #9751 - Uses global actions for fragments not owned by homeFragment

* For #9751 - Cleans up SearchFragment directions

* For #9751 - Removes settings action from DeleteBrowsingDataFragment

* For #9751 - Removes browser action from SettingsFragment

* For #9751 - Adds ManagePhoneFeature global action

* For #9751 - Clean up unused deletebrowsingfragment actions

* For #9751 - Cleans Up HistoryFragment actions

* For #9751 - Removes Home -> Search action

* For #9751 - Removes the Bookmark -> Browser action

* For #9751 - Cleans up bookmark fragment actions

* For #9751 - Cleans up actions from ShareController

* For #9751 - Removes defaultBrowserFragment to browserFragment action

* For #9751 - Removes about -> browser action

* For #9751 - Adds global action to TrackingProtectionFragment

* For #9751 - Removes exception -> browser action

* For #9751 - Removes login -> browser action

* For #9751 - Fixes LoginFragment directions

* For #9751 - Removes ExternalAppBrowser directions

* for #9751 - Cleans up actions

* For #9751 - Fixes unit tests

* For #9751 - Addresses nits in PR
 2020-04-13 21:43:45 -07:00
Arturo Mejia
eace991859 For issue #8520: Improve add-ons UI 2020-04-13 19:01:58 -04:00
ekager
b8fba63be4 For #9890 - Do not display full screen snackbar with toolbar padding 2020-04-13 14:56:51 -07:00
ekager
ac3a557ddf For #9703 - Exit full screen on pause if pip not entered 2020-04-13 14:31:57 -07:00
Sawyer Blatz
7c3394ea7c
For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs (#9893) 2020-04-13 13:08:08 -07:00
ekager
8c238402e2 For #9692 - Fix "Install" PWA menu item labeling 2020-04-13 10:09:37 -07:00
ekager
5039546dc5 For #7208 For #7212 - Update parameterized strings 2020-04-13 09:40:47 -07:00
Christian Sadilek
152642d98d Configure M2 AMO collection for Nightly/Debug 2020-04-13 10:42:39 -04:00
Oana Horvath
52857b09d7
fix #9670 intermittent tests (#9767) 
also disabled intermittent closePrivateTabsNotification
 2020-04-13 13:17:35 +03:00
mcarare
8cdc523de9 For #9698: Add unit tests for Context extension getStringWithArgSafe 2020-04-13 09:40:00 +03:00
mcarare
a214f04b4a For #9698: Use extension to ensure fallback to English and avoid crash 2020-04-13 09:40:00 +03:00
mcarare
4a1a875233 For #9698: Add Context extension to avoid format IllegalArgumentException 2020-04-13 09:40:00 +03:00
Mozilla L10n Automation Bot
e1bc8dc190 Import l10n. 2020-04-13 09:38:41 +03:00
Mugurell
b72c223244
For #7157 - Set BrowserMenu width to be max 314 dp (#9731) 
Instead of having a fixed width of 250dp the BrowserMenu will now have a
dynamic width between 250dp and 314dp allowing for a better fit for the menu
items it could display.
 2020-04-10 10:17:07 -07:00
mcarare
1881975a31 For #9793: Adjust relative positions to provide correct a11y traversal 2020-04-10 14:35:58 +03:00
Mozilla L10n Automation Bot
c31c198d54 Import l10n. 2020-04-09 17:38:37 -07:00
mcarare
177baf58a8 For #9798: Disable buttons on hiding and enable on showing. 
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
 2020-04-09 16:06:11 -07:00
Simon Chae
de311aef85
Update not yet unavailable add-on string (#9677) 2020-04-09 15:25:08 -04:00
Roger Yang
c9141c9ae5 Close #9827: Support display cutouts 2020-04-09 10:13:37 -07:00
Christian Sadilek
7f1ef17d8b No issue: Re-use existing usecases for addons 2020-04-09 12:53:47 -04:00
ekager
56eb2ec1d7 For #2818 - Adds Picture-in-Picture feature 2020-04-09 08:56:48 -07:00
Mozilla L10n Automation Bot
ed466d34f7 Import l10n. 2020-04-09 08:20:41 +03:00
Michael Comella
4437ddd536 No issue: Move Do and OpenClass to utils pkg. 
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
 2020-04-08 12:39:22 -07:00
mcarare
413af92bc5 For #9797: Set min height of dialog edit text to 48dp. 2020-04-08 10:12:20 -04:00
Abhay Agarwal
1c65bb8255 Closes #9495: Dismiss the ShareFragment in onPause() 2020-04-08 13:10:37 +03:00
Sawyer Blatz
12d486bf02
Issue #9682: Reduces size of branding (#9784) 2020-04-07 14:05:07 -07:00
Christian Sadilek
0f1bff7402 No issue: Refactor readerview to use browser-state 2020-04-07 16:31:03 -04:00
Sawyer Blatz
e94af334fc
No issue: Add more settings animations (#9750) 2020-04-07 10:44:23 -07:00
Mihai Eduard Badea
d66da53c9a For #2768 - Prevent screenshots in private mode 
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
 2020-04-07 17:23:06 +03:00
Mugurell
29539c458e For #9770 - Disable pull to refresh pending changes 2020-04-07 17:06:43 +03:00
Mozilla L10n Automation Bot
a12cb5b0c3 Import l10n. 2020-04-07 10:30:26 +03:00
Michael Comella
9305331a56 For #9631: remove assertk dependency. 2020-04-06 16:56:40 -07:00
Michael Comella
376740cd2c For #9631: replace assertk assertions with junit. 
I created a series of editor macros to do this with minimal errors (and
to do it quickly!).
 2020-04-06 16:56:40 -07:00
Jeff Boek
c632b93ee7
For #220 - Removes feature flag for language picker (#9191) 
* For #220 - Removes feature flag for language picker

* For #220 - Updates Android Components
 2020-04-06 14:29:52 -07:00
Mihai Adrian
dfded8e69c
For #9687: Refactor onboarding cards to follow app architecture (#9743) 
* For #9687: Refactor onboarding cards to follow app architecture

* For #9687: Update unit test to new controller parameters
 2020-04-06 11:00:47 -07:00
Arturo Mejia
025656d8fd For issue #9647 Crash when tapping settings after quickly 
enabling/disabling add-on
 2020-04-06 13:47:21 -04:00
Michael Droettboom
3789f50423 Fix errors in top_sites_count metric 
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.

[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
 2020-04-06 10:34:52 -07:00
Mozilla L10n Automation Bot
2d55b07935 Import l10n. 2020-04-06 12:20:41 +03:00
mcarare
cac8115e55 For #9663: Allow more than one line for onboarding card header 2020-04-03 17:47:11 -07:00
Mozilla L10n Automation Bot
9e470c93ca Import l10n. 2020-04-03 17:38:26 -07:00
Aaron Train
b35704beed Closes #9688: Disable ReaderViewTest for intermittent investigation in detection issues 2020-04-03 22:04:43 +03:00
Oana Horvath
b2da0bd922
For #9670: Disabled intermittent tabMediaControlButton test (#9679) 
and removed file created by mistake -e

added reason for disabled tests
 2020-04-03 20:39:33 +03:00
Mugurell
904bfc9ebe For #3262 - Enable pull down to refresh in Nightly 2020-04-03 19:40:08 +03:00
Michael Comella
51a76651d6 For #9605 - review: clarify comments in new test runner. 2020-04-03 09:27:49 -07:00
Michael Comella
b60a21c08d For #9605: Add LintUnitTestRunner gradle task. 
This will prevent us from regressing on adding older versions of the
unit test runner.
 2020-04-03 09:27:49 -07:00
Michael Comella
efef8eaba0 For #9605: TestApplication -> FenixRobolectricTestApplication. 
This disambiguates it from the FirefoxTestApplication used in on-device
tests.
 2020-04-03 09:27:49 -07:00
Michael Comella
8df49473c0 For #9605: move TestApplication to the helpers package. 
The helpers/ package is created to separate the test support code from
the code under test.
 2020-04-03 09:27:49 -07:00
Michael Comella
6e0d851da3 For #9605: replace unit test runners with FenixRobolectricTestRunner. 
This is how we can apply the new test runner to remove duplication.

This commit was generated programmatically with the following commands:
```
  // Replace test runners with new one.
  find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
  find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +

  // Replace imports of old test runners with new one
  find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
  find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +

  // Remove unused imports
  find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
  find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```

Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
 2020-04-03 09:27:49 -07:00
Michael Comella
b0cfa3ee5c For #9605: add FenixRobolectricTestRunner. 
This class will help us reduce duplication by specifying the
configuration within the test runner rather than each test needing to
specify it itself.

This class is adapted from Firefox for Fire TV:
  https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt
 2020-04-03 09:27:49 -07:00
Michael Comella
392dda5eda For #9605: remove unnecessary @RunWith(Robolectric in unit tests. 
robolectric increases the run time of tests so it's important to remove
them when they're unnecessary.

Between this change and the last one, the unit test runtime was reduced
by ~10s.
 2020-04-03 09:27:49 -07:00
Michael Comella
f2acef66b5 For #9605: remove unnecessary @RunWith(AndroidJUnit4) in unit tests. 
In unit tests, this annotation annotations defer to robolectric, non-trivially
increasing test runtime so it's important to remove them when they're
unnecessary.
 2020-04-03 09:27:49 -07:00
Aaron Train
cb009f915c
No issue: re-enable libraryMenuItemsTest and backButtonTest (#9639) 2020-04-03 10:37:03 -04:00
MickeyMoz
f46cfc2ad2 Update Android Components version to 38.0.20200403130109. 2020-04-03 16:15:31 +02:00
Mozilla L10n Automation Bot
8413b8133d Import l10n. 2020-04-03 16:19:33 +03:00
Michael Comella
4a8dc5b54f No issue: add kdoc to HomeActivity. 
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
 2020-04-02 16:27:00 -07:00
Sawyer Blatz
e3ed7ed268
Issue #9128 & #9222 & #9499: Refactors snackbar creation and fixes placement (#9628) 2020-04-02 12:30:13 -07:00
Codrut Topliceanu
8c43935ba3
For #7978 - Put views above button in scrollView (#8819) 2020-04-02 10:13:32 -07:00
Gabriel Luong
dc6d479da3
For #6174 - Add telemetry for WebExtensions (#8318) 2020-04-02 10:12:31 -07:00
Mihai Adrian
7043f9ee4e
For #9604: Swap and adjust margin with padding to avoid text being cut (#9617) 2020-04-02 09:40:29 -07:00
Michael Comella
c15a005ca8 No issue: remove unused FirefoxTestRunner. 
It would be used for on device tests but it doesn't seem to hooked up
currently.
 2020-04-02 07:57:09 -07:00
Mozilla L10n Automation Bot
202172cd04 Import l10n. 2020-04-02 13:42:58 +03:00
mcarare
fac61fbb41 For #9422: Nit: Fix xml indenting 2020-04-02 09:11:31 +03:00
mcarare
4d0b37a3b8 For #9422: Align widget text to viewStart to support RTL layouts 2020-04-02 09:11:31 +03:00
Emily Kager
327009efc4
For #768: Add first time PWA dialog (#9308) 
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
 2020-04-01 22:56:12 -04:00
Sebastian Kaspari
045b4a5715 Use same configuration for "forPerformanceTest" builds like we do for "fennec" flavor builds. 2020-04-01 17:51:32 -07:00
David Walsh
26137f63a2
Prevent favicons from flashing when items are selected in History (#9233) 2020-04-01 15:43:21 -07:00
Mihai Adrian
8cd6d7460c
For #9336 Check current destination before navigating (#9353) 
* For #9336 Check current destination before navigating

* For #9336 Update unit test to check for navigateSafe
 2020-04-01 15:36:56 -07:00
Mihai Adrian
90787cf630
For #9423: Align preference title and summary to viewStart (#9426) 
* For #9423: Align preference title and summary to viewStart

* Update checkbox_left_preference_etp.xml

Co-authored-by: Jeff Boek <jeff@jeffboek.com>
 2020-04-01 15:36:01 -07:00
ekager
fd60270da8 For #9533 - Switch to using enum for Library Item Selected Telemetry 2020-04-01 15:29:08 -07:00
Grisha Kruglov
8d3d030feb Closes #9553: Only update account UI state once when creating SettingsFragment 2020-04-01 15:28:39 -07:00
ekager
96c6401457 For #8125 - Send top sites count with metrics ping 2020-04-01 15:27:39 -07:00
mcarare
8c398c86ef For #9365: Partially reverse menu items order when using top toolbar 2020-04-01 15:21:22 -07:00
mcarare
b119700820 For #9365: Update naming to reflect history item 2020-04-01 15:21:22 -07:00
Kate Glazko
cca3dae290 NoIssueFixMetropolisAccountPref 2020-04-01 15:13:03 -07:00
Sawyer Blatz
208a58bc58
Issue #9598 & #8697: Fixes force expand crash (#9599) 2020-04-01 12:32:00 -07:00
codrut.topliceanu
3d1d146c94 For #9549 - Scrolling to top sites now includes header. 2020-04-01 10:28:04 -07:00
mcarare
a2ea53d8f2 For #9574: Remove category layout from LeakCanary SwitchPreference 2020-04-01 10:17:21 -07:00
ekager
4159cd3da7 Closes #9564 : Fixes cut off strings in ETP panel 2020-04-01 10:16:51 -07:00
Mihai Branescu
24596fd3cd For #9109 - remove the sync error highlight from three-dot menu 2020-04-01 10:42:00 +03:00
Kate Glazko
d9d5de98c9 For 3687 Use Metropolis Font for Header 2020-03-31 19:31:15 -07:00
Mozilla L10n Automation Bot
9043120dd7 Import l10n. 2020-03-31 17:52:51 -07:00
Grisha Kruglov
54b7fd8834 Make sure reconnect item is displayed in HomeMenu in case of account problems 
AccountObserver listeners were being triggered correctly, however, during every time
we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
block. Before this patch, the init block would never touch the account manager.
After this patch, it will query it if account manager has already been initialized.
 2020-03-31 16:07:35 -07:00
Grisha Kruglov
60943df6d9 Closes #9561: Fix initialization order in HomeMenu 
`init` blocks are executed before `val` initialization which is declared afterwards
in the class. In this case, we had `quitItem` and `reconnectToSyncItem` as lazy,
but declared after the `init` block which may need them. And so, while this compiles
just fine, in practice we run into an NPE as the `init` block tries to get the lazy's value.

Simply re-ordering initialization fixes the problem.
 2020-03-31 16:07:35 -07:00
Arturo Mejia
804eb0f5ba For issue #8520: Polish Add-on manager UIs 2020-03-31 17:20:20 -04:00
Sawyer Blatz
1a2b65d854
Issue #9472: ForceExpand browser toolbar when navigating (#9552) 2020-03-31 11:16:40 -07:00
Oana Horvath
5f68d6cb29
Updated the method to verify system notifications and added new tests for media notifications (#9330) 2020-03-31 21:11:41 +03:00
ValentinTimisica
cee34893ed
For #8412: Passes error handling function to 'CustomTabWindowFeature' (#8903) 
* For #8412: Passes error handling function to 'CustomTabWindowFeature'

Change required for showing error message when the app can't handle a specific
scheme. Implemented in AC:
https://github.com/mozilla-mobile/android-components/pull/6122

* Upgrade AC version

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
 2020-03-31 10:17:29 -07:00
Grisha Kruglov
f76acc5db1 Closes #9530: Don't crash on failed avatar fetches 2020-03-31 09:17:17 -07:00
Mozilla L10n Automation Bot
fd263d8329 Import l10n. 2020-03-30 22:00:19 -07:00
Grisha Kruglov
6c38b77315 Part 6: Kick-off account manager initialization after visual completeness 
In order to hide the time it takes for the account manager to be initialized
(which always involves disk IO, and often network IO), let's kick it off
after "visual completeness".
This makes sure that for most users, by the time they interact with the account
manager-related functionality (e.g. in Settings), it's ready to go.

Also, for signed-in users, this will establish background sync workers.
 2020-03-30 21:43:38 -07:00
Grisha Kruglov
057e28d4e4 Part 5: Refactor HomeMenu<->HomeFragment interaction 
This refactor "reverses" relationship between these two classes, allowing
HomeMenu to inform its parent, HomeFragment, of any changes to the menu.

Once that's in place, we start observing account manager changes (once its ready)
for account problems.

This solves two problems:
- initialization of the account manager is no longer necessary to build a home menu
- home menu now starts observing changes to the account manager's state (before it was static)
 2020-03-30 21:43:38 -07:00
Grisha Kruglov
029fae4559 Part 4: Make sure 'sync is on' snackbar does not initialize account manager 2020-03-30 21:43:38 -07:00
Grisha Kruglov
eb98df4edd Part 3: Mark accountManager as 'lazy' in Mode.kt 
This is enough to cause it to be initialized only if we're going through onboarding.
 2020-03-30 21:43:38 -07:00
Grisha Kruglov
3efaa516ca Part 2: Do not eagerly initilize account manager within HomeActivity 
Instead of always kicking off accountManager's init and telling it to sync right away in
'onResume', we move these tasks to some abstract point later on, whenever account manager
is available.
 2020-03-30 21:43:38 -07:00
Grisha Kruglov
0677fc35de Part 1: Add 'accountManagerReady' queue to BackgroundServices 
This gives us an ability to perform tasks against 'accountManager' without
causing its immediate initialization.
 2020-03-30 21:43:38 -07:00
Grisha Kruglov
be1fa8df7d Pre: introduce a RunWhenReadyQueue 
This replaces the StartupTaskManager we had with a more general class.
New implementation is a thread-safe "gated task executor", which either
runs the task right away if it's marked as 'ready', or queries it to be
executed later on.

This ability to either execute or queue a task will be useful later on in the
commit series.
 2020-03-30 21:43:38 -07:00
Aaron Train
4d139d52c4
Closes #9189: Fixes "static asset not found" error in doNotSaveLoginFromPromptTest, saveLoginFromPromptTest UI tests (#9439) 
AndroidAssetDispatcher class dispatcher was attempting to open a local asset with a query suffix from the request. If query suffix is found, remove it. Re-enable saveLoginFromPromptTest() and doNotSaveLoginFromPromptTest()
 2020-03-30 18:01:58 -04:00
David Walsh
9679b91e82 For #9525 - Add bottom margin to top sites header 2020-03-30 14:48:45 -07:00
Sawyer Blatz
4ac29530cd
Issue #9132: Update to search animation for top toolbar (#9524) 
* let animation in top toolbar mode play nicely.

* remove duplicate methods, make code readable.

* migrate getToolbarNavOptions method to BrowserAnimator, one method to rule them all.

* Update linting

Co-authored-by: ahmedmamdouh13 <ahmedmamdouh13196@gmail.com>
 2020-03-30 12:07:00 -07:00
ekager
3d55578242 Use existing strings for announcement 2020-03-30 11:10:40 -07:00
asavill
c383d4225e Closes #7720: 
- Increased atp switch size to be consistent with `dimen/tracking_protection_item_height`(48dp).
- Cut out redundant traversal of TextViews in SwitchWithTraversal as per https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md
- Reuse `QuickSettingsText.Icon` style on the switch component to be consistent with other items in the component_tracking_protection_panel.xml
- Added new string resources for textOff and textOn state to get appropriate screen reader description (unsure of the translation/localisation process here!)
 2020-03-30 11:10:40 -07:00
David Walsh
e1187ebf31 For #7059 - Allow search engines to scroll 2020-03-30 10:31:39 -07:00
David Walsh
d989616f62 Add top sites heading to home screen 2020-03-30 10:29:40 -07:00
mcarare
76f15a1f7f For #9498: Update unit tests with new constructor argument 2020-03-30 09:56:51 -07:00
mcarare
f52fa44207 For #9498: Replace navargs with viewModel to remember if scroll to tab 2020-03-30 09:56:51 -07:00
mcarare
ab78951146 For #9496: Vertically align collection name and icons to collection icon 2020-03-30 08:30:06 -07:00
Simon Chae
e820a35f56 Update NotYetSupported add-ons copy 2020-03-30 10:36:49 -04:00
codrut.topliceanu
1e63d6ce76 For #9500 - Revert patch for 8568 
The patch for 8568 introduced this regression.
Let's just revert it until we can come up with a better solution.
 2020-03-30 07:20:13 -07:00
Sebastian Kaspari
02aabea14a Update to new feature-media API. 2020-03-29 23:13:13 -07:00
Mozilla L10n Automation Bot
cd7c2c4bd5 Import l10n. 2020-03-29 12:32:40 -07:00
Edouard Oger
394f386ac3 Add secret debug menu to override FxA servers 2020-03-27 22:59:14 -07:00
mcarare
18533d3434 For #8764: Use list component for items in collections 2020-03-27 22:14:59 -07:00
mcarare
62bbbd9e37 For #8764: Update collection design, including list elements 2020-03-27 22:14:59 -07:00
mcarare
38a97cd1e0 For #9252: Add progress bar to saved logins view 2020-03-27 22:13:58 -07:00
mcarare
f3bbcc4e17 For #9252: Update views visibility ony when list has finished loading 2020-03-27 22:13:58 -07:00
Arturo Mejia
f9cc2ccfe2 For issue #8017 enable SitePermissionsWifiIntegration 2020-03-27 20:44:16 -04:00
Mozilla L10n Automation Bot
75aba7a2b4 Import l10n. 2020-03-27 17:33:26 -07:00
codrut.topliceanu
ba39a46b88 For #8568 - Refocus URL editText in SearchFragment onResume 2020-03-27 17:24:14 -07:00
Amaan Marfatia
3dcfed3761 AboutPageAdapter doesn't use notifyDataSetChanged() 
We make the AboutPageAdapter inherit from a ListAdapter so that we don't use notifyDataSetChanged().
 2020-03-27 17:23:27 -07:00
David Walsh
180652deab No issue - Make fill link from clipboard divider stretch full screen 2020-03-28 02:10:18 +02:00
mcarare
677a9da5ec For #8485 Update UI tests after settings reorg 2020-03-27 17:05:49 -07:00
mcarare
edabf9c865 For #8485 Move Remote debugging and LeakCanary to Advanced section 2020-03-27 17:05:49 -07:00
mcarare
012e318724 For #8968: Hide keyboard when navigating away from browser 2020-03-27 16:44:11 -07:00
ValentinTimisica
3647606aae Fixes #9280: Remove tabs fade in animation when pressing on Add new collection 2020-03-27 15:54:24 -07:00
Mugurell
9f3bbf1fb7 For #8651 - Add HistoryInteractor/Controller unit/ui tests 2020-03-27 15:53:31 -07:00
Mugurell
fc0260d6ee For #8651 - Ensure FenixSnackbar has a proper root for inflating into 
FenixSnackbar, as the platform Snackbar can only be inflated in either a
`CoordinatorLayout` or a `FrameLayout`.
Ensure our HistoryFragment's layout uses one of these as it's root.
 2020-03-27 15:53:31 -07:00
Mugurell
a1cdd31f0c Fix #8651 - Add new menu actions for a history item 
We'll now also support:
- Copy url
- Share to another FXA device
- Open in new tab
- Open in private tab
 2020-03-27 15:53:31 -07:00
mcarare
b77f92f9d1 For #9435: Adjust margins and paddings to mirror correctly in RTL 2020-03-27 14:45:47 -07:00
Mihai Branescu
3f12c1cdb9 Closes #9352 - changed capitalisation of 'Open in app' 2020-03-27 14:43:32 -07:00
David Walsh
28406eaf3d No issue - Add content descriptions when missing 2020-03-27 14:41:51 -07:00
mcarare
e8ad2389ac For #7356: Scroll to selected tab when pressing tab overview 2020-03-27 14:13:26 -07:00
ekager
414e905b76 Closes #8944 - Adds custom lint checks 2020-03-27 13:59:51 -07:00
Sawyer Blatz
06e5efd03e
No issue: Removes settings entrance animation for now (#9443) 2020-03-27 09:55:24 -07:00
Mihai Eduard Badea
91690d7b48 Replaced name field with search string field 2020-03-27 16:38:59 +02:00
ValentinTimisica
69e8a2f357 Fixes #4987: Remove close tabs functionality when they are added to a collection 2020-03-27 15:42:17 +02:00
ValentinTimisica
a72d50d78f Fixes #7734: Remove animation for back button 2020-03-27 15:37:33 +02:00
Mozilla L10n Automation Bot
5894999f28 Import l10n. 2020-03-27 09:43:08 +02:00
Sawyer Blatz
6065ff85a1
No issue: Fixes indentations on several settings fragments (#9442) 2020-03-26 14:52:08 -07:00
Christian Sadilek
5e9d5dd545 Closes #9414: Make AMO collection configurable 2020-03-26 17:26:20 -04:00
Grisha Kruglov
9e324fa02a Perform storage warm-up after visual completeness 2020-03-26 14:12:35 -07:00
Grisha Kruglov
20f8b97dcb Pass lazy references to FennecMigrator 2020-03-26 11:57:45 -07:00
Sebastian Kaspari
0f0d56e60a Issue #5208: Use new tab/collection restore API. 2020-03-26 10:55:12 -07:00
Mihai Branescu
73a7330b2b For #9395 - Trimmed name for custom search engines 2020-03-26 09:35:23 +02:00
Mozilla L10n Automation Bot
5a9be5e053 Import l10n. 2020-03-26 08:54:04 +02:00
Jonathan Almeida
40ba43311e For #7661: Add deeplink schemas for fennec variants 2020-03-25 15:39:44 -04:00
Arturo Mejia
f785a07ef9 No issue: Add add-on updater information dialog 2020-03-25 13:57:51 -04:00
ValentinTimisica
eb5303fa48 Fixes #8288: Adds content description for ETP back button 2020-03-25 13:18:41 +02:00
Mozilla L10n Automation Bot
d2c23f21cc Import l10n. 2020-03-25 13:12:34 +02:00
Christian Sadilek
d184b99649 Closes #9333: Prevent compression of omni.ja to improve startup time 
Co-authored-by: Markus Stange <mstange@themasta.com>
Co-authored-by: Agi Sferro <agi@sferro.dev>
 2020-03-24 16:10:11 -07:00
Mihai Branescu
a23bcebb5d For #8972 Replaced purple colors to match the rest of the app 2020-03-25 00:13:59 +02:00
Mihai Branescu
494db56ea5 For #9207 - changed status bar color in home fragment to match gradient background 2020-03-24 23:44:46 +02:00
Arturo Mejia
fa9dae0d72 For issue #9364 Crash when blocking app permissions and returning to 
the app
 2020-03-24 13:44:54 -07:00
ekager
eea6eb0c4c Add toolbar padding for bookmark snackbar 2020-03-24 13:33:50 -07:00
ekager
16b40992d2 For #9351 - Show snackbars with toolbar padding to work with dynamic toolbar 2020-03-24 13:33:50 -07:00
Arturo Mejia
5e75140b3d For issue #8809 Notification permissions can't be disabled/re-enabled 
unless you restart the browser
 2020-03-24 15:25:33 -04:00
Arturo Mejia
b484ad38cc No issue: Remove feature flag for removing one TP exception 2020-03-24 11:14:07 -04:00
mcarare
55ea92be5b For #8759 Update Unit tests with activityName instead of packageName 2020-03-24 17:10:19 +02:00
mcarare
7fbb1640b6 For #8759 Use activityName instead of packageName as app identification 2020-03-24 17:10:19 +02:00
Aaron Train
f23b9fcb89
Closes #9346: Add ViewIdlingResource for Reader View UI tests (#9347) 2020-03-24 10:47:11 -04:00
ValentinTimisica
79dc133c9c For #9359: Revert 8491. 
In the UX review of 8491 it was discovered that the proposed solution is not
optimal and we should actually better stick with the old implementation.

This ticket comes to help with that and revert the already merged patch for
8491 and so will add same gradient to the top toolbar as the bottom toolbar.
 2020-03-24 15:12:56 +02:00
Mozilla L10n Automation Bot
8be6c77695 Import l10n. 2020-03-24 09:44:22 +02:00
Arturo Mejia
301f56d144 For issue #9334 Fix Remove of one exception is deleting all 2020-03-23 20:04:04 -04:00
exobyte101
dee1d92293 Remove extra transparent space from widget preview image 2020-03-23 16:54:35 -07:00
exobyte101
746a11c30f Closes #4766: Adjust search widget min height and width according to guildelines 2020-03-23 16:54:35 -07:00
Sawyer Blatz
9feb44852b
For #9256: Attempts to fix installation ping not being sent (#9331) 2020-03-23 14:27:28 -07:00
Kate Glazko
47b2f6a070 For 7077 Simplify Display Url 2020-03-23 12:36:48 -07:00
codrut.topliceanu
9059a6b465 For #6317 - Applies 3dot menuItem look to quickSettings and tracking panel 2020-03-23 12:26:52 -07:00
Aaron Train
f8048462b5
Closes 9291: Fix shortcutSearchEngineSettingsTest (#9292) 2020-03-23 11:04:10 -04:00
Mozilla L10n Automation Bot
db1a093661 Import l10n. 2020-03-23 10:15:56 +02:00
Amaan Marfatia
7236913d94 Closes #7761: Makes the Parent Folder Selector height 48dp for touch accessibility 2020-03-22 00:10:09 +02:00
Mihai Branescu
ab04155222 For #8653 - changed menu strings 2020-03-22 00:03:26 +02:00
mcarare
14338a3b13 For #8899: Set viable anchor for snackbars in both custom and normal tab 2020-03-20 22:46:59 -07:00
ValentinTimisica
8871c05c9d Fixes #9243: Remove tabs fade in animation when pressing on Save to Collection 2020-03-20 22:44:31 -07:00
David Walsh
681d6cf8a1 For #8652 - Allow sharing multiple bookmarks 2020-03-20 20:28:36 -07:00
David Walsh
27502bdd34 For #9177, #8248 - Hide empty verified by block when no cert 2020-03-20 19:40:51 -07:00
Mozilla L10n Automation Bot
930c74a42a Import l10n. 2020-03-20 19:40:15 -07:00
Severin Rudie
35a132d7ff
8017 advanced autoplay controls. (#8978) 
* For #8017: add advanced autoplay controls
 2020-03-20 12:10:42 -07:00
Elise Richards
5d8a9bb4be
For #8592: Relocate device name in account preferences. Deactivate device name field while syncing. (#9255) 2020-03-20 12:32:04 -05:00
Sawyer Blatz
a356b4b2c4
For #9136: Send all adjust properties to glean (#9253) 2020-03-20 10:06:55 -07:00
Mugurell
21606bf94f For #8693 - Add rtl onboarding toolbar position picker images 2020-03-20 09:48:04 -07:00
Mugurell
1dca146e4f For #8693 - Add rtl onboarding theme picker images 2020-03-20 09:48:04 -07:00
Aaron Train
8f37977e79
Closes #9262: Add additional waits to LibraryMenuTest (#9263) 2020-03-20 12:16:50 -04:00
ValentinTimisica
fbeff33ef5 Fixes #8491: Changed toolbar background for PBM when is set to top 
This change was required so that the background of the toolbar match the
homeFragment gradient
 2020-03-20 17:13:19 +02:00
Mozilla L10n Automation Bot
e97387257b Import l10n. 2020-03-20 10:51:47 +02:00
Mozilla L10n Automation Bot
310b3caf70 Import l10n. 2020-03-19 16:25:18 -07:00
Sawyer Blatz
b9059c8208
For #9256: Attempts to fix installation ping not being sent (#9254) 2020-03-19 16:22:28 -07:00
Sebastian Kaspari
0198305bfb MigrationPushRenewer: Remove ExperimentalCoroutinesApi. 2020-03-19 16:11:53 -07:00
Grisha Kruglov
e541e10427 Initialize storage after visual completeness 
In order to eat the perceived performance costs, we initialize storage
once we're visually complete. This way, we're reducing chances of user performing
a UI action which will trigger storage init and delay said action.
 2020-03-19 15:46:50 -07:00
Grisha Kruglov
eb14532c3c Closes #7450: Lazy storage initialization 
Make sure that we actually lazily initialize our storage layers.

With this patch applied, storage layers (history, logins, bookmarks) will be initialized when first
accessed. We will no longer block GeckoEngine init, for example, on waiting for the logins storage
to initialize (which needs to access the costly securePrefStorage).
Similarly, BackgroundServices init will no longer require initialized instances of the storage
components - references to their "lazy wrappers" will suffice.

In practice, this change changes when our storage layers are initialized in the following ways.
Currently, we will initialize everything on startup. This includes loading our megazord, as well.

With this change, init path depends on if the user is signed-into FxA or not.

If user is not an FxA user:
- on startup, none of the storage layers are initialized
- history storage will be initialized once, whenever:
  - first non-customTab page is loaded (access to the HistoryDelegate)
  - first interaction with the awesomebar
  - history UI is accessed
- bookmarks storage will be initialized once, whenever:
  - something is bookmarked, or we need to figure out if something's bookmarked
  - bookmarks UI is accessed
- logins storage will be initialized once, whenever:
  - first page is loaded with a login/password fields that can be autofilled
  - (or some other interaction by GV with the autofill/loginStorage delegates)
  - logins UI is accessed
- all of these storages will be initialized if the user logs into FxA and starts syncing data
  - except, if a storage is not chosen to be synced, it will not be initialized

If user is an FxA user:
- on startup, none of the storage layers are initialized
- sometime shortly after startup is complete, when a sync worker runs in the background, all storage
layers that are enabled to sync will be initialized.

This change also means that we delay loading the megazord until first access (as described above).
 2020-03-19 15:46:50 -07:00
mcarare
e4acabb329 For #8600:Increase space below left checkbox preference 2020-03-19 15:41:05 +02:00
mcarare
a098b66d26 For #8591: Allow items in quick_action_sheet to be read by a11y services 2020-03-19 15:18:40 +02:00
mcarare
756b1fbadd For #9140: Remove drawable from title in empty state panes 2020-03-19 14:32:40 +02:00
Ryan Kelly
a0f8be25b6 Add support for application-services autoPublish local dev workflow. 2020-03-19 10:51:08 +02:00
Arturo Mejia
7dff584b82 Remove @ObsoleteCoroutinesApi from tests 2020-03-18 17:25:51 -07:00
Arturo Mejia
823eea44ed No issue: Add serverConfig param to FxaWebChannelFeature 2020-03-18 17:25:51 -07:00
Arturo Mejia
e977486809 Remove @UseExperimental for usages of the flow api 2020-03-18 17:25:51 -07:00
mcarare
4425e7139e For #9200: Remove star icon from empty state icon in toolbar 2020-03-18 10:23:50 -07:00
mcarare
772c7062fd For #8814: Change icon asset for top sites menu option 2020-03-18 08:30:33 -07:00
Mozilla L10n Automation Bot
937e1cd2e6 Import l10n. 2020-03-18 15:02:07 +01:00
Jonathan Almeida
ffd4cdd970 For #7661: Add variant-specific schemas for deep links 
In order to target specific variants of Fenix, we're adding schemas that
are specific that app in order to avoid collisions with the other
variants and with other forks of fenix that may have the same schemas.

The current schema for variants:
 - Fenix Nightly: `fenix-nightly://`
 - Fenix Beta: `fenix-beta://`
 - Everything else: `fenix://`
 2020-03-17 17:21:09 -04:00
Sawyer Blatz
b4e1360f59
For #3086: Adds settings animations (#9187) 2020-03-17 12:35:00 -07:00
Christian Sadilek
0d974fe262 For #8808 #9139: Add-on should be able to configure how to open options page 2020-03-17 12:34:07 -04:00
Edouard Oger
a1ea94fe76 Prepare for a-c a-s upgrade 2020-03-17 11:49:54 -04:00
Sebastian Kaspari
34144fd254 Use pinned Android Components Nightly version instead of snapshots. 2020-03-17 12:09:36 +01:00
Severin Rudie
3e38b002dd
No issue: fixes test broken by snapshot (#9176) 
* No issue: fixes test broken by snapshot

* No issue: ignore flaky tests
 2020-03-16 16:44:39 -07:00
Christian Sadilek
63517a52e4 No issue: Remove unneeded logic to adjust TP 2020-03-13 14:08:49 -04:00
isabelrios
74433ba27a
ui-tests-homescreen-fix-to-enable (#9050) 2020-03-13 11:16:47 -04:00
Mozilla L10n Automation Bot
dd38f1df0a Import l10n. 2020-03-13 07:45:13 -07:00
Jonathan Almeida
3d387e2dde Add nightly-only feature flag for WebPush integration 2020-03-12 18:39:32 -07:00
codrut.topliceanu
030bd38631 For #8561 - Scroll to topSites on app cold start 2020-03-12 10:54:58 -07:00
Sawyer Blatz
cc8f34b68b
For #8773: Fixes issue with snackbar placement on ContextMenu (#8942) 2020-03-12 09:54:13 -07:00
Roger Yang
9a582a6983
Closes #9104: Pass release channel information to Socorro service (#9130) 2020-03-12 12:00:14 -04:00
isabelrios
97b5754562
For #9076 - Upddate pipenv to run without error. (#9077) 
* For #9076 - Upddate pipenv to run without error

* pipenv fixed the issue after update
 2020-03-12 11:36:51 -04:00
Jeff Boek
c862ca93ba No issue - Fixes shadow on top layout 2020-03-11 22:59:42 -07:00
Jeff Boek
74ce62b5c3 For #8949 - Removes old motionlayout code, fixes how shadow is drawn 2020-03-11 17:10:40 -07:00
David Walsh
fc67747409 Show the collections header when there are no collections 2020-03-11 16:26:39 -07:00
ekager
31cc7d9166 For #8897 - Don't remove all external sessions on back press 2020-03-11 14:04:27 -07:00
Michael Comella
5bd0369aed No issue: remove unused HotStartPerformanceMonitor. 
This monitor for hot start was intended to be used by FNPRMS to measure
hot start. However, hot start was deprioritized so it's now essentially
unused.
 2020-03-11 11:28:38 -07:00
Mihai Branescu
b0e4453fb7 For #8800 - add tests for dismissing highlighted items 2020-03-11 19:05:55 +02:00
Mihai Branescu
485efacd33 For #8800 - dismiss all highlights when menu is closed 2020-03-11 19:05:55 +02:00
Severin Rudie
1381444a52 For #8800: clear menu highlights on use 2020-03-11 19:05:55 +02:00
mcarare
95a89f9dba For #8474 Remove obsolete unit tests for removed menu items 2020-03-11 09:52:28 -07:00
mcarare
2ffbecaefa For #8474 Reorganize browser menu items 2020-03-11 09:52:28 -07:00
Arturo Mejia
ce4293c8c8 For issue #8908 Notify users when previously unsupported add-ons 
become available
 2020-03-11 11:24:01 -04:00
Severin Rudie
e86120027f For #9091: fix test failure 2020-03-11 14:51:05 +01:00
ekager
709bf6f627 For #7087 - Add SearchView to Logins Fragment 2020-03-10 23:01:51 -07:00
ekager
d5f4444447 No issue: Remove useContentProcessHint from GV beta GeckoProvider 2020-03-10 22:33:11 -07:00
Severin Rudie
8663c479dc
For #8017: remove redundant string per localization team (#9068) 
Based on conversation in https://github.com/mozilla-mobile/fenix/pull/8953#issuecomment-594332067
 2020-03-10 13:29:24 -07:00
ekager
feb6215fae For #8296 - Adds user account avatar to Account Preference 2020-03-10 11:19:22 -07:00
Emily Kager
93bc87e273
For #7270 - Do not overlap long logins items (#9013) 2020-03-10 09:39:50 -05:00
Oana Horvath
7e9811b20c
Close private tabs tests (#8999) 2020-03-10 11:44:21 +02:00
Jonathan Almeida
ef42becbf9 For #9059: Add WebPush engine integration 2020-03-09 16:50:29 -04:00
ekager
667ebe3142 For #8967 - Remove ability to pref login autofilling by itself 2020-03-09 13:19:47 -07:00
mcarare
320fc4e4ae For #8788 Use Flexbox instead of Grid manager for top sites 2020-03-09 11:01:14 -07:00
mcarare
a581486e1c For #8985 Fix Share Menu display when having recently used list. 
Allow for All Actions recyclerview to scroll to end.
Adjust padding for views.
 2020-03-09 10:48:02 -07:00
Emily Kager
93cb3c2053
For #8423 - Adds delete login confirmation dialog (#9014) 2020-03-09 15:51:18 +02:00
mozilla-l10n-automation-bot
2563346f07
Import l10n. (#9041) 2020-03-09 14:56:32 +02:00
Mozilla L10n Automation Bot
23456834ba Import l10n. 2020-03-06 20:24:51 -08:00
David Walsh
0436c8d8a4 For #8874 - Update tab deletion colors 2020-03-05 21:21:37 -08:00
Mozilla L10n Automation Bot
2aef886591 Import l10n. 2020-03-05 21:19:42 -08:00
mcarare
7ae1304612 For #8975: Update unit tests for new separator between title and url 2020-03-05 21:17:36 -08:00