Commit Graph

1909 Commits

Author SHA1 Message Date
Sawyer Blatz
2896b36d14
No issue: Updates naming of launch links privately var (#5701)
The previous name was pretty confusing
2019-10-02 12:11:21 -07:00
Sawyer Blatz
eb3c9f86e2
No issue: Removes feature flags for delete data (#5738) 2019-10-02 10:43:37 -07:00
Sawyer Blatz
2f0d8d8243 For #5712: Updates text color for fill link from clipboard 2019-10-01 16:29:39 -07:00
Emily Kager
f7c9ab11eb For #3487 - Add back open image in new tab 2019-10-01 12:45:09 -07:00
Michael Droettboom
a250241523 1585250: Initialize metrics off of the main thread 2019-10-01 10:29:54 -07:00
Sawyer Blatz
669e694af9 For #5672: Fixes broken send tab link 2019-09-30 16:13:40 -07:00
Axel Hecht
214ca421f7 Import strings from android-l10n
State: mozilla-l10n/android-l10n@10559d774c
2019-09-30 16:10:08 -07:00
Sawyer Blatz
69c42b6192 For #5681: Sets OPEN_TO_BROWSER false when using new tab shortcut 2019-09-30 14:56:16 -07:00
ekager
7dab810ee6 For #5534 - Make FIP Robot Wait for Text Changes 2019-09-30 13:17:29 -07:00
Emily Kager
e9a0f1f65d For #2078 - Filter Out Self in Share Sheet (#5641) 2019-09-30 12:43:47 -07:00
Sawyer Blatz
c8af16bd47
For #5679: Hides autoplay behind feature flag (#5685) 2019-09-30 12:01:04 -07:00
ekager
ef29fe2584 Update BackgroundServicesTest, Suppress Complex Method 2019-09-30 10:33:56 -07:00
Grisha Kruglov
a4097cd380 FxA WebChannels integration
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971)

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-30 10:33:56 -07:00
Chenxia Liu
8f97d247a6 For #235 - Add Glean crash count + docs. 2019-09-30 08:32:33 -07:00
Sawyer Blatz
3e42114190 For #5656: Fixes nightly major version number crash 2019-09-27 15:06:57 -07:00
Sawyer Blatz
a38b73f19e Fixes #5653: Removes crash with null campaign 2019-09-27 15:01:00 -07:00
mcarare
64923978e6 For #1071 Added Desktop Mode icon 2019-09-27 09:47:10 -07:00
Sawyer Blatz
5e18ead45e For #4474: Adds tests and fixes issues 2019-09-27 08:59:05 -07:00
Tiger Oakes
ee1f040e53 No issue: Move signedIn tracking to BookmarksSharedViewModel (#4755) 2019-09-27 08:57:38 -07:00
Sawyer Blatz
7f328a6dc4
For #1298: Adds adjustCampaignId to core ping (#5579) 2019-09-27 08:56:33 -07:00
Sawyer Blatz
6babf72352
For #5197: Adds telemetry for media notification (#5520) 2019-09-27 08:02:29 -07:00
Tiger Oakes
88aa519210 Closes #4711 - Extract VoiceSearchActivity (#5502) 2019-09-27 07:54:29 -07:00
Emily Kager
3f41a4e9c6 No issue: Update navigation library 2019-09-26 17:01:13 -07:00
Sawyer Blatz
11baabb63a No issue: Updates fact mapping to use enums 2019-09-26 17:00:51 -07:00
Emily Kager
c3287b17ac Closes #5624 - Fix crash on preference change listener 2019-09-26 16:56:54 -07:00
Mihai Adrian
62ae025d65 For #4991:Ensured deleteSelectedBookmarks deletes all selected bookmarks (#5559)
Moved the deletion to a CoroutineScope(IO) to decouple from fragment lifecycle
Used local val tempStorage to keep reference to bookmarkStorage of outside class
Ran deletions with awaitAll to avoid concurrency issues on storage
2019-09-26 16:52:59 -07:00
Severin Rudie
dffa61bf16 Closes #4513: fixes bookmark tests broken by loading change
Note that BookmarkFragmentStoreTest changes preserve existing behavior, which in many cases is more expansive than the test name implies
2019-09-26 16:29:14 -07:00
Severin Rudie
fd7f1b2665 Closes #4513: adds tests for bookmark loading state 2019-09-26 16:29:14 -07:00
Severin Rudie
fbdd537bc7 Closes #4513: show progress bar when loading bookmarks 2019-09-26 16:29:14 -07:00
Severin Rudie
ca6c324f29 Issue #4513: added isLoading to bookmark state
This was added to the state object as a top level param because it could reasonably coexist with any value of `tree` or `mode`. Even if we don't now, we may someday want to display a loading indicator while also showing cached bookmarks.

For now, we set isLoading to false whenever we receive any bookmarks
2019-09-26 16:29:14 -07:00
Severin Rudie
5e8798e89c Issue #4513: add ProgressBar to bookmark component layout 2019-09-26 16:29:14 -07:00
Severin Rudie
96472a533a Issue #4513: fix mismatched bookmark listener lifecycles
The mismatch here was creating potentially inconsistent states. When first put into a CREATED or STARTED state, the listener would not be active, however after going through onResume it would then stay active until destroyed.

We should only be navigating to bookmarks when in a RESUMED state, so this change should be safe. I tried it a few times to verify. But I've been wrong before!
2019-09-26 16:29:14 -07:00
Colin Lee
de93b05cac For #2754 Add tab cards to share sheet (#5493)
* For #2754 Add tab cards to share sheet

* For #2754: Fix background near rounded corners and ShareButtonAppearanceTest

* Add license to share_tab_item
2019-09-26 14:25:34 -07:00
Christian Sadilek
ac2611d744 Upgrade to A-C 15.0.0-SNAPSHOT (incl. required changes) (#5578)
* Upgrade to Mozilla Android components 15.0.0-SNAPSHOT

* Update findinpage integration to use browser-state

* Use new UseCases APIs after download migration.
2019-09-26 12:50:50 -07:00
Mugurell
c5330c6880 For 5092 - Show a Snackbar with retry option if sharing to devices fails (#5158)
* For #5092 - Show a Snackbar with retry option if sharing to devices fails

ShareController will contain all the business logic for checking the result
status of the `share to device` operations. When this fails it will show a
snackbar which also offer the possibility to retry the just failed operation.
To allow this even in the event the user has closed the share fragment we'll
use a GlobalScope's coroutine.
Refactored out the TabsSharedCallback from ShareFragment because otherwise we
would have neede to sent through that the just failed operation. After the
refactor the ShareController is solely responsable for showing the right
snackbar and handling the retry actions.

* For #5092 - Refactor ShareControllerTest

* For #5092: Adds color theming of snackbars
2019-09-26 12:30:28 -07:00
Yeon Taek Jeong
59e2c124cb No issue: Update long-press shortcut strings (#5284)
* No issue: Update long-press shortcut strings

* Updates identifiers
2019-09-26 11:57:37 -07:00
ekager
0b01635ce0 For #2874, #5375, #5131 - submitList workaround for Android 5 + 6 2019-09-25 19:59:07 -07:00
Agi Sferro
365936b8df For #5529: Enable about:config in geckoNightly. 2019-09-25 16:17:09 -07:00
ekager
44bb592b43 For #5312 - Send ETP Strict/Standard event 2019-09-25 15:23:30 -07:00
ekager
24b3ed4384 For #5568 - Don't pass in Session for QuickActionSheetController 2019-09-25 13:33:38 -07:00
Emily Kager
b0b60aa27d For #5281 - Use TrackerLog for reporting ETP categories (#5556) 2019-09-25 10:48:06 -07:00
Sawyer Blatz
b6e6e36ccd For #561: Fix stutter of search icon & text when animating 2019-09-25 10:06:38 -07:00
Sawyer Blatz
75a25c9bd0 For #561: Fix linting issue 2019-09-25 10:06:38 -07:00
Jeff Boek
c592a69aad For #561 - Fixes snackbar placement on homeview 2019-09-25 10:06:38 -07:00
Jeff Boek
32c506121e For #561 - Fixes visual inconsistencies with the search bar 2019-09-25 10:06:38 -07:00
Jeff Boek
5c092c1ef1 For #561 - Adds shadow/highlightto the bottom bar 2019-09-25 10:06:38 -07:00
Jeff Boek
00d1be97ac For #561 - Wires up add tab button inside the bottom bar 2019-09-25 10:06:38 -07:00
Jeff Boek
b16754d78a For #561 - Adds add tab and menu button to bottom bar
- Adds space between wordmark and session control component
2019-09-25 10:06:38 -07:00
Jeff Boek
abbb310ce3 For #561 - Removes the toolbar from the home screen
- Removes the menu button
- Fixes motionlayout animation with the wordmark/private browsing button
2019-09-25 10:06:38 -07:00
Axel Hecht
2829235651 Import strings from android-l10n
State: mozilla-l10n/android-l10n@97355ffcdc
2019-09-25 09:02:42 -07:00
Jeff Boek
1c9c5317eb For #5552 - Temporary fix for startup crash on es locales 2019-09-24 19:21:47 -07:00
Sawyer Blatz
856399e9e2
No issue: Fixes GleanMetricsService nits & broken UI test (#5539)
* No issue: Fixes GleanMetricsService nits

* No issue: fixes broken UI test
2019-09-24 16:12:09 -07:00
Alessio Placitelli
1ffdf1cf9b Add basic test coverage for Glean metrics in Fenix
This introduces test coverage, using the Glean SDK
testing API, for the metrics that are set at startup
by Fenix in the GleanMetricsService.

This additional adds a basic test for the translation
of the `app_opened` event.
2019-09-24 12:33:14 -07:00
Alessio Placitelli
ebd11dbca8 Add the workmanager dependency to enable testing with Glean 2019-09-24 12:33:14 -07:00
Johan Lorenzo
7d3be2a509 taskgraph: Speed up gradle calls 2019-09-24 11:05:22 -07:00
Emily Kager
25e2a7abfc For #2765 - Run places maintenance daily (#5466) 2019-09-24 10:50:11 -07:00
Mihai Adrian
c7c752cabb For #5356 Improves private browsing "common myths" link accessibility (#5479)
Added separate TextView for link text
Used UnderlineSpan to show text as link
Split string private_browsing_placeholder, one for each TextView
Set clickListener on TextView so it can be accessed via Talkback
2019-09-24 10:46:34 -07:00
Tiger Oakes
8c30200ced Only use Context.settings() function (not getter) (#5335)
Remove unused String extensions
2019-09-24 10:33:46 -07:00
Tiger Oakes
734d4031e2 Extract UriOpened observer from HomeActivity 2019-09-24 09:37:24 -07:00
Tiger Oakes
e3c60faf24 Move BookmarkNode extensions to helper class (#4752) 2019-09-24 09:17:29 -07:00
Mihai Adrian
236f702bbe For#5468 Changed info source for url clipboard copy from view to session (#5514) 2019-09-24 07:56:59 -07:00
Axel Hecht
7c55aff1be Import strings from android-l10n (#5482)
State: mozilla-l10n/android-l10n@d10506f569
2019-09-23 19:53:57 -07:00
Jonathan Almeida
612b0fc006 For #5406: Ignore intermittent failing test temporarily 2019-09-23 14:23:21 -07:00
Tiger Oakes
cb7701584f No issue: Extract home fragment mode (#5343) 2019-09-23 09:33:55 -07:00
Nicholas
72eed21bfc For https://github.com/mozilla-mobile/fenix/issues/5474 - Adapt Autoplay icon to theme 2019-09-23 08:56:09 -07:00
Emily Kager
9d9ff959b5 For #5312 - Add Telemetry for Tracking Protection 2019-09-23 08:29:45 -07:00
Richard Pappalardo
057451178c
Move UI tests to x86 devices on Firebase (#5463) 2019-09-22 19:19:10 -07:00
Christian Sadilek
c866ae1a1e Closes #5444: IntentReceiverActivity: Add tests for intent processing 2019-09-20 19:44:05 -04:00
Sawyer Blatz
f02603be37
For #5460: Fixes styling of fill link from clipboard (#5464) 2019-09-20 15:29:16 -07:00
Sawyer Blatz
4a6e647167
For #5197: Adds telemetry for media controls (#5266) 2019-09-20 14:49:27 -07:00
mcarare
77ce658033 For #5383 Refactored ETP layout to keep appearance for larger font size.
Added paddingTop to layout to maintain similar space above title.
Added image's bottom colour as background color to fill space below image.
Refactored TextViews alignment to chain.
Changed guideline to percent instead of dp for wider screens including tablets.
2019-09-20 14:01:30 -07:00
Tiger Oakes
6c30a94081 Move settings classes to packages 2019-09-20 12:36:15 -07:00
Tiger Oakes
699eacab39 For #778 - Rename CustomTabActivity 2019-09-20 12:35:12 -07:00
Tiger Oakes
e9fd6892ba For #394, #778 - Add hide toolbar feature
And also add CustomTabsServiceStore
2019-09-20 12:34:49 -07:00
ekager
78ac6fc912 For #5448 - Reload custom tab session when TP is toggled 2019-09-20 12:30:02 -07:00
Michael Droettboom
a63eaa9d67 1581556: Initialize Glean on the main thread 2019-09-20 12:29:40 -07:00
mihai-adrian
47064a68e0 For #5141 Changed "learn more" link to be accessible to Talkback users 2019-09-20 12:29:02 -07:00
Tiger Oakes
172a9cf06c Extract and test crash reporter code 2019-09-20 11:04:11 -07:00
ekager
464122fda1 For #5421 - Make share dialog scrim dismiss fragment 2019-09-20 09:52:39 -07:00
mcarare
95a7aa9223 For #4526 Prevent automatic theme summary being cutoff with long text 2019-09-20 09:20:57 -07:00
Dennis Schubert
5577470d0b No bug - Add WebCompat feature. 2019-09-20 08:33:48 -07:00
Tiger Oakes
f71ec8928b Add note about lazy in FeatureFlags 2019-09-20 08:33:29 -07:00
Sawyer Blatz
6f3d7b4ee8 For #5396: Adds "always launch in private mode" to settings 2019-09-20 08:33:07 -07:00
Sawyer Blatz
13146c2b2a Reverts #1151: Removes unused Flipper library 2019-09-20 08:05:14 -07:00
Emily Kager
9591172ee9 No issue: Make Shortcut dialog buttons match other dialogs 2019-09-20 08:04:55 -07:00
Mihai Adrian
a1c8fc0698 For #3731 Improved UX for opening tabs from a Collection (#5427)
* For #3731 Changed order of items for a collection's overflow menu

* For #3731 Changed the order tabs open to keep same order from collections
2019-09-20 06:41:04 -07:00
Tiger Oakes
05a4faec78 Add tryGetHostFromUrl and update ExceptionDomains 2019-09-19 22:40:35 -04:00
Colin Lee
1aa4f5a519 For #255: Toggle Media Autoplay 2019-09-19 15:13:04 -07:00
Sawyer Blatz
2db2d9ceae For #1744: Adds tests for clipboard 2019-09-19 08:24:27 -07:00
Sawyer Blatz
fd1fcd8b89 For #4155: Adds paste & go for search terms 2019-09-19 08:24:27 -07:00
Sawyer Blatz
e961a9d63d For #1744: Adds clipboard provider to search engine screen 2019-09-19 08:24:27 -07:00
Tiger Oakes
1777b5a830 Use enum to simplify delete on quit code 2019-09-18 20:20:08 -07:00
Jonathan Almeida
fe8a8bfb0a No issue: Add Digital Asset Links token for TWAs 2019-09-18 20:19:47 -07:00
Tiger Oakes
106458c2c9 For #3440 - Reduce HomeFragment require calls 2019-09-18 17:25:44 -07:00
Jeff Boek
976c840047 For #3077 - Replaces connect another device dialog with a scree 2019-09-18 17:24:43 -07:00
Unpublished
065ce13999 Pass color resource for what's new menu item by id 2019-09-18 16:41:03 -07:00
Sawyer Blatz
956f4f0534
For #5411: Fixes delete button turning red (#5412) 2019-09-18 15:20:05 -07:00
Sawyer Blatz
50cd2920d3
For #5371: Updates search engine settings string (#5393) 2019-09-18 11:26:44 -07:00
Emily Kager
a68fabd3a7 For #1749 - Update to new ETP Settings Strings (#5395) 2019-09-18 10:36:09 -07:00
Emily Kager
95e4f2d754 No issue: Land strings for login management 2019-09-18 08:06:20 -07:00