Commit Graph

88 Commits

Author SHA1 Message Date
Gabriel Luong 9654b4dfb1 For #27667 - Remove import-ordering from the list of disabled ktlint rules 2022-11-03 23:27:03 +00:00
mcarare ffcef5ff2e For #26844: Fix ktlint issues and remove them from baseline. 2022-09-09 16:52:09 +00:00
Noah Bond 8656fd48eb For #26227 - Remove search term tab groups from Jump Back In 2022-08-04 00:10:47 +00:00
Christian Sadilek 7ddc50017e Revert "For #26227 - Remove search term tab groups from Jump Back In"
This reverts commit fa00527dc6.
2022-08-03 02:39:42 +00:00
Noah Bond fa00527dc6 For #26227 - Remove search term tab groups from Jump Back In 2022-08-02 22:46:10 +00:00
Noah Bond 7e59a644d5 For #21898 - Remove search term tab groups from the Tabs Tray 2022-07-19 16:59:57 +00:00
sarah541 da4328e53f For #22186 - Scroll to collection after creating one 2022-07-19 16:07:18 +00:00
Noah Bond 5f7fd5313c For #25491 - Refactor InactiveTabs interactors and controllers 2022-06-22 18:37:06 +00:00
Noah Bond 08a84f8353 For #21897 - Convert inactive tabs to compose 2022-06-03 18:49:13 +00:00
mcarare d20ba1d0fe For #25437: Fix label values for labeled counters. 2022-05-31 10:25:06 +00:00
mcarare ffa1ecd300 For #21292: Remove unused MetricController parameters. 2022-05-03 09:46:23 +00:00
Mugurell 8b56a2ebc7 For #25044 - Remove the broken code for focusing the newly created collection
This functionality seems broken for a long time now.
It's importance and whether to reimplement it is to be re-assessed in
https://github.com/mozilla-mobile/fenix/issues/24389
2022-05-02 22:50:06 +00:00
MatthewTighe 414a54ed02 for #24549: add telemetry for recent synced tab 2022-04-12 00:17:30 +00:00
Brais Gabín 1f633edd7d For #23046 - Align detekt config between Fenix and Android Components
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2022-03-29 00:03:06 +00:00
mcarare 1f18f62a5a For #24098: Remove wrapper from tabs tray metrics. 2022-03-28 12:30:30 +00:00
MatthewTighe 9d681a9de0 closes #24306: add nav argument to open tabs tray to an initial page 2022-03-17 21:05:08 +00:00
Gabriel Luong ad95f950bb For #24252 - Rename contrastText attribute to textOnColorPrimary 2022-03-14 22:08:08 +00:00
Noah Bond 48141b25a9 For #21900 - Delete files from Synced Tabs XML implementation 2022-02-15 00:01:57 +00:00
Roger Yang 047ec890b2 Closes #22550: Refactor search term tab grouping logic to rely on middleware 2022-01-13 03:32:12 +00:00
mavduevskiy 89f5e96d73
For #18160: Show a prompt when trying to leave private browsing with active downloads (#22912)
Co-authored-by: mike a <mavduevskiy@gmail.com>
2021-12-22 00:12:44 -08:00
mcarare b4bf7abfb3 For #22784: Show collection snackbar only if fragment is still attached. 2021-12-10 15:09:04 +00:00
Noah Bond de1c6b0dae
Tab group count telemetry (#22479)
* For #22410 - Refactored tab sorter metrics into a middleware

* For #22410 - Created distribution metric for tab group sizes

* For #22410 - Created tests for tabs tray middleware

* For #22410 - Merge fixes

* For #22410 - Added PR number to metric

* For #22410 - Fixed unit tests post merge. Added waitUntilIdle to new tests.

* For #22410 - Added missing line to middleware to have the Store process actions

* For #22410 - Updated metric expiration to December

* For #22410 - PR Feedback

* For #22410 - Removed else from middleware when
2021-11-29 18:16:57 +00:00
Jonathan Almeida e3b6e00331 Close #22223: Move to the selected page when switching modes 2021-11-10 18:25:44 +00:00
Jonathan Almeida 08b15689b1 Close #22305: Use TabsTrayStore for populating adapters 2021-11-08 22:28:31 +00:00
Arturo Mejia cff78afe27 For #22078 Selecting search group in Jump back in switches active tab 2021-11-03 22:02:22 +00:00
Jonathan Almeida 8c43ccc0f6 Issue #20704: Use AppStore for inactive expanded state 2021-11-01 19:23:42 +00:00
codrut.topliceanu a53b52b764 For #21565 - Adds inactive tabs onboarding popup 2021-10-05 10:00:33 +00:00
codrut.topliceanu bf5b4a5655 For #17917: Use View binding in tabs tray 2021-08-20 14:18:39 +00:00
Elise Richards 7fdade49ec
No issue: fix glean metrics tests for expired metrics (#20621)
* Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed.

* Add ignores for performance metrics that have expired.

* Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes.

* Remove metrics controller from signature and remove in tests
2021-08-02 18:14:17 +00:00
Jonathan Almeida 69d630f46c Issue #20349: Add inactive tab grouping to tabs tray 2021-08-02 11:44:13 +02:00
Sebastian Kaspari 971b419d77 Run ktlintFormat to adapt to latest formatting rules. 2021-07-30 11:58:02 +00:00
codrut.topliceanu 083d50aafd For #20250 - Adds FLAG_SECURE to TabsTray dialog 2021-07-08 08:49:06 +00:00
Roger Yang e69f3dfbbb Closes #19090: Show snackbar on adding to bookmarks from tabs tray 2021-07-06 22:13:38 +00:00
Roger Yang cabd004390 Closes #19182: Close Tabs Tray when sharing completes 2021-06-22 02:53:02 +00:00
Roger Yang 74c1cc82fb Closes #19921: Update appcompat and fragment dependencies to 1.3.x 2021-06-22 01:39:52 +00:00
codrut.topliceanu 37e2c6ceeb For #19739 - Adds start tabsTray with multiSelect support 2021-06-21 16:17:09 +00:00
Mihai Adrian Carare 9c9e26953f
For #19813: Invalidate tab tray adapter structure on screen rotation. (#20044) 2021-06-17 13:57:50 +03:00
mcarare df2efcf310 For #20024: Visit FAB after synced tabs in a11y traversal.
This helps focus on FAB without going through whole tab lists.
2021-06-16 19:01:24 -04:00
Jonathan Almeida 5be35df969 Revert "For #19739 - Adds start tabsTray with multiSelect support"
This reverts commit d8288f5e89.
2021-06-16 16:57:59 -04:00
Jonathan Almeida aeb186f79c Revert "For #19739 - Moves argument to initial state init"
This reverts commit f198e110d7.
2021-06-16 16:57:59 -04:00
codrut.topliceanu f198e110d7 For #19739 - Moves argument to initial state init 2021-06-16 13:16:18 -04:00
codrut.topliceanu d8288f5e89 For #19739 - Adds start tabsTray with multiSelect support 2021-06-16 13:16:18 -04:00
Mugurell abeb8b5576 For #19135 - Set different offsets for expanded trays
As in the previous version of tabs tray when tray is expanded while in portrait
it should have a 40dp offset and when the tray is expanded while in landscape
it should have a 0dp offset - effectively making it fullscreen.

These values were set in code, always overriding the xml set value so I
removed that xml declaration.
2021-06-15 10:01:49 +03:00
Mugurell 3cbb67da5c For #19135 - Expand the tabs tray in landscape
Track the current orientation and collapse / expand it the tabs tray depending
on the orientation and the number of opened tabs.
2021-06-15 10:01:49 +03:00
Mugurell d7544337b8 For #19135 - Refactor the behavior code to support more functionality later
Setup a new TabSheetBehaviorManager with all the dependencies it needs to
set the initial tray's behavior.
This same manager will later be called to update behavior's properties.
2021-06-15 10:01:49 +03:00
mcarare d43acbd03d For #19938: Remove a11y workaround for tab tray new tab button.
Historically, button was introduced in a3dc565c10,
because FAB was not selectable by a11y in previous implementation of tab tray.
2021-06-14 22:34:58 +04:00
codrut.topliceanu 5729137ddb For #19738 - Adds tests for SecureTabsTrayBinding.kt 2021-06-08 20:29:37 +04:00
codrut.topliceanu 0572cab97c For #19738 - Secure mode enabled in private tabs tray
Prevents screenshots while tabs tray with private tabs page is open.
2021-06-08 20:29:37 +04:00
Jonathan Almeida a64cac6c7f Issue #19792: Add content description for tab tray action button 2021-06-05 02:44:33 +04:00
Roger Yang 2e4635334a
Closes #19090: Show snackbar on adding to bookmarks from tabs tray (#19807) 2021-06-04 14:45:20 -04:00