ishan/fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
5,527 Commits 34 Branches 356 Tags 125 MiB
79d1c08402
Commit Graph

4722 Commits

Author SHA1 Message Date
mozilla-l10n-automation-bot
c941bd99b0
Import l10n. (#16001) 2020-10-17 21:54:08 -04:00
mozilla-l10n-automation-bot
1d91f1f087
Import l10n. (#15986) 2020-10-17 09:41:31 -04:00
Gabriel Luong
d33bd76e40
For #15796 - Use the device locale for the system locale subtitle (#15975) 2020-10-17 09:40:28 -04:00
Gabriel Luong
87ec7a77ae
For #15937 - Remove topFrecentSite feature flag (#15967) 
* For #15937 - Remove the topFrecentSite feature flag

* For #15937 - Hide the "Pull to refresh" preference since its visibility is managed by a feature flag
 2020-10-16 18:37:27 -07:00
ekager
d208ffe002
For #7345 - Update new shield icons, remove lottie (#15909) 2020-10-16 16:01:38 -07:00
Christian Sadilek
c852301c93 Closes #11286: Add TelemetryMiddleware to remove Session[Manager] observers 2020-10-16 11:05:34 -07:00
Gabriel Luong
412b412d5f
For #15796 - show device language under follow device language (#15966) 2020-10-16 12:47:56 -04:00
amkcpu
7ba5e130ba For #10683: Show longer tab titles 
Also update tab tray item layout according to specs posted in the issue.
 2020-10-16 15:50:29 +03:00
mozilla-l10n-automation-bot
a2a4284a1a
Import l10n. (#15945) 2020-10-15 17:29:04 -07:00
Jeff Boek
55515d8f7c
For #15596 - Removes upgrade faq link from fennec builds (#15643) 2020-10-15 15:02:51 -07:00
Gabriel Luong
b79df0ba8f For #14922: Use padding instead of margin to use the full screen width for the "Add search engine" button 2020-10-15 16:09:13 -04:00
mcarare
9f14007a98 For #14922: Adjust margins for add search engine preference. 2020-10-15 16:09:13 -04:00
mcarare
ba0c005ae9 For #14922: Add divider above address bar preferences. 2020-10-15 16:09:13 -04:00
mcarare
7510b1609f For #15898: Add dividers above subheadings in tabs screen. 2020-10-15 13:13:52 -04:00
mcarare
e50cb21fd0 For #15898: Add dividers above subheadings in customise screen. 2020-10-15 13:13:52 -04:00
Michael Comella
439dfc5cb1 For #15644: add comment for why we set the app theme in test. 2020-10-15 09:53:13 -07:00
Michael Comella
4a000ab4f9 For #15644: change apply to with in GleanMetricsService. 
While the callback receiver is identical in these two methods, they're
semantically different: apply is for initializing the receiver while with
is anything else benefiting from a new `this` receiver.

I didn't change the usage of apply that has a return statement because I
was afraid my change might change behavior.
 2020-10-15 09:53:13 -07:00
Michael Comella
690554b5c6 For #15644: mock package inspection dependencies in GleanMetricsService. 
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.
 2020-10-15 09:53:13 -07:00
ekager
2c7789b1a8 Sets theme in FenixRobolectricTestApplication onCreate 2020-10-15 09:53:13 -07:00
Michael Comella
3a6f74031c For #15644: escalate many Performance check severity in lint.xml. 
I exhaustively looked through the list of checks labeled performance and
marked them accordingly. To see all lint checks, type:
  <android-sdk>/tools/bin/lint --show
 2020-10-15 09:53:13 -07:00
Michael Comella
fc9ae308d3 For #15644: remove unnecessary lint ignore. 2020-10-15 09:53:13 -07:00
Michael Comella
ac953ab8ca For #15644: escalate InefficientWeight to error. 
All violations of this type were addressed in the previous commit.
 2020-10-15 09:53:13 -07:00
ekager
4d348dd26a Fixes existing lint errors 2020-10-15 09:53:13 -07:00
Gabriel Luong
665a71cbb0 For #15907 - Remove the usage of the TabTrayGridItemDecorator 2020-10-15 10:02:07 -04:00
ekager
508ec8b8ff For #15347 - Adds telemetry for tabs settings 2020-10-14 22:53:31 -04:00
ekager
b6587455f8 fix detekt errors 2020-10-14 18:22:02 -07:00
Sebastian Kaspari
430282c8ec Use new SearchEngineProvider interface. 2020-10-14 18:22:02 -07:00
Mozilla L10n Automation Bot
ce99cc9ccf Import l10n. 2020-10-14 17:49:27 -07:00
Michael Comella
ea2bb0df75 For #15280 - review: add license to lint-baseline.xml. 2020-10-14 15:20:28 -07:00
Michael Comella
341a92a10e For #15280: add current ConstraintLayout warnings to lint baseline. 2020-10-14 15:20:28 -07:00
Michael Comella
c6b83b10e0 For #15280: suppress new lint rule in migration code. 2020-10-14 15:20:28 -07:00
ekager
e56043c485 For #15265 - Save cached top sites for metrics ping 2020-10-14 15:08:54 -07:00
ekager
cbe293d3e4 For #12062 - Launch back to browser if we previoulsy had tabs 2020-10-14 15:05:20 -07:00
Mugurell
dd83130d9f For #15890 - Ensure app locale switcher works for Windows builds 
A hardcoded unix file separator prevented us from building a proper list of
locales for which we actually have packaged translations.
 2020-10-14 15:34:39 +02:00
Mozilla L10n Automation Bot
399c9c57fb Import l10n. 2020-10-13 20:54:10 -04:00
ekager
7931d66c8e For #15853 - Always set fontSizeFactor setting with new text scale 2020-10-13 09:40:43 -07:00
Mihai Adrian Carare
0e2657e262
For #14735: Remove debug logs from release build. (#15747) 2020-10-13 09:17:58 -04:00
Mozilla L10n Automation Bot
2751da0372 Import l10n. 2020-10-12 17:50:57 -07:00
Gabriel Luong
ee5f678442 For #15777 - [Grid View] Set the height of the title to 30dp 2020-10-12 10:38:54 -07:00
Gabriel Luong
463f83a79a For #15758 ⁃ [Grid View] Add a divider between the tab item's title and thumbnail 2020-10-12 10:38:54 -07:00
Mozilla L10n Automation Bot
83b5bae65e Import l10n. 2020-10-11 22:55:02 -04:00
Mozilla L10n Automation Bot
25c9706cfd Import l10n. 2020-10-11 10:04:34 -04:00
Grisha Kruglov
2030580fc8 Closes #15812: Check for a null context during onScanResult 2020-10-09 20:40:03 -07:00
Mozilla L10n Automation Bot
d5bef99834 Import l10n. 2020-10-09 20:42:16 -04:00
Shen
45e3f7805b For #13168 - Removed the close button from history navigation bar 2020-10-09 20:33:37 -04:00
Michael Comella
850d41a727 For #10069 - post: link to issue, data review. 2020-10-09 15:47:55 -07:00
Michael Comella
4179ab05bb For #10069 - review: clarify init time for External...Activity. 2020-10-09 15:47:55 -07:00
Michael Comella
a1bbd2589e For #10069 - review: change extra name to firstFramePreDrawNanos. 2020-10-09 15:47:55 -07:00
sraturi
8f16f9cb37 for #10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types. 2020-10-09 15:47:55 -07:00
mcarare
6516eff5c8 For #13831: Adjust buttons dimensions to improve a11y. 
Margins were also adjusted to maintain relative placements.
 2020-10-09 15:39:31 -07:00
mcarare
e89b9756ee For #13831: Add ripple for the copy password button. 2020-10-09 15:39:31 -07:00
ekager
881e3d6ccd For #14923 - Removes auto size preference toggle 2020-10-09 15:04:57 -07:00
Sijan Rijal
127d006d66
For #15402: Hide ETP pop-up if the toolbar is not visible (#15667) 
For #15402: Hide ETP pop-up when top or bottom toolbar is not visible
 2020-10-09 16:22:57 +03:00
Sijan Rijal
70908307fc
For #15497: Hide and remove the three dot menu from the Desktop Bookmarks folder (#15649) 
For #15497: Remove and disable the three dot menu button
 2020-10-09 14:39:03 +03:00
Mozilla L10n Automation Bot
0fbb28296e Import l10n. 2020-10-08 21:20:56 -04:00
Jonathan Almeida
666781aa62 Fix lint warnings and test in site permissions 2020-10-08 19:37:56 -04:00
Arturo Mejia
de521192e0 Add support for local storage permission 2020-10-08 19:37:56 -04:00
Gabriel Luong
5153a3f2c5 For #15115 - Part 9: Fix ui tests for the tabs settings 2020-10-08 12:50:43 -04:00
Gabriel Luong
2dd019c05f For #15115 - Part 8: Add a feature flag for showing the grid view in the tabs setting 2020-10-08 12:50:43 -04:00
Gabriel Luong
af0af7f88a For #15115 - Part 7: Draw a border around the selected tab 2020-10-08 12:50:43 -04:00
Gabriel Luong
5fcc486caa For #15115 - Part 6: Display the tab's favicon in the grid view 2020-10-08 12:50:43 -04:00
Gabriel Luong
5fa72cf48c For #15115 - Part 5: Don't draw any background when swiping to delete a tab 2020-10-08 12:50:43 -04:00
Gabriel Luong
a001004add For #15115 - Part 4: Formatted TabTrayView.kt 2020-10-08 12:50:43 -04:00
Gabriel Luong
6c77cdab41 For #15115 - Part 3: Implement a grid view layout for the tabs 
Co-authored-by: Abhijit Valluri avalluri2@bloomberg.net
 2020-10-08 12:50:43 -04:00
Gabriel Luong
2117dfb524 For #15115 - Part 2: Remove unused xmlns:mozac in component_tabstray.xml 2020-10-08 12:50:43 -04:00
Gabriel Luong
ed3986662f For #15115 - Part 1: Convert the CloseTabsSettingsFragment to a general TabsSettingsFragment 
- Renames CloseTabsSettingsFragment.kt to TabsSettingsFragment.kt
- Renames close_tabs_preferences.xml to tabs_preferences.xml
- Adds preference options for the switching between the Grid and List tab views
 2020-10-08 12:50:43 -04:00
Michael Comella
7c0d00c800 No issue: fix tests related to inline change. 
The difficulty in mocking StrictMode.resetAfter is concerning.
I'm starting to second-guess whether or not making strict mode manager a class
was a good idea.
 2020-10-08 07:24:21 -07:00
Michael Comella
7b5cd8c165 No issue: remove inline from StrictModeManager.resetAfter. 
I believe this was a premature optimization: it's unclear that it would
actually improve performance and yet  we had to add several weird
workarounds to make it work that broke encapsulation. It's also
possible it would be worse for the APK size because of excessive
inlining.
 2020-10-08 07:24:21 -07:00
Mozilla L10n Automation Bot
a72b5b0dd6 Import l10n. 2020-10-07 21:56:24 -07:00
Jonathan Almeida
ee673348bf Issue #15754: Disable failing notification UI tests 2020-10-07 20:01:35 -04:00
Jonathan Almeida
23d9951e78 Upgrade to Android Component 62.0.20201006190820 with breaking changes 2020-10-07 20:01:35 -04:00
Chenxia Liu
fe0ea19b1d Adding link data review request 2020-10-07 11:02:42 -07:00
Chenxia Liu
6e522436b5 startup.timeline 2020-10-07 11:02:42 -07:00
Chenxia Liu
05f37e75fb sync, sync_items, telemetry, theme, toolbar_position, 
tracking_protection, default_engine
 2020-10-07 11:02:42 -07:00
Chenxia Liu
8892a6ec85 accesssibility, open_links, remote_debugging, search_suggestions, 
show_search
 2020-10-07 11:02:42 -07:00
Chenxia Liu
5f74e18bca search_count, search_widget, tabs_count, toolbar_position 2020-10-07 11:02:42 -07:00
Chenxia Liu
29970f5cb2 has, count: open_tabs, pwa, top_sites 2020-10-07 11:02:42 -07:00
Chenxia Liu
0b9c50f62e default*browser, mozilla_products 2020-10-07 11:02:42 -07:00
Chenxia Liu
03e6167b5f browser.search, events.total_uri_count, metrics.adjust* 2020-10-07 11:02:42 -07:00
Chenxia Liu
ca57a2d3ab first_session 2020-10-07 11:02:42 -07:00
Chenxia Liu
815e159183 user_specified_search_engine, voice_search 2020-10-07 11:02:42 -07:00
Chenxia Liu
2edb812663 top_sites, tracking_protection 2020-10-07 11:02:42 -07:00
Chenxia Liu
bf381a6a7c tab, tabs_tray, toolbar_settings 2020-10-07 11:02:42 -07:00
Chenxia Liu
bb7515f76e syenc_account, sync_auth 2020-10-07 11:02:42 -07:00
Chenxia Liu
68ba986fd2 search_suggestions, search_shortcuts, search_widget 2020-10-07 11:02:42 -07:00
Chenxia Liu
965af504ad private_browsing, qr_scanner 2020-10-07 11:02:42 -07:00
Chenxia Liu
04d0e59468 pocket, onboarding 2020-10-07 11:02:42 -07:00
Chenxia Liu
ac28667995 logins, media_notification, media_state 2020-10-07 11:02:42 -07:00
Chenxia Liu
d50fbd062d Issue #14142 - find_in_page, history, reader_mode, tip 2020-10-07 11:02:42 -07:00
mcarare
9845626eca For #15711: Also add custom engines to fallback list. 2020-10-07 10:19:26 -07:00
mozilla-l10n-automation-bot
0ac7feacb4
Import l10n. (#15738) 2020-10-06 18:19:11 -07:00
Elise Richards
13f3304912
For #8765: Use shared list widget in collections (#15733) 
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
 2020-10-06 16:24:08 -05:00
Michael Comella
4302cd20b2 For #13959 - post: decrement expected suppression count. 
Running locally, I get the same error: I think that there legitimately
was an reduction in the number of StrictMode suppressions on start up.
 2020-10-06 14:11:53 -07:00
Michael Comella
3e96f6b385 For #13959 - review: add clarifying comments. 2020-10-06 14:11:53 -07:00
Michael Comella
50959d997e For #13959: add marker when StrictMode is suppressed. 2020-10-06 14:11:53 -07:00
Michael Comella
3b5d6d58d9 For #13959: add MozillaStrictModeSuppression detekt check. 2020-10-06 14:11:53 -07:00
Michael Comella
b222376cb0 For #13959: add test to prevent increasing StrictMode suppression count. 2020-10-06 14:11:53 -07:00
Michael Comella
c33aafb024 For #13959: add HomeActivityTestRule.skipOnboarding. 
This is more correct, faster, and results in less copy-paste duplication
than the current behavior:
  homeScreen { }.dismissOnboarding()

Which opens settings to dismiss onboarding.
 2020-10-06 14:11:53 -07:00
Michael Comella
4a4edeb184 For #13959: count StrictMode suppressions on startup. 2020-10-06 14:11:53 -07:00
Jocelyne Abi Haidar
a5de2c0352 For #15675: Disable Save button when editing saved login until something has been changed 
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
 2020-10-06 11:47:12 +03:00
mozilla-l10n-automation-bot
5fed37cf45
Import l10n. (#15712) 2020-10-05 18:08:06 -07:00
Mozilla L10n Automation Bot
ad2b99f9f9 Import l10n. 2020-10-05 12:19:48 +02:00
mcarare
07748f69b7 For #15632: Improve checking open tabs logic to show collection button. 
Check now considers selected tab tray mode.
 2020-10-02 20:46:29 -04:00
ekager
ec3595d4fc For #15600 - Move removal of timed out sessions to immediately after restoration 2020-10-02 13:22:49 -07:00
ekager
01eedd159a No issue: Update biometric, core, and recyclerview libraries 2020-10-02 08:47:40 -07:00
mcarare
b696fc4c4b For #13031: Show size in KB for smaller downloaded files. 2020-10-02 11:04:48 -04:00
Mozilla L10n Automation Bot
ee4a5283a4 Import l10n. 2020-10-01 17:46:57 -07:00
Jocelyne
0154c81f81
For #10107: Show Today and Yesterday labels in History (#15415) 2020-10-01 16:42:50 -07:00
Michael Comella
f690f8736d No issue: replace LintUnitTestRunner with detekt implementation. 
This should be more performant and easier to maintain.
 2020-10-01 16:06:53 -07:00
Jeff Boek
41a92a8d8b For #15593 - Reverts back to simple UUID creation without Fenix side caching 2020-10-01 15:51:30 -07:00
Jocelyne
e74a12b442
For #15471: Show Delete button in red in multi-select overflow menu (#15576) 2020-10-01 13:10:33 -07:00
Mozilla L10n Automation Bot
97adee3bd9 Import l10n. 2020-10-01 20:13:40 +02:00
Grisha Kruglov
51dab196c4 Closes #15443: Use fragment's lifecycleScope for AlertDialog actions 2020-09-30 17:42:40 -07:00
Christian Sadilek
ced92d69d1 Issue #15555: Set channel to Nightly explicitly for SettingsFragmentTest 2020-09-30 18:35:20 -04:00
mcarare
67310061a3 For #15559: Allow tabs to stretch in landscape mode for tablets. 
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
 2020-09-30 14:46:22 -07:00
Christian Sadilek
4a06e40e70 Closes #15555: Intermittent failures in SettingsFragmentTest 2020-09-30 14:53:18 -04:00
Stefan Arentz
ff930175de
For #15537 - Be more verbose about leanplum identifiers (#15538) 2020-09-30 13:05:28 -04:00
mcarare
19b377c021 For #15535: hasOpenTabs now considers the selected tab mode in tray tab. 2020-09-30 08:33:38 -07:00
Michael Comella
56f78cb30c No issue: elaborate on Components class doc. 
This is to clarify a misunderstanding I found in PR review.
 2020-09-29 15:39:10 -07:00
Sebastian Kaspari
2fda22e857 Revert "For #12565: Pass metrics to share controller" for debug test failures. 
This reverts commit bbaca06274.
 2020-09-29 10:59:31 +02:00
Sebastian Kaspari
4de466883b Revert "For #12565: Pass bookmark storage to controller" for debug test failures. 
This reverts commit 3c22100b84.
 2020-09-29 10:59:17 +02:00
Andrew Gaul
cfbad1dae9 Show undo snackbars with padding with static bottom toolbar 
This specifically fixes the close tab snackbar.  This commit mirrors
the logic when not using Undo from
9e876ebc44.  References #14982.
 2020-09-29 10:15:30 +02:00
ekager
01e802fef0 For #15324 - Show tab settings and recently closed items in menu when no tabs 2020-09-28 21:09:30 -07:00
ekager
e49cd9c558 For #15503 - Change recently closed max to 10 2020-09-29 00:03:49 -04:00
TrianguloY
b07af9ccd3
For #13856 - Prevent overscroll in swipe to switch tabs gesture 2020-09-28 20:43:44 -07:00
Tiger Oakes
25f62f1c76 Extract locale settings initial state 2020-09-28 20:39:49 -07:00
Tiger Oakes
acbad66f45 Add test for initial logins list state 2020-09-28 20:39:49 -07:00
Tiger Oakes
f2a6aa4f25 Add tests for initial collection creation state 2020-09-28 20:39:49 -07:00
Sören Hentzschel
01fdb4ac3f For #11561 - changed inactive heading and menu icon color in dark mode 2020-09-28 20:24:12 -07:00
Mozilla L10n Automation Bot
863b135723 Import l10n. 2020-09-28 20:18:50 -07:00
Tiger Oakes
3c22100b84 For #12565: Pass bookmark storage to controller 2020-09-28 20:05:50 -07:00
Tiger Oakes
bbaca06274 For #12565: Pass metrics to share controller 2020-09-28 20:05:50 -07:00
Michael Comella
d767cd199e For #13959: fix startup crash by using arg Context. 
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
 2020-09-28 18:01:19 -07:00
Michael Comella
42cca072e2 For #13959: remove resetAfter & port tests to StrictModeManager. 2020-09-28 18:01:19 -07:00
Michael Comella
dd73cb628b For #13959: clean up existing StrictMode test names. 2020-09-28 18:01:19 -07:00
Michael Comella
f19c9920f9 For #13959: move resetAfter into StrictModeManager. 
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.

Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```

We're going to have to add a lint check to prevent them from doing that.
 2020-09-28 18:01:19 -07:00
Michael Comella
6abeb2d9e7 For #13959: change StrictModeManager to class from object. 
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
 2020-09-28 18:01:19 -07:00
Christian Sadilek
d4ab728cff For #14034: Add debug preference to override AMO collection in Nightly 2020-09-28 17:25:52 -04:00
Michael Comella
a92356fe00 For #13959: comment about duplication in logic in StrictMode. 
I had to drop a commit that addressed the issue because it was too hard
to fix.
 2020-09-28 13:52:40 -07:00
Michael Comella
e1bd6191c7 For #13959: add comment to explain why we only resetAfter in certain build modes. 2020-09-28 13:52:40 -07:00
Michael Comella
3bf71ef655 For #13959: use ac StrictMode.resetAfter rather than duplicating functionality. 2020-09-28 13:52:40 -07:00
Michael Comella
2c1befaa25 For #13959: rename to attachListenerToDisablePenaltyDeath for clarity. 2020-09-28 13:52:40 -07:00
Michael Comella
c03c7ef793 For #13959: remove unused penaltyDialog parameter. 
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
 2020-09-28 13:52:40 -07:00
Michael Comella
f05a542060 For #13959: always enable detectNonSdkApiUsage. 
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
 2020-09-28 13:52:40 -07:00
Sebastian Kaspari
3983c509dc Use "undo" implementation from Android Components. 
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.

Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
 2020-09-28 10:04:46 -07:00
Mozilla L10n Automation Bot
d287e6e9e0 Import l10n. 2020-09-28 17:16:11 +02:00
mcarare
daced89387 For #15310: Add test for ActivityNotFoundException when sharing to app. 2020-09-28 13:29:17 +03:00
mcarare
6289da892c For #15310: Also catch ActivityNotFoundException when sharing to app. 2020-09-28 13:29:17 +03:00
ekager
0d0a28d551 No issue: Update AC to 61.0.20200925190057 2020-09-26 12:21:10 +02:00
ekager
7d5c199e51 For #12383 #15407 #12860 - Switch to using shared view model for session to delete on home 2020-09-25 16:54:54 -07:00
Grisha Kruglov
2999f64d0a Closes #15434: Don't try to display a 'signed in' snackbar in a 'headless' mode 2020-09-25 15:31:07 -07:00
Grisha Kruglov
d98eba1d64 Closes #15432: Invoke UI updates on main thread in response to account events 2020-09-25 15:30:48 -07:00
Grisha Kruglov
24985d54fa Closes #15436: Auto-close tabs during startup on the main thread 2020-09-25 15:11:21 -07:00
Christian Sadilek
81aaacda61 Configure M5 AMO collection for Nightly/Debug 2020-09-25 11:18:07 -04:00
mcarare
cd53b8fdaf For #15130: Remove "what's new card" check in UI test. 2020-09-25 18:04:48 +03:00
mcarare
04e59e0ac5 For #15130: Remove "what's new card" from onboarding screen. 2020-09-25 18:04:48 +03:00
Mozilla L10n Automation Bot
f32d2011df Import l10n. 2020-09-24 18:03:47 -07:00
Kate Glazko
e8855c09e6 For #15320: Ensure Mimetype Other PDF Shows PDF Icon 2020-09-24 13:49:51 -07:00
Elise Richards
1adf467248
For #14280, #14743: Remove old search fragment (#15169) 
* Remove search fragment

* Use new folder to search dialog

* Rebase and lint

* Update tests with search dialog nav directions

* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
 2020-09-24 15:46:42 -05:00
Jonathan Almeida
add60611b4 For #15349: Fixes SyncedTabs suggestion not clicking 2020-09-24 15:35:06 -04:00
Grisha Kruglov
f1b0827a0b For #15296: Allow excluding bookmark subtrees when editing parent folder 
I'm really not a fan of how title overwriting and structure processing are mangled together,
but will leave clearing that up for another day.
 2020-09-23 23:22:44 -07:00
Mozilla L10n Automation Bot
4fad099b23 Import l10n. 2020-09-23 21:16:24 -07:00
Sawyer Blatz
0fa2509bef
For #14243: Pre-land visuals for Close Tabs CFR (#15171) 2020-09-23 14:57:52 -07:00
Grisha Kruglov
71b51146cb Update breaking changes in the FxA/Sync integration 2020-09-23 14:51:04 -07:00
Jocelyne
d45e482373
For #11800: Hide reveal and clear password icons if the password is empty when editing a saved login (#15244) 
Co-authored-by: Jocelyne Abi Haidar <jocelyne.abihaidar@gotocme.com>
 2020-09-23 12:10:49 -07:00
Sebastian Kaspari
943455658b Issue #13270: Do not launch into Fennec's task anymore. 
Initially we did this to avoid a duplicated task right after the migration from Fennec. We'd end up
with the original task from Fennec and the new one from Fenix; with the Fennec task still showing
Fennec in the app switcher, but launching Fenix once selected.

Anyhow, now on Android 11 this causes the Fenix task to get duplicated. The simple fix is to not
do any of that anymore. This may re-introduce the problem with the Fennec migration, but:
* We are at 100% rollout for quite some time. There are still users migrating, but the impact
  of the bug is much lower.
* The bug after the migration was only temporary. This bug here is happening every time you
  launch Fenix. So I'd rather fix this than a possible inconvenience right after the migration.
 2020-09-23 18:05:05 +02:00
mcarare
c1bf66618e #274-android-l10n: Update create account string to avoid partial translations. 2020-09-23 08:49:23 -07:00
Christian Sadilek
601e847094 Configure M4 AMO collection for all builds 2020-09-22 19:01:37 -04:00
person808
baccb153b7 For #15219 - Fix tab tray handle size. 
Also use dimens for the tab history handle.
 2020-09-22 15:24:22 -07:00
aprabhakara
657ce60f8d For #15262: Updated margins 2020-09-22 14:57:53 -07:00
ekager
24983af94e For #15291 - Limit current CFRs to show max one every 3 days 2020-09-22 10:43:14 -07:00
mcarare
94d9a2a1ed For #15263: Properly update open links in app preference. 2020-09-22 09:44:32 -07:00
ekager
a9075ff87b For #15272 - Remove bottom margin for toolbar on enter fullscreen 2020-09-22 08:34:29 -07:00
ekager
030d6a5b36 For #15121 - Ensure tabs removed while on browser select an available parent session 2020-09-22 08:33:39 -07:00
mcarare
e3b5dcbfec For #15268: Update unit tests for safe navigation to details fragment. 2020-09-22 18:23:17 +03:00
mcarare
896c1b7875 For #15268: Use safe navigation to addon details fragments. 2020-09-22 18:23:17 +03:00
Oana Horvath
108666c277 Closes #14524, #12896, #13830: re-enabled strict ETP tests after code bug fix 2020-09-22 13:42:30 +03:00
Grisha Kruglov
f51b570654 For #15284: Process root titles when creating new folders 
This also simplifies how we do this. We're no longer creating instances of `DesktopFolder` class
nor creating copies of BookmarkNodes just to display root titles correctly for the 'edit folder' UI.
 2020-09-21 20:03:04 -07:00
ekager
f16ade33df For #15089 - Disable recently closed in multiselect 2020-09-21 18:35:08 -07:00
ekager
b5f1e772bd For #15112 - Still show recently closed when history empty 2020-09-21 18:35:08 -07:00
Grisha Kruglov
5691088787 For #15286: Don't crash when separators are long-touched 2020-09-21 18:34:08 -07:00
Mozilla L10n Automation Bot
c326be9fd3 Import l10n. 2020-09-21 18:17:38 -07:00
ekager
9a2103a9a7 For #13934 - Make TabHistory work on PWA/Custom Tabs 2020-09-21 16:07:56 -07:00
ekager
407c31fdb3 No issue: Fixes strict mode death in debug custom tab 2020-09-21 12:59:33 -07:00
ekager
9e876ebc44 For #14982 - Show snackbars with padding with static bottom toolbar 2020-09-21 10:05:28 -07:00
ekager
18ca211434 For #14458 - dismiss keyboard on fill link from clipboard 2020-09-21 08:27:46 -07:00
Mozilla L10n Automation Bot
7cad83f64b Import l10n. 2020-09-20 20:19:09 -07:00
ekager
e162aefbc6 For #15245 - Remove margin for toolbar on toolbar-less PWA 2020-09-20 19:41:29 -07:00
Mozilla L10n Automation Bot
1f6a22a340 Import l10n. 2020-09-19 21:33:21 -07:00
Grisha Kruglov
b7b3ee5ce6 For #2792: Display bookmark folders at the top of the bookmarks UI 2020-09-18 22:01:17 -07:00
Grisha Kruglov
078843675b For #15211: Make sure bookmarks are moved to the end of folders 2020-09-18 21:52:58 -07:00
Grisha Kruglov
027c1f9ea7 Closes #15206: Only track 'move' event if bookmark parent was changed 2020-09-18 21:52:58 -07:00
Grisha Kruglov
b5b32ba6ea For #11502: Make sure to always process root titles for parent folders during edit 
This also switches to a simpler bookmarks query API ('getBookmark') which doesn't fetch
children. We don't need 'children' for this dialog, and so don't need to do the extra work.
 2020-09-18 21:16:57 -07:00
Grisha Kruglov
958474f9fb For #13157: Filter out folder being edited from 'select folder' dialog 2020-09-18 20:13:45 -07:00
Grisha Kruglov
fe288edb5d Rename 'visitedAddBookmark' arg to a less confusing name 2020-09-18 20:13:45 -07:00
Grisha Kruglov
24de85f805 Remove unused nav arg from 'select folder' 2020-09-18 20:13:45 -07:00
Mozilla L10n Automation Bot
af03b88f1e Import l10n. 2020-09-18 19:01:38 -07:00
Tiger Oakes
b563576335
Closes #14131: Move constants to dimens.xml (#14135) 
Co-authored-by: Elise Richards <erichards@mozilla.com>
 2020-09-18 16:13:57 -07:00
Tom Klein
dc9bc534db For #13300 - Adjust the 'Sharing a Collection' layout to prevent overlapping of the close icon and 'Share' label in RTL 
Note that the "Share" title is still constrained to start at the end of the
close button - I don't know why the previous extra constraint was causing the
differing behavior in LTR and RTL, but this seems to fix it.
 2020-09-18 14:04:03 -07:00
Elise Richards
a4ff782565
For #13812: add ETP category for redirect trackers (#15139) 
* Feature flag for ETP cookie purging

* Strings for new ETP description

* Remove icons from ETP info screeen and add category for redirect trackers

* ETP policy factory tests

* Remove icons from ETP panel and add cross tracking allowed field.

* Remove icons on ETP panel. Add blocked category for redirect trackers to panel.

* Add margins to tracking protection settings
 2020-09-18 14:03:51 -05:00
Jeff Boek
6781018556 For mozilla-mobile/android-components#8429 - Dont initialize MLS if token is null 2020-09-18 11:51:50 -07:00
Jeff Boek
8bdc9d0431 Revert "For #12544 - Prevent search engines mixup" 
This reverts commit 0a4a170f7e.
 2020-09-18 11:51:50 -07:00
Hakkı Kaan Çalışkan
0afb7a3f25 For #13922: Add indicator to synced tabs suggestions in awesomebar 2020-09-18 09:54:19 -07:00
Jonathan Almeida
d063cd5396 For #14230: Stop redrawing all top sites when one is removed 2020-09-18 12:53:23 -04:00
mcarare
5b33044999 For #12829: Add create account option on the the sign in screen. 2020-09-18 09:04:54 -07:00
mcarare
81985f4179 For #12829: Update addUnderline extension function to accept parameters. 2020-09-18 09:04:54 -07:00
mcarare
cc9667f722 For #15150: Do not show open banner if open in app is ON in settings. 2020-09-18 10:47:02 +03:00
Mozilla L10n Automation Bot
80a573a62c Import l10n. 2020-09-18 10:26:22 +03:00
mcarare
79135b1df5 For #13943: Change strict mode penalty to penaltyDeath. 
Also, keep dialogPenalty as replacement option for penaltyDeath.
 2020-09-18 09:45:08 +03:00
Oana Horvath
abe06da6e2 Closes #13829: Added idling resources to the addon details view" 2020-09-18 09:43:06 +03:00
mcarare
f793c3a5f9 For #14727: Add content description to resync tabs button. 2020-09-17 16:44:36 -07:00
Sören Hentzschel
55b5a452d1 For #14933 - Fixed private browsing icon color in preferences fragment 2020-09-17 16:41:02 -07:00
Tiger Oakes
b927b688c9 Merge bookmark item and folder view holders 2020-09-17 15:59:42 -07:00
Tiger Oakes
3059a57747 Change separator to use its own view holder 2020-09-17 15:59:42 -07:00
Elise Richards
9afe9679d8
For #15079: handle QR permissions when changed in Android settings (#15097) 
* Define intent data for activity

* Search dialog shows permissions for allow and deny camera

* Check camera permissions for fxa pairing

* Check camera permissions for old search

* Tests for pairing sync interactor and controller.

* Cleanup

* Use bool pref for setting. Use interfaces and default implementations for the sync interactor and controller.

* Lint
 2020-09-17 16:41:28 -05:00
Sawyer Blatz
8a81c1ee1d For #15123: Fix top sites text color 2020-09-17 11:35:51 -07:00
Sawyer Blatz
1f17371df6 For #14565: Add telemetry for top sites 2020-09-17 10:06:39 -07:00
Arturo Mejia
19f0c543fe Fix add-ons permissions breaking change 2020-09-17 09:48:57 -07:00
mcarare
e5a9311613 For #15116: Also do not expand or set bottom toolbar behavior on TWA tabs. 2020-09-17 09:30:27 -07:00
mcarare
83478b9db4 For #15116: Do not set bottom toolbar behavior on PWA tabs. 2020-09-17 09:30:27 -07:00
mcarare
c5a2e2e5a0 For #15116: Do not expand toolbar on PWA tabs. 2020-09-17 09:30:27 -07:00
mcarare
1f004aff8c For #15116: Use safe cast for layout params. 2020-09-17 09:30:27 -07:00
Sebastian Kaspari
ee3384ac52 Issue #14225: Remove task when finishing ExternalAppBrowserActivity. 2020-09-17 18:13:47 +02:00
Mozilla L10n Automation Bot
f036d3db67 Import l10n. 2020-09-16 18:31:50 -07:00
Mozilla L10n Automation Bot
f6684862a4 Import l10n. 2020-09-16 09:31:34 +03:00
Hakkı Kaan Çalışkan
f87ca730a9 For #11245: Integrate Synced Tabs AwesomeBar suggestions 
fix pr
 2020-09-15 13:58:29 -04:00
mozilla-l10n-automation-bot
2059156193
Import l10n. (#15099) 2020-09-14 18:08:22 -07:00
Jeff Boek
c632b6b0a1
For #15007 - Puts swipe to delete behind a feature flag (#15009) 2020-09-14 15:20:46 -07:00
Mozilla L10n Automation Bot
0a8b9e378c Import l10n. 2020-09-14 12:02:00 -07:00
codrut.topliceanu
b892af773e For #14546 - Speculative fix for ANR 2020-09-14 09:10:28 -07:00
Gabriel Luong
05857ba55d For #14145 - Add pinned badge for pinned sites 2020-09-11 20:42:40 -04:00
Mugurell
75aa2d413a For #14974 - Ensure website bottom elements stay at bottom 
engineView.setDynamicToolbarMaxHeight(0) vs
engineView.setDynamicToolbarMaxHeight(toolbarHeight)
ensures webpage's bottom elements are aligned to the bottom of the browser.

We also need to make sure that when the toolbar is static it does not cover the
bottom of the page - something desired when the toolbar was dynamic.
For this the engineView will have a toolbarHeight bottom margin.
 2020-09-11 16:39:34 -07:00
codrut.topliceanu
b5cf484360 For #14559 - Persist searchFragment keyboard status 2020-09-11 13:58:47 -07:00
Elise Richards
4afaf34a78
Access shared prefs in fxa pairing (#14997) 2020-09-11 14:56:03 -05:00
Jeff Boek
79180250ea For #14283 - Fixes overlapping search suggestions and hint 2020-09-11 12:25:09 -07:00
ekager
09fbb43f80 For #2486 - Adds Recently Closed Tabs 2020-09-11 12:02:30 -07:00
codrut.topliceanu
cce58e7d51 For #14725 - Resize search engine radio button 2020-09-11 09:53:55 -07:00
ekager
b986730031 No issue - Updates AC to 58.0.20200910190642 and fixes imports 2020-09-11 10:57:24 +03:00
Mugurell
b54949e58f
For #14902 - Disabling bottom toolbar animation now works (#14927) 2020-09-10 18:06:38 -07:00
Jeff Boek
f9b2d65993 For #5745 - Create preference to disable domain autocompletion 2020-09-10 17:39:42 -07:00
Mozilla L10n Automation Bot
8e7d10c33c Import l10n. 2020-09-10 17:34:03 -07:00
Elise Richards
87bd44145f
For #14239: Notification for QR scan when permissions have been denied (#14553) 
* Show dialog when permissions are denied

* Add qr permissions dialog to search dialog fragment

* Add qr permissions dialog to the pairing screen

* Show dialog after permissions have been denied

* Reset focus after denying permissions

* Show dialog after permissions denied in search frag and par frag

* Use shared preferences to store camera permission state

* Move dialog creation into the search controller and add tests

* Dialog controller implementation and test

* Route to intent with correct activity. Set focus when dismissing dialog

* Get preferences in old search
 2020-09-10 19:09:38 -05:00
Abhijit Kiran Valluri
b0729f655c
Fix #14950 - Make the "Add new tab" button visible in private mode on light theme (#14951) 2020-09-10 16:53:05 -07:00
Mugurell
a6a50d78e0 For #14903 - Prevent BrowserFragment's view leak 2020-09-10 18:25:54 +03:00
Oana Horvath
2e38635781 For #13829: Disables verifyAddonsCanBeUninstalled UI test 2020-09-10 15:58:11 +03:00
ekager
82d7313add For #13467 For #14910 - Dismiss dialog on blank URL commit 2020-09-09 20:51:54 -07:00
ekager
806f74abe7 For #14680 - Revert ObserverRegistry changes to WifiConnectionMonitor 2020-09-09 20:49:56 -07:00
Michael Debertol
4142c36820 For #14212: Pass historyStorage to ToolbarView 2020-09-09 20:47:43 -07:00
Michael Debertol
cc8aa1f381 For #13423: Pass isPrivate flag to ToolbarView 2020-09-09 20:47:43 -07:00
Mozilla L10n Automation Bot
c7a25cd8aa Import l10n. 2020-09-09 18:31:50 -07:00