Commit Graph

1615 Commits

Author SHA1 Message Date
Jeff Boek
2813a3cff7 For #4441 - Keeps the ID 0 based for the recyclerview 2019-08-01 10:45:23 -07:00
Christian Sadilek
9887945296 For #4412: Only consume state change when UI initialized 2019-08-01 11:51:32 -04:00
isabelrios
f815ef1dd0 Fixes #4324 - Add more l10n screenshots tests (#4350)
* Fixes #4324 - l10n Add more screenshots tests

* change test name

* final changes

* fixing reviewer comments
2019-08-01 08:35:47 -07:00
Christian Sadilek
b646e87d9e No issue: Add engine warmup call 2019-08-01 10:53:55 -04:00
Jeff Boek
e4700f76c6 For #3886 - Uses defaultDeviceName for the DeviceConfig device name 2019-07-31 21:34:21 -07:00
Jeff Boek
a75c2f7cfb No Issue - Fixes the offset key to prevent endless history bug 2019-07-31 17:58:56 -07:00
Sawyer Blatz
97f7d5ba87 For #2267: Fixes telemetry for reader view (#4328) 2019-07-31 17:58:37 -07:00
Sawyer Blatz
2e7a61860a For #969: Adds more telemetry for collections (#4358) 2019-07-31 17:07:41 -07:00
Jonathan Almeida
4922e5d09d No issue: Move PublicSuffixList to root component
With the PublicSuffixList class in Utilities, the first instantiation
of it (prefetching in onCreate), causes the Utilities to instantiate
and thus slowing down startup by needing the SearchEngineManager from
instantiating as well.

Moving this back to the root component fixes the immediate perf issue.

Co-authored-by: Will Hawkins <whh8b@obs.cr>
2019-07-31 17:01:14 -07:00
Christian Sadilek
59c0005979 For #4412: SiteSecurityClickedListener set incorrectly 2019-07-31 19:52:53 -04:00
Will Hawkins
ed31d990a4 No Issue: Move notification manager to member of background services
Instead of taking notification manager as a parameter
(from the utils class), create one private to the
BackgroundServices class. This means that we do not need
to create the entirety of utilities just to use
the notification manager.
2019-07-31 16:11:46 -07:00
mihai-adrian
fa8199f429 fixes #4221 - The tap area for Open tabs' new tab and 3 dot menu buttons is too small
changed size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
2019-07-31 14:42:43 -07:00
mihai-adrian
30ecbc6000 fixes #4221 - The tap area for Open tabs' new tab and 3 dot menu buttons is too small
changes size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
2019-07-31 14:42:43 -07:00
Jeff Boek
e7ec6246fd For #4137 - Fixes HistoryStoreTest 2019-07-31 14:35:33 -07:00
Jeff Boek
af449c84d5 For #4137 - Fixes HistoryInteractorTest 2019-07-31 14:35:33 -07:00
ekager
4494e40dbc For #4137 - Adds pagination to the history view 2019-07-31 14:35:33 -07:00
Emily Kager
0773069dad For #3829 - Ignore Intents Launched From History 2019-07-31 17:07:54 -04:00
Nikit Bhandari
46de06d132 For #4339 reduce build warnings (#4340) 2019-07-31 11:43:49 -07:00
Emily Kager
95208c84a9 Closes #4265 - Do not pop after all exceptions are removed (#4392) 2019-07-31 11:43:15 -07:00
Christian Sadilek
76ed07bd5d Closes #4412: BrowserInteractor has not been initialized (#4414) 2019-07-31 09:14:05 -07:00
Afzal Najam
8946bf20c4 Closes #3341 - Remove UserAgentRewriter 2019-07-31 11:05:42 -04:00
Emily Kager
ec0bd85f6d For #4198 - Include Intent.ACTION_SEND to open to browser 2019-07-31 01:11:39 -04:00
Jonathan Almeida
026dcb01f5 No issue: Enable Send Tab and Push in production 2019-07-30 22:32:59 -04:00
Jonathan Almeida
90b1e5c262 Closes #4355: unsubscribe FxA subscription on logout 2019-07-30 22:27:12 -04:00
Maurya Talisetti
093b76593d Closes #3419: Use better accessibility strings for tab collections 2019-07-30 16:37:49 -04:00
ekager
3fb20aea6a Closes #4040 - Remove NestedScrollView from Bookmark Layout 2019-07-30 16:29:12 -04:00
mihai-adrian
458632f4bf fixes #4237 - Cannot edit the default name of a collection, only replace it
changed setting of text to be done before transition, preventing transition to make textView unclickable;
 added renaming situation to showKeyboard in onResume();
 changed title text when renaming, from: "Name collection" to "Rename collection".
2019-07-30 16:26:10 -04:00
mihai-adrian
ef3c813aee fixes #4237 - Cannot edit the default name of a collection, only replace it
changed setting of text to be done before transition, preventing transition to make textView unclickable;
 added renaming situation to showKeyboard in onResume();
 changed title text when renaming, from: "Name collection" to "Rename collection".
2019-07-30 16:26:10 -04:00
mihai-adrian
2e300fc8cf fixes #4237 - Cannot edit the default name of a collection, only replace it
made name_collection_edittext field clickable
2019-07-30 16:26:10 -04:00
Sawyer Blatz
385dfd2f15
For #4376: Removes usage of selectedSessionOrThrow (#4381) 2019-07-30 12:39:58 -07:00
mihai-adrian
4ee8a890a8 fixes #3843 - (L10N) regression: alignment issue when saving tabs to collection
changed height to match_constraints instead of wrap_content - this makes for a better calculation of space, avoids setting textView on two lines, with blank line below.
2019-07-30 13:41:23 -04:00
ekager
0703fdc91f Closes #4240 - Exclude custom tabs from displayed tab count 2019-07-30 13:28:50 -04:00
bloslo
8ff77b90f3 For #3886 - Change default device name to show the app name. (#3916)
* Fix default device name to show the app name.

* Add string resource with placeholders.

* Wrap line that triggers MaxLineLength lint issue.
2019-07-30 10:28:19 -07:00
bloslo
7ab4498771 For #3548 - Fix close tab button visibility. (#3801)
* For #3548 - Fix close tab button visibility.

* Switch to 'wrap_content' instead of fixed values.

* Align close tab button with settings button.

* Change margin top
2019-07-30 10:25:44 -07:00
Tiger Oakes
ecc743a1f9 Minify logo path (#4276) 2019-07-30 09:56:11 -07:00
Sebastian Kaspari
d1d91e9e6a Switch to GeckoView 69 Beta. 2019-07-30 18:53:27 +02:00
Tiger Oakes
d1651ecf71 Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
Tiger Oakes
2467588c4a Create shared custom view for library items 2019-07-30 12:26:15 -04:00
Mihai Adrian
ed60bdf470 fixes #3905 - "Go back" button too low on high risk error pages (#4378)
added to border-box value to box-sizing property for tablets so that the height property includes content and padding
2019-07-30 09:24:10 -07:00
Sawyer Blatz
437ecfbca8
For #1750: Adds gradient to private BrowserToolbar (#4361)
Also updates the color of quickActionSheet ot be "above" attribute
2019-07-30 09:19:48 -07:00
Mugurell
bf44c50dfd Fix #4372 - Set SitePermissionsDetailsExceptionsFragment toolbar title in onResume
The flow we are currently using involves setting a new title for the containing
Activity when the user navigates to a new Fragment.
This happened for SitePermissionsDetailsExceptionsFragment in it's onCreate().
Opening a permission (SitePermissionsManageExceptionsPhoneFeatureFragment) will
set a new title in it's onCreate() but going back from this new Fragment will
not create again a new SitePermissionsDetailsExceptionsFragment.
As a workaround I moved the call to set Activity's title in onResume().
2019-07-30 11:56:44 -04:00
Nikit Bhandari
5e52fc46b8 For #3443 - convert textPercentageSeekBar to Kotlin (#4081)
* convert textPercentageSeekBar to Kotlin

* fix test

* fix test again

* fix test again

* conflicts resolved

* merge multiple kdocs into one
2019-07-30 10:17:41 -05:00
Axel Hecht
be66e00303 Import strings from android-l10n
State: mozilla-l10n/android-l10n@1412258878
2019-07-30 15:35:41 +02:00
Colin Lee
9bc0122ce3
For #4359: findBookmarkedUrl blocks the main thread (#4362) 2019-07-29 17:01:02 -05:00
Amaan Marfatia
4c13f45e9e Fixes #4192: Private keyboard in private browsing (#4345)
Sets compliant keyboards to private mode when in private browsing.
2019-07-29 18:00:48 -04:00
James Hugman
ac359f6970 Closes #1331 - Filter consecutive history items using simplified URL 2019-07-29 17:22:19 -04:00
Sawyer Blatz
6fa022c2f8
For #4124: Migrate BrowserToolbar to Libstate (#4279)
* For #4124: Migrate BrowserToolbar to Libstate

* Restores QuickActionSheetReducer

* Improve tests

* Make QuickActionSheetController

* Finalize tests

* Breaks out QuickActionSheetState

* Fix comments

* Adds BrowserStoreTest
2019-07-29 12:39:36 -07:00
Tiger Oakes
87d8f3b037 Remove redundant super calls 2019-07-29 10:22:53 -07:00
Tiger Oakes
88c05a5f43 Use glide-like image loading function 2019-07-29 10:22:23 -07:00
Andrey Mukamolov
ccfaa3826b For #2142: Added accessibility focus 2019-07-29 09:26:33 -07:00
Andrey Mukamolov
965d99a1c1 For #2142: Added UI test assertion 2019-07-29 09:26:33 -07:00
Andrey Mukamolov
d5eeadda66 Closes #2142: Enable private browsing button is focused instead of Search or address 2019-07-29 09:26:33 -07:00
Tiger Oakes
c2e6e25bef Fixes #4005 - Move getColorFromAttr to Context 2019-07-26 16:44:11 -04:00
Jonathan Almeida
c8148e61d5 No issue: Reset push subscriptions 2019-07-26 13:50:57 -04:00
Sawyer Blatz
e6487ba609
No issue: Add more useful test output to TaskCluster (#4165) 2019-07-26 08:56:13 -07:00
Richard Pappalardo
b39afe1548
Add taskcluster job for UI tests (#4088) 2019-07-26 08:08:01 -07:00
Colin Lee
48aeb19db1
For #3695: Make SessionSuggestionProvider link to existing tab (#4280) 2019-07-26 09:49:25 -05:00
Christian Sadilek
1846a61475 For #4096: Use new A-C API to observe store / state changes
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
2019-07-26 10:40:33 -04:00
Colin Lee
3dc20543e3
For #4128: Migrate Bookmarks to LibState (#4254) 2019-07-25 21:55:51 -05:00
ValentinTimisica
4747f2c165 Fixes #4161: Modified style of bookmark_folders_sign_in button. (#4291)
To make this match the style of the other button I applied the same style to it
and also changed it to be a MaterialButton.
I also decided to extract the margin and padding values of the button.
2019-07-25 14:10:11 -05:00
chiragmantri
9bbd14a542 removed unused import. 2019-07-25 14:36:36 -04:00
chiragmantri
945b1ee274 [#4089] Moved PublicSuffixList to a sub-component(Utilities) class. 2019-07-25 14:36:36 -04:00
Sawyer Blatz
9db0d88346
For #4262: Updates color and text of buttons (#4250) 2019-07-25 11:01:25 -07:00
isabelrios
a05d3e2aa0 For #4260 - UITests update data collection string (#4261) 2019-07-24 10:05:28 -07:00
Jonathan Almeida
1026a92f32 Update to use Mozilla Android Components 6.0.0 2019-07-23 17:55:39 -04:00
Jonathan Almeida
2531e9dd62 No issue: Use correct server host and force subscribe for push 2019-07-23 17:55:39 -04:00
Sawyer Blatz
28eb5c541a
For #1944 & #1750: Updates private & night mode colors (#4232) 2019-07-23 09:35:24 -07:00
Tiger Oakes
3c99c8540f Switch to new intent processors 2019-07-23 12:33:02 -04:00
Sawyer Blatz
6480f405e2
Fixes #4091 & Fixes #4092: Resolve issues with Search UI tests (#4224) 2019-07-23 09:30:57 -07:00
Michael Droettboom
ce19709eae 1567988: Reduce likelihood of invalid URL loading Glean build script 2019-07-23 11:21:19 +02:00
Emily Kager
be10d427e8 For #4127 - Converts Exceptions to LibState and adds tests 2019-07-22 17:21:06 -04:00
Emily Kager
9b5baa2358 For #3360 - Adds empty state for TP Exceptions 2019-07-22 17:21:06 -04:00
Sawyer Blatz
7588251f8b
Closes #3986 & Closes #3661: Migrate QuickActionSheet to LibState & add tests (#4058)
* Closes #3986: Migrate QuickActionSheet to LibState

* Closes #3661: Add tests for QuickActionSheet

Co-authored-by: boek <jeff@jeffboek.com>

* For #3986: Fix feedback
2019-07-22 10:31:31 -07:00
Nikit Bhandari
9d9685625a For #4201 fix app crash on renaming a collection (#4202)
* For #4201 fix app crash on renaming a collection

* update
2019-07-22 10:31:00 -07:00
isabelrios
a984bb4799 For #4094 - Improved original PR to fix screenshots tests API21 (#4144)
use robot for three dot menu screenshot
2019-07-22 09:58:53 -07:00
Jonathan Almeida
5ecdce6ba6 Closes #4171: Do not pause deviceEventObserver on lifecycle events 2019-07-19 14:00:26 -07:00
Nikit Bhandari
f110ba2861 use synthetic binding instead of findviewbyid 2019-07-19 16:51:26 -04:00
Tiger Oakes
8ebd7cd744 Update to use Mozilla Android Components 5.0.0 2019-07-19 16:41:38 -04:00
Jeff Boek
5630904f93
For#3278 - Updates strings in preferences (#4184) 2019-07-19 12:31:55 -07:00
Mihai Adrian
c74cb61455 fixes #4176 (#4175)
adds content description to 'browse privately' card, replacing placeholder %s with the header_text of card
2019-07-19 14:23:10 -05:00
Emily Kager
fc2bff0fde For #4145 - Remove anchor view from fullscreen snackbar (#4160) 2019-07-19 11:18:47 -07:00
Emily Kager
9f40c25c75 For #4143 - Allow user to rotate to other landscape orientation 2019-07-19 14:12:33 -04:00
Sawyer Blatz
b70719bd00
Fixes #2464: Remove Glide dependency (#4169) 2019-07-19 11:06:49 -07:00
Jonathan Almeida
d298b5f2f5 Closes #4075: Add Feature Flag class (#4077) 2019-07-18 17:20:12 -07:00
Sawyer Blatz
e25ceafd1f No issue: Removes unnecessary fragment transitions from accounts
Co-authored-by: ekager <emilykager@gmail.com>
2019-07-18 19:56:25 -04:00
Sawyer Blatz
becdb88f4b Revert "For #1944 & #1750: Updates private & night mode colors (#4162)"
This reverts commit 2c95bb614a.
2019-07-18 19:55:56 -04:00
Axel Hecht
709a2652b5 Import strings from android-l10n (#4110)
State: mozilla-l10n/android-l10n@e521a2aab2
2019-07-18 16:07:01 -07:00
Sawyer Blatz
13198f56df For #969: Adds telemetry for collections (#3935) 2019-07-18 16:05:42 -07:00
Sawyer Blatz
e544827e83 For #2267: Adds telemetry for reader mode (#3941) 2019-07-18 15:17:15 -07:00
Tiger Oakes
edb0a3ed08 For #3633 - Update StoreProvider to use a callback
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2019-07-18 18:16:49 -04:00
Jeff Boek
e294521c92
Fix search metrics (#4150)
* For #4082 - Changes lifecycles for metrics

* For #4082 - Replaces the SearchEngine name with the identifier for
countLabel
2019-07-18 14:35:34 -07:00
Sawyer Blatz
9251597e84 For #2362: Fixes telemetry for history (#4156) 2019-07-18 13:36:52 -07:00
Tiger Oakes
981b6b5b02 For #4124 - Remove browser toolbar editing code 2019-07-18 15:40:33 -04:00
James Hugman
62850430b7 Closes AC#3695 - Add UI to open current page in external app 2019-07-18 15:33:31 -04:00
Tiger Oakes
6da6ddb095 Use StateListDrawable & resources w/ TabCollection 2019-07-18 15:29:06 -04:00
Emily Kager
451093fd9e Closes #2560 - Updates Private Browsing explanation string 2019-07-18 15:27:59 -04:00
Sawyer Blatz
2c95bb614a
For #1944 & #1750: Updates private & night mode colors (#4162) 2019-07-18 11:22:07 -07:00
Johan Lorenzo
7f8cf79241
Use Raptor release now that GV release is used (#4070) 2019-07-18 16:47:18 +02:00
Emily Kager
ae3d187909 For #3987 - Convert History to Lib-State and add tests 2019-07-17 17:23:09 -07:00
Emily Kager
9ab67557cf For #4078 - Request landscape mode when entering fullscreen 2019-07-17 16:06:37 -07:00
Richard Pappalardo
ac37d4971c Revert "For #4094 - Fix screenshots tests on API 21 devices (#4108)" (#4138)
This reverts commit d8e45e55d4.
2019-07-17 14:58:12 -07:00
isabelrios
d8e45e55d4 For #4094 - Fix screenshots tests on API 21 devices (#4108)
fix ktlint error
2019-07-17 14:27:59 -07:00
Christian Sadilek
c04dcec03f Closes #4096: IllegalStateException in SearchFragment (#4131) 2019-07-17 15:10:24 -05:00
James Hugman
90dd0ab469 Closes #4114 - Re-enable app-links 2019-07-17 10:39:17 -07:00
Emily Kager
95367c2b50 For #3521 - Show Quick Settings Dialog Entirely in Landscape 2019-07-17 09:52:01 -07:00
Emily Kager
8381025ac5 For #2160 - Hide Keyboard in onPause from EditBookmarkFragment 2019-07-17 09:20:28 -07:00
Emily Kager
68dae52fd1 Closes #3332 - Do not alter text of hosts of tabs in collection 2019-07-17 09:02:30 -07:00
Emily Kager
8daaa6378d Closes #4038 - Adds margin before close icon in tab item 2019-07-16 14:14:08 -07:00
Aaron Train
6aa6cf8a99 Closes #3977: Add basic navigational UI tests (#3978)
- Adds UI tests (and assets) for basic navigation

fix: review changes

fix: linter cleanup

fix: detekt cleanup

fix: adjust wait approaches
2019-07-16 13:02:12 -07:00
Emily Kager
3143227692 For #3998 - Make Turn On Sync Fragment scrollable in landscape 2019-07-16 12:56:07 -07:00
Sawyer Blatz
11d36b5a00
For #2362: Adds telemetry for history (#3940) 2019-07-16 12:21:03 -07:00
Colin Lee
8855af2234
For #3615: Long pressing the address bar should not copy link (#4083) 2019-07-16 13:42:05 -05:00
Emily Kager
6b4c160d18 Closes #4080 - Trim New Bookmark Folder Title Text 2019-07-16 11:02:36 -07:00
Sebastian Kaspari
110dd732e2 Use Mozilla Android Components 4.0.0. 2019-07-16 18:35:35 +02:00
Tiger Oakes
52d4c43916 Merge some library UIView code for toolbar 2019-07-16 09:27:30 -07:00
Tiger Oakes
447123367a Remove unused sessions resources 2019-07-16 09:15:50 -07:00
Colin Lee
badf79da48 Fixes #4072: Re-installing Fenix shows tabs from previous install (#4076) 2019-07-16 08:28:18 -07:00
Jonathan Almeida
5792acf442 No issue: Enable send tab in nightly legacy 2019-07-16 08:54:45 -04:00
Emily Kager
13b7e64c9b For #3134 - Add confirmation dialog to sign out of FxA (#3959) 2019-07-15 16:21:13 -07:00
Jeff Boek
ec099a6e11
For #3633 - Creates generic store provider (#4060) 2019-07-15 15:54:13 -07:00
Sawyer Blatz
6b29affbee No issue: Speed up onboarding UI test (#4061) 2019-07-15 17:02:55 -05:00
Tiger Oakes
7747d5c240 Use tools:text to avoid inflating strings twice (#3619) 2019-07-15 17:01:37 -05:00
Jonathan Almeida
fd7ff58ab8 No issue: Add comments on the push flag state 2019-07-15 17:42:58 -04:00
Sawyer Blatz
c779889cbd
Closes #4027: Adds search fragment UI tests (#4033) 2019-07-15 14:25:31 -07:00
Axel Hecht
42cbe50a5a Import strings from android-l10n (#4054)
State: mozilla-l10n/android-l10n@64a8eca673
2019-07-15 16:09:44 -05:00
ekager
706f7d5961 For #3554 - Add DiffUtil to HistoryAdapter 2019-07-15 13:46:21 -07:00
Jonathan Almeida
cf9ae87d50 For #3015: Add push support for send tab 2019-07-15 16:38:49 -04:00
Sebastian Kaspari
9b1e63224c Closes #4052: Remove pending intent workaround. (#4059)
Previously we needed to set a static launch function to be invoked when the find in page
integration should be launched. Now we can access the integration class directly and
can avoid the static property that caused issues when used by multiple activities.
2019-07-15 14:15:59 -05:00
Colin Lee
04b34f70fd
For #3865: Use separate app name and icon for Nightly build (#3873) 2019-07-15 14:12:30 -05:00
Christian Sadilek
e91a2e61a2 For #3633: Add unit tests for SearchStore 2019-07-15 13:47:01 -04:00
Sebastian Kaspari
f8ef0225e1 Use updated feature-tab-collections API. (#4056) 2019-07-15 09:58:33 -07:00
Christian Sadilek
b91895a81c Closes #1350: Use GeckoView fetch client for service-fretboard / kinto 2019-07-15 11:26:40 -04:00
Tiger Oakes
5de1678e65 No issue: Use putCompoundDrawables helper (#3982) 2019-07-15 08:24:59 -07:00
ekager
89a500beaf For #4039 - Set angle of progress bar gradient 2019-07-15 08:02:06 -07:00
Sebastian Kaspari
abc4e93cc3 After mege day: Switch from GV 68 beta to GV 68 release. 2019-07-15 16:29:41 +02:00
Sebastian Kaspari
e4e0d45c1b Closes #3996: Remove workaround for opening custom tab in browser.
`EngineView` now allows releasing the `Session` so that it can be rendered by an
other `EngineView` instance.
2019-07-15 10:52:57 +02:00
Jeff Boek
e4ff70c542
For #3633 - Refactors the search screen to use lib-state
* For #3633 - Adds SearchStore

* For #3633 - Refactors AwesomeBarUIView

* For #3633 - Refactors ToolbarUIView to use lib-state

* For #3633 - Fixes a couple of state bugs

* For #3633 - Moves all user interaction to SearchInteractor

* For #3633 - Adds kdocs to SearchStore and SearchInteractor

* For #3633 - Adds documentation for the properties on SearchState
Also removes uneccessary property

* For #3633 - Creates `StateViewModel` to handle state restoration

* For #3633 - Adds a test for onTextChanged

* For #3633 - Adds tests for SearchInteractor

* For #3633 - Fixes bugs and adds documentation
2019-07-12 16:32:00 -07:00
Sawyer Blatz
6b639b1a32
For #4032: Fixes broken homescreen UI tests (#4011) 2019-07-12 16:19:08 -07:00
Emily Kager
a9bfb303f7 For #3997 - Use ScrollView so landscape mode displays entire view 2019-07-12 11:49:12 -07:00
Emily Kager
867067537a For #3568 - Use correct styling for QR and Share Alert Dialogs 2019-07-12 11:40:33 -07:00
Tiger Oakes
ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Emily Kager
5b10badc00 No issue: Remove rounded QAB corners to avoid overlapping web content 2019-07-12 09:59:19 -07:00
Colin Lee
2feddc9bd6
No issue: Enable Strict Mode in Debug Builds (#4014) 2019-07-12 00:23:28 -05:00
Emily Kager
7cea2ed048 For #3997 - Use srcCompat for sign in ImageView 2019-07-11 13:29:24 -04:00
Emily Kager
1f108f3c88 For #3806 - Adds corner radius to QAB and dialogs 2019-07-11 12:57:27 -04:00
Grisha Kruglov
fe51bbcf7b Update FxA integration to new APIs 2019-07-11 13:19:37 +02:00
Emily Kager
c81dd0a4a8 For #3772 - Update FXA sign in UI (#3933) 2019-07-10 21:20:06 -05:00
Emily Kager
547c5d7bbe For #3906 - Add backgrounds to Permissions Buttons (#3958) 2019-07-10 20:59:47 -05:00
Emily Kager
9e7282cf18 For #1949 - Fixes bookmark separator appearance, removes menu (#3957) 2019-07-10 14:23:35 -05:00
Emily Kager
21c75ca1bb For #3478 - Add Tab sent snackbar confirmation for device sharing 2019-07-10 14:13:10 -04:00
ekager
c6c9818751 For #3240 - Create AuthCustomTabActivity to fix dead end on auth 2019-07-10 12:23:01 -04:00
Emily Kager
41ace512ec No issue: Adds new strings for sync, fxa, and settings 2019-07-09 18:52:36 -04:00
Richard Pappalardo
329c7d6e66
Update HomeScreenTest and add first run (#3951) 2019-07-09 14:52:15 -07:00
Colin Lee
5a204f0bbc
For #3818: Handle crashes accessing view after onDestroyView (#3942) 2019-07-08 18:42:17 -05:00
Sawyer Blatz
83312b38aa
For #3175: Correctly grabs focus in search fragment (#3938) 2019-07-08 14:44:30 -07:00
Tiger Oakes
9901514766 Replace deprecated pxToDp (#3932) 2019-07-08 14:45:07 -05:00
Mugurell
0bf8b96790 Fix #3425 - Use Share header text as contentDescription (#3822) 2019-07-08 14:35:53 -05:00
Jeff Boek
fa2c87b323 For #2094 - Keep motionlayout internals from being optimized away by (#3937)
proguard

Co-Authored-By: sblatz <sdblatz@gmail.com>
2019-07-08 14:29:51 -05:00
Colin Lee
15d887e41f
For #2251 - Add bookmark adapter diffutil (#3936)
* For #2251 - Add bookmark adapter diffutil

* For #2251 - Fix unit tests for bookmark adapter diffutil
2019-07-08 14:00:25 -05:00
afr30010
c92eabdd64 Modify the order of Privacy Policy and About in Settings (#2760) 2019-07-08 12:16:18 -05:00
Axel Hecht
45cfeb858b Import strings from android-l10n (#3923)
State: mozilla-l10n/android-l10n@5d8852d69a
2019-07-08 12:11:44 -05:00
Emily Kager
d168d52516 For #3772 - Remove Create an Account Option on TurnOnSyncFragment (#3928) 2019-07-08 12:07:09 -05:00
Colin Lee
747e83da91
Closes #2683. Update Gradle to 5.5 (#3929)
* Closes #2683. Update Gradle to `5.4.1`

* Upgrade to Gradle 5.5
2019-07-08 11:14:13 -05:00
Sawyer Blatz
f7cf8473b5
For #2357: Removes snapping threshold on home fragment (#3878) 2019-07-08 09:11:22 -07:00
kglazko
166218f74a Adding l10n screenshot tests for Fenix (#3562)
* Adding l10n screenshot tests for Fenix

* fixing comments

* fix klint and detekt error and adding all tests

* better test name and doc added explaining tests
2019-07-08 11:00:29 -05:00
ekager
eaa9df7018 For #3547 - Use MaterialButton for Share Component Close Button 2019-07-08 08:59:58 -07:00
Christian Sadilek
1169822479 Closes #3914: Exclude gecko.util.DebugConfig from Proguard optimization 2019-07-07 18:37:39 -07:00
ekager
003837eb4f Closes #3879 - Remove attributeSetId from AccountPreference 2019-07-07 18:06:17 -07:00
Richard Pappalardo
e7d0bfe581
Update HomeScreenTest (#3882) 2019-07-05 10:38:09 -07:00
ekager
57ca75139b For #3201 - Update bookmark state when session selected 2019-07-03 11:38:14 -07:00
Emily Kager
f60536b13c For #3829 - Add pop up to nav_graph to browser to home nav 2019-07-03 11:29:49 -07:00
Colin Lee
6bb67a9de7
For #3364: Set bookmark root titles onResume (#3828) 2019-07-03 13:13:53 -05:00
ekager
cad6345c89 For #3715 - Update menu corner radius to 8dp to match tabs 2019-07-03 11:13:23 -07:00
ekager
033eac00e3 No issue: Adds mischievous Fenix debug launcher 2019-07-03 09:47:41 -07:00
Jeff Boek
20993462e9 For #3869 - Creates a SearchLocalizationProvider that sets the region to get the correct default search engine based on a locale 2019-07-03 08:57:59 -07:00
Yeon Taek Jeong
29402a297e For #3317: Prepopulate FxA device name field with existing name (#3733) 2019-07-03 08:38:09 -07:00
Axel Hecht
ba34b7b69f Import strings from android-l10n
State: mozilla-l10n/android-l10n@63a524065c
2019-07-03 17:07:45 +02:00
Axel Hecht
9e9c2c65c8 Import strings from android-l10n
State: mozilla-l10n/android-l10n@1a1047c59e
2019-07-03 13:42:22 +02:00
Axel Hecht
7b9f24edfe Import strings from android-l10n
State: mozilla-l10n/android-l10n@4c73402212
2019-07-03 13:42:22 +02:00
Emily Kager
7a51ee3915 For #3734 - Don't SwipeToDelete RecyclerView without windowfocus (#3839) 2019-07-02 14:42:50 -07:00
Emily Kager
99209aa9da Closes #3268 - Change Tab Favicon Border Radius to 4 (#3856) 2019-07-02 14:42:20 -07:00
Emily Kager
ce2d597af3 For #203 - Adds find in page and request desktop site to custom tab menu (#3835) 2019-07-02 14:41:29 -07:00
Colin Lee
eedb0fa3b2
For #2945: Launches to blank screen and hangs on Nexus 10 (#3854) 2019-07-02 14:58:28 -05:00
Mitchell Hentges
aebcc92080
Re-enables pushing nightly to org.mozilla.fenix (#3823)
* Re-enables pushing nightly to org.mozilla.fenix

* Publishes org.mozilla.fenix.nightly releases on internal track
2019-07-02 11:34:04 -07:00
Sawyer Blatz
dbe29ebbda
For #3174: Adds telemetry for bookmarks (#3724) 2019-07-02 08:41:20 -07:00
Sawyer Blatz
ece0e30655
For #2054: Collapses quick action bar when opening find in page (#3837) 2019-07-02 08:22:34 -07:00
Emily Kager
bed926c317 For #3834 - Initialize job in init 2019-07-01 16:26:46 -07:00
Colin Lee
50052c9b9b
For #3551: Tapping a bookmark/history from Library should open new tab (#3832) 2019-07-01 16:31:30 -05:00
Colin Lee
161e7b3b57
No issue: Fix master builds (#3825) 2019-07-01 14:15:54 -05:00
Tiger Oakes
8cd1a0cb38 Move adapter Job setup code to helper class (#3407) 2019-07-01 13:34:25 -05:00
Sören Hentzschel
eb1ea882cf For #2425 - QAB showed wrong text for bookmarked pages (#3794)
* For #2425 - QAB showed wrong text for bookmarked pages

* fixed linting issue
2019-07-01 11:45:52 -05:00
Sawyer Blatz
7e46e71d00 For #3005: Closes tabs when saving to collection (#3723) 2019-07-01 11:39:48 -05:00
Weverson Nascimento
887102d215 For #3645: Fix search engine selection (#3665)
* Remove RadioButton drawable applied in runtime

* Add default RadioButton layout
2019-07-01 11:08:58 -05:00
Emily Kager
654c2b12df No issue: Remove attributeSetId from DefaultBrowserPreference (#3712) 2019-07-01 09:02:40 -07:00
Colin Lee
7473126f7c
For #3784: Crash loading bookmarks while detached (#3787) 2019-07-01 10:57:31 -05:00
Colin Lee
386a3f3acc
For #3785: Crash onDestroy of BookmarkFragment when detached (#3786) 2019-07-01 10:57:16 -05:00
Tiger Oakes
d42052079a No issue: Remove duplicate wordmark and update about page (#3590) 2019-07-01 08:54:16 -07:00
Yeon Taek Jeong
219b5f3d01 For #3381: Fix 'Remove account' returning app to home screen (#3778)
* For #3381: Fix 'Remove account' returning app to home screen

* Remove unused import

* Move popBackStack() outside lifecycleScope instead
2019-07-01 08:32:06 -07:00
Arturo Mejia
b82340bf1f For #3750: Crash when tapping "Blocked" on Google Maps after disabling
location requests.
2019-06-29 18:39:19 -07:00
Emily Kager
c477c781a5 For #3355 - Allow multilines on bottom bar in Collection Creation (#3782) 2019-06-28 19:10:54 -05:00
Sawyer Blatz
4ccd19a585 For #2210: Improves UI of search fragment (#3773) 2019-06-28 19:03:04 -05:00
Mitchell Hentges
e5f47a8210 Nightly package name should be "org.mozilla.fenix.nightly" (#3771) 2019-06-28 18:56:55 -05:00
Divya Raj
073b0ae103 Fixed Issue #3741 - %s in Japanese version + A few typos (#3749)
* Typo in README

* Fixed Issue #3741 - %s in Japanese version

* Fixed various typos
2019-06-28 18:56:25 -05:00
ekager
7fa4cf4487 Use sessionId in FIP Integration, use pendingIntent for startActivity 2019-06-28 14:00:59 -07:00
ekager
6d0a4fdb4d Revert "For #3609 - Remove FIP Integration, Use FIP Feature"
This reverts commit 428643d598e938f58a2fe4abfee417c46edec167.
2019-06-28 14:00:59 -07:00
Emily Kager
2d6ebb986d Revert "For #3135 - Reduce swipe to delete sensitivity"
This reverts commit 94881f8241.
2019-06-28 12:47:36 -07:00
Colin Lee
f375eac6bd
For #3732: Race Condition Crash in HomeFragment onPreDraw (#3737) 2019-06-27 20:33:21 -05:00
Emily Kager
9142e2279c For #1968 - Adds menu option to add new folder in BookmarkFragment menu 2019-06-27 15:17:00 -07:00
Tiger Oakes
606e66219c No issue: Use chains for bookmark items (#3696)
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-06-27 13:47:42 -07:00
Emily Kager
c9962a7ad0 Closes #3701 - When deleted use bookmark title if url is null in snackbar (#3716) 2019-06-27 13:39:00 -05:00
Sawyer Blatz
13df8d7ddd
For #3711: Fixes save to collection from browser crash (#3714) 2019-06-27 11:29:00 -07:00
Sawyer Blatz
a36f2a7288
For #3244: Updates account icon in settings (#3692) 2019-06-27 11:28:42 -07:00
Sawyer Blatz
66eb4fd03b No issue: Fixes master compilation 2019-06-27 09:05:57 -07:00
Colin Lee
7481d52c4b
For #3505: Opening a sent tab crashes Fenix (#3507) 2019-06-27 10:47:54 -05:00
Nikit Bhandari
6ccd32f093 For #3496: dismiss share fragment when clicking outside content (#3513)
* dismiss share fragment when clicking outside content

* add logic in view layer
2019-06-27 10:43:13 -05:00
Emily Kager
77edb7afe1 For #2960 Closes #3671 - Fixes bookmark deletion with undo, wraps list 2019-06-26 18:59:13 -07:00
ekager
61a8795576 For #1211 - Hide keyboard on fling suggestions list 2019-06-26 16:44:35 -07:00
ekager
eb54d7c97f For #3690 - Gives defined size to pill_wrapper 2019-06-26 16:44:35 -07:00
Tiger Oakes
e8bd090a8e No issue: Use ImageView rather than rebuilding drawable (#3616)
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
2019-06-26 16:03:06 -07:00
Tiger Oakes
4994554576 No issue: Adds lint exception for when statement (#3685) 2019-06-26 15:52:24 -07:00
Sawyer Blatz
309014139d For #3488: Cleans up edit mode calls (#3689) 2019-06-26 15:40:07 -05:00
Yeon Taek Jeong
2cafd5bba6 For #3678: Fix crash when tapping on your account (#3688) 2019-06-26 13:33:27 -07:00
Emily Kager
a1ddf17364 Closes #3569 - Uses primary text attr for bookmark folder icon (#3675) 2019-06-26 15:29:21 -05:00
Emily Kager
427bc5c1e6 Revert "For #1211 - Hide keyboard on fling suggestions list"
This reverts commit cb6fd83c9879c268cb739fb768187d5276c5af66.
2019-06-26 11:19:09 -07:00
Tiger Oakes
a78d36354a Switch RadioButtonPreference to ConstraintLayout
Also ensure that RTL works properly.
2019-06-26 09:45:55 -07:00
Sawyer Blatz
d28168ac64 For #2940: Hides send tab header on FxA error 2019-06-25 17:08:46 -07:00
Tiger Oakes
30930cdc88 Import variables referred to by path 2019-06-25 13:57:34 -07:00
Tiger Oakes
55f5c5d049 Use lifecycleScope for settings fragments 2019-06-25 13:56:33 -07:00
Tiger Oakes
d01bb8c442 Use lifecycleScope for collections fragments 2019-06-25 13:56:15 -07:00
Tiger Oakes
6bf8d6be34 Use @JvmOverloads instead of multiple constructors 2019-06-25 13:55:31 -07:00
Colin Lee
94e99cf877
For #3364: Edit bookmarks should show corrected bookmarks tree (#3446) 2019-06-25 14:19:33 -05:00
Emily Kager
74111c75de For #3639 - Remove fontInflationEnabled (#3640) 2019-06-25 10:24:32 -05:00
Colin Lee
d28bb76d25 No issue: Fix broken Settings test 2019-06-24 19:17:08 -07:00
Emily Kager
ddebc98718 No issue: Follow up on optional filter style 2019-06-24 17:03:38 -07:00
Colin Lee
ea7841b8c5 No issue: Add Sentry breadcrumbs to ease crash investigations 2019-06-24 16:21:43 -07:00
Sören Hentzschel
e1e4c7c1f9 No issue - reduce margin between favicon and title/url in library 2019-06-24 16:16:32 -07:00
Denys M
6d6b240e48 Add unit tests for Settings.
Add unit tests for `Settings`.
2019-06-24 16:02:34 -07:00
Emily Kager
718ac5612c For #3593 For #3581 - Pass sessions to delete to delete all with undo (#3594) 2019-06-24 15:41:38 -07:00
Emily Kager
084fab77d4 For #3609 - Remove FIP Integration, Use FIP Feature (#3637) 2019-06-24 15:31:32 -07:00
Emily Kager
6e3197f61c For #3622 - Add ID to engine shortcut suggestions (#3636) 2019-06-24 15:30:27 -07:00
royang51
e244aae104 For #3214 - History multi-selection aborted, the same item can't be selected again (#3607) 2019-06-24 15:27:06 -07:00
Sawyer Blatz
07516f47c3
For #3215: Adds collection restoration with unique IDs (#3635) 2019-06-24 14:12:51 -07:00
vmbaicu
021900e7ad Fixes #3527 - Set Collection name max length (#3531) 2019-06-24 13:58:04 -07:00
Nikit Bhandari
cfefc5632b For #3489: Disables blank collection names (#3490) 2019-06-24 13:44:02 -07:00
Andrei Teslovan
2ebe0a2a48 Fixes #3529 - Display "Edit folder" title when editing a bookmark folder (#3549) 2019-06-24 13:34:15 -07:00
Emily Kager
03a5cb2fb4 For #3620 - Adds automatic theme onboarding content description (#3629) 2019-06-24 13:15:38 -07:00
Sawyer Blatz
a5a518f4a5
For #2940: Hides send tab on FxA error (#3595) 2019-06-24 12:52:20 -07:00
Sawyer Blatz
721908ade6
For #3055: Adds android components version to about page (#3596) 2019-06-24 12:52:04 -07:00
Colin Lee
22bcd70edc
For #3213: Fix multi-select bookmarks on return to fragment (#3413) 2019-06-24 10:10:49 -07:00
Emily Kager
afb59251c1 For #3588 - Preload the content process when starting Gecko (#3589) 2019-06-20 13:00:22 -07:00