Mugurell
0324baef03
For #15968 - Show a border for the selected tab in the grid based tabs tray
...
The border for the grid item will now be updated in the same method that
updates the background for the list item.
2020-10-30 18:13:50 -04:00
Mugurell
482739ba8c
For #15756 - Add a play/pause button in the tabs tray grid layout
...
Moved the previous layout in a new, bigger FrameLayout that would serve as a
buffer space for the play/pause button to be translated to the exterior.
Otherwise the button would be clipped.
2020-10-30 18:13:50 -04:00
Gabriel Luong
66210469c0
For #9548 - Ability to rename top sites ( #16285 )
...
* Ability to rename top sites, closes #9548
* Highlight the "Remove" top site action as destructive
With more menu items in the top site contextual menu, it makes sense to differentiate
* Added test for the top site renaming action
* Fixed lint check (wildcard imports, blank spaces)
* Applied suggestions from code review
* Apply suggestions from code review
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
* Implemented dialog click listener with manual dismiss/cancel
Co-authored-by: Lorenzo Stanco <lorenzo.stanco@gmail.com>
2020-10-30 15:08:04 -04:00
ekager
9bb3440fce
No issue: Make sure we are cleaning up test coroutines
2020-10-29 18:57:23 -07:00
mozilla-l10n-automation-bot
d1ec6cac86
Import l10n. ( #16274 )
2020-10-29 21:40:40 -04:00
ekager
4246293a93
For #16161 - Fixes Saved Login toolbar layout
2020-10-29 16:10:06 -07:00
Codrut Topliceanu
975a5b76ec
For #14637 - Fix sitePermissionsFeature breaking change + AC bump ( #16229 )
...
* For #14637 - Compatibility patch for AC - 8554
* Update Android Components version to 65.0.20201029143039
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2020-10-29 19:08:31 -04:00
mozilla-l10n-automation-bot
e21c81a0dd
Import l10n. ( #16240 )
2020-10-29 10:42:14 -04:00
mcarare
3cb2c83980
For #16250 : Disable remote USB debugging for SDK <23.
2020-10-29 15:02:02 +01:00
Mihai Adrian Carare
0ee7e1c28d
For # 15929: Remove the search widget discoverability experiment. ( #16081 )
...
* For #15929 : Remove SearchWidgetCFR telemetry.
* For #15929 : Remove SearchWidgetCFR and search widget experiment.
* For #15929 : Remove unit tests references to search widget experiment.
2020-10-28 13:46:02 -07:00
mcarare
9748c65c71
For #15413 : Use proper url when bookmarking a page.
2020-10-28 16:33:48 +02:00
Oana Horvath
e36e61b2c3
For #10690 : re-enable editBookmarkTest
2020-10-28 16:09:52 +02:00
Mozilla L10n Automation Bot
5739140ff3
Import l10n.
2020-10-28 10:54:41 +01:00
Arturo Mejia
bb7d821804
Fix AddonsManagementFragment detekt error
2020-10-27 19:23:32 -04:00
Christian Sadilek
c330426bb7
No issue: Fix onConfigurationChange crashes in Debug build
2020-10-27 18:54:07 -04:00
Christian Sadilek
601aa19176
Closes #11285 : Replace Session[Manager] observers in BaseBrowserFragment
2020-10-27 17:40:58 -04:00
Grisha Kruglov
655a5cbf54
Closes #15816 - Attempt to handle 'allowInPrivate..' pref with detached context
2020-10-27 16:18:19 -04:00
mcarare
21a67de947
For #15379 : Use proper url when sharing.
2020-10-27 14:15:56 -04:00
ekager
9b2162fca2
For #16199 - Don't pass BrowserToolbarView in onStart when we just need parent
2020-10-27 09:13:13 -07:00
Arturo Mejia
0ae0b89d65
Fix add-on translation braking changes
2020-10-27 11:33:18 -04:00
Aaron Train
b8fff8cef1
For #8169 - Upgrade Mockwebserver ( #16186 )
...
Upgrades Mockwebserver to 4.9.0
2020-10-27 10:19:24 -04:00
mozilla-l10n-automation-bot
b8d6dbd426
Import l10n. ( #16198 )
2020-10-26 20:28:45 -04:00
Lorenzo Stanco
90220678cf
For #16122 - Add a dark theme color for the top sites pin icon ( #16180 )
2020-10-26 18:50:41 -04:00
mozilla-l10n-automation-bot
7d59a58134
Import l10n. ( #16163 )
2020-10-26 12:07:02 -04:00
mozilla-l10n-automation-bot
6353e9979e
Import l10n. ( #16154 )
2020-10-23 22:18:34 -04:00
ekager
e15f50712a
For #6313 - Set session ClearColor through Engine DefaultSettings
2020-10-22 20:36:04 -07:00
mozilla-l10n-automation-bot
4acf3c601d
Import l10n. ( #16138 )
2020-10-22 23:12:05 -04:00
Jocelyne Abi Haidar
f514f6099a
For #15508 : Show error when trying to save empty or invalid bookmark URL ( #15674 )
2020-10-22 17:22:37 -04:00
mozilla-l10n-automation-bot
c40b93715f
Import l10n. ( #16108 )
2020-10-21 21:01:50 -04:00
Mugurell
358ca2c87f
For #15543 - Adjust the height of the tabs tray depending on the number of tabs ( #15749 )
2020-10-21 19:21:37 -04:00
ekager
aae43b84eb
For #12062 - Feature Flag return to browser ( #16099 )
2020-10-21 16:29:06 -04:00
ekager
6b8f2001df
For #16084 - Match elevation of Tab in Collection to header ( #16100 )
2020-10-21 15:47:25 -04:00
ekager
d5cb9c599c
For #15910 - Adds back automatic toggle, disables slider when enabled ( #16070 )
2020-10-21 12:20:04 -04:00
Arturo Mejia
dbe6dbb18c
For #16019 - Fix intermittent test failure TrackingProtectionPolicyFactoryTest ( #16056 )
2020-10-21 10:25:25 -04:00
mcarare
1a10215caf
For #14619 : Show half a tab top offset when scrolling to selected tab.
2020-10-21 13:31:59 +03:00
mozilla-l10n-automation-bot
20df97ad57
Import l10n. ( #16074 )
2020-10-20 20:41:54 -04:00
Mugurell
57462d612f
For #16054 - Enable pull to refresh webpage in Nightly and Debug ( #16060 )
2020-10-20 20:41:14 -04:00
Elise Richards
7e3c26914c
For #15080 : Handle default search engine when editing or removing ( #15768 )
2020-10-20 16:00:00 -07:00
Juan C. Goncalves
eb0712d9b4
For #11397 - Add lint rule for AppCompatResources instead of ContextCompat ( #16011 )
2020-10-20 13:23:43 -07:00
Sebastian Kaspari
0d97862824
FennecWebAppIntentProcessor: Catch JSONException.
2020-10-20 15:46:18 +02:00
Mihai Adrian Carare
b1bc024ff5
For #11631 : Move report site issue extension to main menu. ( #15884 )
...
* For #11631 : Move report site issue extension to main menu.
* For #11631 : Update UI test for installing add-on.
2020-10-20 09:34:54 +03:00
Tom Klein
57ba92080f
For #15480 - Update the UI when a collection is renamed
2020-10-19 19:32:11 -07:00
mcarare
edd613ace2
For #15688 : Update UI tests.
2020-10-19 17:45:46 -07:00
mcarare
5f01583f25
For #15688 : Update unit tests.
2020-10-19 17:45:46 -07:00
mcarare
9274558e2f
For #15688 : Navigate to home screen with arguments on new tab action.
2020-10-19 17:45:46 -07:00
Mozilla L10n Automation Bot
ae74edecdb
Import l10n.
2020-10-19 17:37:17 -07:00
Sebastian Kaspari
2da24cd91d
Update Android Components, Kotlin, Gradle plugin ( #16021 )
...
* Closes #13262 : Update AGP to 4
* Update to Mozilla Android Components 63.0.20201019090011.
* Update Kotlin to 1.4.10 and Coroutines to 1.3.9.
* Fix new compiler warnings.
* Fix compilation of lint rules module.
* Pin JNA version.
* Fix new lint errors.
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
2020-10-19 14:07:47 -04:00
Mihai Adrian Carare
3ed49d8802
For #14744 : Also show Fill link from clipboard with search shortcuts. ( #15885 )
2020-10-19 13:58:54 -04:00
Christian Sadilek
f59cfd961c
Configure M5 AMO collection for all builds
2020-10-19 11:19:47 -04:00
mozilla-l10n-automation-bot
46ff7a182a
Import l10n. ( #16014 )
2020-10-18 23:26:52 -04:00
mozilla-l10n-automation-bot
c941bd99b0
Import l10n. ( #16001 )
2020-10-17 21:54:08 -04:00
mozilla-l10n-automation-bot
1d91f1f087
Import l10n. ( #15986 )
2020-10-17 09:41:31 -04:00
Gabriel Luong
d33bd76e40
For #15796 - Use the device locale for the system locale subtitle ( #15975 )
2020-10-17 09:40:28 -04:00
Gabriel Luong
87ec7a77ae
For #15937 - Remove topFrecentSite feature flag ( #15967 )
...
* For #15937 - Remove the topFrecentSite feature flag
* For #15937 - Hide the "Pull to refresh" preference since its visibility is managed by a feature flag
2020-10-16 18:37:27 -07:00
ekager
d208ffe002
For #7345 - Update new shield icons, remove lottie ( #15909 )
2020-10-16 16:01:38 -07:00
Christian Sadilek
c852301c93
Closes #11286 : Add TelemetryMiddleware to remove Session[Manager] observers
2020-10-16 11:05:34 -07:00
Gabriel Luong
412b412d5f
For #15796 - show device language under follow device language ( #15966 )
2020-10-16 12:47:56 -04:00
amkcpu
7ba5e130ba
For #10683 : Show longer tab titles
...
Also update tab tray item layout according to specs posted in the issue.
2020-10-16 15:50:29 +03:00
mozilla-l10n-automation-bot
a2a4284a1a
Import l10n. ( #15945 )
2020-10-15 17:29:04 -07:00
Jeff Boek
55515d8f7c
For #15596 - Removes upgrade faq link from fennec builds ( #15643 )
2020-10-15 15:02:51 -07:00
Gabriel Luong
b79df0ba8f
For #14922 : Use padding instead of margin to use the full screen width for the "Add search engine" button
2020-10-15 16:09:13 -04:00
mcarare
9f14007a98
For #14922 : Adjust margins for add search engine preference.
2020-10-15 16:09:13 -04:00
mcarare
ba0c005ae9
For #14922 : Add divider above address bar preferences.
2020-10-15 16:09:13 -04:00
mcarare
7510b1609f
For #15898 : Add dividers above subheadings in tabs screen.
2020-10-15 13:13:52 -04:00
mcarare
e50cb21fd0
For #15898 : Add dividers above subheadings in customise screen.
2020-10-15 13:13:52 -04:00
Michael Comella
439dfc5cb1
For #15644 : add comment for why we set the app theme in test.
2020-10-15 09:53:13 -07:00
Michael Comella
4a000ab4f9
For #15644 : change apply to with in GleanMetricsService.
...
While the callback receiver is identical in these two methods, they're
semantically different: apply is for initializing the receiver while with
is anything else benefiting from a new `this` receiver.
I didn't change the usage of apply that has a return statement because I
was afraid my change might change behavior.
2020-10-15 09:53:13 -07:00
Michael Comella
690554b5c6
For #15644 : mock package inspection dependencies in GleanMetricsService.
...
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.
2020-10-15 09:53:13 -07:00
ekager
2c7789b1a8
Sets theme in FenixRobolectricTestApplication onCreate
2020-10-15 09:53:13 -07:00
Michael Comella
3a6f74031c
For #15644 : escalate many Performance check severity in lint.xml.
...
I exhaustively looked through the list of checks labeled performance and
marked them accordingly. To see all lint checks, type:
<android-sdk>/tools/bin/lint --show
2020-10-15 09:53:13 -07:00
Michael Comella
fc9ae308d3
For #15644 : remove unnecessary lint ignore.
2020-10-15 09:53:13 -07:00
Michael Comella
ac953ab8ca
For #15644 : escalate InefficientWeight to error.
...
All violations of this type were addressed in the previous commit.
2020-10-15 09:53:13 -07:00
ekager
4d348dd26a
Fixes existing lint errors
2020-10-15 09:53:13 -07:00
Gabriel Luong
665a71cbb0
For #15907 - Remove the usage of the TabTrayGridItemDecorator
2020-10-15 10:02:07 -04:00
ekager
508ec8b8ff
For #15347 - Adds telemetry for tabs settings
2020-10-14 22:53:31 -04:00
ekager
b6587455f8
fix detekt errors
2020-10-14 18:22:02 -07:00
Sebastian Kaspari
430282c8ec
Use new SearchEngineProvider interface.
2020-10-14 18:22:02 -07:00
Mozilla L10n Automation Bot
ce99cc9ccf
Import l10n.
2020-10-14 17:49:27 -07:00
Michael Comella
ea2bb0df75
For #15280 - review: add license to lint-baseline.xml.
2020-10-14 15:20:28 -07:00
Michael Comella
341a92a10e
For #15280 : add current ConstraintLayout warnings to lint baseline.
2020-10-14 15:20:28 -07:00
Michael Comella
c6b83b10e0
For #15280 : suppress new lint rule in migration code.
2020-10-14 15:20:28 -07:00
ekager
e56043c485
For #15265 - Save cached top sites for metrics ping
2020-10-14 15:08:54 -07:00
ekager
cbe293d3e4
For #12062 - Launch back to browser if we previoulsy had tabs
2020-10-14 15:05:20 -07:00
Mugurell
dd83130d9f
For #15890 - Ensure app locale switcher works for Windows builds
...
A hardcoded unix file separator prevented us from building a proper list of
locales for which we actually have packaged translations.
2020-10-14 15:34:39 +02:00
Mozilla L10n Automation Bot
399c9c57fb
Import l10n.
2020-10-13 20:54:10 -04:00
ekager
7931d66c8e
For #15853 - Always set fontSizeFactor setting with new text scale
2020-10-13 09:40:43 -07:00
Mihai Adrian Carare
0e2657e262
For #14735 : Remove debug logs from release build. ( #15747 )
2020-10-13 09:17:58 -04:00
Mozilla L10n Automation Bot
2751da0372
Import l10n.
2020-10-12 17:50:57 -07:00
Gabriel Luong
ee5f678442
For #15777 - [Grid View] Set the height of the title to 30dp
2020-10-12 10:38:54 -07:00
Gabriel Luong
463f83a79a
For #15758 ⁃ [Grid View] Add a divider between the tab item's title and thumbnail
2020-10-12 10:38:54 -07:00
Mozilla L10n Automation Bot
83b5bae65e
Import l10n.
2020-10-11 22:55:02 -04:00
Mozilla L10n Automation Bot
25c9706cfd
Import l10n.
2020-10-11 10:04:34 -04:00
Grisha Kruglov
2030580fc8
Closes #15812 : Check for a null context during onScanResult
2020-10-09 20:40:03 -07:00
Mozilla L10n Automation Bot
d5bef99834
Import l10n.
2020-10-09 20:42:16 -04:00
Shen
45e3f7805b
For #13168 - Removed the close button from history navigation bar
2020-10-09 20:33:37 -04:00
Michael Comella
850d41a727
For #10069 - post: link to issue, data review.
2020-10-09 15:47:55 -07:00
Michael Comella
4179ab05bb
For #10069 - review: clarify init time for External...Activity.
2020-10-09 15:47:55 -07:00
Michael Comella
a1bbd2589e
For #10069 - review: change extra name to firstFramePreDrawNanos.
2020-10-09 15:47:55 -07:00
sraturi
8f16f9cb37
for #10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types.
2020-10-09 15:47:55 -07:00
mcarare
6516eff5c8
For #13831 : Adjust buttons dimensions to improve a11y.
...
Margins were also adjusted to maintain relative placements.
2020-10-09 15:39:31 -07:00
mcarare
e89b9756ee
For #13831 : Add ripple for the copy password button.
2020-10-09 15:39:31 -07:00
ekager
881e3d6ccd
For #14923 - Removes auto size preference toggle
2020-10-09 15:04:57 -07:00
Sijan Rijal
127d006d66
For #15402 : Hide ETP pop-up if the toolbar is not visible ( #15667 )
...
For #15402 : Hide ETP pop-up when top or bottom toolbar is not visible
2020-10-09 16:22:57 +03:00
Sijan Rijal
70908307fc
For #15497 : Hide and remove the three dot menu from the Desktop Bookmarks folder ( #15649 )
...
For #15497 : Remove and disable the three dot menu button
2020-10-09 14:39:03 +03:00
Mozilla L10n Automation Bot
0fbb28296e
Import l10n.
2020-10-08 21:20:56 -04:00
Jonathan Almeida
666781aa62
Fix lint warnings and test in site permissions
2020-10-08 19:37:56 -04:00
Arturo Mejia
de521192e0
Add support for local storage permission
2020-10-08 19:37:56 -04:00
Gabriel Luong
5153a3f2c5
For #15115 - Part 9: Fix ui tests for the tabs settings
2020-10-08 12:50:43 -04:00
Gabriel Luong
2dd019c05f
For #15115 - Part 8: Add a feature flag for showing the grid view in the tabs setting
2020-10-08 12:50:43 -04:00
Gabriel Luong
af0af7f88a
For #15115 - Part 7: Draw a border around the selected tab
2020-10-08 12:50:43 -04:00
Gabriel Luong
5fcc486caa
For #15115 - Part 6: Display the tab's favicon in the grid view
2020-10-08 12:50:43 -04:00
Gabriel Luong
5fa72cf48c
For #15115 - Part 5: Don't draw any background when swiping to delete a tab
2020-10-08 12:50:43 -04:00
Gabriel Luong
a001004add
For #15115 - Part 4: Formatted TabTrayView.kt
2020-10-08 12:50:43 -04:00
Gabriel Luong
6c77cdab41
For #15115 - Part 3: Implement a grid view layout for the tabs
...
Co-authored-by: Abhijit Valluri avalluri2@bloomberg.net
2020-10-08 12:50:43 -04:00
Gabriel Luong
2117dfb524
For #15115 - Part 2: Remove unused xmlns:mozac in component_tabstray.xml
2020-10-08 12:50:43 -04:00
Gabriel Luong
ed3986662f
For #15115 - Part 1: Convert the CloseTabsSettingsFragment to a general TabsSettingsFragment
...
- Renames CloseTabsSettingsFragment.kt to TabsSettingsFragment.kt
- Renames close_tabs_preferences.xml to tabs_preferences.xml
- Adds preference options for the switching between the Grid and List tab views
2020-10-08 12:50:43 -04:00
Michael Comella
7c0d00c800
No issue: fix tests related to inline change.
...
The difficulty in mocking StrictMode.resetAfter is concerning.
I'm starting to second-guess whether or not making strict mode manager a class
was a good idea.
2020-10-08 07:24:21 -07:00
Michael Comella
7b5cd8c165
No issue: remove inline from StrictModeManager.resetAfter.
...
I believe this was a premature optimization: it's unclear that it would
actually improve performance and yet we had to add several weird
workarounds to make it work that broke encapsulation. It's also
possible it would be worse for the APK size because of excessive
inlining.
2020-10-08 07:24:21 -07:00
Mozilla L10n Automation Bot
a72b5b0dd6
Import l10n.
2020-10-07 21:56:24 -07:00
Jonathan Almeida
ee673348bf
Issue #15754 : Disable failing notification UI tests
2020-10-07 20:01:35 -04:00
Jonathan Almeida
23d9951e78
Upgrade to Android Component 62.0.20201006190820 with breaking changes
2020-10-07 20:01:35 -04:00
Chenxia Liu
fe0ea19b1d
Adding link data review request
2020-10-07 11:02:42 -07:00
Chenxia Liu
6e522436b5
startup.timeline
2020-10-07 11:02:42 -07:00
Chenxia Liu
05f37e75fb
sync, sync_items, telemetry, theme, toolbar_position,
...
tracking_protection, default_engine
2020-10-07 11:02:42 -07:00
Chenxia Liu
8892a6ec85
accesssibility, open_links, remote_debugging, search_suggestions,
...
show_search
2020-10-07 11:02:42 -07:00
Chenxia Liu
5f74e18bca
search_count, search_widget, tabs_count, toolbar_position
2020-10-07 11:02:42 -07:00
Chenxia Liu
29970f5cb2
has, count: open_tabs, pwa, top_sites
2020-10-07 11:02:42 -07:00
Chenxia Liu
0b9c50f62e
default*browser, mozilla_products
2020-10-07 11:02:42 -07:00
Chenxia Liu
03e6167b5f
browser.search, events.total_uri_count, metrics.adjust*
2020-10-07 11:02:42 -07:00
Chenxia Liu
ca57a2d3ab
first_session
2020-10-07 11:02:42 -07:00
Chenxia Liu
815e159183
user_specified_search_engine, voice_search
2020-10-07 11:02:42 -07:00
Chenxia Liu
2edb812663
top_sites, tracking_protection
2020-10-07 11:02:42 -07:00
Chenxia Liu
bf381a6a7c
tab, tabs_tray, toolbar_settings
2020-10-07 11:02:42 -07:00
Chenxia Liu
bb7515f76e
syenc_account, sync_auth
2020-10-07 11:02:42 -07:00
Chenxia Liu
68ba986fd2
search_suggestions, search_shortcuts, search_widget
2020-10-07 11:02:42 -07:00
Chenxia Liu
965af504ad
private_browsing, qr_scanner
2020-10-07 11:02:42 -07:00
Chenxia Liu
04d0e59468
pocket, onboarding
2020-10-07 11:02:42 -07:00
Chenxia Liu
ac28667995
logins, media_notification, media_state
2020-10-07 11:02:42 -07:00
Chenxia Liu
d50fbd062d
Issue #14142 - find_in_page, history, reader_mode, tip
2020-10-07 11:02:42 -07:00
mcarare
9845626eca
For #15711 : Also add custom engines to fallback list.
2020-10-07 10:19:26 -07:00
mozilla-l10n-automation-bot
0ac7feacb4
Import l10n. ( #15738 )
2020-10-06 18:19:11 -07:00
Elise Richards
13f3304912
For #8765 : Use shared list widget in collections ( #15733 )
...
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
2020-10-06 16:24:08 -05:00
Michael Comella
4302cd20b2
For #13959 - post: decrement expected suppression count.
...
Running locally, I get the same error: I think that there legitimately
was an reduction in the number of StrictMode suppressions on start up.
2020-10-06 14:11:53 -07:00
Michael Comella
3e96f6b385
For #13959 - review: add clarifying comments.
2020-10-06 14:11:53 -07:00
Michael Comella
50959d997e
For #13959 : add marker when StrictMode is suppressed.
2020-10-06 14:11:53 -07:00
Michael Comella
3b5d6d58d9
For #13959 : add MozillaStrictModeSuppression detekt check.
2020-10-06 14:11:53 -07:00
Michael Comella
b222376cb0
For #13959 : add test to prevent increasing StrictMode suppression count.
2020-10-06 14:11:53 -07:00
Michael Comella
c33aafb024
For #13959 : add HomeActivityTestRule.skipOnboarding.
...
This is more correct, faster, and results in less copy-paste duplication
than the current behavior:
homeScreen { }.dismissOnboarding()
Which opens settings to dismiss onboarding.
2020-10-06 14:11:53 -07:00
Michael Comella
4a4edeb184
For #13959 : count StrictMode suppressions on startup.
2020-10-06 14:11:53 -07:00
Jocelyne Abi Haidar
a5de2c0352
For #15675 : Disable Save button when editing saved login until something has been changed
...
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
2020-10-06 11:47:12 +03:00