ishan/fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
5,289 Commits 34 Branches 356 Tags 125 MiB
20df97ad57
Commit Graph

4364 Commits

Author SHA1 Message Date
Grisha Kruglov
2030580fc8 Closes #15812: Check for a null context during onScanResult 2020-10-09 20:40:03 -07:00
Mozilla L10n Automation Bot
d5bef99834 Import l10n. 2020-10-09 20:42:16 -04:00
Shen
45e3f7805b For #13168 - Removed the close button from history navigation bar 2020-10-09 20:33:37 -04:00
Michael Comella
4179ab05bb For #10069 - review: clarify init time for External...Activity. 2020-10-09 15:47:55 -07:00
Michael Comella
a1bbd2589e For #10069 - review: change extra name to firstFramePreDrawNanos. 2020-10-09 15:47:55 -07:00
sraturi
8f16f9cb37 for #10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types. 2020-10-09 15:47:55 -07:00
mcarare
6516eff5c8 For #13831: Adjust buttons dimensions to improve a11y. 
Margins were also adjusted to maintain relative placements.
 2020-10-09 15:39:31 -07:00
mcarare
e89b9756ee For #13831: Add ripple for the copy password button. 2020-10-09 15:39:31 -07:00
ekager
881e3d6ccd For #14923 - Removes auto size preference toggle 2020-10-09 15:04:57 -07:00
Sijan Rijal
127d006d66
For #15402: Hide ETP pop-up if the toolbar is not visible (#15667) 
For #15402: Hide ETP pop-up when top or bottom toolbar is not visible
 2020-10-09 16:22:57 +03:00
Sijan Rijal
70908307fc
For #15497: Hide and remove the three dot menu from the Desktop Bookmarks folder (#15649) 
For #15497: Remove and disable the three dot menu button
 2020-10-09 14:39:03 +03:00
Mozilla L10n Automation Bot
0fbb28296e Import l10n. 2020-10-08 21:20:56 -04:00
Jonathan Almeida
666781aa62 Fix lint warnings and test in site permissions 2020-10-08 19:37:56 -04:00
Arturo Mejia
de521192e0 Add support for local storage permission 2020-10-08 19:37:56 -04:00
Gabriel Luong
5153a3f2c5 For #15115 - Part 9: Fix ui tests for the tabs settings 2020-10-08 12:50:43 -04:00
Gabriel Luong
2dd019c05f For #15115 - Part 8: Add a feature flag for showing the grid view in the tabs setting 2020-10-08 12:50:43 -04:00
Gabriel Luong
af0af7f88a For #15115 - Part 7: Draw a border around the selected tab 2020-10-08 12:50:43 -04:00
Gabriel Luong
5fcc486caa For #15115 - Part 6: Display the tab's favicon in the grid view 2020-10-08 12:50:43 -04:00
Gabriel Luong
5fa72cf48c For #15115 - Part 5: Don't draw any background when swiping to delete a tab 2020-10-08 12:50:43 -04:00
Gabriel Luong
a001004add For #15115 - Part 4: Formatted TabTrayView.kt 2020-10-08 12:50:43 -04:00
Gabriel Luong
6c77cdab41 For #15115 - Part 3: Implement a grid view layout for the tabs 
Co-authored-by: Abhijit Valluri avalluri2@bloomberg.net
 2020-10-08 12:50:43 -04:00
Gabriel Luong
2117dfb524 For #15115 - Part 2: Remove unused xmlns:mozac in component_tabstray.xml 2020-10-08 12:50:43 -04:00
Gabriel Luong
ed3986662f For #15115 - Part 1: Convert the CloseTabsSettingsFragment to a general TabsSettingsFragment 
- Renames CloseTabsSettingsFragment.kt to TabsSettingsFragment.kt
- Renames close_tabs_preferences.xml to tabs_preferences.xml
- Adds preference options for the switching between the Grid and List tab views
 2020-10-08 12:50:43 -04:00
Michael Comella
7c0d00c800 No issue: fix tests related to inline change. 
The difficulty in mocking StrictMode.resetAfter is concerning.
I'm starting to second-guess whether or not making strict mode manager a class
was a good idea.
 2020-10-08 07:24:21 -07:00
Michael Comella
7b5cd8c165 No issue: remove inline from StrictModeManager.resetAfter. 
I believe this was a premature optimization: it's unclear that it would
actually improve performance and yet  we had to add several weird
workarounds to make it work that broke encapsulation. It's also
possible it would be worse for the APK size because of excessive
inlining.
 2020-10-08 07:24:21 -07:00
Mozilla L10n Automation Bot
a72b5b0dd6 Import l10n. 2020-10-07 21:56:24 -07:00
Jonathan Almeida
ee673348bf Issue #15754: Disable failing notification UI tests 2020-10-07 20:01:35 -04:00
Jonathan Almeida
23d9951e78 Upgrade to Android Component 62.0.20201006190820 with breaking changes 2020-10-07 20:01:35 -04:00
mcarare
9845626eca For #15711: Also add custom engines to fallback list. 2020-10-07 10:19:26 -07:00
mozilla-l10n-automation-bot
0ac7feacb4
Import l10n. (#15738) 2020-10-06 18:19:11 -07:00
Elise Richards
13f3304912
For #8765: Use shared list widget in collections (#15733) 
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
 2020-10-06 16:24:08 -05:00
Michael Comella
4302cd20b2 For #13959 - post: decrement expected suppression count. 
Running locally, I get the same error: I think that there legitimately
was an reduction in the number of StrictMode suppressions on start up.
 2020-10-06 14:11:53 -07:00
Michael Comella
3e96f6b385 For #13959 - review: add clarifying comments. 2020-10-06 14:11:53 -07:00
Michael Comella
50959d997e For #13959: add marker when StrictMode is suppressed. 2020-10-06 14:11:53 -07:00
Michael Comella
3b5d6d58d9 For #13959: add MozillaStrictModeSuppression detekt check. 2020-10-06 14:11:53 -07:00
Michael Comella
b222376cb0 For #13959: add test to prevent increasing StrictMode suppression count. 2020-10-06 14:11:53 -07:00
Michael Comella
c33aafb024 For #13959: add HomeActivityTestRule.skipOnboarding. 
This is more correct, faster, and results in less copy-paste duplication
than the current behavior:
  homeScreen { }.dismissOnboarding()

Which opens settings to dismiss onboarding.
 2020-10-06 14:11:53 -07:00
Michael Comella
4a4edeb184 For #13959: count StrictMode suppressions on startup. 2020-10-06 14:11:53 -07:00
Jocelyne Abi Haidar
a5de2c0352 For #15675: Disable Save button when editing saved login until something has been changed 
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
 2020-10-06 11:47:12 +03:00
mozilla-l10n-automation-bot
5fed37cf45
Import l10n. (#15712) 2020-10-05 18:08:06 -07:00
Mozilla L10n Automation Bot
ad2b99f9f9 Import l10n. 2020-10-05 12:19:48 +02:00
mcarare
07748f69b7 For #15632: Improve checking open tabs logic to show collection button. 
Check now considers selected tab tray mode.
 2020-10-02 20:46:29 -04:00
ekager
ec3595d4fc For #15600 - Move removal of timed out sessions to immediately after restoration 2020-10-02 13:22:49 -07:00
ekager
01eedd159a No issue: Update biometric, core, and recyclerview libraries 2020-10-02 08:47:40 -07:00
mcarare
b696fc4c4b For #13031: Show size in KB for smaller downloaded files. 2020-10-02 11:04:48 -04:00
Mozilla L10n Automation Bot
ee4a5283a4 Import l10n. 2020-10-01 17:46:57 -07:00
Jocelyne
0154c81f81
For #10107: Show Today and Yesterday labels in History (#15415) 2020-10-01 16:42:50 -07:00
Jeff Boek
41a92a8d8b For #15593 - Reverts back to simple UUID creation without Fenix side caching 2020-10-01 15:51:30 -07:00
Jocelyne
e74a12b442
For #15471: Show Delete button in red in multi-select overflow menu (#15576) 2020-10-01 13:10:33 -07:00
Mozilla L10n Automation Bot
97adee3bd9 Import l10n. 2020-10-01 20:13:40 +02:00
Grisha Kruglov
51dab196c4 Closes #15443: Use fragment's lifecycleScope for AlertDialog actions 2020-09-30 17:42:40 -07:00
Christian Sadilek
ced92d69d1 Issue #15555: Set channel to Nightly explicitly for SettingsFragmentTest 2020-09-30 18:35:20 -04:00
mcarare
67310061a3 For #15559: Allow tabs to stretch in landscape mode for tablets. 
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
 2020-09-30 14:46:22 -07:00
Christian Sadilek
4a06e40e70 Closes #15555: Intermittent failures in SettingsFragmentTest 2020-09-30 14:53:18 -04:00
Stefan Arentz
ff930175de
For #15537 - Be more verbose about leanplum identifiers (#15538) 2020-09-30 13:05:28 -04:00
mcarare
19b377c021 For #15535: hasOpenTabs now considers the selected tab mode in tray tab. 2020-09-30 08:33:38 -07:00
Michael Comella
56f78cb30c No issue: elaborate on Components class doc. 
This is to clarify a misunderstanding I found in PR review.
 2020-09-29 15:39:10 -07:00
Sebastian Kaspari
2fda22e857 Revert "For #12565: Pass metrics to share controller" for debug test failures. 
This reverts commit bbaca06274.
 2020-09-29 10:59:31 +02:00
Sebastian Kaspari
4de466883b Revert "For #12565: Pass bookmark storage to controller" for debug test failures. 
This reverts commit 3c22100b84.
 2020-09-29 10:59:17 +02:00
Andrew Gaul
cfbad1dae9 Show undo snackbars with padding with static bottom toolbar 
This specifically fixes the close tab snackbar.  This commit mirrors
the logic when not using Undo from
9e876ebc44.  References #14982.
 2020-09-29 10:15:30 +02:00
ekager
01e802fef0 For #15324 - Show tab settings and recently closed items in menu when no tabs 2020-09-28 21:09:30 -07:00
ekager
e49cd9c558 For #15503 - Change recently closed max to 10 2020-09-29 00:03:49 -04:00
TrianguloY
b07af9ccd3
For #13856 - Prevent overscroll in swipe to switch tabs gesture 2020-09-28 20:43:44 -07:00
Tiger Oakes
25f62f1c76 Extract locale settings initial state 2020-09-28 20:39:49 -07:00
Tiger Oakes
acbad66f45 Add test for initial logins list state 2020-09-28 20:39:49 -07:00
Tiger Oakes
f2a6aa4f25 Add tests for initial collection creation state 2020-09-28 20:39:49 -07:00
Sören Hentzschel
01fdb4ac3f For #11561 - changed inactive heading and menu icon color in dark mode 2020-09-28 20:24:12 -07:00
Mozilla L10n Automation Bot
863b135723 Import l10n. 2020-09-28 20:18:50 -07:00
Tiger Oakes
3c22100b84 For #12565: Pass bookmark storage to controller 2020-09-28 20:05:50 -07:00
Tiger Oakes
bbaca06274 For #12565: Pass metrics to share controller 2020-09-28 20:05:50 -07:00
Michael Comella
d767cd199e For #13959: fix startup crash by using arg Context. 
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
 2020-09-28 18:01:19 -07:00
Michael Comella
42cca072e2 For #13959: remove resetAfter & port tests to StrictModeManager. 2020-09-28 18:01:19 -07:00
Michael Comella
dd73cb628b For #13959: clean up existing StrictMode test names. 2020-09-28 18:01:19 -07:00
Michael Comella
f19c9920f9 For #13959: move resetAfter into StrictModeManager. 
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.

Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```

We're going to have to add a lint check to prevent them from doing that.
 2020-09-28 18:01:19 -07:00
Michael Comella
6abeb2d9e7 For #13959: change StrictModeManager to class from object. 
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
 2020-09-28 18:01:19 -07:00
Christian Sadilek
d4ab728cff For #14034: Add debug preference to override AMO collection in Nightly 2020-09-28 17:25:52 -04:00
Michael Comella
a92356fe00 For #13959: comment about duplication in logic in StrictMode. 
I had to drop a commit that addressed the issue because it was too hard
to fix.
 2020-09-28 13:52:40 -07:00
Michael Comella
e1bd6191c7 For #13959: add comment to explain why we only resetAfter in certain build modes. 2020-09-28 13:52:40 -07:00
Michael Comella
3bf71ef655 For #13959: use ac StrictMode.resetAfter rather than duplicating functionality. 2020-09-28 13:52:40 -07:00
Michael Comella
2c1befaa25 For #13959: rename to attachListenerToDisablePenaltyDeath for clarity. 2020-09-28 13:52:40 -07:00
Michael Comella
c03c7ef793 For #13959: remove unused penaltyDialog parameter. 
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
 2020-09-28 13:52:40 -07:00
Michael Comella
f05a542060 For #13959: always enable detectNonSdkApiUsage. 
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
 2020-09-28 13:52:40 -07:00
Sebastian Kaspari
3983c509dc Use "undo" implementation from Android Components. 
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.

Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
 2020-09-28 10:04:46 -07:00
Mozilla L10n Automation Bot
d287e6e9e0 Import l10n. 2020-09-28 17:16:11 +02:00
mcarare
daced89387 For #15310: Add test for ActivityNotFoundException when sharing to app. 2020-09-28 13:29:17 +03:00
mcarare
6289da892c For #15310: Also catch ActivityNotFoundException when sharing to app. 2020-09-28 13:29:17 +03:00
ekager
0d0a28d551 No issue: Update AC to 61.0.20200925190057 2020-09-26 12:21:10 +02:00
ekager
7d5c199e51 For #12383 #15407 #12860 - Switch to using shared view model for session to delete on home 2020-09-25 16:54:54 -07:00
Grisha Kruglov
2999f64d0a Closes #15434: Don't try to display a 'signed in' snackbar in a 'headless' mode 2020-09-25 15:31:07 -07:00
Grisha Kruglov
d98eba1d64 Closes #15432: Invoke UI updates on main thread in response to account events 2020-09-25 15:30:48 -07:00
Grisha Kruglov
24985d54fa Closes #15436: Auto-close tabs during startup on the main thread 2020-09-25 15:11:21 -07:00
mcarare
cd53b8fdaf For #15130: Remove "what's new card" check in UI test. 2020-09-25 18:04:48 +03:00
mcarare
04e59e0ac5 For #15130: Remove "what's new card" from onboarding screen. 2020-09-25 18:04:48 +03:00
Mozilla L10n Automation Bot
f32d2011df Import l10n. 2020-09-24 18:03:47 -07:00
Kate Glazko
e8855c09e6 For #15320: Ensure Mimetype Other PDF Shows PDF Icon 2020-09-24 13:49:51 -07:00
Elise Richards
1adf467248
For #14280, #14743: Remove old search fragment (#15169) 
* Remove search fragment

* Use new folder to search dialog

* Rebase and lint

* Update tests with search dialog nav directions

* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
 2020-09-24 15:46:42 -05:00
Jonathan Almeida
add60611b4 For #15349: Fixes SyncedTabs suggestion not clicking 2020-09-24 15:35:06 -04:00
Grisha Kruglov
f1b0827a0b For #15296: Allow excluding bookmark subtrees when editing parent folder 
I'm really not a fan of how title overwriting and structure processing are mangled together,
but will leave clearing that up for another day.
 2020-09-23 23:22:44 -07:00
Mozilla L10n Automation Bot
4fad099b23 Import l10n. 2020-09-23 21:16:24 -07:00
Sawyer Blatz
0fa2509bef
For #14243: Pre-land visuals for Close Tabs CFR (#15171) 2020-09-23 14:57:52 -07:00