Commit Graph

1302 Commits

Author SHA1 Message Date
Colin Lee
7481d52c4b
For #3505: Opening a sent tab crashes Fenix (#3507) 2019-06-27 10:47:54 -05:00
Nikit Bhandari
6ccd32f093 For #3496: dismiss share fragment when clicking outside content (#3513)
* dismiss share fragment when clicking outside content

* add logic in view layer
2019-06-27 10:43:13 -05:00
Emily Kager
77edb7afe1 For #2960 Closes #3671 - Fixes bookmark deletion with undo, wraps list 2019-06-26 18:59:13 -07:00
ekager
61a8795576 For #1211 - Hide keyboard on fling suggestions list 2019-06-26 16:44:35 -07:00
ekager
eb54d7c97f For #3690 - Gives defined size to pill_wrapper 2019-06-26 16:44:35 -07:00
Tiger Oakes
e8bd090a8e No issue: Use ImageView rather than rebuilding drawable (#3616)
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
2019-06-26 16:03:06 -07:00
Tiger Oakes
4994554576 No issue: Adds lint exception for when statement (#3685) 2019-06-26 15:52:24 -07:00
Sawyer Blatz
309014139d For #3488: Cleans up edit mode calls (#3689) 2019-06-26 15:40:07 -05:00
Yeon Taek Jeong
2cafd5bba6 For #3678: Fix crash when tapping on your account (#3688) 2019-06-26 13:33:27 -07:00
Emily Kager
a1ddf17364 Closes #3569 - Uses primary text attr for bookmark folder icon (#3675) 2019-06-26 15:29:21 -05:00
Emily Kager
427bc5c1e6 Revert "For #1211 - Hide keyboard on fling suggestions list"
This reverts commit cb6fd83c9879c268cb739fb768187d5276c5af66.
2019-06-26 11:19:09 -07:00
Tiger Oakes
a78d36354a Switch RadioButtonPreference to ConstraintLayout
Also ensure that RTL works properly.
2019-06-26 09:45:55 -07:00
Sawyer Blatz
d28168ac64 For #2940: Hides send tab header on FxA error 2019-06-25 17:08:46 -07:00
Tiger Oakes
30930cdc88 Import variables referred to by path 2019-06-25 13:57:34 -07:00
Tiger Oakes
55f5c5d049 Use lifecycleScope for settings fragments 2019-06-25 13:56:33 -07:00
Tiger Oakes
d01bb8c442 Use lifecycleScope for collections fragments 2019-06-25 13:56:15 -07:00
Tiger Oakes
6bf8d6be34 Use @JvmOverloads instead of multiple constructors 2019-06-25 13:55:31 -07:00
Colin Lee
94e99cf877
For #3364: Edit bookmarks should show corrected bookmarks tree (#3446) 2019-06-25 14:19:33 -05:00
Emily Kager
74111c75de For #3639 - Remove fontInflationEnabled (#3640) 2019-06-25 10:24:32 -05:00
Colin Lee
d28bb76d25 No issue: Fix broken Settings test 2019-06-24 19:17:08 -07:00
Emily Kager
ddebc98718 No issue: Follow up on optional filter style 2019-06-24 17:03:38 -07:00
Colin Lee
ea7841b8c5 No issue: Add Sentry breadcrumbs to ease crash investigations 2019-06-24 16:21:43 -07:00
Sören Hentzschel
e1e4c7c1f9 No issue - reduce margin between favicon and title/url in library 2019-06-24 16:16:32 -07:00
Denys M
6d6b240e48 Add unit tests for Settings.
Add unit tests for `Settings`.
2019-06-24 16:02:34 -07:00
Emily Kager
718ac5612c For #3593 For #3581 - Pass sessions to delete to delete all with undo (#3594) 2019-06-24 15:41:38 -07:00
Emily Kager
084fab77d4 For #3609 - Remove FIP Integration, Use FIP Feature (#3637) 2019-06-24 15:31:32 -07:00
Emily Kager
6e3197f61c For #3622 - Add ID to engine shortcut suggestions (#3636) 2019-06-24 15:30:27 -07:00
royang51
e244aae104 For #3214 - History multi-selection aborted, the same item can't be selected again (#3607) 2019-06-24 15:27:06 -07:00
Sawyer Blatz
07516f47c3
For #3215: Adds collection restoration with unique IDs (#3635) 2019-06-24 14:12:51 -07:00
vmbaicu
021900e7ad Fixes #3527 - Set Collection name max length (#3531) 2019-06-24 13:58:04 -07:00
Nikit Bhandari
cfefc5632b For #3489: Disables blank collection names (#3490) 2019-06-24 13:44:02 -07:00
Andrei Teslovan
2ebe0a2a48 Fixes #3529 - Display "Edit folder" title when editing a bookmark folder (#3549) 2019-06-24 13:34:15 -07:00
Emily Kager
03a5cb2fb4 For #3620 - Adds automatic theme onboarding content description (#3629) 2019-06-24 13:15:38 -07:00
Sawyer Blatz
a5a518f4a5
For #2940: Hides send tab on FxA error (#3595) 2019-06-24 12:52:20 -07:00
Sawyer Blatz
721908ade6
For #3055: Adds android components version to about page (#3596) 2019-06-24 12:52:04 -07:00
Colin Lee
22bcd70edc
For #3213: Fix multi-select bookmarks on return to fragment (#3413) 2019-06-24 10:10:49 -07:00
Emily Kager
afb59251c1 For #3588 - Preload the content process when starting Gecko (#3589) 2019-06-20 13:00:22 -07:00
Emily Kager
b1102c2e76 For #3544 - Set SearchSuggestions preference value from settings 2019-06-18 16:56:34 -07:00
Tiger Oakes
ab6101b0f4 Fixes #3539 - vectordrawablecompat for gradients (#3541) 2019-06-18 16:38:56 -07:00
Tiger Oakes
b70dced16e Fixes #3538 - Fix ic_tabs icon path (#3540) 2019-06-18 16:38:42 -07:00
Colin Lee
0135424883 For #3508: "Send crash report" checkbox is ignored (#3512) 2019-06-18 16:38:29 -07:00
Grisha Kruglov
521312c6f8 Disable send tab for non-nightly, non-debug builds (#3542)
* Put deviceCapabilities list behind a SEND_TAB_ENABLED flag

* Disable SEND_TAB for non-debug, non-nightly builds
2019-06-18 16:37:50 -07:00
Mihai Tabara
ccc5b91992 Import PR 3500 from ekager 2019-06-14 18:52:27 -07:00
Stefan Arentz
6e6e662c47 Update HomeFragment.kt 2019-06-14 18:34:58 -07:00
Jeff Boek
90bdbd04e0 No Issue - Capture session manager in scope before creating the delete operation 2019-06-14 18:34:58 -07:00
Emily Kager
ac5c4a0f79 Closes #3493 - Show tab saved to collection snackbar in BrowserFragment 2019-06-14 15:49:56 -07:00
Jeff Boek
7ebdfcc87b For #1116 - Uses alias link for help 2019-06-14 15:33:34 -07:00
Jeff Boek
5540230e3d For #1116 - Changes help link (#3491) 2019-06-14 15:29:10 -05:00
Jeff Boek
3b848393f7 For #981 - Adds link to mma.md to telemetry.md 2019-06-14 13:27:50 -07:00
Jeff Boek
45b096c84f For #981 - mma docs 2019-06-14 13:27:50 -07:00
Jeff Boek
f323c38be0 For #981 - Adds missing Leanplum events 2019-06-14 13:27:50 -07:00
Colin Lee
e7576b2831
For i18n testing: Enable pseudolocales (#3391) 2019-06-14 13:44:36 -05:00
Emily Kager
6bd9b82385 No issue: Remove flash of tab adapter updating data in create collection 2019-06-14 11:01:54 -07:00
Emily Kager
1de63df01f Closes #3080 - Update constraints so first collection visible by default 2019-06-14 11:01:54 -07:00
Colin Lee
d5c5587a0c
For #3209: Disable shared element animations for crash temporarily (#3482) 2019-06-14 12:13:13 -05:00
Emily Kager
9009d16ac6 Closes #3452 Closes #3553 - Implement one button style for all themes 2019-06-14 09:38:17 -07:00
Tiger Oakes
f0f5374a57 Minify vector drawables 2019-06-14 09:37:35 -07:00
Sawyer Blatz
041eaa2a5c
For #3275: Cleans up feedback from James (#3398) 2019-06-14 08:59:57 -07:00
Johan Lorenzo
2f8dc488bc Let raptor use the geckoview builds 2019-06-14 14:59:42 +02:00
Axel Hecht
22f39fbebf Import strings from android-l10n
State: mozilla-l10n/android-l10n@60fcf55878
2019-06-14 14:19:01 +02:00
Emily Kager
a941b875b4 For #3439 - Clean up where accent colors didn't work with dark theming 2019-06-13 22:39:00 -07:00
Emily Kager
7abf135c89 For #2896 - Update Checkbox color on tab in collection creation 2019-06-13 22:38:08 -07:00
Emily Kager
e28277693b Closes #3428 - Make + in collection creation selection stage clickable 2019-06-13 22:37:47 -07:00
Sawyer Blatz
c48d7fb0c3 For #3447: Fixes folder icon color 2019-06-13 16:40:42 -07:00
Jonathan Almeida
986bc91347 For #3401: Update toolbar tab counter when view is attached
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2019-06-13 16:12:19 -07:00
vladikoff
dfe181aa0a Add application-services fretboard feature flags 2019-06-13 15:29:59 -07:00
Emily Kager
ce33054173 Closes #3454 - Update Collections Icon in Delete Browsing Data 2019-06-13 15:23:08 -07:00
Emily Kager
8b4c2db4e4 For #3433 - Add checkbox hide changes to change payload 2019-06-13 13:01:44 -07:00
Emily Kager
1f1320920f For #3275 - Invoke pending single session delete job on close all (#3438) 2019-06-13 12:58:45 -05:00
Jeff Boek
1212887e08 For #1242 - properly record metrics (#3437) 2019-06-13 09:57:56 -07:00
Emily Kager
510b6f7373 For #2899 - Improve collections scroll and highlight animations 2019-06-13 09:21:12 -07:00
Andrei Teslovan
e458d8b6a1 Fixes #3365 - Set selectedFolder to null if it's already selected (#3415) 2019-06-13 10:52:35 -05:00
Emily Kager
5eb2bc6d55 For #3138 - Sets height of toolbar in SearchFragment to match_parent (#3400) 2019-06-12 19:44:44 -05:00
Sawyer Blatz
381a5e6089 For #3403: Subscribes to tab collections in BrowserFragment 2019-06-12 16:44:35 -07:00
Jeff Boek
227a80957e For #382 - Include Marshmellow in the guard.. 2019-06-12 15:45:58 -07:00
Jeff Boek
dad671ca3c For #382 - Hides default browser switch for older versions of Android 2019-06-12 15:07:58 -07:00
Jonathan Almeida
1b7a9817e2 For #2905: Remove device name during sync logout 2019-06-12 17:07:56 -04:00
Jonathan Almeida
f71bdcfd10 For #3388: Set max length for device name (#3397) 2019-06-12 15:35:06 -05:00
Colin Lee
f1088222b4
For #3203: Updates edit bookmarks to have user friendly names (#3372)
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>"
2019-06-12 14:10:43 -05:00
Tiger Oakes
2868e376a6 Replace notification icon (#3395) 2019-06-12 14:07:20 -05:00
Emily Kager
186983b786 For #3275 - Adds PendingSessionDeletion data class to handle multiple emit session calls (#3393) 2019-06-12 10:49:20 -07:00
Jonathan Almeida
80e7868fd7 For #1134: Set UA to GeckoView 69.0 for whitelisted domains 2019-06-12 13:27:42 -04:00
Sawyer Blatz
7bcc8d576e For #2219: Inflates toolbar menu from bottom (#3389) 2019-06-12 11:17:33 -05:00
Andrei Teslovan
d70b6418b4 Issue 3334 - Fix icons alignment in Collections cards (#3382) 2019-06-12 10:26:13 -05:00
Colin Lee
66a836cf3a
For #3314: Toolbar and QAB unresponsive after Android 6 perms check (#3373) 2019-06-12 10:08:39 -05:00
Jeff Boek
94556cceda For #3278 - Fixes property order in search_engine_radio_button.xml 2019-06-11 16:24:28 -07:00
Jeff Boek
332b4c4da5 For #3278 - makes the string a constant 2019-06-11 16:24:28 -07:00
Jeff Boek
fc603e65a5 For #3278 - Removed redundant override 2019-06-11 16:24:28 -07:00
Jeff Boek
fead5183c8 For #3278 - pin the default search engine to the top 2019-06-11 16:24:28 -07:00
Jeff Boek
a86ec60f8f For #3278 - Fixes search engine selector layout 2019-06-11 16:24:28 -07:00
Jeff Boek
811fbfc5fd For #3278 - Removes icon and preference item 2019-06-11 16:24:28 -07:00
Emily Kager
68fe93b420 For #3369 - Assign dark mode new collection icon colors (#3370) 2019-06-11 17:38:05 -05:00
Tiger Oakes
c73ba83f45 Minify drawable assets 2019-06-11 15:11:33 -07:00
Emily Kager
71f2b0bdaa For #2253 - Use toolbar as anchorView with fullscreen snackbar 2019-06-11 15:09:07 -07:00
Jonathan Almeida
8e3aeb1545 No issue: Enable send tab for all builds 2019-06-11 18:02:39 -04:00
Christian Sadilek
ccc7c70967 For #3252: Reader mode appearance buttons are not visible in PB
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2019-06-11 18:02:29 -04:00
a79014
d2c3427f1e Doesn't print gecko emoji on android ver < 7 (android N) (#3115)
* Doesnt print gecko emoji on android ver < 7

* fixed typo on maybeGecko variable

* Closes #3076: Lizard char now doesn't appear if not supported androidver

* Closes #3115: Prints string instead of gecko emoji in unsupported
android versions
2019-06-11 16:40:51 -05:00
Emily Kager
edc1422b68 For #3288 - call setChecked after calling setOnCheckedChangeListener (#3357) 2019-06-11 16:38:32 -05:00
Colin Lee
b498f5559b
For #3333: Only show desktop bookmarks if logged in (#3356) 2019-06-11 16:37:34 -05:00
jhugman
26d0ddda98 Fixes #3358 - disable feature-app-links (#3359) 2019-06-11 16:34:28 -05:00
Emily Kager
de45dfd98a For #3131 - Add new task and clear task flags when opening intent (#3363) 2019-06-11 16:33:38 -05:00
Gabriel Luong
f05eb032d4 For #2684: Add an extension function Session.toTab to map Session to Tab and clean up their usage 2019-06-11 13:14:23 -07:00
Jeff Boek
cce41afb7e For #3351 - Adds docs for search_default_engine telemetry 2019-06-11 10:55:54 -07:00
vmbaicu
a2f2a23a15 Fixes #3281 - Fix Report and onboarding lint errors and issues (#3339) 2019-06-11 12:33:12 -05:00
Sawyer Blatz
3e5b6ca007 For #975: Removes leakcanary and default browser telemetry (#3350) 2019-06-11 12:30:25 -05:00
Emily Kager
82cf81242f For #3331 - Delay restoring layout while list restores (#3354) 2019-06-11 12:27:32 -05:00
Tiger Oakes
2e0a0ab65a Fix round icon (#3353) 2019-06-11 12:26:08 -05:00
Axel Hecht
7c37f77cfc Import strings from android-l10n
State: mozilla-l10n/android-l10n@53a583feb6
2019-06-11 09:49:26 -07:00
Sawyer Blatz
decacbfc97 For #3323 Runs PublicSuffixList synchronously 2019-06-11 09:19:51 -07:00
Grisha Kruglov
a58a77317e Automatically close the 'auth-problems fragment' once we're through the auth flow (#3340) 2019-06-11 09:36:05 -05:00
Emily Kager
e57e7b50ee For #2899 - Scroll to Collections on change, animate new collections (#3279)
* For #2899 - Scroll to Collections on change, animate new collections

* For #2899 - Scroll to tabs when tabs opened from collection
2019-06-11 09:01:00 -05:00
Emily Kager
975975e789 For #3326 - Remove open image in tab from context menu (#3327) 2019-06-11 08:59:00 -05:00
Thom Chiovoloni
4d82c29743 Don't substitute application-services packages which are not part of the megazord 2019-06-10 15:24:27 -07:00
Sawyer Blatz
c17d024452
For #975: Adds preferenceToggled event (#3316)
🤦🏼‍♂️
2019-06-10 13:56:12 -07:00
Sawyer Blatz
ab000d2e51
For #3280: Revert "For #3215: Restores collections properly" (#3320)
This reverts commit 3e9ee79c00f4a6b34af74ce7c179e0cbe37decf5.
2019-06-10 13:54:03 -07:00
Arturo Mejia
5df726715f Revert "For #3008, For #2162 Add Simple Logic for Menu Orientation" (#3310)
#3114
2019-06-10 10:58:18 -05:00
Colin Lee
f7b5fc3e18
For #3186: Add environment to Sentry reports (#3261) 2019-06-10 10:55:39 -05:00
Tiger Oakes
82d2a0661b Remove deprecatd support-ktx methods (#3305) 2019-06-10 09:12:11 -05:00
Tiger Oakes
64229f6f34 Minify launcher icon (#3309) 2019-06-10 09:10:29 -05:00
Denys M
c9570fd6ff Use Drawable.toBitmap() from androidx-ktx. (#3286) 2019-06-10 08:50:37 -04:00
Nikit Bhandari
d814e95794 fix crash on renaming a collection 2019-06-08 06:44:15 -07:00
Jeff Boek
b42b4df024 No Issue - Moves string to static string until next export (#3274) 2019-06-07 19:38:45 -05:00
Sawyer Blatz
86aac3e313 For #3176: Hides camera options on devices without cameras (#3273) 2019-06-07 19:37:43 -05:00
Emily Kager
bf4916418a For #1998 - Removes stable flag in entering fullscreen navigation 2019-06-07 15:20:30 -07:00
Sawyer Blatz
b2ca77269b
For #3251: Fixes shortcut typing (#3271) 2019-06-07 15:07:46 -07:00
Sawyer Blatz
054635735a
For #2750: Removes unecessary invalidate CollectionViewHolder call (#3264) 2019-06-07 13:38:18 -07:00
Jeff Boek
5dfde74376 For #1881 - Uses flex box to pin button to the bottom 2019-06-07 13:15:26 -07:00
Sawyer Blatz
45c509fbce
For #2648: Updates trimming of url hostname (#3191)
* For #2648: Updates trimming of url hostname

* For #2648: Fix nits
2019-06-07 09:33:07 -07:00
Emily Kager
7368a95d29 No issue: Sets up observers for tab collection changes (#3248) 2019-06-07 09:45:38 -05:00
Axel Hecht
ada0c4da28 Import strings from android-l10n (#3253)
State: mozilla-l10n/android-l10n@8a22efc7b2
2019-06-07 09:44:17 -05:00
Jonathan Almeida
f7bd39da77 For #3138: Fix white background on search bar 2019-06-06 17:11:06 -07:00
Colin Lee
1e6da54263 For #3238: fixes race condition crash, nav destination unknown 2019-06-06 15:46:34 -07:00
Jonathan Almeida
0a3b001abe For #3167: Show help page in browser menu (#3230) 2019-06-06 16:55:15 -05:00
Emily Kager
acea0d5668 For #2785 - Adds back item animator session control (#3233) 2019-06-06 16:54:49 -05:00
Emily Kager
ed39b7828b For #3234 - Updates labels of fragments in the nav graph to avoid flash (#3235) 2019-06-06 16:52:25 -05:00
Grisha Kruglov
01ef0d5ac2 No issue: Use 'Turn on Sync' instead of 'Sign In'
Seems like we've started using a wrong string at some point.
Thankfully, the correct one is already in the tree.
2019-06-06 14:11:54 -07:00
Colin Lee
9e5d0a2408 For #1301: Change ping for total_uri_count 2019-06-06 12:58:55 -07:00
Jeff Boek
0fefbbf5fb For #1809 - Restore all crashed tabs 2019-06-06 12:58:32 -07:00
Sawyer Blatz
8537ff10a8 For #3215: Restores collections properly (#3219) 2019-06-06 14:26:05 -05:00
Emily Kager
4954aadd84 For #3156 - If only one tab adding to collection make it selected (#3222) 2019-06-06 14:24:25 -05:00
Jonathan Almeida
c197d055b3 For #3047: Fix blank space for system edit text controls (#3227) 2019-06-06 14:22:58 -05:00
Colin Lee
28ecf241f5
For #1301: Always observe sessions to keep uri_count (#3172) 2019-06-06 14:16:31 -05:00
Sawyer Blatz
6682386fc8 For #1242 & #975: Fixes camelcase of telemetry 2019-06-06 10:59:09 -07:00
Denys M
605a552f16 For #1366. Update toolbar search state when typing. (#2908) 2019-06-06 08:16:22 -07:00
Emily Kager
33eb26861d For #3141 For #3142 Do not try to fade BrowserFragment in transitions (#3195) 2019-06-05 20:37:58 -05:00
Emily Kager
9624964bc3 For #3087 - Adds disabled color attr (#3192)
* For #3087 - Adds disabled color attr

* Change alpha to 40%
2019-06-05 20:37:16 -05:00
Emily Kager
93a5456785 For #2253 - Shorten Fullscreen snackbar length (#3190) 2019-06-05 20:36:13 -05:00
Emily Kager
883afe9bd4 No issue: Update dependencies 2019-06-05 16:30:01 -07:00
Emily Kager
704f1e6a3d For #3004 - Restore MotionLayout on Home View only in onCreateView 2019-06-05 14:46:38 -07:00
Grisha Kruglov
fe3c163a20 Fix how we reflect FxA state in preference
This cleans up how we're displaying account state in the main preference UI.
Before when it worked, it worked mostly accidentally.
'launch' wrapper around "update ui" methods would trigger a race condition
between binding the account pref view holder and actually updating that view
with values. Sometimes the "update view with values" would happen after view
was bound, and the UI will be correct. Most of the time it would happen before,
and so there will be nothing to update and we'd get into an inconsistent state.

This also splits up the "accountpreference" into two: account is good,
and account needs re-auth. This greatly simplifies their management.
2019-06-05 14:38:06 -07:00