Fixes #22688: remove inactive_tabs_recently_closed probe
This commit is contained in:
parent
986a48b1db
commit
fee26e62a8
|
@ -3030,19 +3030,6 @@ tabs_tray:
|
|||
- android-probes@mozilla.com
|
||||
- erichards@mozilla.com
|
||||
expires: never
|
||||
inactive_tabs_recently_closed:
|
||||
type: event
|
||||
description: |
|
||||
A user tapped the "Recently closed" option of the inactive tabs menu.
|
||||
bugs:
|
||||
- https://github.com/mozilla-mobile/fenix/issues/20328
|
||||
data_reviews:
|
||||
- https://github.com/mozilla-mobile/fenix/issues/20328
|
||||
data_sensitivity:
|
||||
- interaction
|
||||
notification_emails:
|
||||
- android-probes@mozilla.com
|
||||
expires: "2022-08-01"
|
||||
inactive_tabs_expanded:
|
||||
type: event
|
||||
description: |
|
||||
|
|
|
@ -203,7 +203,6 @@ sealed class Event {
|
|||
object TabsTraySaveToCollectionPressed : Event()
|
||||
object TabsTrayShareAllTabsPressed : Event()
|
||||
object TabsTrayCloseAllTabsPressed : Event()
|
||||
object TabsTrayRecentlyClosedPressed : Event()
|
||||
object TabsTrayInactiveTabsExpanded : Event()
|
||||
object TabsTrayInactiveTabsCollapsed : Event()
|
||||
object TabsTrayAutoCloseDialogSeen : Event()
|
||||
|
|
|
@ -614,9 +614,6 @@ private val Event.wrapper: EventWrapper<*>?
|
|||
is Event.TabsTrayCloseAllTabsPressed -> EventWrapper<NoExtraKeys>(
|
||||
{ TabsTray.closeAllTabs.record(it) }
|
||||
)
|
||||
is Event.TabsTrayRecentlyClosedPressed -> EventWrapper<NoExtraKeys>(
|
||||
{ TabsTray.inactiveTabsRecentlyClosed.record(it) }
|
||||
)
|
||||
is Event.TabsTrayInactiveTabsExpanded -> EventWrapper<NoExtraKeys>(
|
||||
{ TabsTray.inactiveTabsExpanded.record(it) }
|
||||
)
|
||||
|
|
|
@ -205,8 +205,6 @@ class DefaultTabsTrayController(
|
|||
dismissTray()
|
||||
|
||||
navController.navigate(R.id.recentlyClosedFragment)
|
||||
|
||||
metrics.track(Event.TabsTrayRecentlyClosedPressed)
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
|
@ -4,7 +4,6 @@
|
|||
|
||||
package org.mozilla.fenix.components.metrics
|
||||
|
||||
import io.mockk.MockKAnnotations
|
||||
import mozilla.components.service.glean.testing.GleanTestRule
|
||||
import mozilla.components.support.test.robolectric.testContext
|
||||
import org.junit.Assert.assertEquals
|
||||
|
@ -34,8 +33,6 @@ class GleanMetricsServiceTest {
|
|||
|
||||
@Before
|
||||
fun setup() {
|
||||
MockKAnnotations.init(this)
|
||||
|
||||
gleanService = GleanMetricsService(testContext)
|
||||
}
|
||||
|
||||
|
@ -286,10 +283,6 @@ class GleanMetricsServiceTest {
|
|||
assertFalse(TabsTray.closeAllTabs.testHasValue())
|
||||
gleanService.track(Event.TabsTrayCloseAllTabsPressed)
|
||||
assertTrue(TabsTray.closeAllTabs.testHasValue())
|
||||
|
||||
assertFalse(TabsTray.inactiveTabsRecentlyClosed.testHasValue())
|
||||
gleanService.track(Event.TabsTrayRecentlyClosedPressed)
|
||||
assertTrue(TabsTray.inactiveTabsRecentlyClosed.testHasValue())
|
||||
}
|
||||
|
||||
@Test
|
||||
|
|
Loading…
Reference in New Issue