ishan
/
fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

For #21787 - Update the Pocket stories toggle label and summary from homepage settings

This commit is contained in:
Alexandru2909 2022-10-19 16:26:08 +03:00 committed by mergify[bot]
parent 90960153ce
commit fe25aa8e14
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuHomepageRobot.kt
View File

@ -130,7 +130,7 @@ private fun recentlyVisitedButton() =
onView(allOf(withText(R.string.customize_toggle_recently_visited)))
private fun pocketButton() =
onView(allOf(withText(R.string.customize_toggle_pocket)))
onView(allOf(withText(R.string.customize_toggle_pocket_2)))
private fun sponsoredStoriesButton() =
onView(allOf(withText(R.string.customize_toggle_pocket_sponsored)))

6
app/src/main/res/values/strings.xml
View File

@ -436,7 +436,11 @@
a section where users see a list of tabs that they have visited in the past few days -->
<string name="customize_toggle_recently_visited">Recently visited</string>
<!-- Title for the customize home screen section with Pocket. -->
<string name="customize_toggle_pocket">Pocket</string>
<string name="customize_toggle_pocket" moz:RemovedIn="108" tools:ignore="UnusedResources">Pocket</string>
<!-- Title for the customize home screen section with Pocket. -->
<string name="customize_toggle_pocket_2">Thought-provoking stories</string>
<!-- Summary for the customize home screen section with Pocket. -->
<string name="customize_toggle_pocket_summary">Articles powered by Pocket</string>
<!-- Title for the customize home screen section with sponsored Pocket stories. -->
<string name="customize_toggle_pocket_sponsored">Sponsored stories</string>
<!-- Title for the opening wallpaper settings screen -->

3
app/src/main/res/xml/home_preferences.xml
View File

@ -32,7 +32,8 @@
<androidx.preference.SwitchPreference
android:key="@string/pref_key_pocket_homescreen_recommendations"
android:title="@string/customize_toggle_pocket"
android:title="@string/customize_toggle_pocket_2"
android:summary="@string/customize_toggle_pocket_summary"
app:isPreferenceVisible="false" />
<androidx.preference.CheckBoxPreference