ishan
/
fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

For #20892 update connection panel strings

This commit is contained in:
Arturo Mejia 2021-09-08 15:57:33 -04:00 committed by mergify[bot]
parent 28b07e7c8b
commit d288502840
4 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/java/org/mozilla/fenix/settings/quicksettings/QuickSettingsFragmentState.kt
View File

@ -71,11 +71,11 @@ enum class WebsiteSecurityUiValues(
@DrawableRes val iconRes: Int
) {
SECURE(
R.string.quick_settings_sheet_secure_connection,
R.string.quick_settings_sheet_secure_connection_2,
R.drawable.ic_lock
),
INSECURE(
R.string.quick_settings_sheet_insecure_connection,
R.string.quick_settings_sheet_insecure_connection_2,
R.drawable.mozac_ic_broken_lock
)
}

8
app/src/main/res/values/strings.xml
View File

@ -1716,9 +1716,13 @@
<string name="phone_feature_blocked_step_feature"><![CDATA[3. Toggle <b>%1$s</b> to ON]]></string>
<!-- Label that indicates a site is using a secure connection -->
<string name="quick_settings_sheet_secure_connection">Secure Connection</string>
<string name="quick_settings_sheet_secure_connection_2">Connection is secure</string>
<!-- Label that indicates a site is using a insecure connection -->
<string name="quick_settings_sheet_insecure_connection">Insecure Connection</string>
<string name="quick_settings_sheet_insecure_connection_2">Connection is not secure</string>
<!-- Label that indicates a site is using a secure connection -->
<string name="quick_settings_sheet_secure_connection" moz:removedIn="94" tools:ignore="UnusedResources">Secure Connection</string>
<!-- Label that indicates a site is using a insecure connection -->
<string name="quick_settings_sheet_insecure_connection" moz:removedIn="94" tools:ignore="UnusedResources">Insecure Connection</string>
<!-- Confirmation message for a dialog confirming if the user wants to delete all the permissions for all sites-->
<string name="confirm_clear_permissions_on_all_sites">Are you sure that you want to clear all the permissions on all sites?</string>
<!-- Confirmation message for a dialog confirming if the user wants to delete all the permissions for a site-->

4
app/src/test/java/org/mozilla/fenix/settings/quicksettings/ConnectionDetailsViewTest.kt
View File

@ -55,7 +55,7 @@ class ConnectionDetailsViewTest {
verify { icons.loadIntoView(binding.faviconImage, IconRequest(websiteUrl)) }
assertEquals("https://mozilla.org", binding.url.text)
assertEquals("Secure Connection", binding.securityInfo.text)
assertEquals("Connection is secure", binding.securityInfo.text)
}
@Test
@ -69,7 +69,7 @@ class ConnectionDetailsViewTest {
)
)
assertEquals("Insecure Connection", binding.securityInfo.text)
assertEquals("Connection is not secure", binding.securityInfo.text)
}
@Test

4
app/src/test/java/org/mozilla/fenix/settings/quicksettings/WebsiteInfoViewTest.kt
View File

@ -52,7 +52,7 @@ class WebsiteInfoViewTest {
verify { icons.loadIntoView(binding.faviconImage, IconRequest(websiteUrl)) }
assertEquals("mozilla.org", binding.url.text)
assertEquals("Secure Connection", binding.securityInfo.text)
assertEquals("Connection is secure", binding.securityInfo.text)
}
@Test
@ -68,6 +68,6 @@ class WebsiteInfoViewTest {
verify { view.bindConnectionDetailsListener() }
assertEquals("Insecure Connection", binding.securityInfo.text)
assertEquals("Connection is not secure", binding.securityInfo.text)
}
}