Remove search suggestions in private telemetry
This commit is contained in:
parent
19d8f58b47
commit
c9626019ef
|
@ -3366,24 +3366,6 @@ logins:
|
||||||
- android-probes@mozilla.com
|
- android-probes@mozilla.com
|
||||||
expires: "2022-02-01"
|
expires: "2022-02-01"
|
||||||
|
|
||||||
search_suggestions:
|
|
||||||
enable_in_private:
|
|
||||||
type: event
|
|
||||||
description: |
|
|
||||||
A user enabled receiving search suggestions in private sessions
|
|
||||||
bugs:
|
|
||||||
- https://github.com/mozilla-mobile/fenix/issues/6070
|
|
||||||
data_reviews:
|
|
||||||
- https://github.com/mozilla-mobile/fenix/pull/6746
|
|
||||||
- https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068
|
|
||||||
- https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789
|
|
||||||
data_sensitivity:
|
|
||||||
- technical
|
|
||||||
- interaction
|
|
||||||
notification_emails:
|
|
||||||
- android-probes@mozilla.com
|
|
||||||
expires: "2021-08-01"
|
|
||||||
|
|
||||||
voice_search:
|
voice_search:
|
||||||
tapped:
|
tapped:
|
||||||
type: event
|
type: event
|
||||||
|
|
|
@ -124,7 +124,6 @@ sealed class Event {
|
||||||
object EditLogin : Event()
|
object EditLogin : Event()
|
||||||
object EditLoginSave : Event()
|
object EditLoginSave : Event()
|
||||||
object ViewLoginPassword : Event()
|
object ViewLoginPassword : Event()
|
||||||
object PrivateBrowsingShowSearchSuggestions : Event()
|
|
||||||
object WhatsNewTapped : Event()
|
object WhatsNewTapped : Event()
|
||||||
object PocketTopSiteClicked : Event()
|
object PocketTopSiteClicked : Event()
|
||||||
object PocketTopSiteRemoved : Event()
|
object PocketTopSiteRemoved : Event()
|
||||||
|
|
|
@ -41,7 +41,6 @@ import org.mozilla.fenix.GleanMetrics.ReaderMode
|
||||||
import org.mozilla.fenix.GleanMetrics.RecentBookmarks
|
import org.mozilla.fenix.GleanMetrics.RecentBookmarks
|
||||||
import org.mozilla.fenix.GleanMetrics.RecentTabs
|
import org.mozilla.fenix.GleanMetrics.RecentTabs
|
||||||
import org.mozilla.fenix.GleanMetrics.SearchShortcuts
|
import org.mozilla.fenix.GleanMetrics.SearchShortcuts
|
||||||
import org.mozilla.fenix.GleanMetrics.SearchSuggestions
|
|
||||||
import org.mozilla.fenix.GleanMetrics.SearchWidget
|
import org.mozilla.fenix.GleanMetrics.SearchWidget
|
||||||
import org.mozilla.fenix.GleanMetrics.SetDefaultNewtabExperiment
|
import org.mozilla.fenix.GleanMetrics.SetDefaultNewtabExperiment
|
||||||
import org.mozilla.fenix.GleanMetrics.SetDefaultSettingExperiment
|
import org.mozilla.fenix.GleanMetrics.SetDefaultSettingExperiment
|
||||||
|
@ -443,9 +442,6 @@ private val Event.wrapper: EventWrapper<*>?
|
||||||
is Event.EditLoginSave -> EventWrapper<NoExtraKeys>(
|
is Event.EditLoginSave -> EventWrapper<NoExtraKeys>(
|
||||||
{ Logins.saveEditedLogin.record(it) }
|
{ Logins.saveEditedLogin.record(it) }
|
||||||
)
|
)
|
||||||
is Event.PrivateBrowsingShowSearchSuggestions -> EventWrapper<NoExtraKeys>(
|
|
||||||
{ SearchSuggestions.enableInPrivate.record(it) }
|
|
||||||
)
|
|
||||||
is Event.ToolbarPositionChanged -> EventWrapper(
|
is Event.ToolbarPositionChanged -> EventWrapper(
|
||||||
{ ToolbarSettings.changedPosition.record(it) },
|
{ ToolbarSettings.changedPosition.record(it) },
|
||||||
{ ToolbarSettings.changedPositionKeys.valueOf(it) }
|
{ ToolbarSettings.changedPositionKeys.valueOf(it) }
|
||||||
|
|
|
@ -318,7 +318,6 @@ class SearchDialogFragment : AppCompatDialogFragment(), UserInteractionHandler {
|
||||||
}
|
}
|
||||||
store.dispatch(SearchFragmentAction.SetShowSearchSuggestions(true))
|
store.dispatch(SearchFragmentAction.SetShowSearchSuggestions(true))
|
||||||
store.dispatch(SearchFragmentAction.AllowSearchSuggestionsInPrivateModePrompt(false))
|
store.dispatch(SearchFragmentAction.AllowSearchSuggestionsInPrivateModePrompt(false))
|
||||||
requireComponents.analytics.metrics.track(Event.PrivateBrowsingShowSearchSuggestions)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
searchSuggestionHintBinding.dismiss.setOnClickListener {
|
searchSuggestionHintBinding.dismiss.setOnClickListener {
|
||||||
|
|
Loading…
Reference in New Issue
Block a user