ishan/fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix intermittent test failures in TrackingProtectionExceptionsInteractorTest

Browse Source
This commit is contained in:
Christian Sadilek 2021-07-28 12:58:08 -04:00 committed by mergify[bot]
parent d0c75740b7
commit b3895e5fde
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
app/src/test/java/org/mozilla/fenix/exceptions/trackingprotection/TrackingProtectionExceptionsInteractorTest.kt
View File

@ -4,14 +4,10 @@
package org.mozilla.fenix.exceptions.trackingprotection package org.mozilla.fenix.exceptions.trackingprotection
import io.mockk.CapturingSlot
import io.mockk.MockKAnnotations import io.mockk.MockKAnnotations
import io.mockk.Runs
import io.mockk.every import io.mockk.every
import io.mockk.impl.annotations.MockK import io.mockk.impl.annotations.MockK
import io.mockk.just
import io.mockk.mockk import io.mockk.mockk
import io.mockk.slot
import io.mockk.verify import io.mockk.verify
import io.mockk.verifySequence import io.mockk.verifySequence
import mozilla.components.concept.engine.content.blocking.TrackingProtectionException import mozilla.components.concept.engine.content.blocking.TrackingProtectionException
@ -28,7 +24,7 @@ class TrackingProtectionExceptionsInteractorTest {
@MockK(relaxed = true) private lateinit var exceptionsStore: ExceptionsFragmentStore @MockK(relaxed = true) private lateinit var exceptionsStore: ExceptionsFragmentStore
@MockK(relaxed = true) private lateinit var trackingProtectionUseCases: TrackingProtectionUseCases @MockK(relaxed = true) private lateinit var trackingProtectionUseCases: TrackingProtectionUseCases
private lateinit var interactor: TrackingProtectionExceptionsInteractor private lateinit var interactor: TrackingProtectionExceptionsInteractor
private lateinit var onResult: CapturingSlot<(List<TrackingProtectionException>) -> Unit> private lateinit var results: List<TrackingProtectionException>
@Before @Before
fun setup() { fun setup() {
@ -39,8 +35,10 @@ class TrackingProtectionExceptionsInteractorTest {
trackingProtectionUseCases = trackingProtectionUseCases trackingProtectionUseCases = trackingProtectionUseCases
) )
onResult = slot() results = emptyList()
every { trackingProtectionUseCases.fetchExceptions(capture(onResult)) } just Runs every { trackingProtectionUseCases.fetchExceptions(any()) } answers {
firstArg<(List<TrackingProtectionException>) -> Unit>()(results)
}
} }
@Test @Test
@ -67,8 +65,6 @@ class TrackingProtectionExceptionsInteractorTest {
trackingProtectionUseCases.fetchExceptions(any()) trackingProtectionUseCases.fetchExceptions(any())
} }
val results = mockk<List<TrackingProtectionException>>()
onResult.captured(results)
verify { exceptionsStore.dispatch(ExceptionsFragmentAction.Change(results)) } verify { exceptionsStore.dispatch(ExceptionsFragmentAction.Change(results)) }
} }
@ -81,8 +77,6 @@ class TrackingProtectionExceptionsInteractorTest {
trackingProtectionUseCases.fetchExceptions(any()) trackingProtectionUseCases.fetchExceptions(any())
} }
val results = mockk<List<TrackingProtectionException>>()
onResult.captured(results)
verify { exceptionsStore.dispatch(ExceptionsFragmentAction.Change(results)) } verify { exceptionsStore.dispatch(ExceptionsFragmentAction.Change(results)) }
} }
} }