For #19357: Remove bookmarks experiment and keep star-with-line icon.
This commit is contained in:
parent
f18e771fb3
commit
93c6403882
|
@ -7,7 +7,6 @@ package org.mozilla.fenix.experiments
|
|||
class Experiments {
|
||||
companion object {
|
||||
const val A_A_NIMBUS_VALIDATION = "fenix-nimbus-validation-v3"
|
||||
const val BOOKMARK_ICON = "fenix-bookmark-list-icon"
|
||||
const val ANDROID_KEYSTORE = "fenix-android-keystore"
|
||||
const val DEFAULT_BROWSER = "fenix-default-browser"
|
||||
}
|
||||
|
|
|
@ -133,17 +133,10 @@ class HomeMenu(
|
|||
) {
|
||||
onItemTapped.invoke(Item.WhatsNew)
|
||||
}
|
||||
|
||||
val experiments = context.components.analytics.experiments
|
||||
val bookmarksIcon = experiments.withExperiment(Experiments.BOOKMARK_ICON) {
|
||||
when (it) {
|
||||
ExperimentBranch.TREATMENT -> R.drawable.ic_bookmark_list
|
||||
else -> R.drawable.ic_bookmark_filled
|
||||
}
|
||||
}
|
||||
val bookmarksItem = BrowserMenuImageText(
|
||||
context.getString(R.string.library_bookmarks),
|
||||
bookmarksIcon,
|
||||
R.drawable.ic_bookmark_list,
|
||||
primaryTextColor
|
||||
) {
|
||||
onItemTapped.invoke(Item.Bookmarks)
|
||||
|
@ -251,15 +244,9 @@ class HomeMenu(
|
|||
val experiments = context.components.analytics.experiments
|
||||
val settings = context.components.settings
|
||||
|
||||
val bookmarksIcon = experiments.withExperiment(Experiments.BOOKMARK_ICON) {
|
||||
when (it) {
|
||||
ExperimentBranch.TREATMENT -> R.drawable.ic_bookmark_list
|
||||
else -> R.drawable.ic_bookmark_filled
|
||||
}
|
||||
}
|
||||
val bookmarksItem = BrowserMenuImageText(
|
||||
context.getString(R.string.library_bookmarks),
|
||||
bookmarksIcon,
|
||||
R.drawable.ic_bookmark_list,
|
||||
primaryTextColor
|
||||
) {
|
||||
onItemTapped.invoke(Item.Bookmarks)
|
||||
|
|
Loading…
Reference in New Issue
Block a user