ishan
/
fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

For #26444: Refactor HomeSectionHeader to have optional show all text.

This commit is contained in:
mcarare 2022-08-30 19:57:15 +03:00 committed by mergify[bot]
parent 310a029c37
commit 8a599bbf4e
1 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
app/src/main/java/org/mozilla/fenix/compose/home/HomeSectionHeader.kt
View File

@ -41,7 +41,7 @@ import org.mozilla.fenix.wallpapers.Wallpaper
fun HomeSectionHeader(
headerText: String,
description: String,
onShowAllClick: () -> Unit
onShowAllClick: (() -> Unit)? = null
) {
if (inComposePreview) {
HomeSectionHeaderContent(
@ -82,7 +82,7 @@ private fun HomeSectionHeaderContent(
headerText: String,
description: String,
showAllTextColor: Color = FirefoxTheme.colors.textAccent,
onShowAllClick: () -> Unit,
onShowAllClick: (() -> Unit)? = null,
) {
Row(
modifier = Modifier.fillMaxWidth(),
@ -94,18 +94,20 @@ private fun HomeSectionHeaderContent(
.wrapContentHeight(align = Alignment.Top)
)
ClickableText(
text = AnnotatedString(text = stringResource(id = R.string.recent_tabs_show_all)),
modifier = Modifier.padding(start = 16.dp)
.semantics {
contentDescription = description
},
style = TextStyle(
color = showAllTextColor,
fontSize = 14.sp
),
onClick = { onShowAllClick() }
)
onShowAllClick?.let {
ClickableText(
text = AnnotatedString(text = stringResource(id = R.string.recent_tabs_show_all)),
modifier = Modifier.padding(start = 16.dp)
.semantics {
contentDescription = description
},
style = TextStyle(
color = showAllTextColor,
fontSize = 14.sp
),
onClick = { onShowAllClick() }
)
}
}
}
@ -116,7 +118,6 @@ private fun HomeSectionsHeaderPreview() {
HomeSectionHeader(
headerText = stringResource(R.string.recently_saved_title),
description = stringResource(R.string.recently_saved_show_all_content_description_2),
onShowAllClick = {}
)
}
}