ishan
/
fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

For #27801 - Update header text for the search selector menu

This commit is contained in:
DreVla 2022-11-15 15:26:41 +02:00 committed by mergify[bot]
parent 3f3f508b2b
commit 868a63a91a
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/org/mozilla/fenix/search/toolbar/SearchSelectorMenu.kt
View File

@ -50,7 +50,7 @@ class SearchSelectorMenu(
internal fun menuItems(searchEngines: List<MenuCandidate>): List<MenuCandidate> {
val headerCandidate = DecorativeTextMenuCandidate(
text = context.getString(R.string.search_header_menu_item),
text = context.getString(R.string.search_header_menu_item_2),
)
val settingsCandidate = TextMenuCandidate(
text = context.getString(R.string.search_settings_menu_item),

4
app/src/main/res/values/strings.xml
View File

@ -244,7 +244,9 @@
<!-- Menu option in the search selector menu to open the search settings -->
<string name="search_settings_menu_item">Search settings</string>
<!-- Header text for the search selector menu -->
<string name="search_header_menu_item">This time search:</string>
<string name="search_header_menu_item" moz:RemovedIn="109" tools:ignore="UnusedResources">This time search:</string>
<!-- Header text for the search selector menu -->
<string name="search_header_menu_item_2">This time search in:</string>
<!-- Home onboarding -->
<!-- Onboarding home screen popup dialog, shown on top of the Jump back in section. -->

2
app/src/test/java/org/mozilla/fenix/search/toolbar/SearchSelectorMenuTest.kt
View File

@ -35,7 +35,7 @@ class SearchSelectorMenuTest {
lastItem.onClick()
assertEquals(
testContext.getString(R.string.search_header_menu_item),
testContext.getString(R.string.search_header_menu_item_2),
(items.first() as DecorativeTextMenuCandidate).text,
)
assertEquals(