ishan
/
fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

No issue: Remove code to generate tab group size metrics

This commit is contained in:
Noah Bond 2022-08-16 10:55:10 -07:00 committed by mergify[bot]
parent edff593ee6
commit 81dae89969
2 changed files with 0 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayMiddleware.kt
View File

@ -4,7 +4,6 @@
package org.mozilla.fenix.tabstray
import androidx.annotation.VisibleForTesting
import mozilla.components.lib.state.Middleware
import mozilla.components.lib.state.MiddlewareContext
import org.mozilla.fenix.GleanMetrics.Metrics
@ -44,17 +43,4 @@ class TabsTrayMiddleware : Middleware<TabsTrayState, TabsTrayAction> {
}
}
}
@Suppress("MagicNumber")
@VisibleForTesting
/**
* This follows the logic outlined in metrics.yaml for "search_terms.group_size_distribution"
*/
internal fun generateTabGroupSizeMappedValue(size: Int): Long =
when (size) {
2 -> 1L
in 3..5 -> 2L
in 6..10 -> 3L
else -> 4L
}
}

17
app/src/test/java/org/mozilla/fenix/tabstray/TabsTrayMiddlewareTest.kt
View File

@ -50,23 +50,6 @@ class TabsTrayMiddlewareTest {
assertEquals(0L, Metrics.inactiveTabsCount.testGetValue())
}
@Test
fun testGenerateTabGroupSizeMappedValue() {
assertEquals(1L, tabsTrayMiddleware.generateTabGroupSizeMappedValue(2))
assertEquals(2L, tabsTrayMiddleware.generateTabGroupSizeMappedValue(3))
assertEquals(2L, tabsTrayMiddleware.generateTabGroupSizeMappedValue(4))
assertEquals(2L, tabsTrayMiddleware.generateTabGroupSizeMappedValue(5))
assertEquals(3L, tabsTrayMiddleware.generateTabGroupSizeMappedValue(6))
assertEquals(3L, tabsTrayMiddleware.generateTabGroupSizeMappedValue(7))
assertEquals(3L, tabsTrayMiddleware.generateTabGroupSizeMappedValue(8))
assertEquals(3L, tabsTrayMiddleware.generateTabGroupSizeMappedValue(9))
assertEquals(3L, tabsTrayMiddleware.generateTabGroupSizeMappedValue(10))
assertEquals(4L, tabsTrayMiddleware.generateTabGroupSizeMappedValue(11))
assertEquals(4L, tabsTrayMiddleware.generateTabGroupSizeMappedValue(12))
assertEquals(4L, tabsTrayMiddleware.generateTabGroupSizeMappedValue(20))
assertEquals(4L, tabsTrayMiddleware.generateTabGroupSizeMappedValue(50))
}
@Test
fun `WHEN multi select mode from menu is entered THEN relevant metrics are collected`() {
assertNull(TabsTray.enterMultiselectMode.testGetValue())