ishan
/
fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Closes #27209: fix WallpapersSettings crash

This commit is contained in:
mike a 2022-09-29 21:56:13 -07:00 committed by mergify[bot]
parent acf9756a76
commit 595d931dc0
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/src/main/java/org/mozilla/fenix/settings/wallpaper/WallpaperSettingsFragment.kt
View File

@ -11,6 +11,7 @@ import android.view.ViewGroup
import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.ui.platform.ComposeView
import androidx.compose.ui.platform.ViewCompositionStrategy
import androidx.coordinatorlayout.widget.CoordinatorLayout
import androidx.fragment.app.Fragment
import androidx.lifecycle.lifecycleScope
import androidx.navigation.fragment.findNavController
@ -43,7 +44,7 @@ class WallpaperSettingsFragment : Fragment() {
savedInstanceState: Bundle?,
): View {
Wallpapers.wallpaperSettingsOpened.record(NoExtras())
return ComposeView(requireContext()).apply {
val wallpaperSettings = ComposeView(requireContext()).apply {
setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed)
setContent {
FirefoxTheme {
@ -70,7 +71,7 @@ class WallpaperSettingsFragment : Fragment() {
onSelectWallpaper = {
coroutineScope.launch {
val result = wallpaperUseCases.selectWallpaper(it)
onWallpaperSelected(it, result, this@apply)
onWallpaperSelected(it, result, requireView())
}
},
onLearnMoreClick = { url, collectionName ->
@ -90,6 +91,12 @@ class WallpaperSettingsFragment : Fragment() {
}
}
}
// Using CoordinatorLayout as a parent view for the fragment gives the benefit of hiding
// snackbars automatically when the fragment is closed.
return CoordinatorLayout(requireContext()).apply {
addView(wallpaperSettings)
}
}
private fun onWallpaperSelected(