ishan/fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix intermittent test failures in PagedHistoryProviderTest

Browse Source
This commit is contained in:
Christian Sadilek 2021-07-28 13:19:20 -04:00 committed by mergify[bot]
parent b3895e5fde
commit 458e8b3cd7
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/src/test/java/org/mozilla/fenix/components/history/PagedHistoryProviderTest.kt
View File

@ -7,10 +7,10 @@ package org.mozilla.fenix.components.history
import io.mockk.coEvery import io.mockk.coEvery
import io.mockk.coVerify import io.mockk.coVerify
import io.mockk.mockk import io.mockk.mockk
import io.mockk.verify
import mozilla.components.concept.storage.HistoryStorage import mozilla.components.concept.storage.HistoryStorage
import mozilla.components.concept.storage.VisitInfo import mozilla.components.concept.storage.VisitInfo
import mozilla.components.concept.storage.VisitType import mozilla.components.concept.storage.VisitType
import org.junit.Assert.assertSame
import org.junit.Before import org.junit.Before
import org.junit.Test import org.junit.Test
@ -27,11 +27,12 @@ class PagedHistoryProviderTest {
fun `getHistory uses getVisitsPaginated`() { fun `getHistory uses getVisitsPaginated`() {
val provider = storage.createSynchronousPagedHistoryProvider() val provider = storage.createSynchronousPagedHistoryProvider()
val results = listOf<VisitInfo>(mockk(), mockk()) val results = listOf<VisitInfo>(mockk(), mockk())
val onComplete = mockk<(List<VisitInfo>) -> Unit>(relaxed = true)
coEvery { storage.getVisitsPaginated(any(), any(), any()) } returns results coEvery { storage.getVisitsPaginated(any(), any(), any()) } returns results
provider.getHistory(10L, 5, onComplete) var actualResults: List<VisitInfo>? = null
provider.getHistory(10L, 5) {
actualResults = it
}
coVerify { coVerify {
storage.getVisitsPaginated( storage.getVisitsPaginated(
@ -48,6 +49,7 @@ class PagedHistoryProviderTest {
) )
) )
} }
verify { onComplete(results) }
assertSame(results, actualResults)
} }
} }