For #13959 - post: decrement expected suppression count.
Running locally, I get the same error: I think that there legitimately was an reduction in the number of StrictMode suppressions on start up.
This commit is contained in:
parent
d2467f7541
commit
4302cd20b2
|
@ -13,9 +13,12 @@ import org.mozilla.fenix.ext.components
|
||||||
import org.mozilla.fenix.helpers.HomeActivityTestRule
|
import org.mozilla.fenix.helpers.HomeActivityTestRule
|
||||||
|
|
||||||
// PLEASE CONSULT WITH PERF TEAM BEFORE CHANGING THIS VALUE.
|
// PLEASE CONSULT WITH PERF TEAM BEFORE CHANGING THIS VALUE.
|
||||||
private const val EXPECTED_SUPPRESSION_COUNT = 12
|
private const val EXPECTED_SUPPRESSION_COUNT = 11
|
||||||
|
|
||||||
private const val FAILURE_MSG = """StrictMode startup suppression count does not match expected count.
|
private const val FAILURE_MSG = """StrictMode startup suppression count does not match expected count.
|
||||||
|
|
||||||
|
If this PR removed code that suppressed StrictMode, great! Please decrement the suppression count.
|
||||||
|
|
||||||
Did this PR add or call code that suppresses a StrictMode violation?
|
Did this PR add or call code that suppresses a StrictMode violation?
|
||||||
Did you know that suppressing a StrictMode violation can introduce performance regressions?
|
Did you know that suppressing a StrictMode violation can introduce performance regressions?
|
||||||
|
|
||||||
|
@ -23,8 +26,6 @@ private const val FAILURE_MSG = """StrictMode startup suppression count does not
|
||||||
Please consult the perf team if you have questions or believe suppressing StrictMode
|
Please consult the perf team if you have questions or believe suppressing StrictMode
|
||||||
is the optimal solution.
|
is the optimal solution.
|
||||||
|
|
||||||
If this PR removed code that suppressed StrictMode, great! Please decrement the suppression count.
|
|
||||||
|
|
||||||
"""
|
"""
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
Loading…
Reference in New Issue
Block a user