ishan
/
fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

For #24780 - Part 1: Rename CreditCardsSettingFragment to AutofillSettingFragment

This commit is contained in:
Gabriel Luong 2022-04-14 00:11:39 -04:00 committed by mergify[bot]
parent f13978bc3b
commit 2b86e25a4a
2 changed files with 14 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/src/main/java/org/mozilla/fenix/settings/creditcards/CreditCardsSettingFragment.kt → app/src/main/java/org/mozilla/fenix/settings/creditcards/AutofillSettingFragment.kt
View File

@ -35,17 +35,15 @@ import org.mozilla.fenix.ext.settings
import org.mozilla.fenix.ext.showToolbar
import org.mozilla.fenix.settings.SharedPreferenceUpdater
import org.mozilla.fenix.settings.SyncPreferenceView
import org.mozilla.fenix.settings.biometric.BiometricPromptFeature
import org.mozilla.fenix.settings.biometric.BiometricPromptPreferenceFragment
import org.mozilla.fenix.settings.requirePreference
/**
* "Credit cards" settings fragment displays a list of settings related to autofilling, adding and
* syncing credit cards. Authentication for saved credit cards uses [BiometricPromptFeature]
* or [KeyguardManager].
* Autofill settings fragment displays a list of settings related to autofilling, adding and
* syncing credit cards and addresses.
*/
@SuppressWarnings("TooManyFunctions")
class CreditCardsSettingFragment : BiometricPromptPreferenceFragment() {
class AutofillSettingFragment : BiometricPromptPreferenceFragment() {
private lateinit var creditCardsStore: CreditCardsFragmentStore
private var isCreditCardsListLoaded: Boolean = false
@ -133,7 +131,7 @@ class CreditCardsSettingFragment : BiometricPromptPreferenceFragment() {
},
onReconnectClicked = {
findNavController().navigate(
CreditCardsSettingFragmentDirections.actionGlobalAccountProblemFragment()
AutofillSettingFragmentDirections.actionGlobalAccountProblemFragment()
)
}
)

20
app/src/test/java/org/mozilla/fenix/settings/creditcards/CreditCardsSettingFragmentTest.kt → app/src/test/java/org/mozilla/fenix/settings/creditcards/AutofillSettingFragmentTest.kt
View File

@ -26,22 +26,22 @@ import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
import org.robolectric.Robolectric
@RunWith(FenixRobolectricTestRunner::class)
class CreditCardsSettingFragmentTest {
class AutofillSettingFragmentTest {
private val testDispatcher = TestCoroutineDispatcher()
private lateinit var creditCardsSettingFragment: CreditCardsSettingFragment
private lateinit var autofillSettingFragment: AutofillSettingFragment
private val navController: NavController = mockk(relaxed = true)
@Before
fun setUp() {
every { testContext.components.settings } returns mockk(relaxed = true)
creditCardsSettingFragment = CreditCardsSettingFragment()
autofillSettingFragment = AutofillSettingFragment()
val activity = Robolectric.buildActivity(FragmentActivity::class.java).create().get()
activity.supportFragmentManager.beginTransaction()
.add(creditCardsSettingFragment, "CreditCardsSettingFragmentTest")
.add(autofillSettingFragment, "CreditCardsSettingFragmentTest")
.commitNow()
testDispatcher.advanceUntilIdle()
}
@ -50,8 +50,8 @@ class CreditCardsSettingFragmentTest {
fun `GIVEN the list of credit cards is not empty, WHEN fragment is displayed THEN the manage credit cards pref is 'Manage saved cards'`() {
val preferenceTitle =
testContext.getString(R.string.preferences_credit_cards_manage_saved_cards)
val manageCardsPreference = creditCardsSettingFragment.findPreference<Preference>(
creditCardsSettingFragment.getPreferenceKey(R.string.pref_key_credit_cards_manage_cards)
val manageCardsPreference = autofillSettingFragment.findPreference<Preference>(
autofillSettingFragment.getPreferenceKey(R.string.pref_key_credit_cards_manage_cards)
)
val creditCards: List<CreditCard> = listOf(mockk(), mockk())
@ -59,7 +59,7 @@ class CreditCardsSettingFragmentTest {
val creditCardsState = CreditCardsListState(creditCards = creditCards)
val creditCardsStore = CreditCardsFragmentStore(creditCardsState)
creditCardsSettingFragment.updateCardManagementPreference(
autofillSettingFragment.updateCardManagementPreference(
creditCardsStore.state.creditCards.isNotEmpty(),
navController
)
@ -72,8 +72,8 @@ class CreditCardsSettingFragmentTest {
fun `GIVEN the list of credit cards is empty, WHEN fragment is displayed THEN the manage credit cards pref is 'Add card'`() {
val preferenceTitle =
testContext.getString(R.string.preferences_credit_cards_add_credit_card)
val manageCardsPreference = creditCardsSettingFragment.findPreference<Preference>(
creditCardsSettingFragment.getPreferenceKey(R.string.pref_key_credit_cards_manage_cards)
val manageCardsPreference = autofillSettingFragment.findPreference<Preference>(
autofillSettingFragment.getPreferenceKey(R.string.pref_key_credit_cards_manage_cards)
)
val directions =
@ -83,7 +83,7 @@ class CreditCardsSettingFragmentTest {
val creditCardsState = CreditCardsListState(creditCards = emptyList())
val creditCardsStore = CreditCardsFragmentStore(creditCardsState)
creditCardsSettingFragment.updateCardManagementPreference(
autofillSettingFragment.updateCardManagementPreference(
creditCardsStore.state.creditCards.isNotEmpty(),
navController
)