For #26023: Remove inaccurate VisibleForTesting annotations.

This commit is contained in:
mcarare 2022-08-25 11:39:20 +03:00 committed by mergify[bot]
parent a914e72b68
commit 258acf5fd9
9 changed files with 14 additions and 25 deletions

View File

@ -38,7 +38,6 @@ class OpenInAppOnboardingObserver(
private val settings: Settings,
private val appLinksUseCases: AppLinksUseCases,
private val container: ViewGroup,
@VisibleForTesting
internal val shouldScrollWithTopToolbar: Boolean = false,
) : LifecycleAwareFeature {
private var scope: CoroutineScope? = null

View File

@ -6,7 +6,6 @@ package org.mozilla.fenix.browser.infobanner
import android.content.Context
import android.view.ViewGroup
import androidx.annotation.VisibleForTesting
import androidx.coordinatorlayout.widget.CoordinatorLayout
/**
@ -19,7 +18,6 @@ import androidx.coordinatorlayout.widget.CoordinatorLayout
class DynamicInfoBanner(
private val context: Context,
container: ViewGroup,
@VisibleForTesting
internal val shouldScrollWithTopToolbar: Boolean = false,
message: String,
dismissText: String,

View File

@ -32,10 +32,8 @@ open class InfoBanner(
private val dismissText: String,
private val actionText: String? = null,
private val dismissByHiding: Boolean = false,
@VisibleForTesting
internal val dismissAction: (() -> Unit)? = null,
@VisibleForTesting
internal val actionToPerform: (() -> Unit)? = null,
private val actionToPerform: (() -> Unit)? = null,
) {
@SuppressLint("InflateParams")
@VisibleForTesting

View File

@ -5,7 +5,6 @@
package org.mozilla.fenix.components
import android.content.Context
import androidx.annotation.VisibleForTesting
import androidx.paging.DataSource
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext
@ -16,8 +15,8 @@ import kotlin.coroutines.CoroutineContext
class PermissionStorage(
private val context: Context,
@VisibleForTesting internal val dispatcher: CoroutineContext = Dispatchers.IO,
@VisibleForTesting internal val permissionsStorage: SitePermissionsStorage =
private val dispatcher: CoroutineContext = Dispatchers.IO,
internal val permissionsStorage: SitePermissionsStorage =
context.components.core.geckoSitePermissionsStorage,
) {

View File

@ -105,9 +105,7 @@ class DefaultQuickSettingsController(
private val browserStore: BrowserStore,
private val ioScope: CoroutineScope,
private val navController: NavController,
@VisibleForTesting
internal val sessionId: String,
@VisibleForTesting
internal var sitePermissions: SitePermissions?,
private val settings: Settings,
private val permissionStorage: PermissionStorage,

View File

@ -43,8 +43,7 @@ private const val VIEW_HOLDER_TYPE_STUDY = 1
class StudiesAdapter(
private val studiesDelegate: StudiesAdapterDelegate,
studies: List<EnrolledExperiment>,
@VisibleForTesting
internal val shouldSubmitOnInit: Boolean = true,
private val shouldSubmitOnInit: Boolean = true,
) : ListAdapter<Any, CustomViewHolder>(DifferCallback) {
/**
* Represents all the studies that will be distributed in multiple headers like

View File

@ -14,7 +14,7 @@ import org.mozilla.fenix.share.listadapters.AppShareOption
class AppViewHolder(
itemView: View,
@VisibleForTesting val interactor: ShareToAppsInteractor,
@get:VisibleForTesting val interactor: ShareToAppsInteractor,
) : RecyclerView.ViewHolder(itemView) {
private var application: AppShareOption? = null

View File

@ -120,7 +120,6 @@ class DefaultTabsTrayController(
private val selectTabPosition: (Int, Boolean) -> Unit,
private val dismissTray: () -> Unit,
private val showUndoSnackbarForTab: (Boolean) -> Unit,
@VisibleForTesting
internal val showCancelledDownloadWarning: (downloadCount: Int, tabId: String?, source: String?) -> Unit,
) : TabsTrayController {

View File

@ -7,7 +7,6 @@ package org.mozilla.fenix.tabstray
import android.content.Context
import android.view.LayoutInflater
import android.view.ViewGroup
import androidx.annotation.VisibleForTesting
import androidx.compose.ui.platform.ComposeView
import androidx.lifecycle.LifecycleOwner
import androidx.recyclerview.widget.ConcatAdapter
@ -25,15 +24,15 @@ import org.mozilla.fenix.tabstray.viewholders.SyncedTabsPageViewHolder
@Suppress("LongParameterList")
class TrayPagerAdapter(
@VisibleForTesting internal val context: Context,
@VisibleForTesting internal val lifecycleOwner: LifecycleOwner,
@VisibleForTesting internal val tabsTrayStore: TabsTrayStore,
@VisibleForTesting internal val browserInteractor: BrowserTrayInteractor,
@VisibleForTesting internal val navInteractor: NavigationInteractor,
@VisibleForTesting internal val tabsTrayInteractor: TabsTrayInteractor,
@VisibleForTesting internal val browserStore: BrowserStore,
@VisibleForTesting internal val appStore: AppStore,
@VisibleForTesting internal val inactiveTabsInteractor: InactiveTabsInteractor,
internal val context: Context,
internal val lifecycleOwner: LifecycleOwner,
internal val tabsTrayStore: TabsTrayStore,
internal val browserInteractor: BrowserTrayInteractor,
internal val navInteractor: NavigationInteractor,
internal val tabsTrayInteractor: TabsTrayInteractor,
internal val browserStore: BrowserStore,
internal val appStore: AppStore,
internal val inactiveTabsInteractor: InactiveTabsInteractor,
) : RecyclerView.Adapter<AbstractPageViewHolder>() {
/**