ishan
/
fenix
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

No issue: Update Cookie banner handling strings

This commit is contained in:
Arturo Mejia 2022-12-12 10:08:02 -05:00 committed by mergify[bot]
parent c216e3b268
commit 1ea7554026
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/org/mozilla/fenix/settings/quicksettings/protections/cookiebanners/CookieBannerHandlingDetailsView.kt
View File

@ -63,7 +63,8 @@ class CookieBannerHandlingDetailsView(
} else {
R.string.reduce_cookie_banner_details_panel_description_on_for_site
}
binding.details.text = context.getString(stringID, context.getString(R.string.app_name))
val appName = context.getString(R.string.app_name)
binding.details.text = context.getString(stringID, appName, appName)
}
@VisibleForTesting

4
app/src/main/res/values/strings.xml
View File

@ -339,8 +339,8 @@
<string name="reduce_cookie_banner_details_panel_title_off_for_site">Turn off Cookie Banner Reduction for %1$s?</string>
<!-- Long text for a detail explanation indicating what will happen if cookie banner handling is off for a site, this is shown as part of the cookie banner panel in the toolbar. The first parameter is the application name -->
<string name="reduce_cookie_banner_details_panel_description_off_for_site">%1$s will clear this site’s cookies and refresh the page. Clearing all cookies may sign you out or empty shopping carts.</string>
<!-- Long text for a detail explanation indicating what will happen if cookie banner handling is on for a site, this is shown as part of the cookie banner panel in the toolbar -->
<string name="reduce_cookie_banner_details_panel_description_on_for_site">Firefox can try to automatically reject cookie requests. If a reject option isn’t available, Firefox may accept all cookies to dismiss the banner.</string>
<!-- Long text for a detail explanation indicating what will happen if cookie banner handling is on for a site, this is shown as part of the cookie banner panel in the toolbar. The first and second parameter are the application name -->
<string name="reduce_cookie_banner_details_panel_description_on_for_site">%1$s can try to automatically reject cookie requests. If a reject option isn’t available, %2$s may accept all cookies to dismiss the banner.</string>
<!-- Description of the preference to enable "HTTPS-Only" mode. -->
<string name="preferences_https_only_summary">Automatically attempts to connect to sites using HTTPS encryption protocol for increased security.</string>

3
app/src/test/java/org/mozilla/fenix/settings/quicksettings/protections/cookiebanners/CookieBannerHandlingDetailsViewTest.kt
View File

@ -131,9 +131,12 @@ class CookieBannerHandlingDetailsViewTest {
fun `GIVEN cookie banner handling is disabled WHEN biding description THEN description view must have the expected string`() {
view.bindDescription(isCookieBannerHandlingEnabled = false)
val appName = testContext.getString(R.string.app_name)
val expectedText =
testContext.getString(
R.string.reduce_cookie_banner_details_panel_description_on_for_site,
appName,
appName,
)
assertEquals(expectedText, view.binding.details.text)