diff --git a/app/metrics.yaml b/app/metrics.yaml index 609d6db32..24e265be5 100644 --- a/app/metrics.yaml +++ b/app/metrics.yaml @@ -906,4 +906,38 @@ history: - https://github.com/mozilla-mobile/fenix/pull/3940 notification_emails: - fenix-core@mozilla.com + expires: "2020-03-01" +reader_mode: + available: + type: event + description: > + Reader mode is available for the current page + bugs: + - 2267 + data_reviews: + - https://github.com/mozilla-mobile/fenix/pull/3941 + notification_emails: + - fenix-core@mozilla.com + expires: "2020-03-01" + opened: + type: event + description: > + A user opened reader mode + bugs: + - 2267 + data_reviews: + - https://github.com/mozilla-mobile/fenix/pull/3941 + notification_emails: + - fenix-core@mozilla.com + expires: "2020-03-01" + appearance: + type: event + description: > + A user tapped the appearance button + bugs: + - 2267 + data_reviews: + - https://github.com/mozilla-mobile/fenix/pull/3941 + notification_emails: + - fenix-core@mozilla.com expires: "2020-03-01" \ No newline at end of file diff --git a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt index d30e1bf62..934fd861b 100644 --- a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt @@ -375,6 +375,10 @@ class BrowserFragment : Fragment(), BackHandler { view.readerViewControlsBar ) { getManagedEmitter().apply { + if (it) { + requireComponents.analytics.metrics.track(Event.ReaderModeAvailable) + } + onNext(QuickActionChange.ReadableStateChange(it)) onNext( QuickActionChange.ReaderActiveStateChange( @@ -527,11 +531,12 @@ class BrowserFragment : Fragment(), BackHandler { } else { feature.showReaderView() actionEmitter.onNext(QuickActionChange.ReaderActiveStateChange(true)) + requireComponents.analytics.metrics.track(Event.ReaderModeOpened) } } } is QuickActionAction.ReadAppearancePressed -> { - // TODO telemetry: https://github.com/mozilla-mobile/fenix/issues/2267 + requireComponents.analytics.metrics.track(Event.ReaderModeAppearanceOpened) readerViewFeature.withFeature { feature -> feature.showControls() } diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt index 7f9e594c4..b25a4e103 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt @@ -98,6 +98,9 @@ sealed class Event { object HistoryItemOpened : Event() object HistoryItemRemoved : Event() object HistoryAllItemsRemoved : Event() + object ReaderModeAvailable : Event() + object ReaderModeOpened : Event() + object ReaderModeAppearanceOpened : Event() data class PreferenceToggled(val preferenceKey: String, val enabled: Boolean, val context: Context) : Event() { private val switchPreferenceTelemetryAllowList = listOf( diff --git a/docs/metrics.md b/docs/metrics.md index 3a429f0de..2ee9632d2 100644 --- a/docs/metrics.md +++ b/docs/metrics.md @@ -705,7 +705,6 @@ tracking_protection - ## history
@@ -762,6 +761,45 @@ tracking_protection
 
+## reader_mode + +
+
+    
+        
+        
+        
+        
+        
+        
+    
+    
+        
+        
+        
+        
+        
+        
+    
+    
+        
+        
+        
+        
+        
+        
+    
+    
+        
+        
+        
+        
+        
+        
+    
+
keytypedescriptiondata deviewextrasexpires
availableeventReader mode is available for the current pagelink2020-03-01
openedeventA user opened reader modelink2020-03-01
appearanceeventA user tapped the appearance buttonlink2020-03-01
+
+ ## Metrics Items that are added to the metrics ping