diff --git a/app/metrics.yaml b/app/metrics.yaml index 89fbb7fd8..055e40c06 100644 --- a/app/metrics.yaml +++ b/app/metrics.yaml @@ -6956,11 +6956,10 @@ search_terms: expires: "2022-12-01" wallpapers: - discovered_wallpaper_feature: - type: boolean - lifetime: application + wallpaper_settings_opened: + type: event description: | - Whether or not the user has discovered the wallpaper feature. + User has opened the wallpaper settings screen. bugs: - https://github.com/mozilla-mobile/fenix/issues/23381 data_reviews: diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt index 6a710dcaa..f220b9c3f 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt @@ -676,7 +676,7 @@ sealed class Event { sealed class Search - object WallpaperFeatureDiscovered : Event() + object WallpaperSettingsOpened : Event() data class WallpaperSelected(val wallpaper: org.mozilla.fenix.wallpapers.Wallpaper) : Event() data class WallpaperSwitched(val wallpaper: org.mozilla.fenix.wallpapers.Wallpaper) : Event() data class ChangeWallpaperWithLogoToggled(val checked: Boolean) : Event() diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt index de6bfbe07..94da3b945 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt @@ -908,8 +908,8 @@ private val Event.wrapper: EventWrapper<*>? is Event.JumpBackInGroupTapped -> EventWrapper( { SearchTerms.jumpBackInGroupTapped.record(it) } ) - is Event.WallpaperFeatureDiscovered -> EventWrapper( - { Wallpapers.discoveredWallpaperFeature.set(true) } + is Event.WallpaperSettingsOpened -> EventWrapper( + { Wallpapers.wallpaperSettingsOpened.record() } ) is Event.WallpaperSelected -> EventWrapper( { diff --git a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt index ef3c5345a..23b0b2b03 100644 --- a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt @@ -768,7 +768,6 @@ class HomeFragment : Fragment() { binding.wordmark.setOnClickListener { val manager = requireComponents.wallpaperManager val newWallpaper = manager.switchToNextWallpaper() - requireComponents.analytics.metrics.track(Event.WallpaperFeatureDiscovered) requireComponents.analytics.metrics.track(Event.WallpaperSwitched(newWallpaper)) manager.updateWallpaper( wallpaperContainer = binding.homeLayout, diff --git a/app/src/main/java/org/mozilla/fenix/settings/wallpaper/WallpaperSettingsFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/wallpaper/WallpaperSettingsFragment.kt index ce5af833d..19e3d2c16 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/wallpaper/WallpaperSettingsFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/wallpaper/WallpaperSettingsFragment.kt @@ -41,7 +41,7 @@ class WallpaperSettingsFragment : Fragment() { container: ViewGroup?, savedInstanceState: Bundle? ): View? { - metrics.track(Event.WallpaperFeatureDiscovered) + metrics.track(Event.WallpaperSettingsOpened) return ComposeView(requireContext()).apply { setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed) setContent {