From 7a01fcbfa9f063326e43812cef428dabcdf3186c Mon Sep 17 00:00:00 2001 From: Christian Sadilek Date: Tue, 22 Dec 2020 11:10:31 -0500 Subject: [PATCH] Closes #17073: Fix intermittent failures in PwaOnboardingObserverTest --- .../fenix/shortcut/PwaOnboardingObserverTest.kt | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/src/test/java/org/mozilla/fenix/shortcut/PwaOnboardingObserverTest.kt b/app/src/test/java/org/mozilla/fenix/shortcut/PwaOnboardingObserverTest.kt index 9ed456972..0c277d205 100644 --- a/app/src/test/java/org/mozilla/fenix/shortcut/PwaOnboardingObserverTest.kt +++ b/app/src/test/java/org/mozilla/fenix/shortcut/PwaOnboardingObserverTest.kt @@ -68,8 +68,10 @@ class PwaOnboardingObserverTest { @Test fun `GIVEN cfr should not yet be shown WHEN installable page is loaded THEN counter is incremented`() { - pwaOnboardingObserver.start() every { webAppUseCases.isInstallable() } returns true + every { settings.userKnowsAboutPwas } returns false + every { settings.shouldShowPwaCfr } returns false + pwaOnboardingObserver.start() store.dispatch(ContentAction.UpdateWebAppManifestAction("1", mockk())).joinBlocking() verify { settings.incrementVisitedInstallableCount() } @@ -81,9 +83,10 @@ class PwaOnboardingObserverTest { @Test fun `GIVEN cfr should be shown WHEN installable page is loaded THEN we navigate to onboarding fragment`() { - pwaOnboardingObserver.start() every { webAppUseCases.isInstallable() } returns true + every { settings.userKnowsAboutPwas } returns false every { settings.shouldShowPwaCfr } returns true + pwaOnboardingObserver.start() store.dispatch(ContentAction.UpdateWebAppManifestAction("1", mockk())).joinBlocking() verify { settings.incrementVisitedInstallableCount() } @@ -95,8 +98,10 @@ class PwaOnboardingObserverTest { @Test fun `GIVEN web app is not installable WHEN page with manifest is loaded THEN nothing happens`() { - pwaOnboardingObserver.start() every { webAppUseCases.isInstallable() } returns false + every { settings.userKnowsAboutPwas } returns false + every { settings.shouldShowPwaCfr } returns true + pwaOnboardingObserver.start() store.dispatch(ContentAction.UpdateWebAppManifestAction("1", mockk())).joinBlocking() verify(exactly = 0) { settings.incrementVisitedInstallableCount() }