From 2193be27b20c4cb366e208da3ce2a598cf5e9255 Mon Sep 17 00:00:00 2001 From: Victor Date: Thu, 18 Feb 2021 13:15:00 -0300 Subject: [PATCH] Solves Leaks on SavedLoginFragment disables options menu to avoid leak removes on click listener to avoid leak --- .../fenix/settings/logins/fragment/SavedLoginsFragment.kt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/src/main/java/org/mozilla/fenix/settings/logins/fragment/SavedLoginsFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/logins/fragment/SavedLoginsFragment.kt index 130e856a6..9339dcdbe 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/logins/fragment/SavedLoginsFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/logins/fragment/SavedLoginsFragment.kt @@ -150,6 +150,8 @@ class SavedLoginsFragment : Fragment() { toolbarChildContainer.visibility = View.GONE (activity as HomeActivity).getSupportActionBarAndInflateIfNecessary().setDisplayShowTitleEnabled(true) sortingStrategyMenu.menuController.dismiss() + sortLoginsMenuRoot.setOnClickListener(null) + setHasOptionsMenu(false) redirectToReAuth(listOf(R.id.loginDetailFragment), findNavController().currentDestination?.id) super.onPause()